Commit Graph

147 Commits

Author SHA1 Message Date
Joseph Greathouse dc9ecf03f8 Fix compiler warning on NVCC path (#1942)
GCC emits a warning about using static functions like
hipCUDAErrorTohipError inside this function, because it has an
inline directive, but it's not static. Adding static to this function
to silence warnings (and prevent potential problems in the future).
2020-03-17 14:02:59 +05:30
Joseph Greathouse 7f49e47217 Fix occupancy calculations API on NVCC (#1941)
NVCC warned if you tried to use hipOccupancyMaxActiveBlocksPerMultiprocessor
because when passing in a device function pointer, "const void* func" was
insufficient to describe it accurately. Adding a C++ templated class type
definition for this function.
2020-03-17 14:02:48 +05:30
Aryan Salmanpour e509a6d0b4 [HIP] add cooperative kernel launch APIs on NVCC (#1929) 2020-03-17 14:01:11 +05:30
Aryan Salmanpour 7bfb990ef7 [HIP] add hip specific properties for cooperative kernel multi device 2020-03-03 13:25:36 -05:00
Aryan Salmanpour 1c013bab3e fix build error in nvcc path 2020-02-11 12:16:51 -05:00
Aryan Salmanpour 75572a4175 code clean up 2020-01-31 13:08:25 -05:00
Aryan Salmanpour 6db9b782be [HIP][HIPIFY] Add some missing flags for cooperative launch and occupancy APIs 2020-01-30 15:05:53 -05:00
vsytch 6da0c82b78 Add missing texturePitchAlignment member to the hipDeviceProp_t struct. (#1802)
* Add missing texturePitchAlignment member to the hipDeviceProp_t struct.

* Add missing hipDeviceAttributeTexturePitchAlignment enumerator to the hipDeviceAttribute_t enum.

* Initialize texturePitchAlignment to 256. This works for gfx9+, but is technically overaligned in most cases for pre-gfx9.

* Add the texturePitchAlignment property to the NVCC path.
2020-01-27 16:37:00 -08:00
Evgeny Mankov 9c2fcff9ce [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path
2020-01-10 13:47:18 +05:30
Rahul Garg 534376cb41 Add hipBindTexture2D on NVCC path (#1773) 2020-01-06 12:33:50 +05:30
Evgeny Mankov ed43699a3a Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)
2019-12-30 19:21:09 +03:00
Evgeny Mankov 4aaa2336a8 [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle
2019-12-23 17:01:35 +03:00
Alex Voicu 150e690a3a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.
2019-12-23 19:11:24 +05:30
Rahul Garg a369bd4418 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
2019-12-06 09:51:53 +05:30
Alex Voicu 022ac3cb0a General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp
2019-11-20 21:36:37 +05:30
Rahul Garg ff31f734fe Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests
2019-11-18 12:19:22 +05:30
Anusha Godavarthy Surya c0fc5e718c Merge branch 'master' into tex_unbind_issue_fix 2019-10-25 15:36:55 +05:30
Anusha Godavarthy Surya b9c8dd8ac6 Fixed CI build failure 2019-10-25 12:21:41 +05:30
Evgeny Mankov 7a1301eab9 [HIP] Fix typo in a comment 2019-10-11 15:20:58 +03:00
Evgeny Mankov 3a83b3a62c [HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow 2019-10-11 15:18:08 +03:00
Evgeny Mankov d8d9f16f17 [HIP] Introduce library_types.h as a common header for libs (#1509)
* [HIP] Introduce library_types.h as a common header for libs

[Reason]
Currently, hipFFT, hipBLAS and other HIP libs use their own data types, prefixed with HIPFFT or HIPBLAS, whereas in CUDA those types are common and declared in library_types.h

[TODO]
Switch hipFFT, hipBLAS and other HIP libs to use common library_types.h.

* [HIP] Move include for library_types.h to hip_runtime.h

[Reason]
Repeat CUDA's behaviour, where library_types.h is included in cuda_runtime.h
2019-10-10 19:57:28 +05:30
Philip Salzmann 11f23bba39 Fix uninitialized var in hipDeviceGetAttribute (#1497)
This fixes the usage of an uninitialized cdattr variable in hipDeviceGetAttribute for the CUDA backend when taking the switch default, as detailed in #1317.

Note that the directed_tests/runtimeApi/device/hipGetDeviceAttribute.tst test fails for me, but it already did before applying this patch. Let's see what CI says!
2019-10-04 13:39:19 +05:30
ansurya 96890792b0 Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.
2019-10-04 13:36:31 +05:30
Sarbojit2019 db4c0c0811 [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.
2019-09-26 13:53:33 +05:30
ansurya e2a934f377 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported
2019-09-16 08:31:30 +00:00
Sarbojit2019 b5ff9e71ed Updated hipErrorString and CUDAErrorTohipError (#1365) 2019-08-29 01:02:59 +00:00
Sarbojit2019 1ae43cbeba [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path
2019-08-29 01:02:41 +00:00
Sarbojit2019 684801fc1d Compilation failure on nvcc path when using hipChannelFormatKind (#1345)
Fix for github #1183 issue reported
2019-08-21 10:01:03 +00:00
Rahul Garg fbc9f7e20a Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check
2019-08-16 02:13:16 +00:00
Sarbojit2019 c4618f2c3b [HIP] Fix for hipArray_t failure on nvcc path
Fixes SWDEV-148407
2019-08-14 11:30:06 +00:00
Rahul Garg 569f35a258 Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis
2019-08-09 11:50:37 +00:00
Rahul Garg 8b6317d041 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error
2019-08-08 08:27:41 +00:00
Maneesh Gupta b24a4000f8 [nvcc] Populate missing fields in hipGetDeviceProperties
Change-Id: Ie90e02674d503e385f144f1ead3d53ff7b49cecc
2019-08-01 13:16:39 +05:30
ansurya 00aa42e05f Add Max Texture 1D,2D,3D device properties (#1226)
* Add Max Texture 1D,2D,3D device properties

* Corrected testcase to use enums defined in hipDeviceAttribute_t

* Added texture 1D,2D and 3D support for NVIDIA path
2019-07-18 03:18:50 +00:00
Jannik a401997b8e Fix call to cuda library (#1197)
* Remove flags parameter from hipOccupancyMaxPotentialBlockSize

This commit makes the hipOccupancyMaxPotentialBlockSize method consistent with hcc path and the CUDA API.
2019-07-04 00:43:22 +00:00
Evgeny Mankov 49b9df7a9e [HIP] fix typo in #1127 2019-05-22 20:48:18 +03:00
Evgeny Mankov 6806ab6745 [HIP] fix nvcc path break in #1127 2019-05-22 20:04:45 +03:00
Evgeny Mankov 9cb3e9aa5e [HIP][HIPIFY] Make hipMemcpyParam2D coherent with cuMemcpy2D
+ Makes hip_Memcpy2D struct compatible with CUDA_MEMCPY2D struct
+ Add hipMemcpyParam2D support in nvcc fallback path
+ Update hipify-clang, tests and docs accordingly
2019-05-22 18:31:39 +03:00
Rahul Garg 6cbc70d238 Fix symbol address issue on NVCC path 2019-05-07 03:59:43 +05:30
Maneesh Gupta 7edb43bc83 Merge pull request #1039 from gargrahul/fix_ptrgetattr_nvcc
Fix hipPointerGetAttributes for NVCC
2019-04-24 16:50:18 +05:30
Rahul Garg 94769fc8dd Add hipMallocManaged default functional support (#1036)
* Add hipMallocManaged default functional support

* Fix build error

* Add dtest
2019-04-24 16:50:03 +05:30
Rahul Garg c0e0f0b7fd Fix hipPointerGetAttributes for NVCC 2019-04-23 03:22:25 +05:30
Steven Noonan 27d6755552 nvcc_detail/hip_runtime_api.h: add missing hipDeviceSetCacheConfig API
Signed-off-by: Steven Noonan <steven@uplinklabs.net>
2019-03-06 11:21:36 -08:00
Maneesh Gupta 38b7a43b43 Update hip_runtime_api.h
Use hipCUResultTohipError instead of hipCUDAErrorTohipError in hipMemsetD32 & hipMemsetD32Async.
2019-03-05 12:10:01 +05:30
Wen-Heng (Jack) Chung 8b7baa0bd9 Address code review comments to use hipDeviceptr_t 2019-03-05 05:51:05 +00:00
Wen-Heng (Jack) Chung b46e684d2e Add implementation for NVCC path 2019-03-04 20:11:12 -08:00
Michael Kuron f71b8cbc7d Fix hipGetSymbolAddress/hipGetSymbolSize on nvcc 2018-11-15 09:48:00 +01:00
Michael Kuron 0b6f5791f8 Implement hipGetSymbolAddress and hipGetSymbolSize 2018-11-04 10:39:34 +01:00
Maneesh Gupta 95be669f4a Merge pull request #703 from mangupta/stream_create_with_priority
Implementation for stream priority
2018-10-17 10:53:43 +05:30
Maneesh Gupta d71006eb99 Add missing hipHostRegister flags on nvcc path
Change-Id: I69f09204d9c544935104d4168ab8d3626666a623
2018-10-15 15:30:24 +05:30