033c4e8fc5
Correct typo in Mi100 metric defs for missing SQ_INSTS_VMEM
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 6cfdca93b9
2024-04-01 14:30:21 -05:00
2c8f4de5e4
Responding to first round of Ben R.'s docs feedback.\n\nThis round includes fixes for comments up to the 'Performance Model' section. I will need to work with our documentation group to respond to those higher level comments.
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 20670da2b7
2024-04-01 14:30:21 -05:00
58d876a2c2
Add timestamp override to rocprofv2 and format Python
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: dfdd8dd21d
2024-04-01 14:30:21 -05:00
e664f7abf4
Pytest add mi200 to analyze workloads ( #334 )
...
* Updated links in documentation. (#328 )
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
* update branch for 2.x documentation builds
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
* update checkout action and use concurrency instead of cancel-workflow-action
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
* test addition of user option for container launch
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
* remove --user option for container, try chown instead
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
* fixing yaml syntax
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
* reorder job step - start with checkout
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
* restore missing run directive
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
* Update workloads to include log.txt
Add missing MI200 workloads
Signed-off-by: Jose Santos <josantos@amd.com >
* Signed-off-by: Jose Santos <josantos@amd.com >
Add vcopy workload for tests
* Change exit codes for caught failures
Signed-off-by: Jose Santos <josantos@amd.com >
* reformat
Signed-off-by: Jose Santos <josantos@amd.com >
* Add pytest-xdist for pytest -n
Signed-off-by: Jose Santos <josantos@amd.com >
---------
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
Signed-off-by: Jose Santos <josantos@amd.com >
Co-authored-by: David Galiffi <David.Galiffi@amd.com >
Co-authored-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: da506ad9b5
2024-04-01 14:30:21 -05:00
a83ea5d582
Create general_options() func to reduce code in parser
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 482fd6f2ca
2024-04-01 14:30:21 -05:00
c693890216
Fix for #300 ( #331 )
...
On some versions of numpy/pandas, applying a str map to an empty series doesn't change the type.
As a result, when adding a float to a string, sometimes numpy dies with a uadd error.
We fix this by explicitly casting to a str first
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: d72ef52208
2024-04-01 14:30:21 -05:00
e64e8b5604
Updated links in documentation. ( #329 )
...
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
[ROCm/rocprofiler-compute commit: ddb5c0ccc9
2024-04-01 14:30:21 -05:00
40764d29a0
restore missing run directive
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 68ea629c14
2024-03-21 11:19:43 -05:00
fa453d34b3
reorder job step - start with checkout
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: ad65ec14f8
2024-03-21 11:13:05 -05:00
d4784ec0ef
fixing yaml syntax
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 5e99f039f6
2024-03-21 11:08:14 -05:00
4d88055dd4
remove --user option for container, try chown instead
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 79aba89337
2024-03-21 11:05:15 -05:00
8059b012a6
test addition of user option for container launch
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 01d41bd428
2024-03-21 11:00:00 -05:00
626f303a2d
update checkout action and use concurrency instead of cancel-workflow-action
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 1ae67a179d
2024-03-21 10:52:43 -05:00
a9705599aa
update branch for 2.x documentation builds
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 65486cb9d5
2024-03-21 10:41:15 -05:00
376a86d2d0
Updated links in documentation. ( #328 )
...
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
[ROCm/rocprofiler-compute commit: f5712875aa
2024-03-21 10:14:37 -05:00
8943f686f5
Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg'
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 62221383a7
2024-03-18 14:28:14 -05:00
fbb88baa20
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 4fc30eb5c4
2024-03-15 16:40:13 -05:00
8167627984
update name for docs 2.x job
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 9d268d76c6
2024-03-15 16:36:51 -05:00
70fa822698
update doc watermark for release candidate
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 03ddba538d
2024-03-15 16:31:42 -05:00
77c0800506
include alternate profilers during testing
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: cabca9cbb8
2024-03-15 16:26:05 -05:00
19a9e0431c
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f4070e3654
2024-03-15 14:04:49 -05:00
ae617872fd
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 0e3809f20b
2024-03-15 14:04:49 -05:00
e370a18a6d
restore test_analyze_workloads to a single ctest
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: e6a00789b4
2024-03-15 14:04:49 -05:00
67236bb0b8
add two missing calls to clean_output_dir
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 8b49bd2e51
2024-03-15 14:04:49 -05:00
a4b6ce2f01
updating test_analyze_commands test configuration to be thread safe
...
for parallel execution; done via use of setup_workload_dir() which
copies contents into unique directory path; no change if running serially
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 30d75066b9
2024-03-15 14:04:49 -05:00
104bf46b4b
Update docs for MI300 support
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b436415784
2024-03-15 12:48:00 -05:00
fa0cc81720
Update roofline distro_map for Ubuntu22.04 ( #319 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2dcad38028
2024-03-15 12:47:30 -05:00
a8dcdec00f
tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the
...
loglevel name in output, but without color
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69de978d35
2024-03-15 09:31:22 -05:00
ba4bccbe0f
tighten up [analyze] help to be consistent with [profile] help
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 357d225716
2024-03-15 09:31:22 -05:00
3a77ecadd3
bug fix for df tracing output - add more function demarcation
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: c29f28e25e
2024-03-15 09:31:22 -05:00
624606771f
enable more function demarcation for analyze tracing
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 76121f20a9
2024-03-15 09:31:22 -05:00
3dbe61f462
logger update: assign color for TRACE level
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 3438bc9d0f
2024-03-14 17:37:30 -05:00
8d6a8e3b06
update logging formatter handling for consistent behavior with error messsages
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69af2ffc83
2024-03-14 17:37:30 -05:00
b8b5409d4f
updating version file for RC1
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 04c0c8ad46
2024-03-14 14:46:41 -05:00
f442662aa2
update analyze_commands tests to demarcate a subset of tests which
...
should be run serially; needed to avoid file output race conditions in
a common directory
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: b38dcfd2c9
2024-03-14 13:39:10 -05:00
c5408fb22b
fixup MI300 MFMA rate disagreement between SOL and pipeline ( #315 )
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: b610e1c27b
2024-03-14 10:41:35 -05:00
4be73b88c6
Trying patch for test_device_filter(). HIP_VISABLE_DEVICES should not dictate expected device
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b3d63ea24e
2024-03-13 16:30:52 -05:00
ead7537cba
Pytest remove kernel verbose ( #314 )
...
* Remove kernel-verbose from pytests
Signed-off-by: Jose Santos <josantos@amd.com >
* remove kernel-vebose from profile in cmake
Signed-off-by: Jose Santos <josantos@amd.com >
* update expected csvs for test_block_TCC
Signed-off-by: Jose Santos <josantos@amd.com >
* Remove stubbed binary
Signed-off-by: Jose Santos <josantos@amd.com >
* always clean workload_dir
Signed-off-by: Jose Santos <josantos@amd.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
[ROCm/rocprofiler-compute commit: 4a86e39a25
2024-03-13 11:30:28 -05:00
0b4ee818ba
Update doc samples for new logging output
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: bfef420099
2024-03-12 20:17:46 -05:00
b2c4c8a8cc
Found a bug in kernel filtering and fixed
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2acc8e98c1
2024-03-12 18:21:35 -05:00
8cb9e5e959
Update expected pytest value for same workload case
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 945da7d83c
2024-03-12 16:49:41 -05:00
63d52b2e4c
Python format
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: cac4b1aff5
2024-03-12 16:47:18 -05:00
1a27707a4d
Throw error if user analyzes two of same path ( #260 , #67 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: fa7c82de75
2024-03-12 16:46:36 -05:00
ff7751724b
Fix missing argv in console_warning()
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e7cc326d5a
2024-03-12 16:44:02 -05:00
31b3bff4de
Update dashboard globals to reflect new (v2) sysinfo keys
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 17262172a8
2024-03-12 16:23:12 -05:00
bd4bc51cd4
change stubbed values to hbm bw ( #302 )
...
* change stubbed values to hbm bw
Signed-off-by: Jose Santos <josantos@amd.com >
* Reformat
Signed-off-by: Jose Santos <josantos@amd.com >
* Update analysis_webui.py
remove print statements
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: efb8f131ec
2024-03-12 16:08:30 -05:00
513ba356ae
Kernel no overwrite ( #303 )
...
* Removing kernel name shortener from profile
- Kernel name shortener now in analyze
- db import uses pymongo to import
Signed-off-by: Jose Santos <josantos@amd.com >
* collections now added using pymongo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* kernel_name_shortener shortens dataframes and not a workload
- argparser: --kernel-verbose to connection group
- analysis_cli, profiler_rocprof_v2: remove kernel_name_shortener, so that it doesnt overwrite workload
- db_import: demangle kernel_name dfs
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix db name in pymongo command
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* reformat
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix typo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* remove checker for verbose in profiler_base
Signed-off-by: Jose Santos <josantos@amd.com >
* kernel_name_shortener now called in create_df_kerenel_top_stats and
create_df_pmc
Signed-off-by: Jose Santos <josantos@amd.com >
* add kernel_verbose to analysis_webui, remove stubbed values
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* Update src/utils/kernel_name_shortener.py
keep console_debug
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/utils/kernel_name_shortener.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4424f320ad
2024-03-12 15:54:52 -05:00
5b53f2a28c
remove binaries from tests directory
...
Signed-off-by: Jose Santos <josantos@amd.com >
[ROCm/rocprofiler-compute commit: 43bc78c1dd
2024-03-12 13:06:11 -05:00
ea4dd893a1
Check for CI_VISIBLE_DEVICES num_devices
...
- add vcopy_MI200
Signed-off-by: Jose Santos <josantos@amd.com >
[ROCm/rocprofiler-compute commit: c4bd700a2d
2024-03-12 13:06:11 -05:00
4fb2f6e2b4
Update DB module for new sysinfo keys
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 706d3bb9f0
2024-03-12 12:24:49 -05:00
colramos-amd
JoseSantosAMD
Nick Curtis
David Galiffi
Karl W. Schulz
Jose Santos