Commit Graph

203 Commits

Author SHA1 Message Date
Tony Tye 040bc455d4 SWDEV-268864 - Use new isa class to access isa related information (part 2)
Change-Id: If7ed535b3012aec3f2cb4eb7ab93d8f5aed9783f
2021-01-19 03:36:22 +00:00
Tony Tye c45b74c9de SWDEV-268864 - Use new isa class to access isa related information
Change-Id: I2122bf85155997d802ca54e456c2dae66b801825
2021-01-18 22:31:01 +00:00
Tony Tye 28e60ec942 Use ROCclr Info.targetId_
Use Info.targetId_ instead of Info.name_ so it will work on Windows
PAL driver and ROCm.

Change-Id: I20537899c36c0ee330a4c09136a52e53d9f35e0d
2021-01-14 05:17:20 +00:00
Rahul Garg c307baf3da Add IPC Events support
Change-Id: Iac2bf3d5e1d9a993bebbb066c20d300d6f05558b
2021-01-08 20:09:26 +00:00
Tao Sang b34dd95124 Remove hip-hcc codes: Part four
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.

Remove Hcc codes from directed_tests and samples.

Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.

Add deprecation notice.

Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce
2021-01-08 10:53:34 -05:00
agodavar 387d0aa829 SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f
2021-01-05 23:29:50 -05:00
Tao Sang c2adc70d4d Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce
2021-01-05 10:39:31 -05:00
Satyanvesh Dittakavi 57dfaab032 SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3
2021-01-05 00:22:12 -05:00
cjatin b96cc0f4c7 Add ELF Flags moved from rocclr
Change-Id: I5febe7bdca80517e9f9492d7930def72db83c14e
2021-01-04 13:43:16 -05:00
Sarbojit Sarkar 36a6baf829 Revert "Fix hipmemset to match CUDA behavior"
This reverts commit 08f827b28b.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a
2021-01-01 00:11:58 -05:00
agodavar d21cabd890 hipmemcpy2D handle height 0
Change-Id: I46bf89e81559c3bfccac0dd0ccd78eee9058c7e3
2020-12-31 01:41:56 -05:00
agodavar 2a4568d416 SWDEV-266089: hipStreamAddCallback argument validation
Change-Id: I3e61006796e88b4e2ba029118c95f3499959257b
2020-12-29 05:42:54 -05:00
agodavar c1dedbd3a0 SWDEV-263180 : Fix null ptr dereference
Change-Id: Iefc9fa3f195af45a5c5ebe075056246c930a6d84
2020-12-19 02:02:54 -05:00
Rahul Garg 08f827b28b Fix hipmemset to match CUDA behavior
Make hipMemset asynchronous with respect to the host unless
destination pointer refers to pinned host memory.

Change-Id: I5ba230e0cc622aa076dc94692a4c43a57dd2df7b
2020-12-17 19:13:31 +00:00
Evgeny d4df2e880d SWDEV-259683 : hipprof: adding hipApiIdByName() method
Change-Id: I1ad2be76efc9fb690ed7c9c2b1091f7eb0c04a31
2020-12-15 15:42:10 -05:00
Satyanvesh Dittakavi 5b10098da9 SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi a7b5347c90 Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8
2020-12-15 01:40:24 -05:00
Sarbojit Sarkar 7c3b1cca22 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb
2020-12-13 11:30:28 -05:00
Tao Sang d074c2491f Some improvements on hip cmake file
1.Fix unexpected repeated hip runtime lib building
2.Seperate test cmake from top cmake.

Change-Id: I1ae457effd639d6c25bca293c1724b026be21ecd
2020-12-11 13:32:15 -05:00
Rahul Garg 15ecdcf084 Handle overflow
Fixes SWDEV-261712

Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed
2020-12-09 19:09:43 -05:00
Saleel Kudchadker 6da16e90d2 Honor hipEventDisableTiming event flag
Change-Id: Ia949db96e81b9af467f04ab40d143e8d6faa9394
2020-12-09 15:10:18 -05:00
Jatin Chaudhary d056171a20 Updating the gcnArchName to now have target id
Change-Id: Ibd5576e0fb5b46e8f212de4ec57cd96eb1d3c157
2020-12-09 01:22:08 -05:00
Jatin Chaudhary 91ca6e6ab3 Adding checks for function, size and params in ihipModuleLaunchKernel to have common message for hipModuleLaunch and hipExtModuleLaunch
Change-Id: I11921ad753930872572571dbfd1c12daba83a725
2020-12-07 03:17:14 -05:00
Saleel Kudchadker 390d8c54cb Add a new flag for profilingInfo to record gpu TS
Add a flag to record gpu TS in a marker, also disable marker flush
if there was already a marker submitted before.

Change-Id: I9cdf8e49137690c0050fe9370764dd059855a2f8
2020-12-03 13:45:39 -05:00
agodavar 77e5c4110e SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar 4c1f86699d SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840
2020-12-03 05:50:42 -05:00
agodavar 9d56e96725 SWDEV-259210 : Handle invalid inputs for hipDeviceGetByPCIBusId and hipDeviceGetPCIBusId APIs
Change-Id: Iab48604941c4c715ee3357ace2e2d26dbc8cad33
2020-12-02 00:01:54 -05:00
Tony aec1c87f34 Add additional targets
Add support for loading the following targets:

- gfx705
- gfx805
- gfx90c
- gfx1031
- gfx1032
- gfx1033

Change-Id: Ib7f61c33662619757409e95fb0b50068f9e11065
2020-11-23 20:31:45 +00:00
Aryan Salmanpour d9a335bccf Add support for hipExtStreamGetCUMask API
Change-Id: I0fa67ad581dd75556f17c7410af2c1d5cb6ae99a
2020-11-20 13:41:38 -05:00
Satyanvesh Dittakavi ee32c0407a SWDEV-255614: Fix Caffe2 Test Failure
Change-Id: I043caa89b2a43dace7f18c739f30d2a7bfa644ca
Fixes the issue when memcpy DtoH is performed on device 0 where the device buffer 
is allocated on device1 and the destination pinned buffer is allocated from device 0.
2020-11-20 10:24:50 -05:00
Vladislav Sytchenko fb04bdc4f2 Report maxTexture1DLinear property
Change-Id: If562bbee80d8b98712806cb8258b5a7482d33bf6
2020-11-20 10:18:20 -05:00
Rahul Garg 0096a215b4 Fix async flag in hipMemset3DAsync
Change-Id: I3dc717c14bdd1d46873e03c687bdf57f9202663e
2020-11-18 20:32:18 -05:00
Yaxun (Sam) Liu b7f66b634a Fix embedding PCH
Change-Id: Ibaf043c9e331f15965185cd4195da98d9441cba3
2020-11-18 00:56:42 -05:00
Rahul Garg ff5c6f808b Fix hipDeviceGetByPCIBusId
SWDEV-260845

Change-Id: I2d6db15906d794c9ebfa85b745a2c1bbb6f3e731
2020-11-16 23:28:52 +00:00
Tao Sang ecd4dca29d Remove unnecessary stuff from hip cmakefile
Remove the following from hip cmakefile,
1.find_package cmds of hsa-runtime64 and amd_comgr;
2.macros of USE_COMGR_LIBRARY and COMGR_DYN_DLL
because they have already been used in Rocclr cmakefile.
cmake mechanism will make hip cmakefile inherite them.

Change-Id: I03b527fc4135c79bb35cbbfe419211ec363cb067
2020-11-13 15:01:32 -05:00
agodavar bf0b75baed SWDEV-249870: Generate Pre-Compiled Headers from includes in source repo for Online Compilation
Change-Id: I663f510603e983927f80f7944df4d039ba7bc0b0
2020-11-12 10:50:33 -05:00
German Andryeyev a04a9a51a8 Add an early exit if it's a null stream wait
Change-Id: I577f5da2f928bff172d64d511a60e08eda28c81d
2020-11-11 13:20:04 -05:00
Konstantin Zhuravlyov c4beefe00b SWDEV-198415 - Implement Target ID Proposal
Changes from Jatin Chaudhary, Tony Tye

Change-Id: I14904920ad2356ae2098cf827b83613089d33962
2020-11-10 13:31:43 -05:00
Tao Sang bcd067f462 Make directed_test support static libs
1.Make directed_test apps linked against static libs
    of hip, rocclr, rocr, roct and amd_comgr.
    2.Remove custom_target amdhip64_static_combiner.
    3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
    4.Simplify argument list parsing.
    5.Install rocclr when rocm is installed.
    6.Fix some original small bugs.

Revert "Revert "Make directed_test support static libs""
This reverts commit 5b7533e49f.

Change-Id: I918eeae94487e5e2ff5bfde083667ac65fb6e702
2020-10-26 12:39:58 -04:00
Sourabh Betigeri 3c4208aa7d SWDEV-251091: Added null checks and empty file check in hip_module and hip_platform
Change-Id: Iad99f996dcf90ffb86f62e79bf4cbd53b35b7e3b
2020-10-20 19:55:01 -04:00
kjayapra-amd f79a03026c SWDEV-250005 - Fixing error code propagation to HIP outer layer.
Change-Id: I0c0e87dbace0b1182f24411200abdfd9cab3f865
2020-10-20 09:43:57 -04:00
Sarbojit Sarkar 0af33580e6 SWDEV-256325 : Fix for hipMemset2D crash
Change-Id: I1f434602fecd4fb935d2bc72f2c72d6a2d4c45fe
2020-10-20 02:54:29 -04:00
Rahul Garg 507ec0a1b8 Fix PCI bus domain ID query
SWDEV-256338

Change-Id: I5db361bd2899a5bf761ecf05ecd4635f9e3dce1d
2020-10-19 12:02:50 -04:00
Rahul Garg 01f6cbed7d Fix maxTexture1D query
Needed by SWDEV-254068

Change-Id: Ib43a3e5e96d3882af354208063e5502673c0f35a
2020-10-14 17:32:04 -04:00
agodavar 2080cc113a SWDEV-249870: Short-Term solution for Pre-Compiled Headers for Online Compilation - Fix static build
Change-Id: Ib608e73dbffa2d803599cba5ba842cd5a2a2ba9d
2020-10-14 00:37:46 -04:00
German Andryeyev d9f655f50e Report managed memory capabilities
Change-Id: I241a42e26ee49fb47dcb3ba87c4bd8fb691dffdf
2020-10-13 16:09:43 -04:00
Aryan Salmanpour c6904623aa Fix a seg fault when unallocated mem handle passed to hipIpcOpenMemHandle API
also validate the flag argument passed to hipIpcOpenMemHandle API and return
error if it is not equal to "hipIpcMemLazyEnablePeerAccess" (defined to 0)
and it is the only supported flag currenlty for this API.

SWDEV-253462

Change-Id: Ie1c8b79c680a29dc72bf262cf53ae5e011fb1247
2020-10-13 11:14:41 -04:00
Julia Jiang c2a3d19acb SWDEV-249487-remove two HCC related APIs
Change-Id: Icf90ece0808643e0c5f0cc00b6644d5171b553d8
2020-10-13 11:08:37 -04:00
agodavar dc1459cfb1 SWDEV-254185 - Added support to pass include headers to hipRTC
Change-Id: Ia19e6806a476d3c6ecd3e9a89c3ed72953a4900c
2020-10-12 06:04:14 -04:00
Tao Sang 5b7533e49f Revert "Make directed_test support static libs"
This reverts commit b41a769517.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Ib2d1084ea21461f70f96f95c6025a08f88288357
2020-10-12 00:01:13 -04:00