Commit Graph

13402 Commits

Author SHA1 Message Date
Evgeny Mankov 20b127bf45 [HIP][doc] Fix typo: AMD-clang -> HIP-clang
HIP-clang is already used below instead of AMD-clang


[ROCm/clr commit: 6284b041e5]
2019-10-28 21:19:21 +03:00
Evgeny Mankov 0737167ee4 [HIP][cmake] Move all *_INSTALL_DIR variables up before first add_subdirectory()
[REASON]
Those vars (may) used by cmake in subdirectories (#1571)


[ROCm/clr commit: 8100e084b8]
2019-10-28 21:07:00 +03:00
foreman cc02406257 P4 to Git Change 2019944 by chui@ocl-promo-incrementor on 2019/10/26 03:00:52
SWDEV-2 - Change OpenCL version number from 3026 to 3027.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2774 edit


[ROCm/clr commit: a8e96b1d3d]
2019-10-26 03:10:02 -04:00
foreman c228e91ff6 P4 to Git Change 2019867 by gandryey@gera-win10 on 2019/10/25 18:12:01
SWDEV-79445 - OCL generic changes and code clean-up
	- Fix memory leaks in COMGR path. Don't create binaryData, since it will be overwritten with action_data_get_data() call.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#65 edit


[ROCm/clr commit: e22fe683e7]
2019-10-25 18:17:54 -04:00
foreman 3fd285e26b P4 to Git Change 2019864 by axie@axie_opencl_pal on 2019/10/25 18:03:56
SWDEV-204995 - Linux Pro: Houdini18 Application hang is seen with pyro sample on OpenCL selection.
	The new Houdini application has around 286.6K byte TLS. In Linux, the TLS resides in thread stack. TLS is allocated and initialized during pthread_create.
	If command queue thread stack size is only 256k byte, pthread_create function failed with return value EINVAL.

	The above information is verified by this test:
	I printed out the address of a __thread variable. Then I printed out an address of a local variable. I confirmed both variables are in the same memory segment according to /proc/id/maps. This memory segment is same size of CQ_THREAD_STACK_SIZE and changed with this environment variable.

	The __thread variable is 286.6K byte away from the bottom of the stack but still inside the stack.

	I have added printf to verify function guessTlsSize can guess tlsSize correctly. And pthread_create succeeded in first invocation with tls size adjustment.

	Tests:
	1. Test houdini - PASS
	2. http://ocltc.amd.com:8111/viewModification.html?modId=128021&personal=true&tab=vcsModificationBuilds

	ReviewBoard: http://ocltc.amd.com/reviews/r/18175

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/os/os_posix.cpp#47 edit


[ROCm/clr commit: be8023429a]
2019-10-25 17:08:39 -05:00
foreman 3888033482 P4 to Git Change 2019704 by cpaquot@cpaquot-ocl-lc-lnx on 2019/10/25 14:07:38
SWDEV-208972 - [HIP] Enable LOG_LEVEL in release bits.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#322 edit


[ROCm/clr commit: 0ce1ad6acb]
2019-10-25 14:17:24 -04:00
Evgeny Mankov 1ef94a4f94 Merge pull request #1590 from emankov/doc
[HIPIFY][tests] Fix ambiguous call to cusparseGetErrorString declared in cusparse.h

[ROCm/clr commit: 7f367ff933]
2019-10-25 16:08:22 +03:00
Evgeny Mankov bcc9d88b20 [HIPIFY][tests] Rename the ambiguous call as well
[ROCm/clr commit: f68bee02f5]
2019-10-25 16:07:31 +03:00
Evgeny Mankov 91732f98c0 [HIPIFY][tests] Fix ambiguous call to cusparseGetErrorString declared in cusparse.h
[ROCm/clr commit: 9529e1d91d]
2019-10-25 16:04:20 +03:00
Anusha Godavarthy Surya dfa019bdf6 Merge branch 'master' into tex_unbind_issue_fix
[ROCm/clr commit: 9332a39838]
2019-10-25 15:54:25 +05:30
amd-lthakur 6bb2cba965 Excluded the test case for nvcc platform
[ROCm/clr commit: 626cd5d07a]
2019-10-25 15:52:11 +05:30
Anusha Godavarthy Surya 0140ea8e1a merge from master
[ROCm/clr commit: ae838f8cee]
2019-10-25 15:52:09 +05:30
Alex Voicu f22391c362 Add missing operators, fix GCC compilation. (#1589)
[ROCm/clr commit: 40522e2b6a]
2019-10-25 15:44:24 +05:30
Alex Voicu acbee5a48b Fix deadlock, remove old __sync_* use. (#1584)
This fixes a deadlock introduced by the switch to TTAS loops, and is therefore mildly urgent (to prevent the CI from hoovering in the broken code).

[ROCm/clr commit: f909a393ff]
2019-10-25 15:44:17 +05:30
Rahul Garg 9c599a3581 [dtest] Fix hipMemset2D test (#1579)
Reverts changes made in #1399. This is a RT api test. For testing hipMemAllocPitch , a new test should be written and that should use correct memset API.

[ROCm/clr commit: 66a3c874c8]
2019-10-25 15:44:05 +05:30
Rahul Garg 7ea7a9c3b7 Add hipMemcpy2DfromArray (#1510)
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.

[ROCm/clr commit: 14b870d1ce]
2019-10-25 15:43:33 +05:30
Anusha Godavarthy Surya 2d538b702d Merge branch 'master' into tex_unbind_issue_fix
[ROCm/clr commit: c0fc5e718c]
2019-10-25 15:36:55 +05:30
foreman fbf144ab47 P4 to Git Change 2019270 by chui@ocl-promo-incrementor on 2019/10/25 03:00:52
SWDEV-2 - Change OpenCL version number from 3025 to 3026.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2773 edit


[ROCm/clr commit: 81c59e130f]
2019-10-25 02:10:07 -05:00
Anusha Godavarthy Surya 1dd70e007b Fixed CI build failure
[ROCm/clr commit: b9c8dd8ac6]
2019-10-25 12:21:41 +05:30
amd-lthakur 796566f156 Refactored the file as suggested
[ROCm/clr commit: b2238bacd4]
2019-10-25 10:44:38 +05:30
amd-lthakur 40c7970293 Update matmul.cpp
[ROCm/clr commit: 84fb936dfe]
2019-10-25 09:22:07 +05:30
amd-lthakur 42fe3f5247 Update hipExtModuleLaunchKernel.cpp
[ROCm/clr commit: 9a860e6766]
2019-10-25 09:19:49 +05:30
foreman a7589c8573 P4 to Git Change 2019036 by gandryey@gera-win10 on 2019/10/24 17:06:27
SWDEV-208424 - ROCr language runtime should not free code object until executable destroy
	- Keep the code object reader alive until the program destruction. Update HSAIL path only, since LC path already handles it correctly.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#107 edit


[ROCm/clr commit: a1c86d10b5]
2019-10-24 17:15:52 -04:00
foreman 7c5f631286 P4 to Git Change 2019005 by gandryey@gera-win10 on 2019/10/24 16:25:40
SWDEV-79445 - OCL generic changes and code clean-up
	- Fix memory leaks in COMGR path.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#64 edit


[ROCm/clr commit: ee2f6fcf88]
2019-10-24 16:29:54 -04:00
foreman 290a5d2463 P4 to Git Change 2018917 by gandryey@gera-win10 on 2019/10/24 14:33:36
SWDEV-197289 - VDI tracing API integration in rocTracer
	- Change the names of the functions according to the new interface

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_activity.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#34 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#32 edit


[ROCm/clr commit: 565ba944d0]
2019-10-24 14:40:22 -04:00
foreman 737f07fa24 P4 to Git Change 2018860 by gandryey@gera-win10 on 2019/10/24 13:29:26
SWDEV-207662 - [EURI][OPENCL][Forum 244452]: Multiple printf statements inside kernel producing strange output on Vega on Windows
	- Correct the printf arguments parsing logic. Don't use local PrintfInfo info, because it can contain some stale data after the first iteration

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#27 edit


[ROCm/clr commit: 7ad6787328]
2019-10-24 13:30:53 -04:00
Rahul Garg 6760e4065e Update profiling doc (#1576)
[ROCm/clr commit: ff8d3fa446]
2019-10-24 17:51:55 +05:30
Jatin Chaudhary e7f4cf4487 Adding New Analyze Target Merging with cppcheck (#1583)
[ROCm/clr commit: f53b1a1755]
2019-10-24 17:46:06 +05:30
Rahul Garg 7f429afe2e Add HIP checks in texture driver sample (#1581)
[ROCm/clr commit: 170c4f0270]
2019-10-24 17:45:51 +05:30
gandryey 21a2925ee7 Hip vdi profiling header (#1577)
Add HIP-VDI profiling interface for GPU timing collection.

[ROCm/clr commit: f25692b399]
2019-10-24 17:45:42 +05:30
Alex Voicu 5b917afa5f Make CAS loops use the TTAS idiom. (#1573)
* Make CAS loops use the TTAS idiom.

* More efficient re-formulation of TTAS.

* Fix typo.

* The typo was not quite a typo


[ROCm/clr commit: 26914ec76e]
2019-10-24 17:45:20 +05:30
satyanveshd ad1e409a24 Fix occupany APIs (#1560)
Addresses SWDEV-205006 

[ROCm/clr commit: 6c5fbf9b4a]
2019-10-24 17:44:47 +05:30
searlmc1 510be4b5dc Improve performance of v2 arg handling (#1539)
* Improve performance of v2 arg handling

* Missing change to `std::string`


[ROCm/clr commit: 15a699688e]
2019-10-24 17:44:05 +05:30
Alex Voicu fb411b56c2 Improve scalar access into vector types. (#1531)
The improvement is based on the ideas here: https://t0rakka.silvrback.com/simd-scalar-accessor. It yields significantly better ISA when the base's .xyzw members are used.

[ROCm/clr commit: 84d5b399f6]
2019-10-24 17:43:49 +05:30
Aryan Salmanpour 9e0eaef846 [hip] add support for implicit kernel argument for multi-grid sync (#1456)
* [hip] add support for implicit kernel argument for multi-grid sync

* modified code for calculating the prev_sum

* change the impCoopArg type to size_t

* add memory clean up

* launch init_gws and main kernels into two separate loops


[ROCm/clr commit: 93c688a0c9]
2019-10-24 17:43:30 +05:30
amd-lthakur 5189d287eb Adding a directed test case for hipExtModuleLaunchKernel() api.
[ROCm/clr commit: 0adcc890b0]
2019-10-24 15:06:28 +05:30
foreman cbe0399836 P4 to Git Change 2018621 by chui@ocl-promo-incrementor on 2019/10/24 03:01:03
SWDEV-2 - Change OpenCL version number from 3024 to 3025.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2772 edit


[ROCm/clr commit: 3991264b0f]
2019-10-24 03:05:42 -04:00
Rahul Garg 764135d242 Merge pull request #1559 from vsytch/win10_aligned_alloc
Fixes for hipMemcpy_simple on Windows

[ROCm/clr commit: 465581612e]
2019-10-23 13:10:59 -07:00
Evgeny Mankov 48b264c154 Merge pull request #1578 from emankov/doc
[HIPIFY][cmake][#1571] Take into account building hipify-clang as a part of building HIP while installing

[ROCm/clr commit: 80bf79c2f8]
2019-10-23 21:23:05 +03:00
Evgeny Mankov 50d72e13ca [HIPIFY][cmake][#1571] Take into account building hipify-clang as a part of building HIP while installing
[Algorithm]
  [Release]
    If CMAKE_INSTALL_PREFIX is set by the user:
       If BIN_INSTALL_DIR is set by HIP, use it as CMAKE_INSTALL_PREFIX, otherwise CMAKE_INSTALL_PREFIX is used unchanged.
    If the user does not set CMAKE_INSTALL_PREFIX (CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT):
       If BIN_INSTALL_DIR is set by HIP, use it as CMAKE_INSTALL_PREFIX, otherwise use PROJECT_BINARY_DIR/bin for installation.
  [Debug]
    If CMAKE_INSTALL_PREFIX is set by the user:
       CMAKE_INSTALL_PREFIX is used unchanged.
    If the user does not set CMAKE_INSTALL_PREFIX (CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT):
       use CMAKE_CURRENT_SOURCE_DIR/bin for installation.

Standalone build left unchanged: CMAKE_INSTALL_PREFIX is used if set.


[ROCm/clr commit: 2435567e70]
2019-10-23 18:54:45 +03:00
foreman d81a977d9c P4 to Git Change 2018213 by eshcherb@evgeny-hip on 2019/10/23 11:36:28
SWDEV-197287 - exporting interception functions

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#33 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#31 edit


[ROCm/clr commit: a416e55516]
2019-10-23 11:45:28 -04:00
foreman 16402a2368 P4 to Git Change 2017982 by chui@ocl-promo-incrementor on 2019/10/23 03:00:51
SWDEV-2 - Change OpenCL version number from 3023 to 3024.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2771 edit


[ROCm/clr commit: 707020264f]
2019-10-23 03:09:40 -04:00
foreman e596e7a7a7 P4 to Git Change 2017678 by jujiang@JJ-OCL-hip on 2019/10/22 17:01:21
SWDEV-208594 - Output mismatch with texture functions

	Revert CL#2014458 for now

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#24 edit


[ROCm/clr commit: f226cb6041]
2019-10-22 17:06:07 -04:00
foreman 4525235100 P4 to Git Change 2017443 by eshcherb@evgeny-hip on 2019/10/22 12:00:47
SWDEV-197287 - prof_protocol fix

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/prof_protocol.h#2 delete
... //depot/stg/opencl/drivers/opencl/runtime/platform/prof_protocol.h#2 edit


[ROCm/clr commit: bd22579c3f]
2019-10-22 12:38:12 -04:00
foreman 9ee15e70c2 P4 to Git Change 2017443 by eshcherb@evgeny-hip on 2019/10/22 12:00:47
SWDEV-197287 - prof_protocol fix

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/prof_protocol.h#2 delete
... //depot/stg/opencl/drivers/opencl/runtime/platform/prof_protocol.h#2 edit


[ROCm/clr commit: 7d6a2ab8f7]
2019-10-22 12:38:12 -04:00
Evgeny Mankov b34b56a761 Merge pull request #1574 from emankov/hipify-clang
[HIPIFY] Disable delayed template parsing

[ROCm/clr commit: 3d16a8b121]
2019-10-22 19:09:13 +03:00
Evgeny Mankov 0896e41987 [HIPIFY] Disable delayed template parsing
By implicit unconditional passing -fno-delayed-template-parsing option (which appeared in LLVM 3.8.0, thus doesn't need compatibility wrapping) to hipify-clang.

[Reason] To parse uncalled template functions otherwise they are not parsed without calling, thus not hipified.

Affects cub_03.cu test, which has uncalled global template function.


[ROCm/clr commit: 7ab06b3892]
2019-10-22 19:07:37 +03:00
Evgeny Mankov 7426cbee0d Merge pull request #1570 from emankov/doc
[HIPIFY][#1569] Fix

[ROCm/clr commit: bf879f9c86]
2019-10-22 11:13:47 +03:00
Evgeny Mankov 82222bf945 [HIPIFY][#1569] Fix
[ROCm/clr commit: e2191e23e6]
2019-10-22 11:08:37 +03:00
Evgeny Mankov fe97898c1a Merge pull request #1568 from emankov/hipify-clang
[HIPIFY][tests] Set max clang's CudaArch for corresponding CUDA major…

[ROCm/clr commit: 62fc6f8487]
2019-10-21 17:52:02 +03:00