Commit Graph

13402 Commits

Author SHA1 Message Date
Rakesh Roy cba04140c0 SWDEV-332603 - Check validity of ihipArrayCreate() first argument
Change-Id: Ifd0bdb5708c110da45e4baa9426cccd749732822


[ROCm/clr commit: 8ea74366d7]
2022-04-22 11:08:37 +05:30
Rakesh Roy 7a572e0162 SWDEV-332604 - Add nullptr check for argument pitch
Change-Id: I6d7aa5356a74b92f21f7a51a7d3e2f8d0b920e07


[ROCm/clr commit: 2613ebf157]
2022-04-22 00:13:24 -04:00
Christophe Paquot 1c5b11fd04 SWDEV-322620 - Virtual Memory Management
Implement hipMemAddressFree and hipMemAddressReserve

Change-Id: I1b09e433db5c5c6d6b9fe2a7a15fe2c09f1e1874


[ROCm/clr commit: fd17b53ea4]
2022-04-21 17:19:10 -04:00
German Andryeyev ecb4165943 SWDEV-333607 - Avoid synchronization of all GPU(s)
Use the original device from creation to sync before host memory
free.

Change-Id: I510e34afa7accf69e3d01338587bbc817b981cec


[ROCm/clr commit: b4c5a01fbc]
2022-04-21 15:36:04 -04:00
Christophe Paquot 0c5bc58a57 SWDEV-322620 - Virtual Memory Management
Implement virtualFree for PAL

Change-Id: I4482777fa52c979d42a7c57103862e2e02279024


[ROCm/clr commit: 4c3a20a16e]
2022-04-21 14:45:11 -04:00
Alex (Bin) Xie 757ad58402 SWDEV-329646 - MicroStation app crash upon closing
Change-Id: I0ca272be42934ee96f45300fa06847cd74170f13


[ROCm/clr commit: 10648c4d70]
2022-04-21 12:29:48 -04:00
Chauncey Hui 6ae15161fd SWDEV-2 - Change OpenCL version number from 3451 to 3452
[ROCm/clr commit: d15c1ebae8]
2022-04-21 03:00:08 -04:00
Saleel Kudchadker 415c5a5766 SWDEV-333237 - Disable cache status
Enable Cache status only for ROC_EVENT_NO_FLUSH

Change-Id: I0de4c5af2226bccd66fd704be23c2db33050f2e2


[ROCm/clr commit: 8864e53265]
2022-04-20 18:12:33 -04:00
Jason Tang 2acbfbc801 SWDEV-1 - Disable OCLAtomicCounter for now
OCLAtomicCounter should only be run when the compiler is HSAIL.

Change-Id: I862e23b22157d2c25bc5697fa58079c78040f5f5


[ROCm/clr commit: a3fe0fafe2]
2022-04-20 16:38:48 -04:00
Ranjith Ramakrishnan db71771099 SWDEV-329277 - Populate hip_version.h wrapper file with actual file contents as dead code
Some components like tensorflow search for the contents of hip_version.h
For backward compatibility insert actual file contents in wrapper file as non executable code
Improvements: wrapper header template file checked in, instead of generating it on runtime
Redundant codes for unsetting variables removed

Change-Id: I67ee48437f8959d8ed70946412d09be3ed262e58


[ROCm/clr commit: 95d0b79ca0]
2022-04-20 12:08:56 -07:00
Alex (Bin) Xie ad6b22597e SWDEV-329646 - MicroStation app crash upon closing
Change-Id: Ie3422788c80b233c836e319c355214ca076e5d4f


[ROCm/clr commit: 3d514c85b9]
2022-04-20 14:34:44 -04:00
Julia Jiang 1320312a62 SWDEV-330164 - Fix in conformance svm_enqueue_api crash
Change-Id: I12eca6ca3e8d722b7534047fca79b289604aa2b0


[ROCm/clr commit: b1611e0123]
2022-04-20 13:20:18 -04:00
Chauncey Hui 2fe395acf1 SWDEV-2 - Change OpenCL version number from 3450 to 3451
[ROCm/clr commit: 4664bde25e]
2022-04-20 03:00:06 -04:00
Jeremy Newton 990733e85d Merge "SWDEV-321116 - Allow disabling ICD loader" into amd-staging
[ROCm/clr commit: 3121b1020a]
2022-04-19 12:35:21 -04:00
Sarbojit Sarkar a687844e68 SWDEV-332809 - Fix for OpenMp crash
Change-Id: I70445edf76261ab8ecf174614f23bd9fb8d60881


[ROCm/clr commit: 71b5235c64]
2022-04-19 11:29:19 -04:00
Alex Xie d7bac9b567 SWDEV-330240 - HLK pnp with IO stress test fail
This code change is to improve error handling.
This code change does not fix issue itself.
Before this code change, hostcallBuffer_ point is initialized in the end of
create() function. If create function fails and returns early,
hostcallBuffer_ point is not initialized. This non-initialized point can
cause access violation when object is destructed.

This code change put the initialization of the pointer in the constructor.

Change-Id: I7fb6e764eb0547196dca03db237e49d3ff0fd06a


[ROCm/clr commit: 5528812aa9]
2022-04-19 11:04:26 -04:00
Chauncey Hui 197b30f798 SWDEV-2 - Change OpenCL version number from 3449 to 3450
[ROCm/clr commit: 66ecd38af6]
2022-04-19 03:00:06 -04:00
Sarbojit Sarkar e22f2e1714 SWDEV-323441 - support for default stream per thread
Change-Id: I0032da0357f5cffbf5e4ec4a02435d2a128a262b


[ROCm/clr commit: fc1f02bbed]
2022-04-18 23:19:55 -04:00
Saleel Kudchadker b306843e26 SWDEV-332512 - Signal pool changes
Create a new signal if the next set of signals are busy

Change-Id: I5108e68c88fe41e3a45bad4495ebdf3742e76dcd


[ROCm/clr commit: 9ec8a7306d]
2022-04-18 15:58:38 -04:00
Saleel Kudchadker d4991641bd SWDEV-301667 - Add separate field for event scope
Change-Id: I0e6b50d1a34b275ea4f1a4c659430c406d9a5a7e


[ROCm/clr commit: aace42cfab]
2022-04-18 15:48:33 -04:00
German Andryeyev 3de1a9e36c SWDEV-311271 - Make sure memory pool can accept default stream
Add lock protection for access to the pool list.
Remove destroyed stream from the list of the safe streams

Change-Id: I1863b89bd3f5e188c161227cc790c3adaf72cc58


[ROCm/clr commit: 5957ff9f7b]
2022-04-18 10:34:21 -04:00
Satyanvesh Dittakavi 5516c2d12e SWDEV-308763 - Remove older hiprtc implementation
Change-Id: I1f0a1fe9b6590070905348bf71b901ac77b196be


[ROCm/clr commit: b06ee8834d]
2022-04-18 05:12:53 -04:00
Satyanvesh Dittakavi 3db2dd9812 SWDEV-332371 - Address seg fault with hip event tests on Windows
Change-Id: I0367f6dbb395b3032c97692c5bde6e99d503c6a9


[ROCm/clr commit: 3b525ad298]
2022-04-18 04:19:23 -04:00
Saleel Kudchadker cad3dfe4ec SWDEV-301667 - Separate scope from marker_ts_
Change-Id: I19f4d394e898bfb8c9d9a2c2edf9d5bf5def3b08


[ROCm/clr commit: b6cbfaf499]
2022-04-16 19:26:31 -04:00
Chauncey Hui 1c28cbdfb6 SWDEV-2 - Change OpenCL version number from 3448 to 3449
[ROCm/clr commit: 5d9063147c]
2022-04-16 03:00:07 -04:00
pghafari 4ace297a73 SWDEV-324412 - Removing depth24
OGLP fails conformance tests with depth24

Change-Id: I1efd66a81f64a5b999d0f3c3e9314b9e6129a587


[ROCm/clr commit: 4d54f873b0]
2022-04-15 15:31:03 -04:00
Chauncey Hui 78be6cdf22 SWDEV-2 - Change OpenCL version number from 3447 to 3448
[ROCm/clr commit: 6cd647270b]
2022-04-15 03:00:06 -04:00
Christophe Paquot 1024cb58a7 SWDEV-322620 - Virtual Memory Management
Adding virtual memory management APIs to rocclr.
The HIP layer will handle virtual allocs on devices.

Change-Id: Ia978f105c2c3fed3959c77580ba228e845105754


[ROCm/clr commit: b5f555f9ec]
2022-04-15 00:10:02 -04:00
German Andryeyev 4b4137ae63 SWDEV-332512 - Add ROC_SIGNAL_POOL_SIZE
Default value is 32 HSA signals in the pool.

Change-Id: Icb69413d3ff6ef228d9a9e22fd024e72c6d8ebe4


[ROCm/clr commit: 7975a07112]
2022-04-14 17:32:00 -04:00
Sourabh Betigeri 9caddbf38a SWDEV-331301 - Fixes error code mismatch
Change-Id: I8dda98609b16ea5c1ce4d9db9471e61e5fb0c12c


[ROCm/clr commit: bd851550bd]
2022-04-13 18:51:06 -07:00
Jeremy Newton dbacdbdf88 SWDEV-321116 - Allow disabling ICD loader
This patch adds an option (BUILD_ICD) to toggle the ICD loader build
with rocm-opencl. This isn't useful for official ROCm use, but distros
or users may want build rocm-opencl with their own OCL ICD loader.

The default option is BUILD_ICD=ON.
If this option is set to OFF, an OpenCL OCD loader must be installed
prior to attempting to build rocm-opencl.

E.g. distros already provide ocl icd loader packages:
sudo yum install ocd-icd-devel
sudo apt-get install ocl-icd-opencl-dev
sudo zypper install ocd-icd-devel

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I6006593eceed543cd829e8949ec2256482815673


[ROCm/clr commit: d1782940f3]
2022-04-13 18:27:13 -04:00
sdashmiz f8355f5fb0 SWDEV-329349 - add display support for Opencl
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Icf5253ba87f3852153c620fb7b789bd6e90cb52e


[ROCm/clr commit: 9f5685ea0a]
2022-04-13 15:11:29 -04:00
Chauncey Hui 4d573e013b SWDEV-2 - Change OpenCL version number from 3446 to 3447
[ROCm/clr commit: ac4ad0ab73]
2022-04-13 03:00:06 -04:00
Saleel Kudchadker 50f0103648 SWDEV-276210 - Honor scopes for hipEventRecord
Honor hipEventReleaseToDevice and hipEventReleaseToSystem flags.
hipEventRecord would flush caches if no release flags are provided. To
change this behavior set ROC_EVENT_NO_FLUSH=1

Change-Id: I03e41b515b1d0cf963b0c2d5b9901b09e71a0e59


[ROCm/clr commit: f320acb797]
2022-04-13 00:35:19 -04:00
Jaydeep Patel 3a7351ef9c SWDEV-330666 - null(default) stream's priority is 0.
Change-Id: I115effc2ddaa28dee32967ee28041b9b8da095b9


[ROCm/clr commit: c1503da69b]
2022-04-13 00:28:52 -04:00
Sourabh Betigeri 89ca29819e SWDEV-329848 - Fixes error code mismatch between CUDA and HIP
Change-Id: Ic48de159ca7bdb4b91dadb915972e535518635ae


[ROCm/clr commit: 345e02358c]
2022-04-12 15:00:44 -04:00
Saleel Kudchadker 3d0100c5ab SWDEV-301667 - Add cache state for a device
- Add a global cache state for a device to indicate scopes of submitted
AQL packets
- Remove scopes for TS marker if hipEventReleaseToDevice is passed. Set
env ROC_EVENT_NO_FLUSH=1 to use NOP AQL for event records.
It would flush caches by default with system scope release.
- Calling finish() should ensure if caches are flushed, if not queue a
marker

Change-Id: Ibbbdbb1cd7ac61cb35649169212142545be159e0


[ROCm/clr commit: 8eeaa998c0]
2022-04-12 12:27:31 -04:00
Hao Yuan abc4522fa3 Merge "SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers" into amd-staging
[ROCm/clr commit: 4d300d1f8a]
2022-04-12 11:00:51 -04:00
haoyuan2 0d4efc9f0f SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers
Change-Id: Ibd3388f0981672cd209d7370f8a28b2883abdea2


[ROCm/clr commit: cb4aabd285]
2022-04-12 11:00:20 -04:00
Chauncey Hui cb7802bc8a SWDEV-2 - Change OpenCL version number from 3445 to 3446
[ROCm/clr commit: 857634241b]
2022-04-12 03:00:05 -04:00
Sarbojit Sarkar 85f6f2a0c7 SWDEV-331126 - Fix to Cuda return type
Change-Id: Iea8e7735ef0c58c1244c92338038d91e61d62c16


[ROCm/clr commit: 8657c40721]
2022-04-11 23:35:04 -04:00
haoyuan2 be69f68ec7 SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers
Change-Id: Idc84eb0db92d21a5ced8769fa1eae064b86c31b0


[ROCm/clr commit: 1fbc01a812]
2022-04-11 16:55:59 -04:00
Maxime Chambonnet 38928e85c1 SWDEV-1 - ROC CLR typos
This is cherry-picked from this github issue:
https://github.com/ROCm-Developer-Tools/ROCclr/issues/28

Change-Id: I236f4f25a2dabe05883159af0fab0bad06ab0fd0


[ROCm/clr commit: d45794e985]
2022-04-11 14:24:39 -04:00
German Andryeyev 3f93be3aec SWDEV-307184 - Hidden heap keyword was renamed
Change-Id: I0a72b0cc16bd3d637cbaa79a692640bc922f62c4


[ROCm/clr commit: abf088ea89]
2022-04-11 09:26:14 -04:00
Ajay 013225775c SWDEV-331095 - Address hipRTC windows test failures
Change-Id: I8c1a36ffd362c6f41449092e4dd85f6ec587206a


[ROCm/clr commit: f301bf3962]
2022-04-11 09:40:35 +00:00
Chauncey Hui ac9195f34a SWDEV-2 - Change OpenCL version number from 3444 to 3445
[ROCm/clr commit: 66d404f707]
2022-04-09 03:00:05 -04:00
haoyuan2 605958392b SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers
Change-Id: I89db993ba90783c53546c5290c00e13f5c24edf4


[ROCm/clr commit: fe173ed9fb]
2022-04-08 12:12:07 -07:00
Jeremy Newton 6e388071ba SWDEV-321118 - Use GNUInstallDirs
Use GNUInstallDirs variables to determine the location of BINDIR,
LIBDIR, DOCDIR, and SYSCONFDIR.

Note that CMAKE_INSTALL_LIBDIR is overriden, since the default for RHEL
is lib64, but ROCm packaging wants it to be lib always. Distros or users
can easily override this.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Ifb38263dce80d80c5ebb4eacd8e49c76bb013a44


[ROCm/clr commit: b8c124acb5]
2022-04-08 13:52:08 -04:00
German Andryeyev 4715a87d44 SWDEV-307184 - Report 1 for unused dimensions
Remove assert for kernel arg size, because COv5 reports a value
bigger than the actual usage in the most of cases

Change-Id: I8e15bc45a9e21b58a5894f9977511ca84408ce61


[ROCm/clr commit: 2be0b1e612]
2022-04-08 13:43:37 -04:00
Jeremy Newton 2e2f21df24 SWDEV-323669 - Improve arch detection
- Clean up detection by using visual studio macros to detect arch; I
  didn't list all possible ARM platforms (can be done later if desired)
- Fixed two incorrect uses of !defined(ATI_ARCH_ARM) to instead use
  defined(ATI_ARCH_X86), as they contain X86 specific code
- Fixed one use of __ARM_ARCH_7A__ to use ATI_ARCH_ARM instead

This is an improvement to the fixes in the last patch for SWDEV-323669

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I8568167293c34ad5331902105877f3ab6e25acb3


[ROCm/clr commit: 00efdc1cd6]
2022-04-08 12:21:58 -04:00