Граф коммитов

841 Коммитов

Автор SHA1 Сообщение Дата
Sarbojit2019 3a20a14134 [dtests] Separated C macros from CPP header file (#1429)
* Separated C macros from CPP header file

* Updated review comment


[ROCm/clr commit: 6c06fb5f0a]
2019-10-01 12:38:32 +05:30
Yaxun (Sam) Liu 2ed78f20a2 Fix cast of __half for HIP-clang (#1475)
[ROCm/clr commit: 7b3b82bd0d]
2019-09-30 10:40:42 +05:30
AlexBinXie 933d31f374 [hip] Added gfx803,gfx1010,gfx1012 kernel binary hipModule test. (#1444)
This is to address hipModule test seg fault in GFX1010

[ROCm/clr commit: cda068edd5]
2019-09-30 10:38:37 +05:30
Evgeny Mankov 3ee668a9b9 [HIPIFY][#1439] Add reinterpret_cast to args of some functions
+ Perl part of [#1458]
+ Affected functions: hipFuncSetCacheConfig, hipFuncGetAttributes
+ Implement function generateHostFunctions() in hipify-clang for that purposes
+ Update hipify-perl accordingly


[ROCm/clr commit: 1db7c1d694]
2019-09-25 18:53:17 +03:00
Evgeny Mankov d3adb0478f [HIPIFY][#1439] Add reinterpret_cast to args of some functions
+ Affected functions: hipFuncSetCacheConfig, hipFuncGetAttributes
+ Add a corresponding Matcher cudaReinterpretCastArgFuncCall
+ Add reinterpret_cast.cu test

TODO: Do the same for hipify-perl


[ROCm/clr commit: cf467b4550]
2019-09-24 09:44:17 +03:00
Evgeny Mankov 2ee59279d6 [HIPIFY][#1435] Add HIP_SYMBOL wrapper to the templated Device Symbol argument of the following functions:
cudaMemcpyToSymbol, cudaMemcpyToSymbolAsync, cudaGetSymbolSize, cudaGetSymbolAddress, cudaMemcpyFromSymbol, cudaMemcpyFromSymbolAsync

+ Add a corresponding cudaSymbolFuncCall matcher.
+ Add device_symbols.cu test for the above 6 functions, update existed.
+ Fix dim3() type cast issue, update affected tests.

TODO: Do the same in hipify-perl


[ROCm/clr commit: d4f8c6bc4b]
2019-09-19 19:33:42 +03:00
Evgeny Mankov 3f90cba68a [HIPIFY][perl][fix] Treat ::device_function as a device function
+ Do not treat somenamespace::device_function_name as a device function
+ Fix generation of warnUnsupportedDeviceFunctions function in hipify-clang
+ Update hipify-perl based on hipify-clang -perl generation
+ Update device test math_functions.cu for hipify-perl

[Restrictions]
- hipify-perl is yet unable to handle function declarations in user namespaces
- hipify-perl is yet unable to handle using directive


[ROCm/clr commit: b43bb7d3c1]
2019-09-16 17:36:55 +03:00
AlexBinXie cc921b35be [hip]Skip test when hipHostMallocCoherent is not supported by implementation (#1380)
[ROCm/clr commit: 313726a457]
2019-09-16 08:31:43 +00:00
ansurya 4436a38e65 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/clr commit: e2a934f377]
2019-09-16 08:31:30 +00:00
Aryan Salmanpour 2596af7f32 [hip][tests] add a unit test for testing hipLaunchCooperativeKernel (#1361)
* [hip][tests] add a unit test for testing hipLaunchCooperativeKernel

* use __ockl_grid_sync function

* remove already defined __ockl_grid_sync function

* use sync function for grid synchronization


[ROCm/clr commit: 51c7fedd36]
2019-09-16 08:31:09 +00:00
Evgeny Mankov 4cfb3aa7b7 [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);


[ROCm/clr commit: 4e3845be83]
2019-09-10 15:59:06 +03:00
Evgeny Mankov 755d1a9ea6 [HIPIFY] Add device functions support
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.


[ROCm/clr commit: aec10d6ee1]
2019-09-06 18:34:12 +03:00
Evgeny Mankov 790ab87461 [HIPIFY][perl][#259] Fix
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );


[ROCm/clr commit: e26ec02a99]
2019-09-03 16:44:20 +03:00
Evgeny Mankov 12efe906e7 [HIPIFY][tests] Add occupancy test
[ROCm/clr commit: 608331250e]
2019-09-02 17:54:06 +03:00
Sameer Sahasrabuddhe 929b6d5f34 remove obsolete test for OCKL Asynchronous Streams
The implementation for OCKL AS was recently removed from the device
library since that feature is now superseded by hostcall.


[ROCm/clr commit: 68c133bd78]
2019-08-30 20:41:29 +05:30
Evgeny Mankov 2b87d21227 Merge pull request #1372 from emankov/master
[HIPIFY][#207][fix] Translate all preprocessor's conditional blocks

[ROCm/clr commit: 451721a821]
2019-08-29 10:30:05 +03:00
Sarbojit2019 4d23e35532 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/clr commit: 1ae43cbeba]
2019-08-29 01:02:41 +00:00
Evgeny Mankov 65ba03dd4c [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly


[ROCm/clr commit: 32f22a0117]
2019-08-28 21:17:35 +03:00
Rahul Garg a160d3ee2e [dtests] refactor windows specific changes (#1313)
* [dtests] refactor windows specific changes

* Refactor hipMemoryAllocateCoherentDriver - PR- 1309

* Fix missing z in _putenv_s

* Revert "Fix missing z in _putenv_s"

This reverts commit 099a1b20a5c75c5f122d57c0ad2bca01745cdc9c.

* Refactor changes from PR 1299

* Update hipEnvVarDriver.cpp


[ROCm/clr commit: c741ad3c80]
2019-08-16 02:13:00 +00:00
Maneesh Gupta 7a43bb6606 [hit] Add support for specifying dependencies in HIT syntax (#1323)
[ROCm/clr commit: 3634695737]
2019-08-14 11:30:42 +00:00
Evgeny Mankov e3cb2756c4 [HIPIFY] Add cudaMallocManaged -> hipMallocManaged
+ Add mapping for corresponding data types
+ Add a test
+ Update docs


[ROCm/clr commit: 9166b1554e]
2019-08-13 17:56:06 +03:00
Evgeny Mankov 7ade29f870 [HIPIFY][cuRAND][#1257] Fix
+ Update CURAND_API_supported_by_HIP.md and test accordingly


[ROCm/clr commit: 2ee0ecde06]
2019-08-09 21:27:16 +03:00
amd-lthakur 079ed286ba [dtests] Fix build issues with hipMemoryAllocateCoherentDriver.cpp on windows (#1309)
Compilation error being observed due to popen(), pclose() and setenv() linux calls on windows. Replaced with appropriate calls on windows.

[ROCm/clr commit: 19ad365834]
2019-08-09 11:53:16 +00:00
amd-lthakur 7879220c48 [dtests] Fix build issue with hipMemcpy_simple.cpp on windows (#1306)
Compilation error being observed on windows due to aligned_alloc() call. Mapped the call to _aligned_malloc() for windows.

[ROCm/clr commit: 93f5940ef8]
2019-08-09 11:52:46 +00:00
ansurya 68135c897a [dtests[ Fix build issues with hipEnvVar*.cpp on windows (#1299)
* replace getopt with clara based command line options

* Removed header getopt.h

[ROCm/clr commit: fc60f3a95b]
2019-08-09 11:52:10 +00:00
amd-lthakur 6c8ea45278 [dtests] Fix build issues with hipLaunchParm.cpp on windows (#1293)
* Removed unwanted #include sys/time.h , gettimeofday() and timeval variables and this also helps avavoid compilation error in windows due to gettimeofday() call equivalent of which is not available in windows

* Changed the Macro name from GPU_PRINT_TIME to MY_LAUNCH_MACRO


[ROCm/clr commit: 36977dc276]
2019-08-09 11:50:10 +00:00
amd-lthakur 421f940def [dtests] Fixed build issues with hipAsynchronousStreams.cpp on windows (#1292)
Changed the third arg of the functions __hip_as_write_block and __ockl_as_write_block from ulong to uint64_t so as to fix the compilation error in windows

[ROCm/clr commit: c212c484af]
2019-08-09 11:49:31 +00:00
lthakur b62254608c Resubmitting the fix so as to address the changed format in the last submission
[ROCm/clr commit: 80acd13ba7]
2019-08-08 11:26:26 +05:30
lthakur 6a15871e91 Fixed compilation errors being observed on windows
[ROCm/clr commit: c4f6d58354]
2019-08-07 15:54:46 +05:30
Sarbojit2019 55fa6a83c6 Enabled gcc for hip host code (#1214)
* Enabled gcc for hip host code

* Adding tests for hip code + (gcc & g++), without kernels

* Excluding nvcc platforms for gcc and g++ tests + Addressing review comments

* minor code clean-up

* Add rocm include path

* Added relative path for library

* Hiding non supported functions for gcc

* Incorporating review comments


[ROCm/clr commit: f23c1a1499]
2019-08-05 09:51:36 +00:00
Evgeny Mankov e278fbf2f9 [HIPIFY][fix][#211] Taking into account include guard controlling macro
...while including HIP main header file, which is inserted now after #indef controlling macro, or after #pragma once, if it's occurred earlier.

+ Add a couple of unit tests.
ToDo: Check backward compatibility on older clang versions.


[ROCm/clr commit: fedef02c37]
2019-08-02 16:46:45 +03:00
wkwchau 7b0f478767 Added CooperativeLaunch and CooperativeMultiDeviceLaunch flag and property for hipDeviceGetAttribute() and hipGetDeviceProperties() (#1247)
[ROCm/clr commit: ed04e96e2d]
2019-08-02 10:00:25 +00:00
wkwchau 75f1bb21b3 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases


[ROCm/clr commit: abe6776677]
2019-08-01 16:03:35 +00:00
Maneesh Gupta 969eddc258 Merge pull request #1276 from vsytch/SWDEV-197675
[hip][tests] Don't use a hardcoded warp size, since it can be dynamically changed.…

[ROCm/clr commit: 6ee5fcc07c]
2019-08-01 08:59:43 +00:00
wkwchau a19b4fbd8b Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()


[ROCm/clr commit: 7b9801fe9a]
2019-08-01 08:58:48 +00:00
Vladislav Sytchenko 5b201fe854 Don't use a hardcoded warp size, since it can be dynamically changed. Query it from the runtime instead.
[ROCm/clr commit: 9a1835ddc3]
2019-07-31 17:04:31 -04:00
Rahul Garg 3b5dac1d9d Add HIP init in hipFuncGetAttributes (#1262)
* Add HIP init in hipFuncGetAttributes

* [dtest]Remove explicit hip init call in hipFuncGetAttributes dtest


[ROCm/clr commit: c610159b85]
2019-07-31 15:42:08 +00:00
ansurya 733178f492 Testcase to validate signed/unsigned char,short as normalized float (#1267)
* Testcase to validate signed/unsigned char,short as normalized float

* corrected test_common.cpp file path


[ROCm/clr commit: 440c5f1677]
2019-07-31 05:02:35 +00:00
Aryan Salmanpour 8b0c37a9ce [hip][tests] add a unit test for using hipExtLaunchMultiKernelMultiDevice API (#1250)
[ROCm/clr commit: 571af6d85b]
2019-07-24 07:57:39 +00:00
Aaron Enye Shi 73af1ac4bd Add GFX908 specific changes to HIP (#1229)
* Add GFX908 specific for HIP

* Fix missing __halfTest in hipTestNativeHalf


[ROCm/clr commit: 8c82f9db77]
2019-07-24 07:51:17 +00:00
Maneesh Gupta a1e4200ee8 [dtests] Fix complex_loading_behavior.cpp build issues on nvcc path (#1242)
[ROCm/clr commit: 7feda764b6]
2019-07-24 07:49:39 +00:00
Aaron Enye Shi 99ca4c2483 Fix hipMemcpy-size test running out of Host Mem (#1224)
* Fix hipMemcpy-size test running out of Host Mem

The hipMemcpy-size uses a maxElem calculated from the total GPU mem /8. Then it will allocate 4 times that amount of host memory. This tests begins failing when there is not enough host memory, such as on systems with 32GB GPU mem, and 16GB RAM. This fixes the test if not enough host memory is available on the system.

* Add windows support to hipMemcpy-size fix

* avoid linking extra libs for windows

* HIPMemcpy-size Remove freeCPU including swap


[ROCm/clr commit: c56876cc19]
2019-07-24 07:49:20 +00:00
Maneesh Gupta f0f831daa7 [hit] Workaround for %cc and %cxx mappings. (#1233)
* [hit] Workaround for %cc and %cxx mappings.

HIP CMakeLists.txt modifies CMAKE_C_COMPILER and CMAKE_CXX_COMPILER.
This messes up any dtests that want to test against cc/c++.

So hardcode %cc to /usr/bin/cc and %cxx to /usr/bin/c++ for now till
we come up with a better solution.

Change-Id: I7dce93ce8360191e612a94e3a735e5612ac27ab5

* [hit] Add auto-variable %hip-path to syntax for BUILD_CMD

Change-Id: Id097a183fbce2b2c9691d0180d3304dd17a4e016


[ROCm/clr commit: af9aae6b4e]
2019-07-19 04:45:56 +00:00
ansurya af2df395a0 [HIP][Tests] Added new testcases for Module API (#1150)
* [HIP][tests] New testcases for module api

* [HIP][Tests]Support for CUDA devices

* Updated tests as per latest master & test GetGlobal to work on all platforms


[ROCm/clr commit: f566bec546]
2019-07-19 04:45:20 +00:00
ansurya 8b8946f78b Add Max Texture 1D,2D,3D device properties (#1226)
* Add Max Texture 1D,2D,3D device properties

* Corrected testcase to use enums defined in hipDeviceAttribute_t

* Added texture 1D,2D and 3D support for NVIDIA path


[ROCm/clr commit: 00aa42e05f]
2019-07-18 03:18:50 +00:00
Maneesh Gupta 61833b948d [dtests] Fix typo in hipAPIStreamDisable.cpp (#1227)
Change-Id: Ib88a6be49ba192578129bb88ad09817839981398

[ROCm/clr commit: d206d66dfe]
2019-07-17 07:28:38 +00:00
Maneesh Gupta ccf76633f9 [dtests] Temporarily disable failing tests (#1218)
Change-Id: I7bb36a964c635bfbdf67484f3454d8fff7168eb2

[ROCm/clr commit: 4d2f2396aa]
2019-07-17 07:28:21 +00:00
Evgeny Mankov 096aad2de2 Merge pull request #1220 from emankov/master
[HIP][HIPIFY] Split HIP_ARRAY_DESCRIPTOR struct to HIP_ARRAY_DESCRIPTOR and HIP_ARRAY3D_DESCRIPTOR

[ROCm/clr commit: c978af3b13]
2019-07-16 18:15:44 +03:00
kpyzhov 71297fa621 Added gfx906 kernel binary to the HIPFB file for hipModule test. (#1215)
[ROCm/clr commit: 728ce926d9]
2019-07-12 03:13:45 +00:00
Evgeny Mankov b5f0cdaa7b [HIP][HIPIFY] Split HIP_ARRAY_DESCRIPTOR struct to HIP_ARRAY_DESCRIPTOR and HIP_ARRAY3D_DESCRIPTOR
[Reason] To be compatible with CUDA [#1133]

Update HIP code, hipify-clang, tests and docs

[TODO] Add support of the corresponding functions on nvcc fallback path


[ROCm/clr commit: f0832fd968]
2019-07-11 14:58:16 +03:00