8294d086a8
Re-sync with upstream.
...
[ROCm/clr commit: 76614f15af
2017-12-03 23:14:58 +00:00
37e40fcd40
This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
...
[ROCm/clr commit: e186bd9533
2017-12-03 23:09:06 +00:00
5b5bbd0b99
Merge pull request #271 from bensander/cppcheck
...
Cppcheck
[ROCm/clr commit: 6e2e029b39
2017-12-02 08:36:17 -06:00
1ba0d0ca14
Remove stray leftover comment.
...
[ROCm/clr commit: 954b7dadf7
2017-12-02 00:03:10 +00:00
6bdde982ff
Replace archaic use of homebrew functionality with calls to the HC maths library. This fixes a hang observed when building hipTestDeviceDouble.
...
[ROCm/clr commit: b8c80bd0b2
2017-12-02 00:01:47 +00:00
cabf4d817c
Fix some cppcheck style issues.
...
[ROCm/clr commit: 5933ca7300
2017-12-01 20:45:34 +00:00
b1aee08dc1
Fix warning from default cppchek.
...
[ROCm/clr commit: 743c54a012
2017-12-01 20:45:33 +00:00
76336d46b4
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
...
[ROCm/clr commit: 33bb425013
2017-11-30 03:29:04 +00:00
a27fa25d76
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit 1cd64164966518846
2017-11-29 21:49:10 +00:00
a1d5f0ab0c
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
...
This reverts commit d2fd1f52557000b56
2017-11-29 21:36:29 +00:00
4d18ad9ebe
Fix compiler version check.
...
[ROCm/clr commit: 93e595c267
2017-11-29 03:05:53 +00:00
0636d6a976
Add missing file.
...
[ROCm/clr commit: e305d3fc94
2017-11-29 02:16:44 +00:00
6b21218303
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
...
[ROCm/clr commit: 37c1811b2a
2017-11-29 01:37:52 +00:00
cdac21c81a
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
...
[ROCm/clr commit: c6ab6f292b
2017-11-29 00:17:44 +00:00
e85f49a57e
Remove leftover agent allocated globals.
...
[ROCm/clr commit: 45a9f4f7b1
2017-11-28 19:56:04 +00:00
abf92dd6e7
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
...
[ROCm/clr commit: d5c8de3f41
2017-11-28 19:45:47 +00:00
914acbe88f
Re-sync with upstream and re-factor platform global management for texture references.
...
[ROCm/clr commit: 6a0efb7ed2
2017-11-28 19:15:29 +00:00
579a3187da
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
[ROCm/clr commit: d37a5a6008
2017-11-28 17:29:11 +00:00
621cc5e5ca
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
[ROCm/clr commit: cc418da654
2017-11-28 17:23:43 +00:00
a59daf78d6
This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
...
[ROCm/clr commit: bb35299560
2017-11-28 17:23:06 +00:00
0de6e0be2b
This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
...
[ROCm/clr commit: 4b7cb0624e
2017-11-28 17:23:06 +00:00
0de96b6e3e
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
[ROCm/clr commit: e93a24bdbe
2017-11-27 13:52:39 -06:00
05963822e7
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
[ROCm/clr commit: 822743845c
2017-11-23 09:57:24 +05:30
212afdf56b
Fixed review comments
...
[ROCm/clr commit: 38029f2849
2017-11-21 21:19:06 +05:30
31deac0768
This corrects how addresses are formed for symbols which reside in shared objects. For this case, the .value component of an ELF symbol holds the offset from the base VA where the shared object was loaded. Thus, to correctly obtain the VA of the object refered by the symbol, we must add the offset to the VA where the shared object is loaded. We were already doing this correctly for symbols denoting functions, but we were incorrect for those denoting objects.
...
[ROCm/clr commit: fb1021cc0a
2017-11-21 13:15:13 +00:00
dc2c56c43d
Changed function hipMemcpy_2D to hipMemcpyParam2D
...
[ROCm/clr commit: 24307fe5c4
2017-11-21 12:36:24 +05:30
1366b2d5ae
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
...
[ROCm/clr commit: f8c1c1b38e
2017-11-21 02:40:34 +00:00
98ea26e613
Clean-up some remaining noise in program_state.cpp.
...
[ROCm/clr commit: 24f8a93ff7
2017-11-20 22:41:46 +00:00
f27cd5ad33
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
...
[ROCm/clr commit: 27bc487635
2017-11-20 16:33:52 +00:00
9cf73ef515
Re-sync with upstream.
...
[ROCm/clr commit: 30d90dab38
2017-11-20 15:34:50 +00:00
fdb4ea06f7
Merge pull request #264 from pzins/missing_end_marker
...
Fix missing MARKER_END
[ROCm/clr commit: a1e0c96689
2017-11-20 06:08:01 -06:00
9cee9705dc
-Moved coGlobals in hipModule class (takes care of multi module case)
...
-Used mutex scope for updating coGlobals
[ROCm/clr commit: eff09fcd86
2017-11-20 16:23:18 +05:30
7453c8b25c
Update hipModuleGetTexRef API
...
[ROCm/clr commit: 76f174b536
2017-11-19 22:10:46 +05:30
af0ae5421c
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
...
[ROCm/clr commit: 0cc921f103
2017-11-19 01:54:12 +00:00
0f8296b0c2
Removed redundant desc variable
...
[ROCm/clr commit: e2e499461a
2017-11-15 18:28:27 +05:30
a0f838a75e
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
[ROCm/clr commit: edbfeeb141
2017-11-15 18:23:28 +05:30
c154921e10
Texture code reorganized
...
[ROCm/clr commit: e536eb038d
2017-11-14 11:09:35 +05:30
75a1e24519
Fix missing MARKER_END
...
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"
[ROCm/clr commit: e60a95d7dd
2017-11-13 16:13:19 -05:00
93df8a2a57
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
[ROCm/clr commit: 1518611976
2017-11-09 23:43:07 +00:00
bb8c31c198
Texture driver APIs support
...
[ROCm/clr commit: 1851c153f6
2017-11-09 22:10:55 +05:30
0b86003f38
Merge pull request #250 from AlexVlx/feature_add_agent_global_support
...
Support for agent globals
[ROCm/clr commit: 925f97fac7
2017-11-09 07:52:09 +05:30
12f00d4881
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# tests/src/runtimeApi/stream/hipStreamSync2.cpp
[ROCm/clr commit: f7919a8321
2017-11-08 10:26:30 +00:00
142213a52b
Clean up trailing whitespace so as to reduce noise in #246 .
...
[ROCm/clr commit: 0ad1308efd
2017-11-08 00:08:55 +00:00
2db0344254
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
[ROCm/clr commit: 8854dec897
2017-11-07 00:01:22 +00:00
2c95d48f87
Check for null event in hipEventElapsedTime
...
[ROCm/clr commit: e71456cc6c
2017-11-06 23:49:31 +00:00
f761859993
hipStreamWaitEvent returns success if event created but not recorded
...
[ROCm/clr commit: b5911acce2
2017-11-06 23:49:31 +00:00
379b3fc7a0
Make hipEvent_t thread safe.
...
Support re-recording of same event by different threads.
- Add criticalData structure to hipEvent_t, similar to mechanism used
for streams, contexts, device. Events are always locked
after streams to avoid deadlock.
- ihipEvent_t::locked_copyCrit can be used to copy critical state
including marker. The critical state in the event can then
be re-recorded.
- refactor hipEventElapsedTime. Remmove stale debug code, native signal
refs.
[ROCm/clr commit: 955cfbfdc7
2017-11-06 23:49:25 +00:00
db9b583cb6
Merge pull request #251 from ROCm-Developer-Tools/fix_event_state
...
Set event state AFTER it is recorded.
[ROCm/clr commit: dbb6b2bab8
2017-11-06 07:28:11 +05:30
6bc2170189
Merge pull request #249 from bensander/warn_event
...
Add HIP_DB=warn + message if sync on dangerous event.
[ROCm/clr commit: 958ca62c63
2017-11-06 07:25:40 +05:30
0c5ce41d7c
Set event state AFTER it is recorded.
...
[ROCm/clr commit: 1c65bb1684
2017-11-05 10:33:18 -06:00
Alex Voicu
Ben Sander
Maneesh Gupta
Rahul Garg
Pierre