Commit Graph

11577 Commits

Author SHA1 Message Date
Evgeny Mankov 61a6949cf0 [HIPIFY] CUDA 10.1 Driver API support
[ROCm/clr commit: 9a660c0d48]
2019-04-10 15:03:34 +03:00
Maneesh Gupta f8194fd6f1 Merge pull request #1013 from yxsamliu/config
Fix hip-config.cmake for hip-clang

[ROCm/clr commit: 75691ff3e4]
2019-04-10 07:53:22 +00:00
foreman c3349370dc P4 to Git Change 1767813 by chui@ocl-promo-incrementor on 2019/04/10 03:00:40
SWDEV-2 - Change OpenCL version number from 2875 to 2876.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2623 edit


[ROCm/clr commit: d4a2b396ef]
2019-04-10 03:10:52 -04:00
foreman d1f62b92c1 P4 to Git Change 1767752 by wchau@wchau_OCL_Linux on 2019/04/09 22:58:03
SWDEV-165259 - Update OpenCL runtime to support MsgPack metadata
	- Add support for the V3 code objects

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#14 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#24 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#336 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#134 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palbe/inc/core/palCmdBuffer.h#63 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palbe/src/core/hw/gfxip/gfx6/gfx6ComputeCmdBuffer.cpp#63 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palbe/src/core/hw/gfxip/gfx9/gfx9ComputeCmdBuffer.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#77 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#27 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#90 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#76 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#130 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#27 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#103 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#47 edit


[ROCm/clr commit: 36a5f2a85f]
2019-04-09 23:24:10 -04:00
Yaxun (Sam) Liu f6151a55fd hip-clang: fix hipcc options
Use -O3 for default optimization level.
Fix --hip-device-lib-path for warnings about unused option.


[ROCm/clr commit: 419eeb4fe0]
2019-04-09 22:31:13 -04:00
Yaxun (Sam) Liu 65aa1eb59c Fix hip-config.cmake for hip-clang
Define HIP_COMPILER and HIP_RUNTIME in hip-config.cmake to
facilitate other packages identify hip-clang and HIP/VDI
runtime.


[ROCm/clr commit: a781d2e017]
2019-04-09 16:41:01 -04:00
Yaxun (Sam) Liu 40cf556b82 hip-clang: add include path for hsa headers
[ROCm/clr commit: 98642129cc]
2019-04-09 15:01:50 -04:00
foreman 293408dca8 P4 to Git Change 1767175 by chui@ocl-promo-incrementor on 2019/04/09 03:00:39
SWDEV-2 - Change OpenCL version number from 2874 to 2875.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2622 edit


[ROCm/clr commit: 0fb499bb71]
2019-04-09 03:14:31 -04:00
Maneesh Gupta 6f8a83bd11 Merge pull request #1010 from ROCm-Developer-Tools/mangupta-patch-1
[ci] Disable hipLaunchParm.tst for now

[ROCm/clr commit: aa8f17193e]
2019-04-09 03:19:56 +00:00
foreman b19d349daa P4 to Git Change 1766904 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/04/08 14:42:29
SWDEV-145570 - Check host_context when matching GPU device.

	- In CL#1766264, `host_context` is introduced for mGPU support. Need to
	  match that context specially when trying to match GPU device context.

	The following tests passed:
	$ python test_dataloader.py TestDictDataLoader.test_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.004s

	OK
	$ python test_dataloader.py TestDataLoader.test_sequential_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.063s

	OK
	$ python test_dataloader.py TestDataLoader.test_shuffle_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.174s

	OK
	$ python test_dataloader.py TestStringDataLoader.test_shuffle_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.104s

	OK
	$ python test_torch.py TestTorch.test_pin_memory
	.
	----------------------------------------------------------------------
	Ran 1 test in 0.124s

	OK

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#52 edit


[ROCm/clr commit: 9b36b245c9]
2019-04-08 15:23:35 -04:00
Evgeny Mankov 0947324f18 [HIPIFY][cmake][doc] Update CMakeLists and Readme cause CUDA 10.1 and clang 8.0.0 are released
+ Fix the error in cmake: clang 8.0.0 supports CUDA 10.0, not 10.1; only trunk clang 9.0.0 supports CUDA 10.1.
+ Update Readme:
  1. clang's bug 36384 is gone, so latest stable release for Linux is clang 8.0.0, which supports CUDA up to 10.0;
  2. update dependencies, testing and building notes.


[ROCm/clr commit: 79e6bd8426]
2019-04-08 20:05:21 +03:00
foreman ec69f42679 P4 to Git Change 1766793 by asalmanp@asalmanp-ocl-stg on 2019/04/08 12:17:18
SWDEV-132899 - [OCL][GFX10] Enable LC by default on gfx10+

	reviewBoardURL = http://ocltc.amd.com/reviews/r/17099/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#75 edit


[ROCm/clr commit: 5420241b68]
2019-04-08 12:32:08 -04:00
Maneesh Gupta 47fab26a20 [ci] Disable hipLaunchParm.tst for now
Due to a HCC bug in rocm-head, the test fails to compile. Disabling the test until the issue is resolved.

Change-Id: Ib4e7baf0b9c2cb5f5dbe38e6dd2bab894d28886a


[ROCm/clr commit: 27013c9af6]
2019-04-08 16:14:25 +05:30
foreman a050cac8dc P4 to Git Change 1766536 by chui@ocl-promo-incrementor on 2019/04/06 03:00:38
SWDEV-2 - Change OpenCL version number from 2873 to 2874.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2621 edit


[ROCm/clr commit: 68a962509b]
2019-04-06 03:12:30 -04:00
Yaxun (Sam) Liu d8acabf24c Fix regression on multi-gpu due to PR#997
[ROCm/clr commit: 5c67ee11f4]
2019-04-05 22:54:41 -04:00
foreman 00680db557 P4 to Git Change 1766349 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/04/05 14:24:45
SWDEV-144570 - Fix pointer attribute query.

	- For memory not registered with runtime, return
	  `hipErrorInvalidValue`. That's the behavior expected to check whether
	  a host buffer is pinned.
	- Return `hipErrorInvalidDevice` in case a registered memory object
	  cannot find its matching device.

	RB: http://ocltc.amd.com/reviews/r/17094/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#51 edit


[ROCm/clr commit: f695910290]
2019-04-05 14:51:37 -04:00
Evgeny Mankov 8d78207849 Merge pull request #1003 from acowley/patch-1
hipify: translate cudaErrorInvalidSymbol

[ROCm/clr commit: 3352d7b174]
2019-04-05 20:21:27 +03:00
David Salinas d1f4e7ea54 append the ELF flags for sram-ecc and xnack to the target triple per code object
[ROCm/clr commit: 4d0dc45078]
2019-04-05 13:17:11 -04:00
Evgeny Mankov 9eb10c5b4d [HIPIFY][doc] Fix typos and minor text inaccuracies in HIP FAQ
[ROCm/clr commit: 4990a1003b]
2019-04-05 19:19:38 +03:00
foreman a0f0714729 P4 to Git Change 1766264 by cpaquot@cpaquot-ocl-lc-lnx on 2019/04/05 11:38:18
SWDEV-145570 - [HIP] Use a context with all devices in system for host register
	hipHostRegister and hipMemcpy 0x10 and 0x20 fail in mGPU systems because
	we only register the memory on the current device. But in HIP, the registering
	needs to happen on all devices.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#50 edit


[ROCm/clr commit: 7a58581c81]
2019-04-05 11:58:25 -04:00
foreman 7f4b615f18 P4 to Git Change 1766171 by chui@ocl-promo-incrementor on 2019/04/05 03:00:37
SWDEV-2 - Change OpenCL version number from 2872 to 2873.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2620 edit


[ROCm/clr commit: 6702260647]
2019-04-05 03:09:53 -04:00
foreman c70ae33d9e P4 to Git Change 1766115 by cpaquot@cpaquot-ocl-lc-lnx on 2019/04/04 18:29:12
SWDEV-145570 - Don't assert when LOG_LEVEL=3 and return value isn't HIP_SUCCESS.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#25 edit


[ROCm/clr commit: 54f50c23fc]
2019-04-04 18:41:09 -04:00
foreman 6f5048ba0a P4 to Git Change 1766106 by kjayapra@99_HIPWS_SLV_CHECKIN on 2019/04/04 18:07:26
SWDEV-144570 - Implementation of hipMemcpyToSymbol and simillar fns for PAL.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#89 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#102 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#46 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.cpp#135 edit


[ROCm/clr commit: 842094ccbf]
2019-04-04 18:22:40 -04:00
foreman fa9f13db43 P4 to Git Change 1766106 by kjayapra@99_HIPWS_SLV_CHECKIN on 2019/04/04 18:07:26
SWDEV-144570 - Implementation of hipMemcpyToSymbol and simillar fns for PAL.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#89 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#102 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#46 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.cpp#135 edit


[ROCm/clr commit: d0c8e12d00]
2019-04-04 18:22:40 -04:00
foreman 0a54fb3e5f P4 to Git Change 1766089 by skudchad@skudchad_rocm on 2019/04/04 17:42:11
SWDEV-145570 - Re-enable subwindow copy. TC issue isnt because of this change

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.cpp#31 edit


[ROCm/clr commit: b4b0b1f61d]
2019-04-04 18:10:02 -04:00
foreman df8687b499 P4 to Git Change 1766076 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/04/04 17:35:28
SWDEV-144570 - Fix pointer attribute query.

	- Device should be numbered from zero.

	RB: http://ocltc.amd.com/reviews/r/17090/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#49 edit


[ROCm/clr commit: 3b461e01ae]
2019-04-04 17:50:08 -04:00
foreman a87d507145 P4 to Git Change 1765926 by skudchad@skudchad_rocm on 2019/04/04 13:58:54
SWDEV-145570 - Disable subwindow copy temporarily to see if TC random hangs go away

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.cpp#30 edit


[ROCm/clr commit: 253ae76c1a]
2019-04-04 14:29:43 -04:00
foreman d81708afb5 P4 to Git Change 1765705 by chui@ocl-promo-incrementor on 2019/04/04 03:00:37
SWDEV-2 - Change OpenCL version number from 2871 to 2872.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2619 edit


[ROCm/clr commit: 54e8916492]
2019-04-04 03:13:11 -04:00
foreman 0b1556055d P4 to Git Change 1765557 by gandryey@gera-w8 on 2019/04/03 16:52:57
SWDEV-79445 - OCL generic changes and code clean-up
	- More changes to make sure runtime and LC could be built separately

Affected files ...

... //depot/stg/opencl/drivers/opencl/Makefile#71 edit
... //depot/stg/opencl/drivers/opencl/compiler/Makefile#73 edit
... //depot/stg/opencl/drivers/opencl/library/build/Makefile.library#78 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#38 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#88 edit


[ROCm/clr commit: ff07325e31]
2019-04-03 17:09:09 -04:00
foreman 4e568feac9 P4 to Git Change 1765529 by asalmanp@asalmanp-ocl-stg on 2019/04/03 15:40:06
SWDEV-132899 - [OCL] set lcWavefrontSize64_ on ROCm for all ASICs except gfx10+ so that we Link wavefrontsize64 correctly

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17081/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.cpp#43 edit


[ROCm/clr commit: dc0fc2d882]
2019-04-03 16:05:38 -04:00
foreman f6228adc9b P4 to Git Change 1765169 by chui@ocl-promo-incrementor on 2019/04/03 03:00:37
SWDEV-2 - Change OpenCL version number from 2870 to 2871.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2618 edit


[ROCm/clr commit: c7f3c70d01]
2019-04-03 03:15:46 -04:00
Siu Chi Chan f6837a4e7f minor workaround for lazy binding
[ROCm/clr commit: b5045af7e9]
2019-04-02 17:28:06 -04:00
foreman b340f1682c P4 to Git Change 1764757 by yaxunl@yaxunl-lc10 on 2019/04/02 11:49:22
SWDEV-145570 - Fix hanging of clinfo due to excessive memory requests.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#304 edit


[ROCm/clr commit: 59c22c5bc9]
2019-04-02 12:23:44 -04:00
foreman 3bfdbccaa1 P4 to Git Change 1764730 by asalmanp@asalmanp-ocl-stg on 2019/04/02 11:18:14
SWDEV-132899 - [OCL][GFX10] Link correct wavefrontsize64 function in non-comgr path

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17069/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#37 edit


[ROCm/clr commit: 7cd51d2386]
2019-04-02 12:03:04 -04:00
Anthony Cowley 191dfc8dff hipify: translate cudaErrorInvalidSymbol
[ROCm/clr commit: f15dd58a91]
2019-04-02 08:54:37 -04:00
foreman c58322379c P4 to Git Change 1764636 by chesik@chesik_bdc-dtw-chesikw10_driver on 2019/04/02 08:20:28
SWDEV-183848 - Update OpenCL perfcounter blocks to match the block lists used by GPUPerfAPI (which is in turn used by RCP and CodeXL)

	- The PAL block index for the PA_SC block was incorrect in all hw generations (in PAL, GpuBlock::SC has ordinal 4, not 3)
	- In GFX9, the MC and SRBM blocks are not supported
	- In GFX10, the following changes are made:
	  -- There are 8 CB instances per SE
	  -- There are 8 DB instances per SE
	  -- There are 2 PA_SU instances per SE
	  -- There are 4 PS_SC instances per SE
	  -- There are 4 RMI instances per SE
	  -- There are 2 GL1A instances per SE
	  -- There are 2 GL1C instances per SE
	  -- There are 8 GL1CG instances per SE
	  -- There are 4 global GL2A instances
	  -- There are 16 global GL2A instances
	  -- There are 4 global CHC instances

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palcounters.cpp#19 edit


[ROCm/clr commit: b751b6cf19]
2019-04-02 08:50:00 -04:00
foreman 5f25c6d76a P4 to Git Change 1764509 by chui@ocl-promo-incrementor on 2019/04/02 03:00:37
SWDEV-2 - Change OpenCL version number from 2869 to 2870.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2617 edit


[ROCm/clr commit: 35bef95807]
2019-04-02 03:13:16 -04:00
Maneesh Gupta bedff2406a Merge pull request #998 from yxsamliu/doc
hip-clang: update installation guide.

[ROCm/clr commit: 2d9e5615b7]
2019-04-02 05:08:18 +00:00
Maneesh Gupta 9d2c0c8e5d Merge pull request #997 from yxsamliu/mgpu
hip-clang: fix kernel not found on multi-gpu

[ROCm/clr commit: a6e7dfefe3]
2019-04-02 05:07:31 +00:00
Evgeny Mankov 17ac0d3e19 [HIPIFY][tests] Fix typo in test for CUDA 10.x
[ROCm/clr commit: 5b59f87305]
2019-04-01 19:52:08 +03:00
Evgeny Mankov 236624a229 [HIPIFY][cmake] Update CMakeLists and Readme cause CUDA 10.1 and clang 8.0.0 are released
[ROCm/clr commit: 799a6f5512]
2019-04-01 19:44:52 +03:00
foreman 1251ab0181 P4 to Git Change 1764069 by michliao@hliao-dev-00-hip-workspace on 2019/04/01 11:23:34
SWDEV-144570 - Handle zero-byte memset & memcpy

	- Properly handle zero-byte memset & memcpy by skipping the real stuff.

	RB: http://ocltc.amd.com/reviews/r/17062/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#48 edit


[ROCm/clr commit: 6220c5059d]
2019-04-01 11:51:06 -04:00
foreman 1f48a844df P4 to Git Change 1763913 by chui@ocl-promo-incrementor on 2019/04/01 03:00:36
SWDEV-2 - Change OpenCL version number from 2868 to 2869.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2616 edit


[ROCm/clr commit: 3a050479de]
2019-04-01 03:21:19 -04:00
Yaxun Sam Liu 12ac74bad1 hip-clang: fix kernel not found on multi-gpu
__hipRegisterFunction is called during by .init functions during program initialization.
It calls hipModuleGetFunction to locate kernel symbol in code objects. hipModuleGetFunction
assumes current device when locating kernel symbols. This works for HCC but not for hip-clang,
since hip-clang needs to locate kernel symbols for different devices without switching
between devices.

This patch introduces a new hsa agent parameter to ihipModuleGetFunction, which allows
__hipRegisterFunction to choose the correct hsa agent when locating kernel symbols. By
default it uses this_agent(), therefore this patch has no impact on HCC.


[ROCm/clr commit: 8f5c812a68]
2019-03-31 10:08:20 -04:00
foreman 3485e143b5 P4 to Git Change 1763808 by chui@ocl-promo-incrementor on 2019/03/31 03:00:35
SWDEV-2 - Change OpenCL version number from 2867 to 2868.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2615 edit


[ROCm/clr commit: 41c4d730bf]
2019-03-31 03:11:12 -04:00
Yaxun (Sam) Liu 54c2b79351 Update INSTALL.md
[ROCm/clr commit: 76a9fdd924]
2019-03-30 08:29:08 -04:00
Yaxun Sam Liu 79ac0097dc hip-clang: update installation guide.
[ROCm/clr commit: 598604aa7f]
2019-03-30 08:24:49 -04:00
foreman 18bbce3ed5 P4 to Git Change 1763767 by chui@ocl-promo-incrementor on 2019/03/30 03:00:35
SWDEV-2 - Change OpenCL version number from 2866 to 2867.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2614 edit


[ROCm/clr commit: 0981972e19]
2019-03-30 03:10:57 -04:00
foreman e3315859c5 P4 to Git Change 1763319 by chui@ocl-promo-incrementor on 2019/03/29 03:00:42
SWDEV-2 - Change OpenCL version number from 2865 to 2866.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2613 edit


[ROCm/clr commit: 4ef1c3e2df]
2019-03-29 03:12:36 -04:00
Wen-Heng (Jack) Chung cfe930f9d6 Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime (#981)
* Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime

In HIP PR #929, quite a few HIP public APIs were made as inline functions with
hidden visibility. It was necessary to support applications with shared
libraries with GPU kernels launched via hipLaunchKernelGGL(), after HIP runtime
is initialized.

In empirical tests, the implementation has been proved to be a bit too
excessive, especially for hipModuleGetGlobal(). The function is used by another
type of client applications which relies on the existence of this function
within HIP runtime so global symbols from HSA code objects loaded dynamically
at runtime can be retrieved programmtically.

This commit moves hipModuleGetGlobal() back to src/hip_module.cpp, and makes it
visible and not inline, to fulfill requirements for applications
aforementioned. It does not change the behavior of applications depending on
hipLaunchKernelGGL().

* Add HIP_INIT_API into the implementation of hipModuleGetGlobal

Address review comments.

* Fix failing HIP unit tests


[ROCm/clr commit: 04915cea2f]
2019-03-29 03:45:04 +00:00