AI/rocm-systems
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,257 Commits 3 Branches 0 Tags
0954c676e5230822524d440f1ccb98ab599b20cc
Commit Graph
9 Commits
Author SHA1 Message Date
Alex Voicu 4966518846 Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions." 
This reverts commit 4792475
 2017-11-29 21:49:10 +00:00
Alex Voicu 2557000b56 Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions." 
This reverts commit d2fd1f5
 2017-11-29 21:36:29 +00:00
Alex Voicu 30d90dab38 Re-sync with upstream. 2017-11-20 15:34:50 +00:00
Alex Voicu 0cc921f103 This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility. 2017-11-19 01:54:12 +00:00
Alex Voicu 28f87f7d2e This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own. 2017-11-01 15:09:59 +00:00
Aditya Atluri 4e57822d95 Added proper device data types 
Change-Id: I42029635ff68c3c13a764a3eda6447e6c77878c6
 2017-01-11 15:06:25 -06:00
Maneesh Gupta 5947878247 directed tests: Updated to use new hip include path 
Change-Id: Iab1aee638b7158eb9674a19625dedf6471947e51
 2016-10-04 22:20:50 +05:30
Maneesh Gupta 1e8282327b directed tests: Enable remaining tests in HIT infrastructure 
Change-Id: I800ee00d6f7d339bb5d2ed898a16362a8541ed3a
 2016-09-27 17:24:33 +05:30
Ben Sander 3feb13c8f6 Refactor directed test infrastructue. 
- Add hierarchy.  Tests now live in directories, each with its own
  CMakeFiles.txt.  Reduces merge conflicts.
- Change make_hip_executable -> build_hip_executable.
- Refresh docs.
- Enable some tests that were previously built but not run.

Change-Id: I8c5de3c954400bf233904282b8b42861a2b7c536
 2016-06-17 15:18:57 -05:00