AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,504 Commits 3 Branches 0 Tags
0b3c8dff0f72fef27745f0755ca79656d934a354
Commit Graph

5504 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Salinas ee887dd6a2 append the ELF flags for sram-ecc and xnack to the target triple per code object 
[ROCm/hip commit: c61f265657]
 2019-04-05 13:17:11 -04:00
Evgeny Mankov 93433d9fe1 [HIPIFY][doc] Fix typos and minor text inaccuracies in HIP FAQ 
[ROCm/hip commit: 6e70b8494b]
 2019-04-05 19:19:38 +03:00
foreman eef83b62ba P4 to Git Change 1766264 by cpaquot@cpaquot-ocl-lc-lnx on 2019/04/05 11:38:18 
SWDEV-145570 - [HIP] Use a context with all devices in system for host register
	hipHostRegister and hipMemcpy 0x10 and 0x20 fail in mGPU systems because
	we only register the memory on the current device. But in HIP, the registering
	needs to happen on all devices.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#50 edit


[ROCm/hip commit: 8753616c97]
 2019-04-05 11:58:25 -04:00
foreman ececd78467 P4 to Git Change 1766115 by cpaquot@cpaquot-ocl-lc-lnx on 2019/04/04 18:29:12 
SWDEV-145570 - Don't assert when LOG_LEVEL=3 and return value isn't HIP_SUCCESS.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#25 edit


[ROCm/hip commit: 22c104f84f]
 2019-04-04 18:41:09 -04:00
foreman 376ad78f89 P4 to Git Change 1766106 by kjayapra@99_HIPWS_SLV_CHECKIN on 2019/04/04 18:07:26 
SWDEV-144570 - Implementation of hipMemcpyToSymbol and simillar fns for PAL.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#89 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#102 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#46 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.cpp#135 edit


[ROCm/hip commit: e3910b720c]
 2019-04-04 18:22:40 -04:00
foreman 9eab4cd826 P4 to Git Change 1766076 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/04/04 17:35:28 
SWDEV-144570 - Fix pointer attribute query.

	- Device should be numbered from zero.

	RB: http://ocltc.amd.com/reviews/r/17090/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#49 edit


[ROCm/hip commit: 41c75b2f8d]
 2019-04-04 17:50:08 -04:00
Siu Chi Chan 23df3b5879 minor workaround for lazy binding 
[ROCm/hip commit: e126f7254c]
 2019-04-02 17:28:06 -04:00
Jenkins 7a5276ca35 Merge 'master' into 'amd-master' 
Change-Id: I4369829444ebd150e59f07f5db44e4584d9cc396


[ROCm/hip commit: 87ce7c278a]
 2019-04-02 12:33:16 -05:00
Anthony Cowley b00a98f27a hipify: translate cudaErrorInvalidSymbol 
[ROCm/hip commit: e9b1881c60]
 2019-04-02 08:54:37 -04:00
Maneesh Gupta 8a93d8e9aa Merge pull request #998 from yxsamliu/doc 
hip-clang: update installation guide.

[ROCm/hip commit: c19874e0f1]
 2019-04-02 05:08:18 +00:00
Maneesh Gupta 1fbff012b4 Merge pull request #997 from yxsamliu/mgpu 
hip-clang: fix kernel not found on multi-gpu

[ROCm/hip commit: 5b1e63ee2d]
 2019-04-02 05:07:31 +00:00
Evgeny Mankov 772b4978ed Merge pull request #1001 from emankov/master 
[HIPIFY][tests] Fix typo in test for CUDA 10.x

[ROCm/hip commit: 9f40e0aa97]
 2019-04-01 19:53:42 +03:00
Evgeny Mankov 7bbf825c74 [HIPIFY][tests] Fix typo in test for CUDA 10.x 
[ROCm/hip commit: 8bca9f1d7a]
 2019-04-01 19:52:08 +03:00
Evgeny Mankov 3b28e2f9b4 Merge pull request #1000 from emankov/master 
[HIPIFY][cmake] Update CMakeLists and Readme cause CUDA 10.1 and clang 8.0.0 are released

[ROCm/hip commit: a7d0e40058]
 2019-04-01 19:49:46 +03:00
Evgeny Mankov 9e32584753 [HIPIFY][cmake] Update CMakeLists and Readme cause CUDA 10.1 and clang 8.0.0 are released 
[ROCm/hip commit: 7c221450fa]
 2019-04-01 19:44:52 +03:00
foreman 2c8d0de12d P4 to Git Change 1764069 by michliao@hliao-dev-00-hip-workspace on 2019/04/01 11:23:34 
SWDEV-144570 - Handle zero-byte memset & memcpy

	- Properly handle zero-byte memset & memcpy by skipping the real stuff.

	RB: http://ocltc.amd.com/reviews/r/17062/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#48 edit


[ROCm/hip commit: b392004e71]
 2019-04-01 11:51:06 -04:00
Yaxun Sam Liu 5072c98f32 hip-clang: fix kernel not found on multi-gpu 
__hipRegisterFunction is called during by .init functions during program initialization.
It calls hipModuleGetFunction to locate kernel symbol in code objects. hipModuleGetFunction
assumes current device when locating kernel symbols. This works for HCC but not for hip-clang,
since hip-clang needs to locate kernel symbols for different devices without switching
between devices.

This patch introduces a new hsa agent parameter to ihipModuleGetFunction, which allows
__hipRegisterFunction to choose the correct hsa agent when locating kernel symbols. By
default it uses this_agent(), therefore this patch has no impact on HCC.


[ROCm/hip commit: 98b9e92908]
 2019-03-31 10:08:20 -04:00
Yaxun (Sam) Liu 595d95cfe8 Update INSTALL.md 
[ROCm/hip commit: ed2fbb27e4]
 2019-03-30 08:29:08 -04:00
Yaxun Sam Liu c0682dda96 hip-clang: update installation guide. 
[ROCm/hip commit: 409aa49218]
 2019-03-30 08:24:49 -04:00
Jenkins 6218c5c00d Merge 'master' into 'amd-master' 
Change-Id: Id0b95bac00a76909d68f53406875028fdbb97ac7


[ROCm/hip commit: f0708722a3]
 2019-03-29 04:09:52 -05:00
Wen-Heng (Jack) Chung 1cc94f9369 Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime (#981) 
* Make hipModuleGetGlobal be in HIP runtime so it can be discovered at runtime

In HIP PR #929, quite a few HIP public APIs were made as inline functions with
hidden visibility. It was necessary to support applications with shared
libraries with GPU kernels launched via hipLaunchKernelGGL(), after HIP runtime
is initialized.

In empirical tests, the implementation has been proved to be a bit too
excessive, especially for hipModuleGetGlobal(). The function is used by another
type of client applications which relies on the existence of this function
within HIP runtime so global symbols from HSA code objects loaded dynamically
at runtime can be retrieved programmtically.

This commit moves hipModuleGetGlobal() back to src/hip_module.cpp, and makes it
visible and not inline, to fulfill requirements for applications
aforementioned. It does not change the behavior of applications depending on
hipLaunchKernelGGL().

* Add HIP_INIT_API into the implementation of hipModuleGetGlobal

Address review comments.

* Fix failing HIP unit tests


[ROCm/hip commit: 4b7177ac42]
 2019-03-29 03:45:04 +00:00
Maneesh Gupta f63c4be10e Merge pull request #992 from gargrahul/handle_d2d_memcpy2d 
Handle D2D in memcpy2D

[ROCm/hip commit: d0e5fbeb72]
 2019-03-28 04:41:36 +00:00
Maneesh Gupta 6effbfe2dd Merge pull request #991 from jeffdaily/per_agent_program_state 
load program state once per agent

[ROCm/hip commit: 8af327e439]
 2019-03-28 04:40:46 +00:00
Jeff Daily fb2beb0c88 improve program state commentary 
Disambiguate calling many varibles "agent".
More detail in exception message.
Create and discard map placeholders; no need to call std::vector::clear() on map value.


[ROCm/hip commit: 7aada87cbd]
 2019-03-27 21:40:27 +00:00
Rahul Garg 0eaa29ad06 Handle D2D in memcpy2D 
[ROCm/hip commit: 0c55db8552]
 2019-03-28 02:21:45 +05:30
Jeff Daily 21f5e142f5 load program state once per agent 
[ROCm/hip commit: c9117de8eb]
 2019-03-27 18:19:10 +00:00
foreman bf0d9947f5 P4 to Git Change 1762349 by yaxunl@yaxunl-lc10 on 2019/03/27 11:50:12 
SWDEV-145570 - Workaround for mismatch of device name and bundle id for gfx906.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#25 edit


[ROCm/hip commit: 292e93bf11]
 2019-03-27 12:53:17 -04:00
Jenkins 0961cb0eee Merge 'master' into 'amd-master' 
Change-Id: Id7c377bd22abccbdffd9d1f8bd31a482102813ce


[ROCm/hip commit: e21df30587]
 2019-03-27 04:09:48 -05:00
Maneesh Gupta 87772a479e Merge pull request #987 from gargrahul/fix_hostmalloc_double_device_map 
Avoid double mapping of devices to hostMalloc buffer

[ROCm/hip commit: 08e12e730e]
 2019-03-27 05:23:47 +00:00
Maneesh Gupta 464c023bb5 Merge pull request #990 from mhbliao/hliao/master/sw 
SWDEV-184380 Fix hcc compilation

[ROCm/hip commit: e66dfa6ea3]
 2019-03-27 05:23:26 +00:00
Maneesh Gupta ed99892664 Merge pull request #986 from mhbliao/hliao/master/build 
[hip] Fix typo in macro `hipLaunchKernel`

[ROCm/hip commit: 3535ced23f]
 2019-03-27 05:22:44 +00:00
Michael LIAO a9a397bc4b SWDEV-184380 Fix hcc compilation 
- `hcc` has no builtin. Need to invoke LLVM intrinsic directly.


[ROCm/hip commit: 939d153c1a]
 2019-03-26 15:20:17 -04:00
Rahul Garg d98d5ca12a Let hipHostMalloc always share/map pinned host ptr 
[ROCm/hip commit: f0af073793]
 2019-03-26 10:19:13 +05:30
Rahul Garg c6ef785464 Avoid double mapping of devices to hostMalloc buffer 
[ROCm/hip commit: 5e917d70f3]
 2019-03-25 23:07:05 +05:30
Michael LIAO 94b7856a1a [hip] Fix typo in macro hipLaunchKernel 
[ROCm/hip commit: b3497824ec]
 2019-03-25 12:06:46 -04:00
Jenkins 5967d30f6f Merge 'master' into 'amd-master' 
Change-Id: I759c530530011ee9cff5aef00944c190e4204df2


[ROCm/hip commit: 0573395340]
 2019-03-25 09:17:20 -05:00
Jenkins 5e6e474217 Merge 'master' into 'amd-master' 
Change-Id: Ie456ccae78b50086939e1eaf65a5f768d40b4aca


[ROCm/hip commit: 99a2c1eb45]
 2019-03-25 04:09:54 -05:00
Maneesh Gupta 82fd86e63f Merge pull request #970 from mangupta/swdev-172995 
hipExtMallocWithFlags implementation

[ROCm/hip commit: 30b5c02ec4]
 2019-03-25 07:46:53 +00:00
Maneesh Gupta 8c6b5bf266 Merge pull request #962 from gargrahul/add_2d_copy_fallback 
Add 2D fallback to use copy kernel

[ROCm/hip commit: eb03d50de9]
 2019-03-25 07:46:43 +00:00
Rahul Garg 63e926cec7 2D Fallback needs hcc workweek 19101 or higher 
[ROCm/hip commit: 9bbfbceb64]
 2019-03-25 12:07:28 +05:30
Maneesh Gupta 67819c0395 hipExtMallocWithFlags needs hcc workweek 19115 or higher 
[ROCm/hip commit: cab119c8b2]
 2019-03-25 11:41:20 +05:30
Maneesh Gupta bfb73dd148 Merge pull request #982 from ROCm-Developer-Tools/hack_swdev-173477 
HACK for SWDEV-173477

[ROCm/hip commit: a75f375788]
 2019-03-22 09:14:38 +00:00
Maneesh Gupta 56dbf717bd Merge pull request #980 from ntrost57/master 
fixed loss of accuracy in hipCfma()

[ROCm/hip commit: 5bf08930a9]
 2019-03-22 09:14:09 +00:00
Jenkins bd994c79f8 Merge 'master' into 'amd-master' 
Change-Id: Id44416aee5dc592d7b6351926abf53d4a49e9b45


[ROCm/hip commit: c93c12f3b1]
 2019-03-22 04:09:52 -05:00
Wen-Heng (Jack) Chung 3eb009913c HACK for SWDEV-173477 
For code objects with global symbols of length 0, ROCR runtime would
ignore them even though they exist in the symbol table. Therefore the
result from read_agent_globals() can't be trusted entirely.

As a workaround to tame applications which depend on the existence of
global symbols with length 0, always return hipSuccess here.

This behavior shall be reverted once ROCR runtime has been fixed to
address SWDEV-173477


[ROCm/hip commit: d941f19399]
 2019-03-21 17:18:16 +00:00
foreman 3d377b70a4 P4 to Git Change 1759609 by kjayapra@1_HIPWS_SL_IPC on 2019/03/21 12:09:27 
SWDEV-144570 - Disbaling __hipHostRegister implementation to unblock pytorch tests in PAL.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#24 edit


[ROCm/hip commit: eb852bdb53]
 2019-03-21 12:43:25 -04:00
Nico Trost 5802734f1b fixed loss of accuracy in hipCfma() 
[ROCm/hip commit: 7bb5a14a4e]
 2019-03-21 10:30:10 +01:00
eshcherb 621ceaf8bc adding hip_prof_gen verbose log (#977) 
* adding hip_prof_gen verbose log

* adding stderr fatal error

* adding no error exit by default

* adding hip_prof_str regeneration dependencies

* adding more informative messages

* fixing error mesage


[ROCm/hip commit: f167e4daf6]
 2019-03-21 05:28:18 +00:00
foreman 38dce09c24 P4 to Git Change 1759248 by cpaquot@cpaquot-ocl-lc-lnx on 2019/03/20 18:32:19 
SWDEV-183452 - [HIP] Typo of | instead of &

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#47 edit


[ROCm/hip commit: 636dadc1aa]
 2019-03-20 19:18:10 -04:00
foreman bc89e5bc5f P4 to Git Change 1759224 by cpaquot@cpaquot-ocl-lc-lnx on 2019/03/20 17:47:43 
SWDEV-183452 - [HIP] PyTorch test_pin_memory fails
	hipPointerGetAttributes should return hipMemoryTypeHost for hipHostMalloc memories.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#46 edit


[ROCm/hip commit: eea83a2c5e]
 2019-03-20 18:43:07 -04:00