Commit Graph

3104 Commits

Author SHA1 Message Date
Nico Trost 0b3f8dce2b fixed loss of accuracy in hipCfma()
[ROCm/clr commit: 725486fb11]
2019-03-21 10:30:10 +01:00
eshcherb 0cf8b184a5 adding hip_prof_gen verbose log (#977)
* adding hip_prof_gen verbose log

* adding stderr fatal error

* adding no error exit by default

* adding hip_prof_str regeneration dependencies

* adding more informative messages

* fixing error mesage


[ROCm/clr commit: 045c6afa2c]
2019-03-21 05:28:18 +00:00
Maneesh Gupta 19bba906a2 Merge pull request #972 from yxsamliu/global
Add declaration of symbol related API for VDI

[ROCm/clr commit: ce72890dcf]
2019-03-20 05:12:21 +00:00
Maneesh Gupta aac0de849c Merge pull request #973 from mhbliao/hliao/master/build
[Device Function] Fix typos.

[ROCm/clr commit: 54091b5273]
2019-03-20 05:12:14 +00:00
Maneesh Gupta 0bae7dac36 Merge pull request #974 from yxsamliu/name2
Change HIP dll name to amdhip64.dll on Windows

[ROCm/clr commit: 48d790e205]
2019-03-20 05:11:58 +00:00
eshcherb 05b9ae6a09 adding prof primitives generator (#967)
* adding prof primitives generator

* minor change, renaming

* minor cosmetic changes, comments correcting and dead code removing

* minor changes and renaming

* minor chane, fixing comments


[ROCm/clr commit: 1229750546]
2019-03-20 05:11:40 +00:00
Siu Chi Chan 597c06b6be reimplement HIP_INIT as hip_impl::hip_init(), add hip_init() to some of the inlined API (#966)
* reimplement HIP_INIT as a function, expose it as hip_impl::hip_init()
so that it could be called from hipLaunchKernelGGL and other inlined
HIP functions

* Don't call hip_init from ihipPreLaunchKernel


[ROCm/clr commit: fa9495841b]
2019-03-20 05:11:15 +00:00
Yaxun Sam Liu d52780d6f9 Change HIP dll name to amdhip64.dll on Windows
[ROCm/clr commit: 55f4c416a0]
2019-03-19 16:27:18 -04:00
Michael LIAO 43afb85ca4 [Device Function] Fix typos.
[ROCm/clr commit: f42e84cef7]
2019-03-19 15:32:19 -04:00
Yaxun Sam Liu 24bd42fb57 Add declaration of symbol related API for VDI
[ROCm/clr commit: fb3241a000]
2019-03-19 11:11:49 -04:00
Maneesh Gupta 5b1ce07700 Merge pull request #969 from nicholasmalaya/patch-1
Update hip_faq.md

[ROCm/clr commit: 6ced14e71c]
2019-03-19 18:42:05 +05:30
Maneesh Gupta 4366c618d5 Merge pull request #965 from mhbliao/hliao/master/immarg
[Device Function] Support immediate argument.

[ROCm/clr commit: e7453483e2]
2019-03-19 18:41:31 +05:30
Maneesh Gupta 64089c1d87 Merge pull request #954 from mhbliao/master
[hip] Re-implement hipLaunchKernelGGL as macros.

[ROCm/clr commit: 1500eec5f7]
2019-03-19 18:39:27 +05:30
Nicholas Malaya bc0eab04fc Update hip_faq.md
Making more clear what this list details. In particular, this list is intended to indicate what items for each CUDA release is supported, and which are not.

[ROCm/clr commit: b1ec4e0b5f]
2019-03-18 14:51:18 -05:00
Michael LIAO 360e5b366d [Device Function] Support immediate argument.
- `immarg`, immediate argument, is enabled on all AMDGPU intrinsics.
  Revise device functions using these intrinsics with immediate
  arguments.


[ROCm/clr commit: b74b4500c4]
2019-03-15 12:38:04 -04:00
Evgeny a0c8ef2e96 tracing callback layer update
[ROCm/clr commit: 2aa88a4505]
2019-03-14 22:43:52 -05:00
Maneesh Gupta 694bbbc366 Merge pull request #963 from gargrahul/add_module_get_global_test
Test hipModuleGetGlobal

[ROCm/clr commit: e3726bbf90]
2019-03-15 06:17:50 +05:30
Maneesh Gupta fc835d6a43 Merge pull request #958 from aaronenyeshi/cxxabi-mismatch-workaround
CXX11 ABI Mismatch Workaround

[ROCm/clr commit: 23170f6af8]
2019-03-15 06:15:46 +05:30
Rahul Garg 19d2ff51c8 Test hipModuleGetGlobal
[ROCm/clr commit: 46346343af]
2019-03-15 04:08:03 +05:30
Siu Chi Chan b2a51c6cdb remove visibility hidden attribute
[ROCm/clr commit: 739d43c5d8]
2019-03-13 11:58:32 -04:00
Evgeny 0b4f2151a2 adding memset32d
[ROCm/clr commit: 0586924ae6]
2019-03-11 21:28:27 -05:00
Siu Chi Chan 2d6ebcaffb minor cleanup
[ROCm/clr commit: 5044c9ba49]
2019-03-11 19:51:57 +00:00
Siu Chi Chan 7955348b8e remove old style triple name
[ROCm/clr commit: f54da9358b]
2019-03-11 19:51:51 +00:00
Siu Chi Chan f7817c48d5 move triple_to_hsa_isa into the header
[ROCm/clr commit: 30053f6443]
2019-03-11 19:51:44 +00:00
Siu Chi Chan 3951fccb4e Fix memory leak introduced by previous change to Agent_global.
Make Agent_global manage the lifetime of the name string


[ROCm/clr commit: fa564a5345]
2019-03-11 19:51:32 +00:00
Aaron Enye Shi 3562ddf981 Fix Agent_global variables failing hipTestDeviceSymbol
Issue: Header uses std::vector<Agent_global> agent_globals which is created by hip_module.cpp
  - Move iterator fails to copy Agent_global from library source into header version
  - Due to different versions of std::string name in struct Agent_global
Fix: Change Agent_global to use char* name instead of std::string name


[ROCm/clr commit: fcde9fe3df]
2019-03-11 19:51:25 +00:00
Aaron Enye Shi 4326d67550 Fix hash_for undefined reference in hipTestConstant test
Issue: mismatch undefined symbols in different user env
  - Binary expects modified return value std::string&
  - Fails to match libhip_hcc.so: return value is std::string& but doesn't match modified C++ env
Fix: Change return value to char*, create new key std::string in header from char*


[ROCm/clr commit: f8aca3159c]
2019-03-11 19:51:18 +00:00
Michael Liao f2229f31b4 [hip] Re-implement hipLaunchKernelGGL as macros.
[ROCm/clr commit: f46d6cf249]
2019-03-08 09:10:51 -05:00
Maneesh Gupta 35ebb36cbd Merge pull request #951 from tycho/nvcc-hipDeviceSetCacheConfig
nvcc_detail/hip_runtime_api.h: add missing hipDeviceSetCacheConfig API

[ROCm/clr commit: 44309ee879]
2019-03-08 09:22:25 +05:30
Yaxun Sam Liu d1721cc124 Fix HIP/VDI build failure due to dlopen change
[ROCm/clr commit: 2dc87b6019]
2019-03-07 14:45:45 -05:00
Steven Noonan 9f642e40ad nvcc_detail/hip_runtime_api.h: add missing hipDeviceSetCacheConfig API
Signed-off-by: Steven Noonan <steven@uplinklabs.net>


[ROCm/clr commit: 27d6755552]
2019-03-06 11:21:36 -08:00
Evgeny Mankov 36f569cba6 [HIPIFY][tests] Update lit testing infrastructure
+ Set -D__LP64__ in case of 64-bit hipify-clang binary
  [partial workaround for clang's bug https://bugs.llvm.org/show_bug.cgi?id=38811]

  C:/GIT/LLVM/trunk/llvm-64-release-vs2017/dist/lib/clang/9.0.0\include\__clang_cuda_device_functions.h(1609,45): error GEF7559A7: no matching function for call to 'roundf'
  __DEVICE__ long lroundf(float __a) { return roundf(__a); }

  #if defined(__LP64__)
  __DEVICE__ long lround(double __a) { return llround(__a); }
  __DEVICE__ long lroundf(float __a) { return llroundf(__a); } // ok: llroundf should be used when 64-bit
  #else
  __DEVICE__ long lround(double __a) { return round(__a); }
  __DEVICE__ long lroundf(float __a) { return roundf(__a); } // error
  #endif

+ Print more system info while testing in the following form:
  ========================================
  CUDA 9.0 - will be used for testing
  LLVM 9.0.0svn - will be used for testing
  AMD64 - Platform architecture
  Windows 10 - Platform OS
  64 - hipify-clang binary bitness
  32 - python 3.7.2 binary bitness
  ========================================


[ROCm/clr commit: f138f89bc8]
2019-03-06 19:26:05 +03:00
eshcherb e4b8389619 roctracer-proto header find_path (#884)
[ROCm/clr commit: 7c3499198c]
2019-03-06 17:36:34 +05:30
Maneesh Gupta 2a11a5529e Merge pull request #949 from gargrahul/single_stream_concurrent_kernels
Add extension for kernel concurrency on same stream

[ROCm/clr commit: 3955f2c131]
2019-03-06 17:34:54 +05:30
Maneesh Gupta b1fdc46049 Merge pull request #932 from ROCm-Developer-Tools/feature_maybe_dlopen_test
Add one test case for complex dynamic loading behavior

[ROCm/clr commit: b9809cb2b6]
2019-03-06 17:32:23 +05:30
Alex Voicu 45f4ac5023 dlopen() fixes (#929)
* Initial attempt to switch over to internally linked state.

* Add missing CMake update.

* hipLaunchKernelGGLImpl must be inline as well. Ensure internal linkage.

* Ensure global retrieval uses internally linked state.

* Hide HC in the implementation. Minimise ADL woes.

* Strange software exists, and must be catered to.

* Use a less spammy mechanism for ensuring internal linkage / non-export.

* Remove leftover internal detail.


[ROCm/clr commit: ed48847237]
2019-03-06 17:31:44 +05:30
Rahul Garg f364b32e29 Add extension for kernel concurrency on same stream
[ROCm/clr commit: 263e82a67a]
2019-03-06 12:55:39 +05:30
Maneesh Gupta 9d4d74e5dc Merge pull request #936 from mangupta/swdev-174923
[hipconfig] Update HIP_PLATFORM detection logic

[ROCm/clr commit: 8099d81788]
2019-03-06 06:08:11 +05:30
Evgeny Mankov ed9ea6cde4 [HIPIFY] Change CUDA Driver's functions' cuMemsetD32(Async) mapping
cuMemsetD32(Async) -> hipMemsetD32(Async) (was hipMemset(Async))

based on:
[#933] https://github.com/ROCm-Developer-Tools/HIP/pull/933


[ROCm/clr commit: dfc631fb44]
2019-03-05 18:13:18 +03:00
Maneesh Gupta 5c939d7f27 Update hipMemset.cpp
Address build issues on nvcc path.

[ROCm/clr commit: 8af4e2b5e4]
2019-03-05 12:11:11 +05:30
Maneesh Gupta 34554f5730 Update hip_runtime_api.h
Use hipCUResultTohipError instead of hipCUDAErrorTohipError in hipMemsetD32 & hipMemsetD32Async.

[ROCm/clr commit: 38b7a43b43]
2019-03-05 12:10:01 +05:30
Wen-Heng (Jack) Chung e34b0ccd48 Address code review comments to use hipDeviceptr_t
[ROCm/clr commit: 8b7baa0bd9]
2019-03-05 05:51:05 +00:00
Wen-Heng (Jack) Chung a4b654a5af Add implementation for NVCC path
[ROCm/clr commit: b46e684d2e]
2019-03-04 20:11:12 -08:00
Wen-Heng (Jack) Chung 21cf5b0ae4 Add direct test for hipMemsetD32 and hipMemsetD32Async
[ROCm/clr commit: 365d08535b]
2019-03-04 17:20:32 +00:00
Wen-Heng (Jack) Chung 2706bf46f2 Add hipMemsetD32 and hipMemsetD32Async
Add 2 extra memset functions which fills memory with integer-typed data

Also change the parameters of ihipMemset to better explain the semantic


[ROCm/clr commit: 392271f4db]
2019-03-04 17:00:33 +00:00
Maneesh Gupta 1269a45f8c Merge pull request #939 from gargrahul/update_hipmemset_test
[dtest] Update hipMemset test

[ROCm/clr commit: 24570ab72a]
2019-03-03 20:29:55 +05:30
Rahul Garg b3ba23ba81 Fix review comments
[ROCm/clr commit: 5900416629]
2019-03-02 23:38:37 +05:30
Maneesh Gupta 0900e28473 Merge pull request #945 from wkwchau/hipMemset3D_fix
Fix hipMemset3D test

[ROCm/clr commit: 8bd168febf]
2019-03-01 21:18:12 +05:30
Wilkin Chau 19b361281a Fix hipMemset3D test
Calculate the allocated size based on the width, height and depth.


[ROCm/clr commit: 99540373cf]
2019-02-28 22:42:46 +00:00
Rahul Garg e6f5850ebb Fix hipMemset test for HIP/NVCC
[ROCm/clr commit: 41afe4d947]
2019-03-01 03:46:57 +05:30