Graf commitů

6462 Commity

Autor SHA1 Zpráva Datum
kjayapra-amd 0f9c624f4c SWDEV-413997 - Physical address size could be more than mapped size, only virtual address needs to be match the size of unmap request.
Change-Id: If0e973149d8ce1b6f01000ab951cf6e9f4b38e97
2024-01-16 07:09:50 -05:00
Maneesh Gupta 4b6912031b SWDEV-1 - Temporarily disable rocprofiler-register support
Change-Id: I2e4b4c5f6c0640fc4e1378dd920b080b88583921
2024-01-16 04:15:05 +00:00
Saleel Kudchadker 0b0df605d4 SWDEV-301667 - Remove resetFenceDirty
Dont track the status of fence_dirty_ flag on the host, instead clear it
when we submit a barrier on the respective stream.

Change-Id: I4d98dbf20c81379c9c5da9f5b67629a8f9f6dfcd
2024-01-15 15:43:14 -05:00
Jonathan R. Madsen 0f1fdc7794 Add rocprofiler-register support
- Add API table versioning defines to hip_api_trace.hpp
- Add rocprofiler-register implementation in hip_api_trace.cpp
  - created ToolInit implementation
  - moved some local functions into anonymous namespace
  - renamed some function to be overloads
  - made most of the initialization code templated (reduced code duplication)
  - enforce ABI
- Updated hipamd/src/CMakeLists.txt
  - find rocprofiler-register package (enabled by default but not required)
- Address review comments
  - simplify size calculation for dispatch table
  - remove setting .size field in GetDispatchTableImpl
- Fix windows build
- Do not enforce ABI on Windows

Change-Id: I08766e8a083528a1236996274bf4522e0e8a1b9f
2024-01-13 01:02:59 -06:00
sdashmiz d23835ffbe SWDEV-421027 - Add hipGraphAddNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ic8cf293ff483ee2547b52d2975062bcb9a6f5d17
2024-01-12 11:36:30 -05:00
Jatin Chaudhary 2cfb8bc3c1 SWDEV-438181 - check stream associated with event
...before we dereference it. It might have been deleted.

Change-Id: Ief832ee0907658a40ca42b9d78d19658153a05dd
2024-01-12 10:39:20 -05:00
Sameer Sahasrabuddhe c5ab5680b4 SWDEV-295298: introduce warp sync functions
The following builtins from the CUDA spec are implemented:

  - __all_sync, __any_sync, __ballot_sync and __activemask
  - __match_any_sync and __match_all_sync
  - __shfl_sync, __shfl_up_sync, __shfl_down_sync, and __shfl_xor_sync

The following builtins are NOT implemented, pending support in the compiler:

  - __reduce_add_sync, __reduce_min_sync, __reduce_max_sync
  - __reduce_and_sync, __reduce_or_sync, __reduce_xor_sync

Change-Id: I07dedbbfe5449f4b5c9b040bed59f5603ccec8c3
2024-01-11 22:31:27 -05:00
Saleel Kudchadker 4b3c4709ff SWDEV-301667 - Missing marker for hipExtLaunch* optimization
- Use isFenceDirty() check in hipStreamQuery.
In case if there is a stopEvent for hipExtLaunch* API we avoid system
scope if there are consecutive hipExtLaunch* and replace them with agent
scope, but then if one uses hipStreamQuery it should detect we need a
barrier with system scope.

Change-Id: I539810f659d4e1c49104e3a0da6ff2803c6b3dee
2024-01-11 18:19:30 -05:00
jujiang 2a2fea6c07 SWDEV-410522 - Fix a doxygen warning in a header in AMD platform
Change-Id: I29cd222af453c42a5d472081747bacf0c3f8d17c
2024-01-11 13:40:25 -05:00
kjayapra-amd 98c87921a3 SWDEV-440106 - Mapping hipDestroyExternalMemory in HIP dispatch table.
Change-Id: I5e6e21f929c95be524ace7fd8735a05994c896e8
2024-01-09 15:02:03 -05:00
sdashmiz 087767d9ac SWDEV-403382 - Add missing graph APIs
- add external semaphor signal and wait node

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If205d48bc4fb60ce2966ca6ed0419e7700755bdd
2024-01-09 14:19:50 -05:00
David Salinas bf7d45050d Change dependency from hipcc to hipcc-nvidia for hip-runtime-nvidia packages
SWDEV-424143 : rocm-llvm is installed with hip-runtime-nvidia package

Change-Id: Ibeffd1df9ee2efcfcd57a258d99b138eb9200681
2024-01-09 18:49:30 +00:00
Rahul Garg 956cc463bf SWDEV-439426 - Update HIP patch version reported through CMake
Change-Id: I2b32edfa18d85d49a4b96ff80ea8f60e1df5d517
2024-01-08 03:43:01 -05:00
Satyanvesh Dittakavi c398c75512 SWDEV-432977 - Set the correct device id in hipIpcOpenMemHandle
hipIpcOpenMemHandle can be used to open memory handle and fetch
  a device pointer on a different device than the actual device
  where the memory was allocated. The device Id must be set to
  the current device in such cases and not the original device.

Change-Id: Ie1c7eada928d02124a41125876876f96015552e5
2024-01-05 00:28:59 -05:00
David Salinas 9fa8dcd1d1 Enable support for roc-obj tools on Windows
SWDEV-301785 - roc-obj - support for Windows COFF

Change-Id: I20d53196e2d126391934351cb824b7bc926fb1ce
2024-01-04 10:31:02 -05:00
Ioannis Assiouras 411bccff5b SWDEV-438299 - Simplified the code in ExtractFatBinaryUsingCOMGR
Change-Id: Ic15f2b71ae87ab3ca36ed5af2c816d57d09b3e70
2024-01-04 04:01:58 -05:00
Ioannis Assiouras af86c1b8a2 SWDEV-438531 - Fixed hipGraphExecMemcpyNodeSetParams for H2H kind
The function erroneously returns hipErrorInvalidValue when kind
is set to hipMemcpyHostToHost

Change-Id: I6810b9f04f3218e517fd2f96410d1375e6ac6ff0
2024-01-04 03:47:39 -05:00
German Andryeyev a1fffac595 SWDEV-311271 - Switch to sorted map for pool allocations
Sorted map can work much faster for many allocations and a low reuse frequency

Change-Id: I6dba29ebc8bfacdf34307149b6a2b194890b2932
2024-01-03 17:36:05 -05:00
shadi a071c4d2fc SWDEV-388256 - correct API name
Signed-off-by: shadi <shadi.dashmiz@amd.com>
Change-Id: Icbf79613268fe0737a8033abfbcc9f33d785bc12
2024-01-03 15:06:41 -05:00
Jatin Chaudhary 49369f0851 SWDEV-436233 - fix the cumode in hiprtc
cumode should be active when wgp mode is off

Change-Id: I12f2e55d942ddeb0fb4470de7abc3caff1f430f7
2024-01-02 17:43:32 -05:00
Satyanvesh Dittakavi dc8f66b86f SWDEV-379212 - Handle template kernels with hiprtc lowered names
Change-Id: Ib8e6493a1f342f92a35031d5ee39b2e22132b56a
2024-01-02 03:28:28 -05:00
Jaydeep Patel c3fc607e7d SWDEV-437440 - Specify which defination to use at compile time.
Change-Id: Ibeee914f293d26fa68ab793cac8b662aa34e8df3
2023-12-21 19:59:39 -05:00
Anusha GodavarthySurya 9b6cf0f74b SWDEV-351966 - Rename hip::__hipExtModuleLaunchKernel to hip::hipExtModuleLaunchKernel
Change-Id: Ie922760f37bf0c9abf2653d36e32705a12ab5a90
2023-12-20 22:50:01 -05:00
Ioannis Assiouras 5158ec1c00 SWDEV-438299 - Fixed out of bounds memory access in ExtractFatBinaryUsingCOMGR
Change-Id: Ib1c6a38da0b81b78d250d7fb88d1194864a0251d
2023-12-20 04:17:40 -05:00
German Andryeyev 3fa4e31180 SWDEV-311271 - Release freed memory from MemPools
Runtime has to release extra memory, held by the pools,
in synchronization points for event, stream or device.

Change-Id: Id533a5e1d137812aa72bdfe101b4b333c6a43d66
2023-12-19 13:47:04 -05:00
Rahul Garg 92aa9d0fba SWDEV-388256 - Add support of hipExtGetLastError
Change-Id: Ie119d5ea611019996b8a80f7b820ca6a160496a6
2023-12-18 22:03:22 -05:00
Ioannis Assiouras d3bfb55d7a SWDEV-437817 - Fix hipMemCpy2D case that erroneously fails with invalid argument error
When an offset is applied to the source or destination pointers plus the kind is set to
hipMemcpyDefault and the source or destination is allocated with hipMallocManaged
hipMemCpy2D erroneously fails with hipErrorInvalidValue.

Change-Id: I0db4c17514f743652d8f9a2691da6601a2abb2a1
2023-12-18 07:31:56 -05:00
Anusha GodavarthySurya 4a7291ded8 SWDEV-436405 - Move hipChooseDevice out of hip namespace
Change-Id: I47a3cc5e5409f418b282d1a2e250128c769f4778
2023-12-18 04:37:39 -05:00
taosang2 d6d235a111 SWDEV-435296 - Fix sporatic segment fault
Fix sporatic segment fault in texture test
via retaining image in texture object which
references the image.
The image will be released when the texture
object is destroyed.

Change-Id: Ic3fefa2d5dda6afebd1acd4d41ad310b138af6dd
2023-12-15 21:06:20 -05:00
Ioannis Assiouras fe739047e5 SWDEV-433745 - Added demangled symbol for hipExtModuleLaunchKernel
Change-Id: Ib8051fcbdf0c8c99e97c845b777d6562220701a0
2023-12-15 16:59:40 -05:00
kjayapra-amd f9fd5f4049 SWDEV-413997 - Alignment should be a multiple of device granularity.
Change-Id: Ie9c636385bbe3139c2dc24c16f31c9d5e2d56b95
2023-12-15 13:27:23 -05:00
Anusha GodavarthySurya 3e72b8d1e1 SWDEV-436405 - Add hipGetDevicePropertiesR0000 and hipChooseDeviceR0000 to hip dispatch table
Change-Id: I5b373ac030502eb88477d20a1d216bc48369b51d
2023-12-15 06:26:52 -05:00
Jaydeep Patel 9551d48e7f SWDEV-411343 - Import VK buffer memory exported by name.
Change-Id: Idc7c840fcd6bf758ecc29ffd6558d24e5bd0a25b
2023-12-14 22:16:11 -05:00
jiabaxie f80985f6a1 SWDEV-435477 - correct MACH IDs and add strx1/halo and krackan support for hip
Change-Id: I5b7ed449f4755d69f10677b90ab2b0ceae050b3d
2023-12-14 13:07:03 -05:00
kjayapra-amd ec010e4d2d SWDEV-413997 - Fixing MGPU cases on PAL side by passing Global Context to virtual alloc.
Change-Id: I6614058d1456d199d710b12acd95160a79aa48c8
2023-12-14 11:34:32 -05:00
German 68d442f29a SWDEV-430809 - Replace hipErrorSharedObjectInitFailed vs hipErrorNoBinaryForGpu
hipErrorSharedObjectInitFailed should be used for interop objects.

Change-Id: Id3bcffaac3b511021f2fd57e9b156a897b646db0
2023-12-14 10:35:10 -05:00
sdashmiz 3a6e1b8fc5 SWDEV-421021 - move new fn pointers to end of the file
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I98d2379b3ef90282de64b22138b1dedcc3586a1b
2023-12-14 09:15:07 -05:00
Sameer Sahasrabuddhe 7137a296dd SWDEV-437090: move the __hip_assert macro to a common place
It cannot be moved to amd_device_functions.h because that causes circular
dependences when trying to use the macro in other files. So we create a new
header and move all assert/abort macros to that common header.

As a side-effect, also fix the macro to correctly expand the entire condition
argument, and also consume the trailing semicolon.

Change-Id: I43688c8e61183503a3a1a039b91321a3779152af
2023-12-14 09:03:14 -05:00
Anusha GodavarthySurya 2bb2446d8f SWDEV-422207 - Fix graph catch tests with graph optimizations(DEBUG_CLR_GRAPH_PACKET_CAPTURE enabled)
Change-Id: I16297e0ddde286bf1798c90f2bf846e69819010d
2023-12-14 01:27:08 -05:00
Mark Searles 704d5df91b SWDEV-435276 - Use -mllvm=<option> syntax rather than -mllvm <option> syntax
Separating -mllvm from its option can cause, in rare circumstances,
the option to be dropped. Or the mllvm to be dropped. Either of which
can cause a compilation error. This issue was exposed investigating
SWDEV-435276

Change-Id: Ie665d49183b55a57c9b58619cad525e44f3be8a5
2023-12-13 13:32:51 -05:00
sdashmiz b8e820f835 SWDEV-421021 - Add hipDrvmemsetnode for graph
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0240a162a16e61549d46b5d086c831404550e833
2023-12-13 09:30:36 -05:00
Jatin Chaudhary d5e596c975 SWDEV-434226 - populate correct output in mempool supported handle type query
Change-Id: Iabbf9c0b54d9978671e3492f13660917499a03fa
2023-12-13 04:40:41 -05:00
Satyanvesh Dittakavi b2102fe939 SWDEV-434846 - Correct the vgprs per simd for MI300
Change-Id: Id4862da7611f64392bfc1538fb644801ec0a9e7f
2023-12-13 03:06:21 -05:00
Jatin Chaudhary 14cbd8d24c SWDEV-431315 - mark stack as non executable in hiprtc generated header
Reference: https://wiki.gentoo.org/wiki/Hardened/GNU_stack_quickstart

Change-Id: I66860eb3787b8c835c52168dcf7a084982f0d7e6
2023-12-12 18:56:51 -05:00
Jatin Chaudhary db909b2a1e SWDEV-430619 - copy uuid via memcpy
If uuid is copied via strncpy it will stop at first null character. We
  need to copy all 16 bytes which might have a null on windows.

Change-Id: I8667919cb251133eec3333a23768c356879727e8
2023-12-12 04:09:05 -05:00
Todd tiantuo Li b825decd42 SWDEV-422544 - Use hipDeviceAttributeUnifiedAddressing as APU flag
Change-Id: If718a20f62f0ba8d83c01a0b2d16ff3f706f7bd4
2023-12-08 11:40:34 -05:00
Satyanvesh Dittakavi 912cc407a4 SWDEV-432684 - SWDEV-433437 - Fix test_gpu_jit MIGraphx test failure
Add clang pragma push and pop diagnostics for ignoring "-Weverything"
in the hiprtc builtins header. Otherwise this will ignore even the
geniune errors occurring in the hiprtc kernels.

Change-Id: I8c3dacf902732b2ea495d83e797369f8aebd75d6
2023-12-08 11:12:43 -05:00
Saleel Kudchadker 058b2702db SWDEV-301667 - Logging refactor
- Remove newline from logging as log function internally inserts a new
line

Change-Id: I25eb2242a1f1e87cf811bcc373d1d485b2e027a8
2023-12-07 12:12:57 -05:00
Saleel Kudchadker 59a6a6c12e SWDEV-433634 - Check Relaxed capture interaction mode for the thread
- Allow capture to be less rectrictive if we set the global thread
interaction mode for the thread.

Change-Id: I84f65d9418ac26ada0477c85a45a3831c2351ce4
2023-12-06 22:35:20 +00:00
Ioannis Assiouras 2ede1c9adb SWDEV-436236 - Fixed integer division to float result in Heap::FindMemory
Change-Id: Ic72cfdbe1f62fabd3e25d33bfa540d82a02480d0
2023-12-06 12:41:00 -05:00