Graf Tiomantas

4607 Tiomáintí

Údar SHA1 Teachtaireacht Dáta
Evgeny Mankov 2863db60b2 [HIPIFY] Add more unsupported device functions
[ROCm/hip commit: 58c1a144d1]
2019-09-12 17:53:25 +03:00
Evgeny Mankov aae3b6dd50 [HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h
[ROCm/hip commit: 0426035468]
2019-09-11 18:07:09 +03:00
Evgeny Mankov 023e47adf1 Merge pull request #1406 from emankov/master
[HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)

[ROCm/hip commit: ccf8ffc0c9]
2019-09-11 15:49:46 +03:00
Evgeny Mankov ba10db6fc6 [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);


[ROCm/hip commit: 56ab105e9d]
2019-09-10 15:59:06 +03:00
Aditya Lad 0a90bd8c0f Replacment of RENAME command in CMakeLists.txt (#1402)
[ROCm/hip commit: 90acfb809c]
2019-09-10 08:35:16 +00:00
foreman 78ecb21bd6 P4 to Git Change 1995672 by skudchad@skudchad_rocm on 2019/09/09 14:45:42
SWDEV-199293 - Fix build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#4 edit


[ROCm/hip commit: 66a6e703f2]
2019-09-09 14:50:37 -04:00
foreman 7b8634a03c P4 to Git Change 1995665 by skudchad@skudchad_test2_win_opencl on 2019/09/09 14:36:57
SWDEV-199293 - Implement hiprtcGetLoweredName

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17960/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#3 edit


[ROCm/hip commit: f3e2d275c5]
2019-09-09 14:42:47 -04:00
foreman bf11a2e460 P4 to Git Change 1994974 by skudchad@skudchad_test2_win_opencl on 2019/09/06 19:09:36
SWDEV-199293 - Implement some hipRTC apis.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17953/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#2 edit


[ROCm/hip commit: 8167dee7d5]
2019-09-06 19:11:43 -04:00
Evgeny Mankov 17b734afde [HIPIFY] Add device functions support
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.


[ROCm/hip commit: 6602fadc16]
2019-09-06 18:34:12 +03:00
foreman d59a4d4b77 P4 to Git Change 1994498 by skudchad@skudchad_test2_win_opencl on 2019/09/06 04:25:22
SWDEV-202136 - Fix windows build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#26 edit


[ROCm/hip commit: 5db35686db]
2019-09-06 04:33:24 -04:00
foreman 8e4664bd3b P4 to Git Change 1994199 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/09/05 16:35:36
SWDEV-202136 - Fix typos in `hip_hcc.def.in`.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#25 edit


[ROCm/hip commit: ee1b139bd9]
2019-09-05 16:45:19 -04:00
foreman cdf514589a P4 to Git Change 1994120 by axie@axie-hip-pal on 2019/09/05 14:22:40
SWDEV-201667 - Linker errors when using hipArrayCreate and hipMemcpyParam2D

	Tests:
	In Windows 10, the linker errors has been fixed with this code change.
	http://ocltc.amd.com:8111/viewModification.html?modId=125600&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17943/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#24 edit


[ROCm/hip commit: 3b5927d7fe]
2019-09-05 14:34:47 -04:00
foreman e841213b5a P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.

	Tests:
	The sample code can be built without linkage error.
	http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17942/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit


[ROCm/hip commit: 485caa0602]
2019-09-05 14:30:10 -04:00
foreman 4ee148290d P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit


[ROCm/hip commit: 9b5b4c4761]
2019-09-05 14:12:32 -04:00
Jeff Daily 191482e1e4 fix bug where HIP_DB=1 seg faults at startup (#1388)
[ROCm/hip commit: 8384f487ad]
2019-09-05 10:04:19 +00:00
mhbliao 4913aec033 [hip] Stop using noduplicate and replace it with convergent. (#1390)
[ROCm/hip commit: 119ee4b671]
2019-09-05 10:03:43 +00:00
Paul Fultz II 9082a9990e Use hcc when building with hcc compiler (#1225)
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME


[ROCm/hip commit: f6cf7e4e79]
2019-09-05 10:03:04 +00:00
Evgeny Mankov 4d105b10ca [HIPIFY][cmake][#1394] Fix
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7


[ROCm/hip commit: ab560d8fd2]
2019-09-05 12:08:56 +03:00
Evgeny Mankov 5ba0d63058 [HIPIFY][perl] Code cleanup (preparation for generating)
[ROCm/hip commit: 3a034a3427]
2019-09-05 11:52:59 +03:00
foreman 6e0697f64f P4 to Git Change 1993529 by skudchad@skudchad_rocm on 2019/09/04 17:08:05
SWDEV-199293 - Initial API checkin and sym export defines

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#1 add


[ROCm/hip commit: 6b67514724]
2019-09-04 17:16:03 -04:00
Evgeny Mankov 835b6481ea [HIPIFY][perl] Sync hipify-perl with hipify-clang
Sync by means of semi-automatic generation: hipify-clang -perl


[ROCm/hip commit: 2a4c008385]
2019-09-04 17:07:45 +03:00
Evgeny Mankov 2b06d68835 [HIPIFY][perl] Code cleanup and formatting
[ROCm/hip commit: 5b8843a127]
2019-09-04 16:37:26 +03:00
Evgeny Mankov 8896d276fe [HIPIFY][perl][#259] Fix
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );


[ROCm/hip commit: b98330609b]
2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu 73b6fe599c Do not include cuda wappers for OMP for hip-clang (#1382)
[ROCm/hip commit: 8fe8fc18c0]
2019-09-03 05:13:59 +00:00
Rahul Garg 83d9c2769b Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit 7dca0455e9.

[ROCm/hip commit: 6545521d6c]
2019-09-03 05:13:46 +00:00
Nicholas Malaya 0915e29c6f Fix Broken Link in hip_porting_guide (#1376)
The math library equivalents between CUDA-HIP are broken. This is a key feature for converting to AMD hardware. This fix corrects the broken link and moves the library equivalents to sit under the "Porting a New Cuda Project" header.

[ROCm/hip commit: 5a6eafcbf1]
2019-09-03 05:13:35 +00:00
Sarbojit2019 fed6843ecf Removed hipLaunchKernel macro got missed in Merge (#1374)
[ROCm/hip commit: e1f9e08ea7]
2019-09-03 05:13:07 +00:00
Evgeny Mankov 29c8b80fc4 [HIPIFY][doc] Update README.md (testing, versions)
[ROCm/hip commit: fbf23ed231]
2019-09-02 18:18:43 +03:00
Evgeny Mankov a4af0f2fc1 [HIPIFY][tests] Add occupancy test
[ROCm/hip commit: 1bf6deb149]
2019-09-02 17:54:06 +03:00
Evgeny Mankov 8a0224db1d [HIPIFY][fix] Fix for upcoming LLVM 10.0
[ROCm/hip commit: ce4140f94d]
2019-09-01 18:15:03 +03:00
Sameer Sahasrabuddhe 8afbecf687 remove obsolete test for OCKL Asynchronous Streams
The implementation for OCKL AS was recently removed from the device
library since that feature is now superseded by hostcall.


[ROCm/hip commit: 70023c9075]
2019-08-30 20:41:29 +05:30
foreman 0b5aa5c913 P4 to Git Change 1991227 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/29 17:26:37
SWDEV-193938 - [HIP] Use fine grained pool for hipHostRegister

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#43 edit


[ROCm/hip commit: d484ac0098]
2019-08-29 17:35:38 -04:00
Evgeny Mankov 4deb26d19f [HIPIFY][DNN] cuDNN 7.6.3 support
[ROCm/hip commit: b45c26361d]
2019-08-29 19:55:38 +03:00
Evgeny Mankov ab9f05e6a3 Merge pull request #1372 from emankov/master
[HIPIFY][#207][fix] Translate all preprocessor's conditional blocks

[ROCm/hip commit: 5d0b628142]
2019-08-29 10:30:05 +03:00
Yaxun (Sam) Liu a795928420 Fix sample 11_texture_driver for hip-clang (#1370)
[ROCm/hip commit: c404312ffe]
2019-08-29 01:03:20 +00:00
Yaxun (Sam) Liu 8aca7f3e25 Do not change opt level for -g for hip-clang (#1369)
Currently hipcc uses -O3 for hip-clang by default but uses -O0 if -g is used. This
causes surprise for users since -g should not affect default opt level.

[ROCm/hip commit: b046ec698b]
2019-08-29 01:03:11 +00:00
Sarbojit2019 73e5c52d0d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/hip commit: 0722704f35]
2019-08-29 01:02:59 +00:00
Sarbojit2019 74a3171c6b [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/hip commit: 5c4f78bac3]
2019-08-29 01:02:41 +00:00
satyanveshd f378b67565 [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments


[ROCm/hip commit: f807cc1a7b]
2019-08-29 01:01:49 +00:00
mshivama 37779f5bef Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support


[ROCm/hip commit: d75dc4eb29]
2019-08-29 01:01:25 +00:00
Evgeny Mankov e78eb9bb47 [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly


[ROCm/hip commit: 24be21495d]
2019-08-28 21:17:35 +03:00
Evgeny Mankov 4cf4ca2e4f [HIPIFY][cmake] Minor refactoring
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions


[ROCm/hip commit: eeb4452b23]
2019-08-28 20:40:10 +03:00
foreman d93d935ac7 P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit


[ROCm/hip commit: dd07e24c2b]
2019-08-27 20:26:25 -04:00
Maneesh Gupta a33dbe9004 [packaging] update soft-links that already exist (#1364)
Change-Id: Ibe9840802b1765094ef998edf2210e95404cb989

[ROCm/hip commit: 5d95ffa010]
2019-08-26 23:41:14 -04:00
foreman 83faff3f3f P4 to Git Change 1989149 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 15:30:45
SWDEV-188177 - Adding ihipTexture APIs to hip_hcc.def.in

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#21 edit


[ROCm/hip commit: b05d95cb8e]
2019-08-26 15:44:58 -04:00
foreman 23b5c2a352 P4 to Git Change 1989089 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 14:24:21
SWDEV-198194 - Delete vars at __hipUnregisterFatBinary.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#40 edit


[ROCm/hip commit: 3cb2dd541a]
2019-08-26 14:32:48 -04:00
Michael LIAO e3d7baceff [hcc] Fix previous replacement of result_of_t.
- `result_of_t` is defined as the shortcut of
  ```
  template< class T >
  using result_of_t = typename result_of<T>::type;
  ```


[ROCm/hip commit: 63e47e525b]
2019-08-26 10:58:38 -04:00
ramcherukuri 8b5587cebd moving result_of_t to result_of
[ROCm/hip commit: 3a6ca29815]
2019-08-24 08:59:58 -04:00
foreman 7fc332833a P4 to Git Change 1988496 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/23 19:43:16
SWDEV-199002 - [HIP] Add hipExtLaunchMultiKernelMultiDevice to in files.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#20 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#22 edit


[ROCm/hip commit: d3bbe46d39]
2019-08-23 19:46:27 -04:00
Evgeny Mankov 7dd84b243b [HIPIFY][cmake] Explicitly set c++14
[Reason] LLVM became c++14 last week due to the following change:

37508d3dd94b0154861a90b1909d17b01400df99
Replace llvm::integer_sequence and friends with the C++14 standard version


[ROCm/hip commit: e1d4f8510a]
2019-08-23 19:32:24 +03:00