foreman
a111c9592e
P4 to Git Change 1999915 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/17 19:43:34
...
SWDEV-201128 - [HIP] test_snli_cuda failure
Default to sync packet
Make sure GPU_NUM_MEM_DEPENDENCY is 0 for HIP
No sync packet is only used when there are mem dependency check
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#86 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#28 edit
[ROCm/hip commit: 1955dc1f99 ]
2019-09-17 19:47:11 -04:00
Evgeny Mankov
b1cf1a21d6
[HIPIFY] Add supported device functions (from math_functions.h)
...
+ [perl] Add generation of sub countSupportedDeviceFunctions
+ [FIX] Do not perform any replacement for supported device functions
+ [perl] Sync hipify-perl accordingly
[ROCm/hip commit: 042c125601 ]
2019-09-17 16:17:28 +03:00
Evgeny Mankov
3ba46a7695
Merge pull request #1423 from emankov/master
...
[HIPIFY][perl][fix] Treat ::device_function as a device function
[ROCm/hip commit: 313eb28379 ]
2019-09-17 10:06:56 +03:00
foreman
482d041757
P4 to Git Change 1998982 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/16 17:49:10
...
SWDEV-145570 - [HIP] Fix regression from new headers.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#18 edit
[ROCm/hip commit: d5181ce77a ]
2019-09-16 17:58:06 -04:00
Evgeny Mankov
2cd2afa84b
[HIPIFY][perl][fix] Treat ::device_function as a device function
...
+ Do not treat somenamespace::device_function_name as a device function
+ Fix generation of warnUnsupportedDeviceFunctions function in hipify-clang
+ Update hipify-perl based on hipify-clang -perl generation
+ Update device test math_functions.cu for hipify-perl
[Restrictions]
- hipify-perl is yet unable to handle function declarations in user namespaces
- hipify-perl is yet unable to handle using directive
[ROCm/hip commit: 4f59ec25fe ]
2019-09-16 17:36:55 +03:00
Evgeny Mankov
d364c58e38
Merge pull request #1422 from emankov/master
...
[HIPIFY] Fix build failure due to typo in [#1377 ]
[ROCm/hip commit: a8bf3c04f1 ]
2019-09-16 14:30:01 +03:00
Evgeny Mankov
a1fcf145f3
[HIPIFY] Fix build failure due to typo in [ #1377 ]
...
[ROCm/hip commit: 3f66e7b0b9 ]
2019-09-16 14:28:52 +03:00
mhbliao
2a58af4380
[HIP] Remove a circular including. ( #1418 )
...
[ROCm/hip commit: 1f8c3bbd3b ]
2019-09-16 08:32:47 +00:00
satyanveshd
fe1fae3ec2
Fix checks in hipMemcpy[D/H]to[D/H]() ( #1397 )
...
* SWDEV-202043 hipMemcpyDtoD() issue
[ROCm/hip commit: cfbd0e77fe ]
2019-09-16 08:32:38 +00:00
AlexBinXie
d86d4d674d
[hip]Skip test when hipHostMallocCoherent is not supported by implementation ( #1380 )
...
[ROCm/hip commit: 5ed1f3e2c8 ]
2019-09-16 08:31:43 +00:00
ansurya
b5549f4397
Added new device attributes ( #1377 )
...
* Added new device attributes
* updated comment
* updated with new device attributes supported
[ROCm/hip commit: ceb734b917 ]
2019-09-16 08:31:30 +00:00
Aryan Salmanpour
9e9a505b39
[hip] add initial support for hipLaunchCooperativeKernelMultiDevice API ( #1368 )
...
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API
* fix formatting
[ROCm/hip commit: bac52d3729 ]
2019-09-16 08:31:17 +00:00
Aryan Salmanpour
8e18dee555
[hip][tests] add a unit test for testing hipLaunchCooperativeKernel ( #1361 )
...
* [hip][tests] add a unit test for testing hipLaunchCooperativeKernel
* use __ockl_grid_sync function
* remove already defined __ockl_grid_sync function
* use sync function for grid synchronization
[ROCm/hip commit: 48880a017e ]
2019-09-16 08:31:09 +00:00
Evgeny Mankov
41c7d044a0
Merge pull request #1421 from emankov/hipify-clang
...
[HIPIFY] Scripting related refactoring
[ROCm/hip commit: 05e689aa73 ]
2019-09-15 21:17:49 +03:00
Evgeny Mankov
8e1256aa00
[HIPIFY] Scripting related refactoring
...
+ Move generating hipify-perl and hipify-python into separate namespaces and files
+ Move getAbsoluteFilePath and getAbsoluteDirectoryPath to StringUtils
[ROCm/hip commit: b7df0627b1 ]
2019-09-15 21:13:56 +03:00
Evgeny Mankov
6bad125069
Merge pull request #1420 from emankov/hipify-clang
...
[HIPIFY][perl] Syn with hipify-clang
[ROCm/hip commit: 8e901f028f ]
2019-09-15 15:26:54 +03:00
Evgeny Mankov
202b65876d
[HIPIFY][perl] Syn with hipify-clang
...
[ROCm/hip commit: 287ceac229 ]
2019-09-15 15:25:40 +03:00
Evgeny Mankov
e2811e486f
Merge pull request #1419 from emankov/hipify-clang
...
[HIPIFY][perl] Generate sub warnUnsupportedDeviceFunctions
[ROCm/hip commit: 78f2386a8e ]
2019-09-15 15:20:13 +03:00
Evgeny Mankov
019d08d2f0
[HIPIFY][perl] Generate sub warnUnsupportedDeviceFunctions
...
[ROCm/hip commit: fd8a7675f8 ]
2019-09-15 15:18:58 +03:00
Evgeny Mankov
37d2ddc72b
Merge pull request #1417 from emankov/master
...
[HIPIFY][doc] Update README.md
[ROCm/hip commit: 6770e993a4 ]
2019-09-13 18:58:22 +03:00
Evgeny Mankov
a4cbc99d2c
Merge pull request #1416 from gargrahul/HACK_hipFreeForManangedMalloc
...
[HACK] Temporary fix in hipFree for hipManagedMalloc use
[ROCm/hip commit: e51880cbca ]
2019-09-13 18:57:21 +03:00
Evgeny Mankov
7a6f9d0e3e
[HIPIFY][doc] Update README.md
...
+ Adding -DLLVM_TARGETS_TO_BUILD="NVPTX" to LLVM's cmake command line for minimizing LLVM's build (tested)
+ Test logs update
+ Versions update
[ROCm/hip commit: 182058fa0b ]
2019-09-13 18:56:48 +03:00
foreman
ed83e2e992
P4 to Git Change 1997981 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/13 11:17:32
...
SWDEV-203438 - [HIP] AllGather RCCL test issue
The test tries to launch a kernel on two devices at once and they need to communicate with each other.
For that, it uses a custom stream for each devices.
Problem is in getNullStream we used to call syncStreams all the time
and it was syncing all the streams even the ones on different devices.
So that made the second kernel launch (on 2n dev) to wait for the first kernel to finish which
would never occur since the first one was waiting for the second one.
The fix is to not call syncStreams from getNullStream because we sync already anyway prior in general.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#24 edit
[ROCm/hip commit: 184ee3f5a0 ]
2019-09-13 11:28:33 -04:00
Jenkins
5370fd1c0f
Merge 'master' into 'amd-master'
...
Change-Id: I449c7c1d18e70c4f7f25b264d7871a49b75fc77c
[ROCm/hip commit: 828e18eff7 ]
2019-09-13 05:10:52 -04:00
Rahul Garg
60adfab243
Fix typo and colon in comment
...
[ROCm/hip commit: f0a1f95864 ]
2019-09-13 03:09:01 +05:30
Rahul Garg
e79f2d0ff8
[HACK] Temporary fix for hipFree for hipManagedMalloc
...
[ROCm/hip commit: fe47b2185c ]
2019-09-13 02:10:21 +05:30
foreman
e755a251e5
P4 to Git Change 1997621 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/12 14:16:09
...
SWDEV-145570 - Fixed some logging issues regarding hip(Ext)ModuleLaunchXXX.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#40 edit
[ROCm/hip commit: a508c497ec ]
2019-09-12 14:35:36 -04:00
Evgeny Mankov
e626477f72
Merge pull request #1414 from emankov/master
...
[HIPIFY] Add unsupported fp16 functions
[ROCm/hip commit: 6739a6d656 ]
2019-09-12 18:53:08 +03:00
Evgeny Mankov
bc550cc062
[HIPIFY] Add unsupported fp16 functions
...
[ROCm/hip commit: 34540002dd ]
2019-09-12 18:51:25 +03:00
Evgeny Mankov
904124fd32
Merge pull request #1413 from emankov/master
...
[HIPIFY] Add more unsupported device functions
[ROCm/hip commit: 63198e0d66 ]
2019-09-12 17:55:43 +03:00
Evgeny Mankov
2863db60b2
[HIPIFY] Add more unsupported device functions
...
[ROCm/hip commit: 58c1a144d1 ]
2019-09-12 17:53:25 +03:00
Jenkins
a45eef7386
Merge 'master' into 'amd-master'
...
Change-Id: I99fcb0d69a58ce09065991a580662660d2941f9f
[ROCm/hip commit: 121206adf9 ]
2019-09-12 06:06:14 -04:00
Evgeny Mankov
9528b8277f
Merge pull request #1410 from emankov/master
...
[HIPIFY][#1404 ] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h
[ROCm/hip commit: 2cf9922754 ]
2019-09-11 18:13:05 +03:00
Evgeny Mankov
aae3b6dd50
[HIPIFY][ #1404 ] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h
...
[ROCm/hip commit: 0426035468 ]
2019-09-11 18:07:09 +03:00
Evgeny Mankov
023e47adf1
Merge pull request #1406 from emankov/master
...
[HIPIFY][#1400 ] Fix Template Instantiation kernel launch (clang & perl)
[ROCm/hip commit: ccf8ffc0c9 ]
2019-09-11 15:49:46 +03:00
Jenkins
883c07ccd2
Merge 'master' into 'amd-master'
...
Change-Id: I836a4d36b2f43db1e1850c55e8b174755abd414f
[ROCm/hip commit: c0f79c5411 ]
2019-09-10 10:07:07 -04:00
Evgeny Mankov
ba10db6fc6
[HIPIFY][ #1400 ] Fix Template Instantiation kernel launch (clang & perl)
...
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.
PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:
#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y
// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);
// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);
// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
[ROCm/hip commit: 56ab105e9d ]
2019-09-10 15:59:06 +03:00
Aditya Lad
0a90bd8c0f
Replacment of RENAME command in CMakeLists.txt ( #1402 )
...
[ROCm/hip commit: 90acfb809c ]
2019-09-10 08:35:16 +00:00
foreman
78ecb21bd6
P4 to Git Change 1995672 by skudchad@skudchad_rocm on 2019/09/09 14:45:42
...
SWDEV-199293 - Fix build
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#4 edit
[ROCm/hip commit: 66a6e703f2 ]
2019-09-09 14:50:37 -04:00
foreman
7b8634a03c
P4 to Git Change 1995665 by skudchad@skudchad_test2_win_opencl on 2019/09/09 14:36:57
...
SWDEV-199293 - Implement hiprtcGetLoweredName
ReviewBoardURL = http://ocltc.amd.com/reviews/r/17960/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#3 edit
[ROCm/hip commit: f3e2d275c5 ]
2019-09-09 14:42:47 -04:00
Jenkins
2f7a11093f
Merge 'master' into 'amd-master'
...
Change-Id: Ibb1dbe78aa52c8aeb77851ee1471e1edaec4c654
[ROCm/hip commit: cbe6b65e2c ]
2019-09-09 05:10:28 -04:00
Evgeny Mankov
cec523f647
Merge pull request #1398 from emankov/master
...
[HIPIFY] Add device functions support
[ROCm/hip commit: 29d09eb269 ]
2019-09-07 19:00:00 +03:00
foreman
bf11a2e460
P4 to Git Change 1994974 by skudchad@skudchad_test2_win_opencl on 2019/09/06 19:09:36
...
SWDEV-199293 - Implement some hipRTC apis.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/17953/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#2 edit
[ROCm/hip commit: 8167dee7d5 ]
2019-09-06 19:11:43 -04:00
Evgeny Mankov
17b734afde
[HIPIFY] Add device functions support
...
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.
[ROCm/hip commit: 6602fadc16 ]
2019-09-06 18:34:12 +03:00
foreman
d59a4d4b77
P4 to Git Change 1994498 by skudchad@skudchad_test2_win_opencl on 2019/09/06 04:25:22
...
SWDEV-202136 - Fix windows build
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#26 edit
[ROCm/hip commit: 5db35686db ]
2019-09-06 04:33:24 -04:00
foreman
8e4664bd3b
P4 to Git Change 1994199 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/09/05 16:35:36
...
SWDEV-202136 - Fix typos in `hip_hcc.def.in`.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#25 edit
[ROCm/hip commit: ee1b139bd9 ]
2019-09-05 16:45:19 -04:00
foreman
cdf514589a
P4 to Git Change 1994120 by axie@axie-hip-pal on 2019/09/05 14:22:40
...
SWDEV-201667 - Linker errors when using hipArrayCreate and hipMemcpyParam2D
Tests:
In Windows 10, the linker errors has been fixed with this code change.
http://ocltc.amd.com:8111/viewModification.html?modId=125600&personal=true&tab=vcsModificationBuilds
Review:
http://ocltc.amd.com/reviews/r/17943/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#24 edit
[ROCm/hip commit: 3b5927d7fe ]
2019-09-05 14:34:47 -04:00
foreman
e841213b5a
P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44
...
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.
Tests:
The sample code can be built without linkage error.
http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds
Review:
http://ocltc.amd.com/reviews/r/17942/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit
[ROCm/hip commit: 485caa0602 ]
2019-09-05 14:30:10 -04:00
foreman
4ee148290d
P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26
...
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit
[ROCm/hip commit: 9b5b4c4761 ]
2019-09-05 14:12:32 -04:00
Jeff Daily
191482e1e4
fix bug where HIP_DB=1 seg faults at startup ( #1388 )
...
[ROCm/hip commit: 8384f487ad ]
2019-09-05 10:04:19 +00:00