Maneesh Gupta
12c48303c8
Revert "SWDEV-351980 - Update hip_prof_str.h"
...
This reverts commit c878ce02f6 .
Reason for revert: Incorrect patch
Change-Id: I9adba47d0ab18f621b599295bd9d0fd98887f5d3
[ROCm/clr commit: 835b7578dc ]
2022-09-21 13:04:38 -04:00
kjayapra-amd
b0825090e9
SWDEV-355727 - Added more rules to target ID comparison in hiprtc.
...
Change-Id: I56137375c3eb47dd604c7a02bb88f7e3dbe6c04d
[ROCm/clr commit: d870bdb9b1 ]
2022-09-21 12:18:13 -04:00
Maneesh Gupta
c878ce02f6
SWDEV-351980 - Update hip_prof_str.h
...
Change-Id: Ied27c137aff54e69dc14129e6daad9196479edf9
[ROCm/clr commit: f296e42803 ]
2022-09-21 11:38:59 +00:00
Laurent Morichetti
d43323b5ea
SWDEV-351980 - Remove the ROCtracer private interface from the public header
...
Change-Id: I51d45cca5051f04d3c1b59ca2a9cf1db5fd1ebd4
[ROCm/clr commit: 0b1ea7e075 ]
2022-09-21 02:41:47 -04:00
Laurent Morichetti
7919db9760
SWDEV-351980 - Consolidate registration tables in the roctracer library
...
Remove the api_callbacks_table_t that was holding the API activities and
user callbacks. Instead use a single roctracer callback (TracerCallback)
used to report both API activities and callbacks.
Remove the hipInitActivityCallback that was setting the ROCtracer
callback and memory pool for asynchronous activities as it did not
allow disctinct pools to be used for each activity. Instead, use
hipRegisterTracerCallback to set the single roctracer callback.
Change-Id: I4c10f04f29a6e4cce8caf15db3016c3f72c86b04
[ROCm/clr commit: 82bce811ee ]
2022-09-21 02:41:39 -04:00
Laurent Morichetti
d4cf83b5d2
SWDEV-351980 - Remove IS_PROFILER_ON
...
The CallbacksTable::is_enabled() can simply be implemented by checking
if enabled_api_count is > 0. The ROCclr does not use IS_PROFILER_ON
to report asynchronous activities.
Change-Id: Iab3d034357e51282bf2c453b2ac5c9726786b9eb
[ROCm/clr commit: eeddffc1b1 ]
2022-09-21 02:41:29 -04:00
Laurent Morichetti
472b3f3155
SWDEV-351980 - Move hip_api_data and record to the HIP function's stack
...
Since the hip_api_data and record are only needed at the HIP function's
scope, there is no need to allocate/free them in the ROCtracer activity
callback, they can reside on the HIP function's stack frame.
This solves an issue with the thread local stacks of records the tracer
maintains that are destroyed first (before any global destructor) on
process exit, making it impossible to use HIP functions in global
destructors when the profiler is enabled.
Change-Id: Ib1d70124d009a44dc1f08d41edff95e5f9f84369
[ROCm/clr commit: 85fd969253 ]
2022-09-21 02:41:15 -04:00
pghafari
c328f3b15f
SWDEV-356554 - updated hipDeviceGetDefaultMemPool
...
updated the error check/messages
Change-Id: I518d497a82a14862d5168cc423aeaa20075336b8
[ROCm/clr commit: 42b5a6d5af ]
2022-09-20 16:42:48 -04:00
pghafari
2363e4dd78
SWDEV-356582 - set the parent node in Graph Clone
...
Change-Id: I9b685ca9827b0a0dddc3ef6a0394b298d1031f04
[ROCm/clr commit: f1d8a02122 ]
2022-09-20 16:42:29 -04:00
Ajay
bfea9634a5
SWDEV-357334 - hipEventRecord_spt() to take optional stream arg
...
Change-Id: I19540c577e2c3635a00379f814350ada41020af2
[ROCm/clr commit: 2801e4fe63 ]
2022-09-19 20:28:13 +00:00
Saleel Kudchadker
ad9557a00b
SWDEV-301667 - Pass all params to API Init
...
- Correct return for ihipLaunchKernel
Change-Id: I66e81fa635473e6e728936e4cfba9f1bc7f018ad
[ROCm/clr commit: df278887fe ]
2022-09-15 22:20:02 -07:00
Sourabh Betigeri
65d3ceb312
SWDEV-340649 - Removes a check to limit the size of allocation that was capped to the size of device memory available
...
Change-Id: Ia99264cc85a1e76293e4fad0734f544351c82809
[ROCm/clr commit: 1ee3a6d5c6 ]
2022-09-14 12:58:33 -04:00
Maneesh Gupta
2e860b68a0
Revert "SWDEV-339488 - Address HIPRT tests failure with spaces in the include path"
...
This reverts commit 147c17cac4 .
Change-Id: I10f91ec0205cd4276b141aade5728fdc20030195
[ROCm/clr commit: 8e10332ff1 ]
2022-09-13 23:06:23 -04:00
sdashmiz
44c74209ed
SWDEV-351274 - add proper checks for set attribute
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I9243e6180f3040341396b7159622f2b96e143ac2
[ROCm/clr commit: 39fc6605ec ]
2022-09-09 10:49:33 -04:00
Anusha Godavarthy Surya
1cb6a65b16
SWDEV-350025 - Added hipLaunchHostFunc functionality
...
Change-Id: I6b9d547f7ddf84e617e35ff5d5a490ff458272ef
[ROCm/clr commit: 52a22a1263 ]
2022-09-07 17:53:26 +00:00
Jaydeep Patel
5053dbe40e
SWDEV-351054 - Move validation for w & h to hipMemAllocPitch.
...
Change-Id: Ia624fc99e797baf88dc029d7e36bb80df1bd7d12
[ROCm/clr commit: e5dff9a140 ]
2022-09-07 01:00:49 -04:00
Sarbojit Sarkar
981281199d
SWDEV-354138 - Fixed SPT functions linking issue
...
Change-Id: I738ccdfd6db8cfa8c29f93bb6061e83795df382b
[ROCm/clr commit: 3b530b5676 ]
2022-09-05 06:22:08 -04:00
Satyanvesh Dittakavi
646e4dd5bd
SWDEV-344342 - hiprtc-config-version.cmake should be generated in build directory
...
Change-Id: I7becaa64873c5e8ba95e814421c1f700a0997a8b
[ROCm/clr commit: b7716825c8 ]
2022-09-05 00:05:18 -04:00
Anusha Godavarthy Surya
459e9539b2
SWDEV-354717 - Fix hipExtLaunchKernel as part of stream capture
...
Change-Id: Ic29d7403dfa38f01bec423aa1df7aa75c60a86e2
[ROCm/clr commit: 7f4c711ac1 ]
2022-09-01 19:26:14 +00:00
Anusha Godavarthy Surya
ed2f9051fa
SWDEV-354717 - Add support for hipExtLaunchKernel as part of stream capture
...
Change-Id: I22708923f454a0f4456ff99d25559daffe08c208
[ROCm/clr commit: 2b322a9087 ]
2022-09-01 05:02:20 +00:00
Anusha Godavarthy Surya
67706897e0
SWDEV-352951 - Add capture support for hipModuleLaunchKernel
...
Change-Id: Iced0846c9f753ecbb87e3f7aec2bfd72137d8c00
[ROCm/clr commit: c72942964d ]
2022-08-31 22:15:02 -04:00
Ranjith Ramakrishnan
fb1fd43157
SWDEV-352582 - Updated warning message
...
Using wrapper header file will generate warning message during build time.
Updated the message content to make it more meaningful
Change-Id: I4e0c5e3d845946d9b493d98879ea8e75a92506ee
[ROCm/clr commit: c833a19284 ]
2022-08-31 11:58:26 -07:00
pghafari
8b508ffc6b
SWDEV-341326 - removing sigabrt for NoBinaryForGpu
...
Change-Id: Ia30fb3efec7f71b870e6a35d5ce51a4aa61fad28
[ROCm/clr commit: 9f37acc55f ]
2022-08-31 09:39:59 -04:00
Saleel Kudchadker
79e1355f3a
SWDEV-301667 - Pretty print logs
...
Change-Id: Ide95a5f8d35d81d4a9eb658f40ae2e82ffa3d97f
[ROCm/clr commit: 1ea4d588ef ]
2022-08-30 12:32:11 -04:00
sdashmiz
e3aa6f4b90
SWDEV-353672 - add missing defines for cuda
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I8e2e0a3b8845d1920e6a40e3ed676c657ab90276
[ROCm/clr commit: da47e7184e ]
2022-08-29 08:59:23 -04:00
sdashmiz
b5ae2dde80
SWDEV-325711: move the API under correct hip version
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: Ia4e1588da7d21b2cb617c374d846ce5e05b1f4f8
[ROCm/clr commit: fd8647807d ]
2022-08-26 15:59:30 -04:00
Satyanvesh Dittakavi
147c17cac4
SWDEV-339488 - Address HIPRT tests failure with spaces in the include path
...
Change-Id: Ic9ed57e44fcfdf82a0d066483bc73e1d59c39e30
[ROCm/clr commit: 89355fb586 ]
2022-08-26 06:47:56 -04:00
Jiabao Xie
2f90d3e296
SWDEV-351055 - changed isParent() to checking directly for parent's pointer. image should not be released for test types in Unit_hipMallocArray_happy
...
Change-Id: I8e4fae8c9188ee68c392237cb824a790ad7c9563
[ROCm/clr commit: d9f002c36f ]
2022-08-25 10:11:54 -04:00
Satyanvesh Dittakavi
e960c639b7
SWDEV-344342 - Expose hiprtc target via cmake config interface
...
Change-Id: I1f19c4792665b078c2799c0c3c9e2d5b28c906de
[ROCm/clr commit: ab112eaf1d ]
2022-08-25 00:29:23 -04:00
sdashmiz
66ed5e2057
SWDEV-352290 - correct params checks
...
- correct condition for flags
- remove check for num of dependency
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I6efd918e203b57c840d74ee0243f24b0c2c80e21
[ROCm/clr commit: a10df01f81 ]
2022-08-24 14:09:51 -04:00
Jaydeep Patel
06501e696d
SWDEV-351282 - Null check for desc.
...
Change-Id: I69d534b6f97442c69b66154476a2637e99c3df77
[ROCm/clr commit: cf57f20407 ]
2022-08-24 13:04:56 -04:00
sdashmiz
72703ab50f
SWDEV-352290 - remove the static list for user obj
...
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I8d7542ad5aacdda4e817c6aaed78c9cac4562efd
[ROCm/clr commit: ce5103ac97 ]
2022-08-24 12:01:41 -04:00
Jason Tang
f69195d51c
SWDEV-333471 - Remove HIP_FORCE_QUEUE_PROFILING
...
HIP_FORCE_QUEUE_PROFILING has been replaced by GPU_FORCE_QUEUE_PROFILING.
Change-Id: Ic8dec4407ef79c27094cb3954e48869075b4732f
[ROCm/clr commit: 97741fe5d4 ]
2022-08-24 11:53:16 -04:00
Anusha Godavarthy Surya
0e1f53bf87
SWDEV-350474 - Added hipExtModuleLaunchKernel API support as part of stream capture
...
Change-Id: I90a880ae0d3a85a0cc8380d2cb21e4759ea8151b
[ROCm/clr commit: 0d6e8e378e ]
2022-08-24 11:20:22 -04:00
Jaydeep Patel
72c93b2ddf
SWDEV-351033 - Change error code to hipErrorHostMemoryNotRegistered
...
Change-Id: I930bb1e2787e284f335689d1900bdd08d328272e
[ROCm/clr commit: efadc772db ]
2022-08-24 07:14:15 -04:00
Jaydeep Patel
66015baadc
SWDEV-351220 - Revert 1752b3049e
...
Change-Id: I08a06307271d0eccdf4b4876dea5ec70ace07d39
[ROCm/clr commit: 349ade7b2e ]
2022-08-24 00:08:53 -04:00
Ranjith Ramakrishnan
a2b9eb12d4
SWDEV-353137 - Fix for incorrect library path for hiprtc
...
Hiprtc related libraries are duplicated when installed from build directory
This happens when cmake install libdir is set with lib64 as default and using hard code path "lib" for LIBRARY_DESTINATION
Replaced "lib" with cmake install libdir
Removed the default setting of libdir in source code and its should be controlled via build argument
Change-Id: Icac55eac9427a5088903d01942e6bfd5263a6fc0
[ROCm/clr commit: ba04f95771 ]
2022-08-23 12:19:06 -04:00
kjayapra-amd
7eecd3e27f
SWDEV-351609 - Updating the right structure with file info.
...
Change-Id: Ia4e1195df0669450162b2df4de50197ff27cfcae
[ROCm/clr commit: f15016227b ]
2022-08-22 21:54:35 -04:00
pghafari
a20fb7d571
SWDEV-342010 - in progress keeping track of events
...
Change-Id: Ic87e4b46d4eebe9922a34af5867e9fc32fcb4066
[ROCm/clr commit: ec16be77fc ]
2022-08-22 03:45:57 -04:00
Laurent Morichetti
acd38f5eaa
SWDEV-351980 - Fix hip_prof_str.h generation
...
Fixed an error in the CMakeLists.txt USE_PERF_API option declaration
that was making it always disabled. Fixing this exposed an issue with
the hip_prof_gen.py script's handling of function variants (for example,
_spt functions) and new HIP_INIT_API_* macros.
Also switched the python interpreter to python3 as python2 may not be
available by default on the build system.
Change-Id: I971fc9edcc746ca63a2bdf4f540e755f9a80fe69
[ROCm/clr commit: 8ac20e5e38 ]
2022-08-18 23:15:27 -07:00
Satyanvesh Dittakavi
feb23ab256
SWDEV-336448 - Load comgr versioned dll in hiprtc
...
Change-Id: I9c966ac6e3beae707d732e4bf84f88457d6265de
[ROCm/clr commit: 651f333140 ]
2022-08-19 00:38:08 -04:00
Laurent Morichetti
fae60db2ff
SWDEV-351980 - Use std::shared_mutex
...
Replace the custom reader/writer lock with the standard implementation
available in C++17.
Change-Id: I46013b821f13a023a16094830b7f45c4bacf11cb
[ROCm/clr commit: 008aa1c2e1 ]
2022-08-18 21:55:31 -04:00
Sarbojit Sarkar
504af979fe
SWDEV-2 - clean-up for hipMemset and other memset APIs
...
Change-Id: I0270be2843ee5f79c1c476cec7807c0b920869de
[ROCm/clr commit: b39a56be25 ]
2022-08-18 12:04:16 -04:00
Jaydeep Patel
71f44c6bc1
SWDEV-351285 - Change error.
...
Change-Id: Ia841a24cf774b2e2d8f6b6e37f3d8f43cb73f8df
[ROCm/clr commit: adfb40ed42 ]
2022-08-18 07:07:56 -04:00
Satyanvesh Dittakavi
6996563bec
SWDEV-351377 - hipIpcOpenEventHandle need not reset device ID
...
Change-Id: If4b4a3dbdd8016accc7fc083911cafa8bcb44154
[ROCm/clr commit: e147318403 ]
2022-08-18 00:30:56 -04:00
sdashmiz
213aad7615
SWDEV-325711: Add userobject functions for graph
...
- add user obj APIs for creating release and retain of user onbjects
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com >
Change-Id: I0bf2999c77e44269565b27c31c7c1461f8a160a2
[ROCm/clr commit: 2c010dec17 ]
2022-08-17 14:31:43 -04:00
Laurent Morichetti
2f467284bb
SWDEV-351980 - Acquire the code object lock in StatCO::getStatFuncName
...
Change-Id: I52ce2530d12fbe47e575feb2aab39bbfdfebd201
[ROCm/clr commit: a682934251 ]
2022-08-16 19:43:15 -04:00
Ajay
91a6c2da56
SWDEV-344168 - hipVmm functionality memory check fix
...
Change-Id: Ia1de96ac9dbcbfb6a94a234aec3bf6cb51961799
[ROCm/clr commit: 113cc9ae2a ]
2022-08-16 11:04:56 -07:00
kjayapra-amd
e8872579cf
SWDEV-351508 - Change the data_kind to BC from FATBIN, since unbundling happens in runtime now.
...
Change-Id: Iaf6e85637edaa92171edc4edc650a0b4598bf625
[ROCm/clr commit: 9e9754be80 ]
2022-08-12 19:52:29 -04:00
Jaydeep Patel
99b2f456e7
SWDEV-351200 - Validate desc.
...
Change-Id: Ic8690c9a2134ca42f4bec626ca787587a32856fb
[ROCm/clr commit: 5b6ffb6380 ]
2022-08-11 07:17:21 +00:00