Commit Graph

1208 Commits

Author SHA1 Message Date
Tao Sang 17cc99c05d SWDEV-306947 Enable hipAddressModeBorder
Enable hipAddressModeBorder.
Fix default of height of hipMallocArray().
Some code improvement.

Change-Id: I57045118e7adf915074c547cbe76349a4cfd72d8
2021-10-27 10:05:53 -04:00
anusha GodavarthySurya 8d30df5ccf SWDEV-307915 - hipHccModuleLaunchKernel correct event timing
Change-Id: I397a3d6cf0cf8639666befb9ed7a357c6753741c
2021-10-25 21:46:46 -07:00
anusha GodavarthySurya 63c6799130 SWDEV-307642 - Fix memcpy directed tests failure
Change-Id: I7a835a5a519b35fcda813c2acc1ac3cf5d0b5f23
2021-10-26 00:15:11 -04:00
German Andryeyev 981508b2af SWDEV-303567 - Correct events for hipHccModuleLaunchKernel
Start event should be collected before the kernel launch.
End event can use the command from the kernel launch.

Change-Id: I5413c340280be680b15a44daa0c69b21ed314213
2021-10-25 16:56:37 -04:00
sdashmiz 848c47c95f SWDEV-305946:add null pointer check
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4e466dfd15123276537c47548fbdfb37c5c230df
2021-10-21 10:28:54 -04:00
Satyanvesh Dittakavi 1da4bb21b9 SWDEV-305163 - Do not limit hipHostMalloc upto max GPU memory available
Change-Id: Iea934088bcbef6cbd5c3f9f97767042fcaf71062
2021-10-20 01:33:44 -04:00
Sarbojit Sarkar 9e4766d990 SWDEV-292547 - Fix for hipStreamPerThread
Change-Id: I9328c7ec92d954433f8e69732d91e65fa6fe013a
2021-10-19 23:26:48 -04:00
cjatin 9caaa6f492 SWDEV-306643 - add align and launch bounds for hiprtc
Change-Id: Id178230eeeec94a8678e96474c35376d5427599a
2021-10-17 17:07:04 -04:00
kjayapra-amd 4d1195f0a7 SWDEV-232903 - Move hipmemset dword optimization into ROCclr.
Change-Id: I1af437de2771f6a48d06ce643ade6b79f551a55c
2021-10-13 11:32:00 -04:00
pghafari a525605e5c SWDEV-245531 - GLInterop: exposing api for linux
Change-Id: I9aa12bf5b6463619d3d6cdaea85ffc18f50bb1ba
2021-10-11 12:21:14 -04:00
anusha GodavarthySurya 13ada9b193 SWDEV-24806 - Fix windows dk build
Change-Id: Iaa497c5736f300c71b63499fc218cfd7769d2e20
2021-10-07 10:05:17 -07:00
anusha GodavarthySurya 3a5c80386d SWDEV-24806 - Fix windows dk build
Change-Id: Ie309da9dbbf5037510ec7e6913a711ea631d3df8
2021-10-06 22:52:44 -07:00
pghafari c5acbf2685 SWDEV-245531 - GLInterop: removing GL dependency
Change-Id: Ie8d794fff9518704d008b71c4d108fb01ea3fcb5
2021-10-06 16:53:49 -04:00
anusha GodavarthySurya f6456c5e27 SWDEV-24806 - Added support for event wait and event record graph APIs
hip graph implementation for APIs AddEventRecordNode, AddEventWaitNode, EventRecordNodeGetEvent, EventWaitNodeGetEvent, EventRecordNodeSetEvent,EventWaitNodeSetEvent, ExecEventRecordNodeSetEvent, ExecEventWaitNodeSetEvent

Change-Id: Ifde51f4591067795d6cbf5595372cbdbd8a7bc26
2021-10-06 00:31:42 -07:00
anusha GodavarthySurya c4eda85835 SWDEV-24806 - Added support for memcpy related graph APIs
hipGraphMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams, hipGraphAddMemcpyNodeFromSymbol, hipGraphMemcpyNodeSetParamsFromSymbol, hipGraphExecMemcpyNodeSetParamsFromSymbol, hipGraphAddMemcpyNodeToSymbol, hipGraphMemcpyNodeSetParamsToSymbol, hipGraphExecMemcpyNodeSetParamsToSymbol

Change-Id: I6896144f340867d938aa1777880c78c46ca6f893
2021-10-05 22:43:49 -07:00
anusha GodavarthySurya a62b6110db SWDEV-240806 - Fix windows build remove unused symbols
Change-Id: I27524f2f0700ed5a9b78d46fbc8a19a516c46ad1
2021-10-05 21:10:44 -07:00
anusha GodavarthySurya 1c51d82dd5 SWDEV-240806 - Added few Graph API Implementation
hipGraph APIs clone, childGraph, RemoveDependencies, GetEdges,GetDependencies, GetDependentNodes, GetType and DestroyNode
hipStream APIs GetCaptureInfo, GetCaptureInfo_v2, UpdateCaptureDependencies.

Change-Id: Ib0f4cb8ea335698eecdd6d744ffab1e954153673
2021-10-05 07:44:54 -07:00
anusha GodavarthySurya 63cd524f1d SWDEV-287830 - Remove hardcoding of /opt/rocm path
Change-Id: I3b654f46d8867651734804f19a4456e17ada740d
2021-10-05 07:38:01 -04:00
anusha GodavarthySurya 1111468b49 SWDEV-240806 - Added few more Graph APIs
Change-Id: I028a1fdf30232b0c47443685e03d7ca410d2a0d0
2021-10-05 07:37:11 -04:00
Sarbojit Sarkar 930807fd20 SWDEV-292547 - To match cuda behavior
Change-Id: I3577609fcc5443949f73644196e8310fc49d887f
2021-10-05 00:31:05 -04:00
Ajay 361dec890c SWDEV-301069 - save device id during hipHostRegister
Change-Id: I789b2252fa1a131ed1924b47718e355cb4fc9037
2021-10-04 12:07:29 -04:00
Maneesh Gupta ce0995e799 Revert "SWDEV-252801 - Fix hipGetLastError/hipPeekAtLastError"
Temporarily reverting to resolve promotion issues.

This reverts commit 3dc47bc839.

Change-Id: I578d1d627e4b9779b146bf2827894522d6673d13
2021-10-04 05:15:43 -04:00
Sarbojit Sarkar 98c172c2e4 SWDEV-301823 - Optimized hipMemset2D/3D
Change-Id: I1e817ab135bfdf9b8f9af18c1bf2cd2e926db729
2021-09-28 00:05:33 -04:00
Sourabh 4177d20877 SWDEV-292525 - [hipamd] Use a blit to streamWait
Implementation to use a blit kernel to perform
a hipStreamWait instead of an AQL packet.

Change-Id: I9d9bc1dd793c1454e91e68afb793460749e10d2e
2021-09-27 13:59:21 -04:00
Payam b075718a0f SWDEV-245531 - GLInterop: linux - Buffer Interop
adding back two missed changes back to cmakelists and amdhip.def

Change-Id: Ibe0ed655d3590f0add13c20b160078ae005feaaf
2021-09-23 17:10:37 -04:00
Jatin Chaudhary c250a13849 SWDEV-297217 - Append user options after default options
Change-Id: I1bdd309f98997f805357baa5d3ff36063797460c
2021-09-21 15:12:36 -04:00
Ajay 198530143c SWDEV-301069 - null ptr check before calling getUserData
Change-Id: Iaff3acd44d89a9629efe0672cb45138942d7fa28
2021-09-17 19:25:24 -04:00
agunashe 29adfcd3c0 SWDEV-301069 - current device id saved while allocating memory
Change-Id: I57045119e7adf915074c547cbe76349a4cfd72d9
2021-09-14 12:19:44 -04:00
Laurent Morichetti 3dc47bc839 SWDEV-252801 - Fix hipGetLastError/hipPeekAtLastError
hipGetLastError/hipPeekAtLastError should really return the last error
produced by any of the runtime calls that did not successfuly complete,
not just the error code of the last runtime call.

For example, in this snippet of code:

   1: hipLaunchKernelGGL(MyKernel, dim3(2), dim3(128), 0, 0, 10000,x);
   2: hipDeviceSynchronize();
   3: hipError_t error = hipGetLastError();

If the call to hipLaunchKernelGGL fails, hipDeviceSynchronize (which
succeeds) should not reset the last error to hipSuccess. hipGetLastError
should still return the non-success error code returned by
hipLaunchKernelGGL.

The last error is reset to hipSuccess after calling hipGetLastError.

Change-Id: Ib7c039067c53c94c99c8ecd83f54212bcef06f81
2021-09-09 12:29:05 -07:00
Laurent Morichetti 3911184607 SWDEV-252801 - Fix return HIP_RETURN(x)
HIP_RETURN(x) is not a value, it is a statement ending with a return,
this commit replaces all instances of "return HIP_RETURN(x)" with simply
"HIP_RETURN(x)"

Change-Id: I03293b2684a65367ff55e02b3a71ea49ec7a517a
2021-09-09 12:19:41 -07:00
Jason Tang 4d06d64939 SWDEV-1 - switch to C++17
Change-Id: Ifdb1ecbf175949462c29035c007acb3e82fe8322
2021-09-09 10:16:43 -04:00
Sarbojit Sarkar 88186db4cd SWDEV-276319 - Added missing null check
Change-Id: I0fcaa55b9a793cbb6c1d2f3022edf288dabea757
2021-09-08 06:53:02 -04:00
Jatin Chaudhary 0faf1244b5 SWDEV-299162 - Use new comgr API to demangle names
Change-Id: I9e34518de94db30c345cd03c92801b8424b4e446
2021-09-08 02:32:41 -04:00
Sarbojit Sarkar c8983ead49 SWDEV-300655 - HIP trace cleanup
Change-Id: Iebc1eefe8d81d2f1f8adbab47e1351f03635868f
2021-09-08 00:32:47 -04:00
anusha GodavarthySurya c9d9fd992a SWDEV-300471 - updated hipFree to wait for all streams to finish
Change-Id: I4983ef48a9e720ed03128d83a8d23ad11024fd8f
2021-09-02 00:45:24 -04:00
jujiang e1cd8c5ae2 SWDEV-286322 - clean up trailing white space
Change-Id: If2e3f72ff4901f20dc91539c7d3c290ebb2a2531
2021-09-01 14:44:16 -04:00
Satyanvesh Dittakavi 9adc14a0f5 SWDEV-300584 - Update memory validation checks in hipMemPrefetchAsync
Change-Id: Ie3f07781da58a5d909b8e6d0284387493a97e488
2021-09-01 13:19:04 -04:00
Satyanvesh Dittakavi dda2613525 SWDEV-300934 - Check if the stream is valid
Change-Id: I41797dc3e726c7eea6a405f20deebd6f59381b5e
2021-09-01 13:16:36 -04:00
Saleel Kudchadker 6f71170772 SWDEV-295275 - Check HW event
Change-Id: I23dfe5626f38b13fbdb6478ab12a0122b03e4a98
2021-08-30 15:55:58 -04:00
Tao Sang 3f1cb97306 SWDEV-299966 - Fix hipModuleGetTexRef
hipModuleGetTexRef() returns success for any global device
variable name even if it's not a texture.
This is wrong thus will fail "hipModuleTexture2dDrv --tests 0x14"
This patch will compare the size to overcome this issue somehow.

Change-Id: I4a4d96f947a68713036437ee525359ff412fefe2
2021-08-30 10:30:52 -04:00
Satyanvesh Dittakavi 037f161f2e SWDEV-298985 - Fix hipMemPrefetchAsync
Use the dst device specified to prefetch the data

Change-Id: Id3d2295e0ae500ba03031ef43473a2c29852e45f
2021-08-27 06:53:09 -04:00
anusha GodavarthySurya b43badaba7 SWDEV-297541 - Fix static lib package generation
Change-Id: Ie39cbe6d8a2cda659902f878ff69b45b93f41981
2021-08-25 00:51:32 -04:00
Jatin Chaudhary 221cf39d65 SWDEV-294764 - Trim spaces from demangled name before comparision
Change-Id: I6359c5c01f68be1bbe98d2f2e079ae9cb06709b0
2021-08-23 08:36:40 -04:00
Payam 710bedf5da SWDEV-245531 - GLInterop - merging changes from opencl
Change-Id: I3e21ff89b64afaa406bf46221c0f82045e905b1f
2021-08-16 19:22:46 -04:00
Satyanvesh Dittakavi a984cbf90c SWDEV-298982 - hipMemPrefetchAsync should not allow more bytes than the actual size allocated
Change-Id: If8df97a79a16d39c66c508a8927ae1b4c276663e
2021-08-16 13:19:04 -04:00
Laurent Morichetti 73ee1afb17 Fix a build failure on Windows
Terse static_assert is only available starting with c++17. Add the
message argument since HIP is not compiled using c++17.

Change-Id: I77bc7ddb635e50ac3e6744d73c8751dc8299087e
2021-08-11 21:25:49 -07:00
Ammar ELWazir 0670e49806 SWDEV-294248 (Fixing Race Conditions):
Fixing race conditions that happened when enabling trace-period feature on the following code:
#include <hip/hip_runtime.h>
__global__ void
kernel ()
{
}
int
main (int argc, char **argv)
{
  for (size_t i = 0; i < 10000; ++i) {
    hipLaunchKernelGGL (kernel, 1, 1, 0, 0);
    hipDeviceSynchronize ();
  }
  return 0;
}

Change-Id: I6d2407ad06ecd602b93f53970859e1f4b67072e8
2021-08-11 11:06:10 -04:00
Vladislav Sytchenko 88f6f3d581 SWDEV-297808 - Correct sampler destruction logic
If the texture object was created from an array, then the array owns
the image SRD. Otherwise, if the texture object is a view, or was
created from a buffer, then it owns the image SRD.

The texture object always owns the sampler SRD.

Change-Id: Id88360c23b2b82418c8c3ae2dd569f427574d420
2021-08-10 11:37:49 -04:00
Vladislav Sytchenko b41d5d73d4 SWDEV-297808 - Free sampler when destroying textures
Change-Id: Idaab76392d18c7f5fedc89497e93f0d17835001a
2021-08-09 21:49:36 -04:00
Julia Jiang 8835b897d5 SWDEV-286322 - Remove execution permission
Change-Id: I96e603fc8d407c3a76fa1053bad81e45744b59ad
2021-08-05 14:04:06 -04:00