Граф коммитов

211 Коммитов

Автор SHA1 Сообщение Дата
Ammar ELWazir f308e36798 Fixing Readme & File structure & Typos
Change-Id: I354b4e0e0448c3e8555d0b766b2c410c8049c2ff
2023-05-31 18:00:16 -04:00
Sriraksha Nagaraj 3fe6016957 SWDEV-356166: Adding fix to load rocminfo without it in the PATH variable
Change-Id: I3f36900b47b72fab44c561123cd7600161124430
2023-05-31 14:49:11 -04:00
Ammar ELWazir 08fc21ac31 SWDEV-403050: Multiple fixes for Memory Leaks in profiler
Change-Id: Ib720a81105af13898ff745ce0cbc2a48c1f4a980
2023-05-30 21:41:54 -05:00
Saurabh Verma 8f82ff6a46 MI300 counters support for rocprof and rocprofv2(Accumulation from all xccs)
1. Xml files updated for gfx940 counters
2. File plugin changes to allow rocprofv2 backward compatibility for results.csv
3. Changes in rocprofv2 script to use tblextr.py, to generate results.csv just like rocprof

Change-Id: I7798f4411ce01f6fbfffb126de654ed806ca7045
(cherry picked from commit 86cbaf38c436be876f0426fa27803b1e64d90378)
2023-05-30 21:41:54 -05:00
Giovanni LB cd9ad067fa SWDEV-401887: Removed output folder sent to att.py
Change-Id: I3e09c1ead9c24a5fd03cd26e4bee18d580a2f377
2023-05-25 07:52:01 -03:00
Ammar ELWazir 3368b7483f Fixing ROCSYS
Change-Id: I907e2d0dae0413ebda4f83227dfe99e8a8f86d12
2023-05-25 00:26:01 -04:00
gobhardw b817742d89 SWDEV-388373 : plugins option validates plugin name
Change-Id: Id1aa810bb6f1f8e52fc0b2f2e5332dd44bf71708
2023-05-24 01:41:13 -04:00
gobhardw 31c9bc44e1 SWDEV-387956 : Added CTF in --help option and Fixed plugin path
Change-Id: I666084ddd4f77c4e1c012b6ca13d101e11dbc494
2023-05-23 00:42:16 +05:30
gobhardw 70a6c26704 fixing ci test issues for v1
Change-Id: I6be62c83a04b6a1a9f7b128086762dcf5ad79fb4
2023-05-17 21:32:12 -04:00
Ammar ELWazir ac6a76d718 Fixing rocprofv2 script
Change-Id: I96ee69e284eb51dc1fbd23682d3d88699a298dae
2023-05-17 11:41:16 -04:00
Ammar ELWazir 256875a69f SWDEV-387702 & SWDEV-387711: Fixing the location of the rocprofilerv2 tool
Change-Id: I5a7439351f1153c4c9f29b3fb4990fcc4de69c65
2023-05-16 18:10:49 +00:00
Ammar ELWazir 52eebaa6e6 Fixing rocprofv2 script
Change-Id: I3adbd216116ad44032e5a01d880f9cf4d4074ae7
2023-05-15 18:40:41 -04:00
Giovanni LB 55c6a2d4ad SWDEV-391616: Added network/file/off option for ATT analysis.
Change-Id: I77d0d6d6652f0bf1b3f46d919aec5c17e29f3da7
2023-05-10 18:39:48 -04:00
Giovanni LB 317147ca11 PLAT-130888: Added counter no-server/json_dump option.
Change-Id: I22fc2477845982beef8934d2fb55b519d2b2960c
2023-05-10 18:39:38 -04:00
Ammar ELWazir 18110d146e SWDEV-398583: Fix for ATT AQLProfile lib Path in rocprofv2
Change-Id: I2b50916654ac5b1abcc9c37a267911cbf9f471a8
2023-05-05 07:14:09 +00:00
Ammar ELWazir 9e62e066fe V1/V2 API Library Separation
V1 library will be supported as librocprofiler64.so and V2 will be supported as librocprofiler64v2.so and headers will be rocprofiler.h for V1 and v2/rocprofiler.h for v2

Change-Id: Ibe5bdbf2f79f0175342c648e917ae77918186604
2023-05-02 22:44:43 -04:00
Giovanni LB fd2376fe90 PLAT-130888: Added support for .out files
Change-Id: Ia2fe1966e0264f42ee1159d732d5606438b7bb91
2023-04-20 23:15:07 -04:00
gobhardw ef31a96b55 updated README for plugins
Change-Id: I8875bf8b624c8e09467bcb30e2794bdf41b31872
2023-03-29 15:55:05 +00:00
Sriraksha Nagaraj f29b968185 SWDEV-379542: Adding to LD_PRELOAD instead of overriding it
Change-Id: Ib6395454ab6d09124baf2f958f26384f8689f64e
2023-03-09 13:21:09 +00:00
Ammar ELWazir ceefad27d0 Solving failed tests for rocprofiler v1
Change-Id: I61ffc4380b077db3a23c9dbb3e680324cf7f1a4a
2023-03-09 13:21:08 +00:00
Giovanni LB 4ec67854e5 SWDEV-384602: Solved issues with multiple users.
Change-Id: Ie40addcbfdfce6ce45ceec8e38fc83d3d72882eb
2023-03-09 13:21:07 +00:00
Ammar ELWazir dc69331379 Fixing rocprofilerv2 naming and CMake issues
Change-Id: Ib6d336349a056731e5c0f35151296d6fea671360
2023-03-09 13:21:01 +00:00
Ammar ELWazir 9b0e58dfdf Fixing Packages installation path
Change-Id: Ide3536b3c6050effcc9337e612375a7e5ddb6522
2023-03-09 13:20:37 +00:00
Konstantin Zhuravlyov e0e5f7336b Explain why kernels are compiled with code object v4
Change-Id: Ib0502f005faa513105cf570a0013517d6c6349c3
2023-02-03 21:54:33 -05:00
Konstantin Zhuravlyov d9c9d39902 Compile kernels with code object v4
Change-Id: I3dc05dff07888cea79ba0a51eaac17ed64f5fec0
2023-02-03 16:17:34 -05:00
Ammar ELWazir bbbd177dd7 Suppressing the hipGraphLaunch issue
hipGraphs acts as a separate activity group as they have their own memory copies and their kernel dispatches and more activities, currently hip api that roctracer depend on doesn't have a way to represent this type, so we are temporarily suppressing the issue up till we have a complete support for the hipGraphs

Change-Id: I5d889be05c9414530672c781e5a712d572ea4104
2022-11-01 23:29:05 -05:00
Ammar ELWazir 7e8df53c44 Fixing merge_traces.sh
merge_traces.sh was depending on tblextr.py, and the location of tblextr.py changed from bin to libexec/rocprofiler

Change-Id: I76f1a0f41ffcff26e6a1119dacfb8b2ebd56d17d
2022-10-28 10:28:36 -05:00
Laurent Morichetti 3b61d6bd8c SWDEV-362165 - Escape argument strings in the JSON file
"a_string\x000" -> \"a_string\\x000\"

Change-Id: I8bf054702b34577f84080080d9538b16abc996fe
2022-10-18 01:47:46 -04:00
Sriraksha Nagaraj 3bb853c56d SWDEV-359118 - fix for misrepresentation for stream ids in Json file
Some trace entries report the stream argument as 'stream=' and some report it as 'hStream='.
Change-Id: I9e7c7af162db72ddadf6f2a3fe4f44a04bf77ed6
2022-10-13 21:48:48 -04:00
Sriraksha Nagaraj c565e2f329 SWDEV-287352 - Changing the description for timestamp option
Change-Id: Ie1d942f7560838efbc38394b21facf04df9bbda5
2022-07-07 15:08:53 -04:00
Sriraksha Nagaraj b0152e0091 SWDEV-323976 - changes in the scripts to display copy activity in the trace output
Change-Id: If8f7df3668c075a8f21508c796220693be9b40d3
2022-07-05 16:24:45 -04:00
Sriraksha Nagaraj c9efa4891e SWDEV-287352: Fixing typos in the rocprof --help description
Change-Id: I39739e53e477c9e621da1b686e248b5d7aff5ad2
2022-06-29 16:26:25 +00:00
Ammar ELWazir 6f97e15d55 Enabling ROCP_STATS_OPT
Enabling the new methodology of ROCP_STATS_OPT of getting HIP activities while the application is running

Change-Id: I19d09e2f2abe16e6528240bf55d6048645aaa09f
2022-06-21 19:30:38 -05:00
Ammar ELWazir 93a79eb99a Google-Chrome Tracer parser attaching flow events to the wrong time slice
This issue happens when we have slices that have overlapping
timestamp values (i.e. start_ts + dur = start_ts of next slice)
and the flow event references that shared timestamp value.
The google chrome parser sorts all the events
and just taking the most recent one.
Rocprof is outputting flow attachment points as start+dur;
the end ts of the slice that can overlap with the next slice
if no gap between them.

Solution proposal by Michael Steffen (Michael.Steffen@amd.com)

Change-Id: Ifcde142144033c9012b01a78c95f047384f972dd
2022-06-13 14:53:14 -04:00
Ammar ELWazir 0be6306cae SWDEV-338186: Fixing Roctracer tool name, path
Using libroctracer_tool.so instead of libtracer_tool.so and fixing the paths for the tracer tool

Change-Id: I9b3ca885f3ca5385b106d5376894b1b4054f9c1d
2022-05-20 05:26:33 -04:00
Laurent Morichetti 0123aa61fa Register the tracer API as a tool library
In a future change, the tracer API library (libroctracer64.so) will be
automatically registered as a tool library. Until then, explicitly
register it by adding it to the HSA_TOOLS_LIB environment variable.

Change-Id: I44d78ac38608e6da5edf04b498a73485f5609d06
2022-05-04 19:19:34 -07:00
Kiumars Sabeti 4d99f8d8e5 SWDEV-320429: wrapping the comma-containing names in the .csv in double quotes at the time the .csv is generated
Change-Id: I62f94a1cf8895eb324080f8aacac3f13c02d7050
2022-04-27 20:45:51 -04:00
Ammar ELWazir 1f925b3f16 SWDEV-332635: Fixing the effect of roctx-rename feature
HIP/HSA traces were asked to access range_data list, however, it was not initialized because roctx tracing was not enabled, moved lists initialization before roctx check

Change-Id: I9942876445cb1b2f69c6bb0d8986d6d9234f1441
2022-04-13 12:58:31 +00:00
Laurent Morichetti 1078a088e9 SWDEV-318682: Using roctx to rename long kernel names to shorter ones.
To enable this feature use the --roctx-rename rocprof option. This
implementation records all messages received in roctxPush calls and
use them to replace corresponding kernel names.

Tested with the following HIP program:

\#include <hip/hip_runtime.h>
\#include <roctracer/roctx.h>

__global__ void
ThisIsALongKernelName ()
{
}

int
main (int argc, char* argv[])
{
  hipSetDevice (0);

  // Not in a roctx range.
  ThisIsALongKernelName<<<1, 1>>> ();

  roctxRangePush ("A");
  // In a simple first level roctx range.
  ThisIsALongKernelName<<<1, 1>>> ();
  roctxRangePop ();

  roctxRangePush ("B");
  roctxRangePush ("C");
  // In a nested roctx range.
  ThisIsALongKernelName<<<1, 1>>> ();
  roctxRangePop ();
  roctxRangePop ();

  roctxRangePush ("D");
  roctxRangePush ("E");
  roctxRangePop ();
  // In a first level roctx range, but after a nested range.
  ThisIsALongKernelName<<<1, 1>>> ();
  roctxRangePop ();

  hipDeviceSynchronize ();
  return 0;
}

Change-Id: I629312234468daff8b017caa5cb0773707d98cce
2022-04-07 18:03:03 -07:00
Ammar ELWazir 46c4e5045a SWDEV-329270: fixed the multiline input.txt issue
In a previous change the key for the var_table in tblextr.py script has been changed from one value to a tuple without changing the usage of the var_table in the rest of the script

Change-Id: I38964f61afad5323d1ca9b64d538cec426298842
2022-03-25 05:09:52 +00:00
Ammar ELWazir fd4767d954 SWDEV-329261: Fix for Post-Processing HSA Memcopy Async Activities
The Post-Processing script was depending HSA API call for async mem copies to correlate it with the HSA Async Memcpy Activity, now if user decided to include input file with filtering HSA Api calls without adding HSA Memcpy, then all the correlation data will be dropped and the Async activity will be reported with the information given from the HSA async activity result file

Change-Id: I5123a5acab9b35a4c25793e7953fdfb74929c999
2022-03-24 10:22:52 -04:00
Ranjith Ramakrishnan d891915a16 Merge "File Reorganization with backward compatibility" into amd-staging 2022-03-08 14:09:13 -05:00
Ranjith Ramakrishnan 015697db74 File Reorganization with backward compatibility
Package files installed in /opt/rocm
Wrapper header files and library soft links installed in/opt/rocm/rocprofiler
Test tools library and binaries renamed
Internal binaries installed in /opt/rocm/libexec/rocprofiler
run.sh updated with file reorg changes

Change-Id: I927d1a0dcd814764ebf0f473d0a64883906d5457
2022-03-05 14:49:41 -08:00
Ammar ELWazir 7a9692766d SWDEV-326120: Fix for Staging
'merge_traces script from rocprof fails to include GPU / HSA / ROCTX activity in merged trace' change was missing tuple addition to the second for loop causing issues on gfx908 and gfx906 | change NO: 628475

Change-Id: Ic0b6140d4372eb109fdf7bdc8d58c0d84239196d
2022-03-04 12:22:37 -05:00
Saurabh Verma 7a7c73b7d8 SWDEV-299902: merge_traces script from rocprof fails to include GPU / HSA / ROCTX activity in merged trace
Change-Id: I29cfd6cfaf34bfa588bd90774db6d8ac501e8aa8
2022-02-18 16:11:08 -06:00
kiumars 7a8f5b5e90 SWDEV-303820: [LLNLA-63]rocprof does not check input arguments at start
Change-Id: I820a2b6df10b799f776518a98519e9c8ca40ec53
2021-11-11 17:31:56 -05:00
Chun Yang ff43ca1542 SWDEV-296922 : Incorrect rounding due to integer division in rocprofiler metrics
Changed var_pattern in tblextr.py to include pattern like "name[0]"

Change-Id: Ibe1c512595cfbdcaca8fa5bddceb3f6a570caf43
2021-09-29 09:15:11 -07:00
Chun Yang f9017cbdc5 SWDEV-296922 : Incorrect rounding due to integer division in rocprofiler metrics
Changed derived metrics to double from int64.
Fixed standalone test due to int64 to float change
Fixed intercept test due to int64 to float change.

Change-Id: I49631c187406ae9dd94a869b3bb13772012e8cdf
2021-09-23 14:52:35 -07:00
Saurabh Verma ca059e1aa9 SWDEV-296100: hipStreamWaitValue64 and hipStreamWriteValue64 break rocprof
Change-Id: I5b31affa6df4359a02014b87b825554ac5519c1a
2021-09-15 12:07:40 -04:00
Laurent Morichetti d926d09134 Merge "Merge roctx_trace.txt" into amd-staging 2021-09-02 12:31:29 -04:00