Commit Graph

103 Commits

Author SHA1 Message Date
Anusha GodavarthySurya a0981e4ccd SWDEV-357759, SWDEV-360041, SWDEV-361145 Fix Stream end capture on forked streams
Change-Id: If0dc6242d2d3ca680e37e14a5dea5cf68dc295df


[ROCm/clr commit: 039e26ee0f]
2022-10-12 13:00:05 -04:00
Rakesh Roy f149b21399 SWDEV-351969 - TLS Optimization
- Aggregate all TLS(Thread Local Storage) variables into a single class
- This is to improve cache accesses per thread

Change-Id: Ic8361eaeae290fff00254684e309471958365eb9


[ROCm/clr commit: 8b391ef18c]
2022-10-09 22:08:14 -04:00
Tao Sang 2be45a82ec SWDEV-318349 - Fix hipGraphKernelNode and hipGraphMemcpyNode
For hipGraphKernelNode, remove func_;
and reorganize functions to naturely support mGPU;
For hipGraphMemcpyNode, make EnqueueCommands() support different
queues' sync
Change-Id: I22708923f454adf4456ff99d25559daffed8c20d


[ROCm/clr commit: f83ba8cd23]
2022-10-07 09:07:56 -04:00
Anusha Godavarthy Surya 459e9539b2 SWDEV-354717 - Fix hipExtLaunchKernel as part of stream capture
Change-Id: Ic29d7403dfa38f01bec423aa1df7aa75c60a86e2


[ROCm/clr commit: 7f4c711ac1]
2022-09-01 19:26:14 +00:00
Anusha Godavarthy Surya ed2f9051fa SWDEV-354717 - Add support for hipExtLaunchKernel as part of stream capture
Change-Id: I22708923f454a0f4456ff99d25559daffe08c208


[ROCm/clr commit: 2b322a9087]
2022-09-01 05:02:20 +00:00
Anusha Godavarthy Surya 67706897e0 SWDEV-352951 - Add capture support for hipModuleLaunchKernel
Change-Id: Iced0846c9f753ecbb87e3f7aec2bfd72137d8c00


[ROCm/clr commit: c72942964d]
2022-08-31 22:15:02 -04:00
sdashmiz 66ed5e2057 SWDEV-352290 - correct params checks
- correct condition for flags

- remove check for num of dependency

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6efd918e203b57c840d74ee0243f24b0c2c80e21


[ROCm/clr commit: a10df01f81]
2022-08-24 14:09:51 -04:00
sdashmiz 72703ab50f SWDEV-352290 - remove the static list for user obj
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I8d7542ad5aacdda4e817c6aaed78c9cac4562efd


[ROCm/clr commit: ce5103ac97]
2022-08-24 12:01:41 -04:00
Anusha Godavarthy Surya 0e1f53bf87 SWDEV-350474 - Added hipExtModuleLaunchKernel API support as part of stream capture
Change-Id: I90a880ae0d3a85a0cc8380d2cb21e4759ea8151b


[ROCm/clr commit: 0d6e8e378e]
2022-08-24 11:20:22 -04:00
sdashmiz 213aad7615 SWDEV-325711: Add userobject functions for graph
- add user obj APIs for creating release and retain of user onbjects

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0bf2999c77e44269565b27c31c7c1461f8a160a2


[ROCm/clr commit: 2c010dec17]
2022-08-17 14:31:43 -04:00
Ajay e6565f3209 SWDEV-327563 - Unit_hipGraphAddKernelNode_Negative null kernelparams fix
Change-Id: Id05f8944f41c04036b310b23358c908a8efb5a5b


[ROCm/clr commit: 4274863f5d]
2022-07-12 12:41:28 -04:00
Sarbojit Sarkar c9226df336 SWDEV-323441 - Phase-II : per thread default stream
Change-Id: I3c796ddaebcf0223d7faf50c425c1674de215f9d


[ROCm/clr commit: e9961fedd8]
2022-07-11 12:22:23 -04:00
Sourabh Betigeri a4b6127a80 SWDEV-273026 - Fixes to retrieve valid device memory data when device context is changed and p2p is enabled
Change-Id: Ie3f0b81f7fc6de8df65ccff35f9aefb8f6abdfbe


[ROCm/clr commit: 8d48e0e6be]
2022-07-08 01:45:49 -04:00
sdashmiz 57a0d997d3 SWDEV-325711 - add Graph memory APIs skeleton
- hipDeviceGet/SetGraphMemAttr

- hipDeviceGraphMemTrim

- there is no memory pool for graphs currently

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I11db76ea7ea1c7732175fc93264448052357e8dc


[ROCm/clr commit: e8194dca76]
2022-06-15 14:47:16 -04:00
Sourabh Betigeri 2c9c07aaa8 SWDEV-331301 - Fixes to return error if the childGraph topologies of instantiated childGraphNode and to-be updated childGraphNode do not match
Change-Id: I372317a4df13e5cd352f46525d820246fe4ca8f2


[ROCm/clr commit: c3db564e94]
2022-06-15 13:39:15 -04:00
Sourabh Betigeri 5d26e66ed7 SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3


[ROCm/clr commit: 5549c8cd1b]
2022-06-14 18:06:21 -04:00
Sourabh Betigeri f3d7a42714 SWDEV-340453 - Fixes coding error. Missing condition in a negative scenario
Change-Id: Ic4b71e143ec883ca73a2511a367ac034444ec7de


[ROCm/clr commit: 2f9e92757c]
2022-06-14 12:24:10 -04:00
agunashe af679a5f1c SWDEV-337331 - Windows graph fixes iteration2
API fixed hipGraphAddDependencies

Change-Id: I1248c00d788c392c71e64c5070fe09653125bb34


[ROCm/clr commit: 9e7b44511a]
2022-06-10 16:42:54 -04:00
sdashmiz 3f588bf604 SWDEV-318833 - Get and Set attribute for kernel nodes
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>


[ROCm/clr commit: efd2d55e9d]
2022-06-09 09:47:05 -04:00
Rakesh Roy f80bffb4ab SWDEV-337776 - Fix hipStreamEndCapture API
- Return hipErrorInvalidValue when pGraph is nullptr

Change-Id: I8846f4448eb15117f98421632885330f132c4fce


[ROCm/clr commit: e2874d5e22]
2022-06-01 00:20:23 -04:00
Sourabh Betigeri ea9847c1fd SWDEV-320640 - Fixes to return right error codes in hipStreamUpdateCaptureDependencies() for negative scenarios
Change-Id: I3c4c54f8955fa9bb17eb595544005fe9f0e8a5f0


[ROCm/clr commit: 5a057af564]
2022-05-31 14:09:22 -04:00
kjayapra-amd 9bc0d08679 SWDEV-290384 - Add Linker API support in hiprtc
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0


[ROCm/clr commit: 84f94fd134]
2022-05-24 09:16:14 -04:00
pghafari b2188142d9 SWDEV-336576 - updated graph check
hipGraphExecMemcpyNodeSetParamsFromSymbo was not working in functional
case

Change-Id: I2ad04f6f91519efa075c36fe737a695fa1bc127a


[ROCm/clr commit: bb9e52ab9f]
2022-05-17 17:36:10 -04:00
Sourabh Betigeri 1171423bcf SWDEV-329829 - Fixes to return right error codes for respective negative scenarios
Change-Id: Icb615a336bb846df1cf2811316d88a0e88381da8


[ROCm/clr commit: 5fa514fea0]
2022-05-10 12:56:20 -04:00
Sourabh Betigeri 9caddbf38a SWDEV-331301 - Fixes error code mismatch
Change-Id: I8dda98609b16ea5c1ce4d9db9471e61e5fb0c12c


[ROCm/clr commit: bd851550bd]
2022-04-13 18:51:06 -07:00
Sourabh Betigeri 89ca29819e SWDEV-329848 - Fixes error code mismatch between CUDA and HIP
Change-Id: Ic48de159ca7bdb4b91dadb915972e535518635ae


[ROCm/clr commit: 345e02358c]
2022-04-12 15:00:44 -04:00
Sarbojit Sarkar 85f6f2a0c7 SWDEV-331126 - Fix to Cuda return type
Change-Id: Iea8e7735ef0c58c1244c92338038d91e61d62c16


[ROCm/clr commit: 8657c40721]
2022-04-11 23:35:04 -04:00
Payam 8a6fd0bd65 SWDEV-316819 - graph check ChildGraphNodeGetGraph
Change-Id: Id3a4fb64e6fb5ce37e97f1f3518e09c8bd9a2d0c


[ROCm/clr commit: 8618b1cd07]
2022-04-05 01:24:36 -04:00
Payam Ghafari 37fa31aaa8 Revert "SWDEV-316819 - adding graph checks"
This reverts commit eff4583118.

Reason for revert: Catch2 test fails

Change-Id: If0ea0eab16b50f27c9acbc471530266917773ff1


[ROCm/clr commit: d888c0a9bf]
2022-03-23 15:23:00 -04:00
Ajay ff6fb01aa1 SWDEV-315567 - hipGraphNodeTypeEventRecord node type get/set fixes
Change-Id: I76e866990a153fb254e1187e7fabcc1f93806469


[ROCm/clr commit: ed487980cd]
2022-03-23 14:05:31 -04:00
Sourabh Betigeri 636464ff5f SWDEV-316991 - Returns hipErrorInvalidValue when a wrong node type is passed to hipGraphExecEventWaitNodeSetEvent and hipGraphExecEventRecordNodeSetEvent APIs
Change-Id: Ic80b0b2b154e017b41af617f5049e037a1b66183


[ROCm/clr commit: f73ff54fda]
2022-03-22 18:09:10 -04:00
Ajay 993b9f790c SWDEV-314982 - hipStreamGetCaptureInfo seq ID ptr check
Change-Id: I84a84121d2064182f0daea22578f0fa5f94f850c


[ROCm/clr commit: 8c103bb898]
2022-03-22 12:07:05 -04:00
sdashmiz 7240db0f2e SWDEV-328556: check for wait event node type
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4b70cb576df1ab31503d9089591026bebe4df16a


[ROCm/clr commit: 610aa33a8b]
2022-03-22 10:54:55 -04:00
Payam 566cd820ac SWDEV-315033,SWDEV-315028 - adding null checks for graph
Change-Id: I9cbea5ea9ff59d7960ae11dfd73d5a744981495f


[ROCm/clr commit: 6a48e430d0]
2022-03-22 02:08:49 -04:00
Sourabh Betigeri d29a3ae502 SWDEV-320640 - Fix to return the right error code when the stream is not in capture mode
Change-Id: Id2f296e0cbf5f90a8163441f4c69c72615dd90a0


[ROCm/clr commit: 02838eb236]
2022-03-21 19:38:00 -04:00
Ajay 38a0792ebe SWDEV-327945 - hipGraphInstantiateWithFlags accept 0,1 as valid flag values
Change-Id: I3100a3464d1a47fca5f9da80f42e7dd2035865ad


[ROCm/clr commit: aacfc3ed7d]
2022-03-21 16:42:21 -04:00
Sourabh Betigeri 389d81161b SWDEV-316226 - Fix to return 'numDependencies' as an independent optional argument in StreamGetCaptureInfo_v2()
Change-Id: I19552c4e62401f324ba876d0aa36472ebaa37aa0


[ROCm/clr commit: 8adb379b1d]
2022-03-18 15:44:43 -05:00
Satyanvesh Dittakavi 64153a23d7 SWDEV-318123 - Address hipGraphHostNodeSetParams negative scenarios
Change-Id: I4884a364b40e93c779ca84f34eee4688f3583aab


[ROCm/clr commit: de069729a5]
2022-03-18 12:08:28 -04:00
sdashmiz 6eca010e9e SWDEV-315402: Null param check for pGraphNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4cd3a539cff1a01b4786d4edbc4201cd68346e0e


[ROCm/clr commit: 8e81b8495c]
2022-03-17 22:17:27 -04:00
Ajay 27d1a6ea94 SWDEV-315756 - hipGraphAddMemcpyNodeFromSymbol issues
Change-Id: Ibf9504454830b63caf6048aa53d726116da6d713


[ROCm/clr commit: 8fad1177e3]
2022-03-17 12:10:31 -04:00
Shadi Dashmiz d8952195eb Revert "SWDEV-315402: Null param check for pGraphNode"
This reverts commit bc59991924.

Reason for revert: want to add one more check

Change-Id: I02b621d0c98b9000f75ea214cf5b4967cfaee95d


[ROCm/clr commit: f8f8b0fd95]
2022-03-17 10:04:43 -04:00
Payam e8d95a939e SWDEV-317494 - Graph - allowing empty params
hipHostNodeParams should work without any parameters for the userData

Change-Id: Iee32c3ba87000e29ed037ee507f7da9ea54988a3


[ROCm/clr commit: 4117655e91]
2022-03-15 14:45:46 -04:00
sdashmiz f604a24a65 SWDEV-315736: event_out param correct nullptr check
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id164bc47c928e9c4541b29a0c9128e41e313ed22


[ROCm/clr commit: 2ae3b6d13f]
2022-03-15 11:05:59 -04:00
Christophe Paquot 0c90a8cda6 SWDEV-323472 - Fix hipThreadExchangeStreamCaptureMode
Matching CUDA's described behavior: Threads have their own mode.

Change-Id: I3ea15826305a607bff73eb317c4ef62728ed5dc8


[ROCm/clr commit: 925c742d42]
2022-03-15 10:53:02 -04:00
Payam eff4583118 SWDEV-316819 - adding graph checks
hipGraphChildGraphNodeGetGraph - Scenario 3: Pass Parent node instead of the child node

Change-Id: Ia55921bca1e2745c9c97f2b7eb36244ffb719eb4


[ROCm/clr commit: 5dd91d698b]
2022-03-14 22:43:58 -04:00
sdashmiz bc59991924 SWDEV-315402: Null param check for pGraphNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie1082bb5e5ebdbcc6d38bb1349cb879c2e85a453


[ROCm/clr commit: e383c5fca0]
2022-03-14 13:36:56 -04:00
Sarbojit Sarkar 8a831bfa39 SWDEV-315595 - Fix for another -ve test
Change-Id: I529c734f32b91cf712348d40fbef00658e7de276


[ROCm/clr commit: be2331bf7b]
2022-03-14 04:03:59 -04:00
Ajay f365706d25 SWDEV-313213 - hipGraphDestroy issues
Change-Id: Idf3ede5ea29161b9e5753e8beb245b1f9fd86d28


[ROCm/clr commit: 42137222ad]
2022-03-10 19:54:01 +00:00
Ajay eba59236b1 SWDEV-315509 - hipStreamEndCapture issues
Change-Id: Id95a77ed9ac57f9e904a32947a3d11e3b353be20


[ROCm/clr commit: 1af17d765d]
2022-03-10 12:08:59 -05:00
Sourabh Betigeri 650e69bbd3 SWDEV-317016 - Fixes bad parameters such as uninitialized graph object, pass parent instead of child graph and changed topology
Change-Id: I2e7a7fa30be57d420a3228b495222f4cf579cb05


[ROCm/clr commit: 104992ffda]
2022-03-09 18:45:48 -05:00