AI/rocm-systems
2
0
Fork 0
Code Issues Pull-Requests Actions Pakete Projekte Releases Wiki Aktivität
68.514 Commits 3 Branches 0 Tags
1c09c87cc7f8a7fc9b737d05fca913a06b3bff58
Commit graph

243 Commits

Autor SHA1 Nachricht Datum
vstojilj 1c09c87cc7 SWDEV-564927 - Allow sizeBytes to be 0 when hipMemsetAsync is captured (#1849) 2025-11-27 17:13:33 +01:00
Jaydeep 98d6d268a0 SWDEV-556588 - Handle graph node set params and disabled nodes for AQL packet batching. (#1099) 2025-10-06 13:26:12 +05:30
Godavarthy Surya, Anusha ce560304a8 SWDEV-548417 - Fix Memleaks in Graph (#713) 
Co-authored-by: Anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>
 2025-09-19 17:39:36 +05:30
Godavarthy Surya, Anusha 1be5c9870a SWDEV-524745 - Part-I Add multi device support for hip graph. Update nodes with DevId. (#812) 
- The graph nodes have been updated to capture the device ID from the capture stream or the current device when explicitly added.
- Update the device ID for the memcpy node, ensuring that the device where the memory is allocated is taken into account for H2D and D2H pinned operations.

Co-authored-by: Anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>
 2025-09-10 11:35:25 +05:30
vstojilj f17e332fe0 Release graph if hipStreamEndCapture fails (#738) 2025-09-08 16:32:03 +02:00
SaleelK c4537e8050 SWDEV-553126 - Improve logging (#835) 
* Ability to mask COPY api usage in logs
* Show total graph nodes in logs
* Add another log level for detailed debug
 2025-09-04 10:08:41 -07:00
systems-assistant[bot] ded5b86e83 SWDEV-540609 - capture of MIOpen OCL kernels needs remainder globalWorkSize (#431) 
Co-authored-by: Rakesh Roy <rakesh.roy@amd.com>
 2025-08-26 16:11:31 -04:00
Danylo Lytovchenko f7338717ae SWDEV-470698 - fix formatting, add format check workflow (#657) 2025-08-20 19:58:06 +05:30
Dittakavi, Satyanvesh a3e576a317 SWDEV-542905 - Update the appropriate grid size in capture hipExtModuleLaunchKernel (#740) 
[ROCm/clr commit: c43ee71e96]
 2025-07-21 13:57:15 +05:30
Brzak, Branislav afa60c590c SWDEV-540609 - hipGraph capture of hipExtModuleLaunchKernel assumed grid size was a multiple of block size (#694) 
[ROCm/clr commit: 32e027e66c]
 2025-07-09 16:05:40 +05:30
Betigeri, Sourabh 328aeb758c SWDEV-508963 - Change hipMemcpy subset of methods to use const qualifier for src (#139) (#418) 
Change-Id: Ia5b68bacff634d3d9e5757f515bac50887895bc3

[ROCm/clr commit: c0c3aa3637]
 2025-05-29 13:07:51 +05:30
Assiouras, Ioannis 3ea732b38a SWDEV-508965 - [6.4 Preview] Remove HIP_MEMSET_NODE_PARAMS struct (#121) (#364) 
[ROCm/clr commit: 968f5599a8]
 2025-05-21 21:16:42 +05:30
Xie, Pengda d0b5bee680 SWDEV-527781 - Remove Stream Validation in HIP APIs 
[ROCm/clr commit: 0457b634f8]
 2025-05-13 13:45:27 -07:00
Godavarthy Surya, Anusha e4a499f22e SWDEV-522841 - Graph nodes must be created/launched on device where they are captured/created (#108) 
[ROCm/clr commit: 2538d7f02b]
 2025-04-29 22:20:39 +05:30
Godavarthy Surya, Anusha ff69bcc903 SWDEV-469422 - Avoid using of hipStream_t in internal methods (#69) 
Change-Id: Ifd5362f371c846a88241927383cb95cf046548ef

[ROCm/clr commit: fb92683d86]
 2025-04-28 15:09:11 +05:30
Godavarthy Surya, Anusha 0eb2e5e8f2 SWDEV-469422 - hipGraphNodeDOTAttribute change std::string members to const char* (#70) 
Compiler creates global variables for every unique string

Change-Id: I4cf8dd3e763d16740096e345da67a7ef72f61515

[ROCm/clr commit: bbcb1f9c70]
 2025-04-28 14:57:36 +05:30
Godavarthy Surya, Anusha d4e36d0900 SWDEV-469423 - hipStreamEndCapture graph* can be nullptr (#170) 
[ROCm/clr commit: e5ce544c45]
 2025-04-24 13:57:09 +05:30
Anusha GodavarthySurya 5535f15104 SWDEV-469422 - hipGraph move to classes from structs 
Change-Id: I0f9c8ef1161c0c92ebe0cce6844b2feacfee83f5


[ROCm/clr commit: 32e5b00c30]
 2025-02-05 00:33:41 -05:00
Marko Arandjelovic 8b956db8db SWDEV-489619 - Added checks for memcpy capture path 
Change-Id: I0e156099282f0b6393bcbcee2e9b96c31034a851


[ROCm/clr commit: 269ec54252]
 2025-01-27 03:51:34 -05:00
Sourabh Betigeri e3c4a81b69 SWDEV-502219 - Adds validity checks for negative parameters passed 
Change-Id: Ib8a531533306a27143d74b81c074de81051eb896


[ROCm/clr commit: c460b0541b]
 2025-01-24 16:32:29 -05:00
Vladana Stojiljkovic 4b786b5207 SWDEV-498061 - Add capture support for hipModuleLaunchCooperativeKernel 
Change-Id: I5ed188e046c680c2785b3952391f59ed1d0c21b8


[ROCm/clr commit: 30cb2d0e67]
 2025-01-16 10:54:30 -05:00
Marko Arandjelovic cf8eeabfe2 SWDEV-489619 - Fix memcpy tests with capture stream enabled 
- Added missing validation as graph node should not be created
 if parameters are invalid
 - Fix conversion of input params to graphNode params

Change-Id: I37ab04942b5fb2eb07386850cb7dbbf26f9ca967


[ROCm/clr commit: db8527f655]
 2025-01-16 10:31:04 -05:00
Rahul Manocha 0a9315f5e0 SWDEV-497288 - Add validation checks to hipGraphExecNodeSetParams 
Change-Id: If8cde47bc8e62414333768e01064298d8a3d80ee


[ROCm/clr commit: 2b32d9aada]
 2025-01-13 16:49:45 -05:00
Anusha GodavarthySurya 08c92f4793 SWDEV-480209 - Make internal callbacks non-blocking 
Change-Id: Ic918d08f341abfd9a7c167d09f9c723cdc43157f


[ROCm/clr commit: 683a942364]
 2025-01-10 02:16:11 -05:00
Jaydeep Patel f20f399915 SWDEV-505276 - Parent graph of orig node and original graph of cloned node should be same. 
Change-Id: I6ebc21cc42e41ad5d952a69fb3b3cb095f32cffb


[ROCm/clr commit: dff8197b1d]
 2024-12-24 04:32:14 -05:00
Anusha GodavarthySurya 4288640f69 SWDEV-469422 - Derive GraphExec from Graph and ChildGraphNode from GraphExec 
Change-Id: I54d67a1665355579bc249d8ff4f9806e9ee14588


[ROCm/clr commit: 13e2e797c0]
 2024-12-16 00:43:57 -05:00
Sourabh Betigeri 750313dfed SWDEV-421020 - Adds hipGraphAddBatchMemOp, SetGetParams and execSetParams APIs 
Change-Id: Ieccecfe6173cc68fd3c01f86c99f7cc09fe194a3


[ROCm/clr commit: f1c05e9026]
 2024-12-13 06:23:39 +00:00
Anusha GodavarthySurya acfcd1098f SWDEV-469422 - Refacor childgraph node 
Remove static functions in graph

Change-Id: I4df94915f81f250acaea60398aea32ef0ed658e2


[ROCm/clr commit: 28cbf2bc4f]
 2024-12-12 12:38:24 -05:00
Branislav Brzak 92b1136755 SWDEV-490860 - Do signal_is_required detection post graph schedule 
Change-Id: Iaf1067a811aeac3d16c08de954036e219b545e07


[ROCm/clr commit: 89dfdc4dbe]
 2024-12-09 03:57:44 -05:00
Jaydeep Patel a7406bbd5d SWDEV-502532 - Exit graph launch in case of empty graph. 
Change-Id: Ifb6ab14ca6810cbc1c9e38c59d1d9e7d367358d9


[ROCm/clr commit: 0d4823ff88]
 2024-12-07 12:27:53 -05:00
Anusha GodavarthySurya b383c1e443 SWDEV-469422 - Always schedule graph nodes 
Change-Id: Icc636527fa19e7bf3eb111bc4b1bb9a5f9acff73


[ROCm/clr commit: b89977d518]
 2024-12-03 23:44:23 -05:00
Marko Arandjelovic 36ba236426 SWDEV-499794 - Update AQL packet after updating GraphNode 
Change-Id: I332d70bdf42a276894a548a02d636e370c2ca08c


[ROCm/clr commit: 08aee16573]
 2024-12-02 12:29:35 -05:00
Anusha GodavarthySurya a3c4a5a19c SWDEV-469422 - Cleanup graph code remove parallellists and nodewaitlists 
Change-Id: I00c7b2894333bd13d47b913d3fcdd6e1ffcb741f


[ROCm/clr commit: c47f9dda58]
 2024-11-30 04:40:51 -05:00
Vladana Stojiljkovic 3e8d5599d4 SWDEV-494612- Add capture support for hipLaunchCooperativeKernel 
Change-Id: I6b3c6af55c60cffd43ce6f47b75998f750b75703


[ROCm/clr commit: b75b0d9a53]
 2024-11-29 08:17:41 -05:00
Rahul Manocha d6a34b0f9f SWDEV-497288 - Enable hipGraphExecSetParams for Ext SemWait and SemSignal Nodes 
Change-Id: I7184a3a04ac17d3d841222ae1559db66d73a429c


[ROCm/clr commit: e0c11624e5]
 2024-11-26 11:34:18 -05:00
Anusha GodavarthySurya aa4f1b31df SWDEV-491643 - DEBUG_HIP_FORCE_GRAPH_QUEUES is 1 enable capture path 
Change-Id: Ibddd50592232b090bf5eab8395fe78a36bb3a14a


[ROCm/clr commit: 25a893658a]
 2024-11-25 05:21:10 -05:00
Satyanvesh Dittakavi b606e3dca7 SWDEV-489570 - Update AQL packet in hipDrvGraphExecMemsetNodeSetParams 
After setting the new params in hipDrvGraphExecMemsetNodeSetParams, we
need to update the AQL packet as well, otherwise during the graph launch
it still dispatches the packet which has the original params and not the
updated one.

Change-Id: Ie49a641ba3f66c8085a29f92d88ac6ea6a1c0534


[ROCm/clr commit: ba2ebb3b99]
 2024-11-01 07:01:10 -04:00
Vladana Stojiljkovic 7ff9aa117d SWDEV-493526 - Create kernel node when hipLaunchByPtr is captured 
Change-Id: Id3493485dfdb468436ab33e6d7cb19b6b0066fd4


[ROCm/clr commit: e08df57502]
 2024-10-31 12:41:31 -04:00
Vladana Stojiljkovic d655fa8c66 SWDEV-489571 - Fix ihipGraphAddMemsetNode to allow memset of 3d portions of an array 
* When hipMemset3dAsync is captured, a 3d extent can set be as a parameter (depth > 1). That worked on nvidia, but on amd wrong portion of array was filled because when creating Memset3D command, extent dimensions were used to create pitchedPtr, instead of original array width and height.
* Also, when capturing hipMemset3dAsync, nvidia allows any of the extent dimension to be 0, and in that case, no work should be done.

Change-Id: I46a605bf9ae801cd3348e98d528c21263a8eefce


[ROCm/clr commit: ec60bb1aed]
 2024-10-31 10:29:54 -04:00
Anusha GodavarthySurya 1a472b9703 SWDEV-480209 - Handle GraphExec object release 
=> GraphExec instance is destroyed before async launch completes,
destroy after all pending graph launches
=> Remove GraphExec destroy during next sync point(hipStreamSync,
hipDeviceSync etc..)

Change-Id: I4df682aae5787fd6e5240a7be936ce50361345d0


[ROCm/clr commit: f9f995c6d0]
 2024-10-22 12:30:46 -04:00
Vladana Stojiljkovic af3e9cb9e2 SWDEV-489823 - Fix hipStreamEndCapture leak when capture is invalidated 
Change-Id: If8f5163d70e04d34a75fd0a7ba6c0a15ea59bb8b


[ROCm/clr commit: 6f2bad3998]
 2024-10-10 04:38:06 -04:00
Jaydeep Patel b31bf885a3 SWDEV-482692, SWDEV-485802, SWDEV-485489 - Handle refcounts owned by graph for user objects. 
Change-Id: Ic739ab1ec5d3dc3143e3ae70f9591922bc0e3d9f


[ROCm/clr commit: e74ac6f580]
 2024-10-08 03:44:44 -04:00
kjayapra-amd f19260d568 SWDEV-480772 - Remove name variable from amd::Monitor class. 
Change-Id: Ie2a4fa44f485786227230f8a892e090e718aa30e


[ROCm/clr commit: 12a39fbf22]
 2024-09-19 11:55:01 -04:00
Anusha GodavarthySurya fc014587f8 SWDEV-477324 - Graph Capture memcpy D2D 
Change-Id: Ifaa4d78854c03b3150233142df187c9bbf731cab


[ROCm/clr commit: e98179d924]
 2024-08-28 23:36:51 -04:00
Anusha GodavarthySurya c2a4062392 SWDEV-470612 - Add stream id to DOT print when DEBUG_HIP_GRAPH_DOT_PRINT is enabled 
Change-Id: Iec3630ba6fb2206925653ea939770bb9820d7c52


[ROCm/clr commit: 19bf971134]
 2024-08-21 00:37:41 -04:00
German Andryeyev 35c7a87014 SWDEV-470612 - Add the optimized multistream path 
- Added the optimized multi stream path in graph execution. It uses a fixed number of async streams in the execution
- Optimize the launch latency, where commands
creation and execution is done at the same time
- Optimize the scheduling to use less barriers and waiting signals if
the same queue  can be detected
- The new path is controlled by  DEBUG_HIP_FORCE_GRAPH_QUEUES
environment variable, where 0 will use the original path and any other
value will force the number of asynchronous queues for execution
- DEBUG_HIP_FORCE_ASYNC_QUEUE can force single queue async
execution in graphs(applicable for Navi families only)

Change-Id: I7eb40bc15c45f508d6911868a6f6d4c3598d380e


[ROCm/clr commit: 9db52f9a46]
 2024-08-02 14:19:44 -04:00
Anusha GodavarthySurya 31927fefd6 SWDEV-468424 - Add support to capture multiple AQL Packets 
=> Added support to capture multiple AQL Packets.
=> Added Interface to callback to hip runtime from rocclr to allocate
kernel args from the graph kernel arg pool.
=> Enabled Support to capture memset node.

Change-Id: I7e1c2ba06927459e024653058af142bd82192c43


[ROCm/clr commit: bd3a35bde1]
 2024-08-01 23:55:51 -04:00
Vladana Stojiljkovic 91800f18ea SWDEV-465142 - Copy memAllocNodePtrs_ when cloning graph 
Change-Id: I5a0907e59397e71b44db59c44b551b74a6e59ba0


[ROCm/clr commit: d62c1dea72]
 2024-08-01 11:05:06 +02:00
Anusha GodavarthySurya b6d82323e9 SWDEV-468424 - Refactor kernel arg 
For refactoring of childGraph to have its own graphExec,
kernelArgs needs to be separated from the graphExec object.
All the childNodes part of graph should share same kernelArg pool.
Otherwise we endup creating multiple device kernel arg memory chucks
for single graphExec.

Change-Id: I4029a46ebc1fa112d87df64ab1fecbf288fabe5e


[ROCm/clr commit: 35079e834e]
 2024-07-16 08:38:44 -04:00
sdashmiz ba07492b20 SWDEV-421021 - Add APIs cuMemcpyNodeGet/Set params 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I24bc0da56aad34c9d5876a3d83b59515f11dc3ea


[ROCm/clr commit: 57e79802cd]
 2024-07-10 12:53:01 -04:00