Rachida Kebichi
e5dd1e9b85
SWDEV-284863 Fixed several issues preventing memcpy info dump in csv
...
Change-Id: I4c6323311ce8314296e81a9b9b5d8adb485e0aa8
2021-05-25 11:10:52 -04:00
Laurent Morichetti
297b613604
Fix random bugs discovered while reading the code
...
In HsaTimer::correlated_pair_ns, the time ID should be used to
select the clock ID passed to clock_gettime.
In MemoryPool::allocator_default, pass the correct value to realloc.
Change-Id: I5d10c0994c07fdeadd99c81deba4e71a4f579523
2021-05-20 21:22:16 -04:00
Laurent Morichetti
8fb3cdb30b
Make HIP_VDI the default
...
As this snippet shows, HCC is no longer supported by roctracer:
#if HIP_VDI
...
#else
#error HCC support dropped
#endif
Removed HIP_VDI from the CMakeLists.txt, and the source code.
Change-Id: Ib273da2a5af6d67fa1b021a7eca3ff785c8b9c73
2021-05-20 21:20:27 -04:00
Laurent Morichetti
38009bfba4
Fix a compilation error with gcc-9.3.0
...
On Ubuntu 20.04, in Release mode, gcc fails with this error:
In file included from /usr/include/string.h:495,
from /opt/rocm/include/hsa/hsa_api_trace.h:57,
from ../roctracer/src/util/hsa_rsrc_factory.h:29,
from ../roctracer/src/util/hsa_rsrc_factory.cpp:25:
In function ‘char* strncpy(char*, const char*, size_t)’,
inlined from ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’ at ../roctracer/src/util/hsa_rsrc_factory.cpp:323:12:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:34: error: ‘char* __builtin___strncpy_chk(char*, const char*, long unsigned int, long unsigned int)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../roctracer/src/util/hsa_rsrc_factory.cpp: In member function ‘const util::AgentInfo* util::HsaRsrcFactory::AddAgentInfo(hsa_agent_t)’:
../roctracer/src/util/hsa_rsrc_factory.cpp:322:39: note: length computed here
322 | const int gfxip_label_len = strlen(agent_info->name) - 2;
| ~~~~~~^~~~~~~~~~~~~~~~~~
The error is caused by the following 2 lines:
const int gfxip_label_len = strlen(agent_info->name) - 2;
strncpy(agent_info->gfxip, agent_info->name, gfxip_label_len);
The size argument to strncpy should not depend on the input string.
Since the terminating character is not considered (the copy is at
most len - 2 bytes), using memcpy is preferable. Also, make sure
the destination does not overflow by clamping the size.
Change-Id: I37c5c45418e7c31a017581b6c16e5d47cd61aec5
2021-04-19 22:57:51 -07:00
Evgeny
2287da5e28
fxing gfxip label
...
Change-Id: Ic22d828b38da8afc5a232c2f2eb5de5410844b70
2021-03-28 08:11:58 +00:00
Evgeny
1c77416a6c
SWDEV-267198 : adding gpu index to hsa_handles file
...
Change-Id: I6ddba45ab31fff97a1f85f889c56693accf8f5bc
2021-03-09 15:37:44 -06:00
Evgeny
912cfd4cf8
SWDEV-251491 : fixing tracing on exit
...
Change-Id: I1bf2a6093331e7a08179b9f64394c5c49206ef0e
2020-12-25 01:49:44 -05:00
Rachida Kebichi
2d31848c44
SWDEV-259683 HIP API records filtering
...
Change-Id: I43ca5e022d2c055b6a9bc2c09b4276b490a4b986
2020-12-16 16:29:36 -05:00
Evgeny
bb5f2231a1
calling python3 explictely
...
Change-Id: I3dda55865bafa41cc6670e414b213f13a2a2a7ac
2020-12-16 14:29:12 -05:00
Evgeny
b83ffeeab8
SWDEV-258731 : cleanup
...
Change-Id: Iabcc81576eb8b6c0484eae820c3e25a896da6c5b
2020-12-02 13:52:57 -06:00
Evgeny Shcherbakov
6a59675f01
Merge "Adding dumping of HSA handles" into amd-staging
2020-12-02 06:35:04 -05:00
Evgeny
7d8fd0606d
Adding dumping of HSA handles
...
Change-Id: I18e2cfdf2574110bffa09d30c7ac1d3941252939
2020-12-01 16:45:33 -05:00
Rachida Kebichi
ef36218286
SWDEV-255938 NEW - added regex and depth support to ostream ops
...
Change-Id: I292255adab3a70fa00a1dd5685b788521687f35b
2020-11-18 16:48:50 -05:00
Evgeny
cb3643da05
SWDEV-254329 : extending debug trace with timestamps, cmake option '-DCMAKE_DEBUG_TRACE=1'
...
Change-Id: Id16c01a6c00f6384c37fa9b5a9709a5e98e1fb57
2020-10-14 00:07:12 -04:00
Evgeny
29c63c5281
SWDEV-213367 : codeobj event implementation
...
Change-Id: Ibcaca6869ce96d8802c5fa8ba241f43834d6f2a7
update - codeobj event implementation
Change-Id: I4c12f26a19f2b31d9ac2211c3426a0e587a332b3
update2 - codeobj event implementation
Change-Id: Ic877549a83542ae00352503471d881e847ebac9c
test - codeobj event implementation
Change-Id: I0618d3a93de94c3d7467372ba4a3d4ea5520bfc7
URI reference test - codeobj event implementation
Change-Id: I6cf7e8a648cf012cb0708058b118a75e58f992b9
adding test/app - codeobj event implementation
Change-Id: Idf4c197c7b9116ccde5ec50ff47a26a858bfab32
uri test fix - codeobj event implementation
Change-Id: I7c385f82f516d9d8f2cd726366f00be3664006e3
uri test cleanup - codeobj event implementation
Change-Id: I542d5baf88c048c8b4717af843b803cd93e8f3bc
URI buffer fix - codeobj event implementation
Change-Id: Iac65e04c03a0939935c10f53c6b580a2e33878f5
HSA events tests trace-check disabled
Change-Id: I0f4d13aeeceb1d1a6e2191673eacbf9c7ae2ae52
2020-10-09 08:36:12 -04:00
Evgeny Shcherbakov
02fcb90a4b
Merge "hip library loader check" into amd-staging
2020-10-07 19:01:55 -04:00
Evgeny
9061c4ea41
hip library loader check
...
Change-Id: I34957db88932e1ed725a0a0d8ca9a66fecc92e38
2020-10-07 17:53:51 -04:00
Evgeny
ef61a39603
SWDEV-249924 : hip correlation id explicite propogation; tracer debug instrumentation;
...
Change-Id: Ibbc411541f5610ce739f3fc1efa1ab7f605220f5
initial commmit
Change-Id: I34b360be62c2083819dc5c3acc8268bd69f2f58a
2020-10-06 13:25:51 -04:00
Evgeny
ed1f1b66ac
build normalizing - generating under build directory
...
Change-Id: Id9203aec7800024bd749059a415fb29b8051005a
2020-09-07 15:24:58 -05:00
Evgeny
156d9327cc
flush-rate option fixed
...
Change-Id: I74ff83ebf2a0a4ba414d30b7cb193522f44660ce
2020-08-20 15:11:38 -05:00
Evgeny
ddcb68d0a8
optimized tool stats
...
Change-Id: Ia9c06879f6e2e195e589c53299c2cafe96a4bfe5
2020-08-20 15:11:21 -05:00
Rachida Kebichi
d3406bdb7b
Merge "Added roctxRangeStart and roctxRangeEnd" into amd-master
2020-08-12 10:32:29 -04:00
Rachida Kebichi
da17a158f8
Added roctxRangeStart and roctxRangeEnd
...
Change-Id: Id7f81c5a7d7f231c8f0e2323d31c37c827687189
Added roctxRangeStart and roctxRangeEnd
Change-Id: Id7f81c5a7d7f231c8f0e2323d31c37c827687189
2020-08-11 17:28:03 -04:00
Evgeny
f027cf1e22
trace buffer initializatino fix
...
Change-Id: Ibb4b3e939d74b776dbdd7ae0c2af02535974abd8
2020-08-06 03:08:33 -05:00
Evgeny
a9048f33a8
roctracer static linking
...
Change-Id: I4df98c6d9991a3a58e2f646fc0c8fe8f104a105d
2020-08-05 02:26:40 -05:00
Evgeny Shcherbakov
de338b02e6
Merge "Added hsa ostream ops generation" into amd-master
2020-07-30 11:24:32 -04:00
Rachida Kebichi
bac4bae41c
Added hsa ostream ops generation
...
Change-Id: Icc68e136d22b05b35d6adaff56e090272633d760
2020-07-29 10:41:32 -04:00
Evgeny
9bb4b0d311
fixed recursive mutex
...
Change-Id: Id63d022b8fd9e900f40b1f991ecb413419d527ad
2020-07-16 05:53:20 -05:00
Rachida Kebichi
64ee8f29ef
support for hip multi kernels
...
Change-Id: Idc8945f924ceb35081e153921181b96ee5f653b6
2020-06-11 15:13:33 -04:00
Evgeny
07479cf881
adding tracer flush/unload stage unloading
...
Change-Id: Id84774b2ce20b261a9a84d2ad802b76093a748d4
2020-06-02 05:10:02 -05:00
Evgeny
511f659a8e
hipLaunchKernel kernel name fix
...
Change-Id: I59c63ec34f77fe39ed1edc8b6395db3871004e40
2020-05-29 13:16:14 -04:00
Evgeny
173c83c6d4
fixing rocm root
...
Change-Id: I79ff754775565d4500254e4566b8c994c237ba34
2020-05-18 22:35:30 -05:00
Evgeny
98dbca9058
hip apr stream porting to hip vdi; hip_api_string off by default
...
Change-Id: I2a9b55b8bdc372743b175797c0d4827fe8931033
2020-05-13 06:06:17 -05:00
Evgeny
807bd250f6
using env variables to set compilers
...
Change-Id: I9af812c4528d0f14c4318436c74a0c63e25d0527
2020-05-08 05:01:19 -04:00
Evgeny
3d4f6b3002
buffer wrap-thread startup fix
...
Change-Id: I857cff63d28dcc068eddbd3ae2bc0193c428ec41
2020-05-07 06:45:29 -05:00
Evgeny Shcherbakov
c73c1bbf29
Merge "Added generation of hip ostream operators" into amd-master
2020-05-05 12:09:29 -04:00
Evgeny
463869d556
optimize HIP API tracing
...
Change-Id: I43df8d8c4d2165d6ad63665b8bd1d86f99c5dffc
2020-05-05 04:08:13 -05:00
Rachida Kebichi
72b0d25ea4
Added generation of hip ostream operators
...
Change-Id: I5d07ea07cdd94097cb44619c29d9deba54e5d6a5
ostream ops code cleanup
Change-Id: Ia4e287de1e1953f5d323a0066c29aa6056442139
2020-05-01 16:15:01 -04:00
Evgeny
5531a38d02
loader verbose prints
...
Change-Id: I99fcdcb0f06b58071a0ff13fbe468c23f7698410
2020-04-22 23:10:05 -05:00
Evgeny
95d05100a7
HIP libraries static definition
...
Change-Id: I7cd45b491f35d5890246f8d4b1ce358f62b4c682
2020-04-20 12:38:02 -05:00
rkebichi
eabcc06785
Update CMakeLists.txt
...
Adding ostream ops for HIP.
2020-03-30 16:59:11 -04:00
Evgeny
5e5fe9917d
normalizing trace comparison mechanism
2020-03-27 00:32:18 -05:00
Evgeny
1be273a1b4
enable tool reloading
2020-03-14 00:13:22 -05:00
Evgeny
3568ca4dbb
compatibility with pre-pcs rocprofiler version
2020-03-11 11:33:27 -05:00
Evgeny
7965a02680
fixing rocprofiler activity enabling
2020-03-09 21:13:44 -05:00
Evgeny
d2243ef1ec
pc sampling integration fix
2020-03-07 19:09:54 -06:00
Evgeny
8b63135ced
PC sampling initial bringup
2020-02-28 14:01:40 -06:00
Evgeny
e9087dcd86
saving time for roctx records
2020-01-29 23:39:08 -06:00
Evgeny
05315465cf
hsa_rsrc_factory sync
2020-01-29 22:39:22 -06:00
Evgeny
89b292ee5c
using CMAKE_CXX_COMPILER intead of gcc
2020-01-28 14:21:39 -06:00