Commit Graph

1586 Commits

Author SHA1 Message Date
sdashmiz f93dfb2a4e SWDEV-366974 - return implicit capture for null stream
- return implicit error if null sream is passed while blocing stream is
  in operation

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4d867a0bddd855e2c0d3eb9b769d5d36412c20c0
2022-11-30 13:45:26 -05:00
Rakesh Roy 4f5d180ca7 SWDEV-368881 - Revert enable hipLaunchCooperativeKernel for hipRTC compiled function
This reverts commit b4d8586a11.

Reason for revert: Doesn't match with CUDA behavior

Change-Id: I413f3d241f864c1e7c21681c5fff8f216ef54306
2022-11-30 03:58:29 -05:00
Anusha GodavarthySurya 16b31b0c54 SWDEV-325711 - Correct formatting
Change-Id: Ie26159e0bb3315cf7c3de1eb682f23ef343df0f2
2022-11-30 05:15:01 +00:00
Anusha GodavarthySurya 596b16da5a SWDEV-325711 - Added graph API hipGraphUpload
Change-Id: I7e4c8c997a5ef940000d599ded9d317d62b8826b
2022-11-30 04:40:17 +00:00
Rakesh Roy cbc3a0a652 SWDEV-348820 - Fix hipPointerAttribute_t incompatibility
- Use hipPointerAttribute_t.type instead of hipPointerAttribute_t.memoryType

Change-Id: I3bf1c0758bdae987213ba7de62247dd420ef4cc9
2022-11-29 00:53:24 -05:00
Rakesh Roy b4d8586a11 SWDEV-368881 - Enable hipLaunchCooperativeKernel for hipRTC compiled function
- Add helper function to validate whether a dynamic function is present or not
- If getStatFunc fails, then check whether the function passed is a valid dynamic function

Change-Id: I4141172f42dce7ff689709560c483e602b5dad4b
2022-11-29 00:35:43 -05:00
Anusha GodavarthySurya 3a9621574c SWDEV-325711 - Added implementation for graph API hipGraphKernelNodeCopyAttributes
Change-Id: I576d0e81c69097fe881556f6d022bb7c7ca3287b
2022-11-29 02:53:14 +00:00
Anusha GodavarthySurya 1ab46fe7ae SWDEV-325711 - Added implementation for graph APIs GetEnabled & SetEnabled
Change-Id: I15a165b3dc548d00b7f5458e1b322b192b8c0d76
2022-11-28 21:50:36 -05:00
German 4471ed1210 SWDEV-1 - Clean-up map file in Linux
Change-Id: Ibfad648c8ec9897a0895057c501d383875e95730
2022-11-28 17:16:23 -05:00
Tao Sang 530ec02aae SWDEV-368280 - Fix crash in graph stream capture
Fix crash in graph stream capture for hipExtModuleLaunchKernel.

Change-Id: Ieaaed1d15b4d268193d8341d4b1609f83a9e4789
2022-11-28 09:33:39 -05:00
Anusha Godavarthy Surya 85296e280a SWDEV-240806 - Fix command release with new commands for every launch
Change-Id: Iecbf11a8f9e9b50f39858f2000a2d5266f0ef364
2022-11-25 09:30:45 +00:00
Anusha Godavarthy Surya 08c4619fab SWDEV-366653 - Added Implemention of DOT file generation for graph
Change-Id: I5ab6a58e49451b5e04f2e93bf594b985ac58cc8d
2022-11-24 11:02:21 -05:00
sdashmiz 5ec93c544e SWDEV-368695 - correct node type
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I23930be7d2f3415c14fc2ec3af4c526cb89d26f7
2022-11-24 10:35:34 -05:00
sdashmiz b665b9a6e8 SWDEV-365587 - reuse the id from capturing stream
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I65f5be3fcc4cffcf3eb5762fd0b43fd051c145c2
2022-11-24 10:35:14 -05:00
Anusha GodavarthySurya 78eef7f173 SWDEV-366653 - Added new graph APIs - Fix windows build
Change-Id: I580133bddcbab5529aecfb70bc9776e8c40de697
2022-11-23 08:57:49 +00:00
Anusha Godavarthy Surya 93ce12c90d SWDEV-325711 - Added Graph APIs hipGraphDebugDotPrint, hipGraphKernelNodeCopyAttributes
hipGraphNodeGetEnabled, hipGraphNodeSetEnabled and hipGraphUpload

Change-Id: Ib5a58fbc0a9b3f134eb56d42cd945f3d7f4922d8
2022-11-22 23:20:25 -05:00
Maneesh Gupta fab70a41ed Revert "SWDEV-330775 - Update search path for LLVM"
This reverts commit 3d15f9cbda.

Reason for revert: SWDEV-368704

Change-Id: I8c38b4f40285f90f7d99145b970c2a14d051d5bb
2022-11-22 09:14:24 -05:00
sdashmiz c5e7b56463 SWDEV-366974 - add proper error
- Null stream correct error when blocing stream is being captured

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0d902a4f4ef02736a6db60ba7bffa7c20011bc84
2022-11-21 10:39:21 -05:00
Maneesh Gupta 1c45f257b9 Revert "SWDEV-363069 - Disable sync force for MT"
This reverts commit 52ff4368e5.

Reason for revert: SWDEV-365075, SWDEV-367163, SWDEV-367164, SWDEV-367173

Change-Id: Id2924c60e46e9879038ded358f777c71cd95b2c1
2022-11-17 01:04:44 -05:00
German 2cde04bf9b SWDEV-367745 - Report hipDeviceAttributeUnifiedAddressing
Change-Id: I4d1d598f64f613430fecdc0d6b4cfa9845e04687
2022-11-15 15:53:02 -05:00
pghafari 06edbb8177 SWDEV-356560 - updating error msg to match cuda
Change-Id: I1c387cf04d041257b4d168b4cf4d8949153fd69f
2022-11-15 13:19:33 -05:00
Rakesh Roy 2b426a632f SWDEV-362366 - Add validation for hipInit flags
- Return hipErrorInvalidValue when flags != 0

Change-Id: Ib2a7ea2acf083fa859d6c3bd91a12b39e877b4fd
2022-11-14 23:52:32 -05:00
Siu Chi Chan 3d15f9cbda SWDEV-330775 - Update search path for LLVM
ROCm's LLVM will be moved into /opt/rocm-<ver>/lib/, teach hipcc and
hipconfig about the new location.

Change-Id: Ie7f17146771aff94c684deb22148226cbb3a2895
2022-11-14 13:31:07 -05:00
Julia Jiang c9ce9b3300 SWDEV-352687 - fix AlignedAllocMem in hmm
Change-Id: Icec74ac732a0a6ac2a2600f504aa1ec73717c0ca
2022-11-14 13:10:02 -05:00
Maneesh Gupta 8f4e94d532 SWDEV-342014 - Handle partial fills in hipDeviceGetName
Change-Id: Ic9f1743c6a8439d88acc6dd1ed496013d551f6ec
2022-11-11 14:52:48 -05:00
kjayapra-amd cc9427e969 SWDEV-356947 - Create a new thread if current thread is nullptr.
Change-Id: Iebd69f22284041ed450d583471d24cb82fb0e47a
2022-11-10 22:12:02 -05:00
Satyanvesh Dittakavi 1155dbda1e SWDEV-364545 - Fix hiprtc cmake target on Windows
Change-Id: I360d0d1ee7f6a0c65a4d6cd07620bfa2a503c19f
2022-11-10 01:23:42 -05:00
Satyanvesh Dittakavi 30d6497953 SWDEV-363369 - Elapsed time needs only stop event timings if both start and stop events are recorded
Change-Id: I91c9ce79aacf1014ae77600d1250cfccd9dd6039
2022-11-09 00:31:06 -05:00
sdashmiz 9c83b3e0b2 SWDEV-361592 - allow nullptr for userdata in hiphostfunc
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I91728d363846ac6417d4a59920509ffacd4c9a58
2022-11-04 13:37:17 -04:00
sdashmiz 33f02abc41 SWDEV-356569 - check for mempool device
- mem pool should be from same device

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id06a7f070c019548462c235bff3c0cd972e6eb8a
2022-11-04 09:36:22 -04:00
Jaydeep Patel e7a34f9efe SWDEV-365048 - extra marker is required for HW event check, which is done before the callback is finished.
Change-Id: Ib46bfc4e060a60fb14aa782688d35b34534cca65
2022-11-04 00:34:14 -04:00
German Andryeyev 55d085ca8c SWDEV-364457 - Don't attempt adding duplicates into the memory map
KMD can enable hipHostRegister optimization  with HMM path.
That will make CPU and GPU pointers matching.

Change-Id: Iad96ceada5cfa3bada20452b906f744f9dbaebbe
2022-11-03 10:04:12 -04:00
Jaydeep Patel 4e2f7192e3 SWDEV-362367 - pciBusId should be large enough to store 13 characters including the NULL-terminator.
Change-Id: Ie58be0495065713bae7e13923ac04a4643e246be
2022-11-03 00:04:27 -04:00
Tao Sang 0c4307f86e SWDEV-363038 - Fix hipGraphKernelNodeSetParams
Fix crash in hipGraphKernelNodeSetParams where paremeters
are taken from hipGraphKernelNodeGetParams.

Change-Id: I2216f72f4d4de6dd3766343b0d821cb3d35d7853
2022-11-01 15:02:39 -04:00
Julia Jiang 3415f0a56e SWDEV-342013,SWDEV-342014 - Update validation on hipDeviceGet and hipDeviceGetName
Change-Id: I719da6169ce9f505449e07775cb94a5718f79ca3
2022-10-31 11:44:40 -04:00
agunashe 47ae1f1fff SWDEV-337331 - Windows graph fix
Unit_hipGraphNodeGetDependentNodes_Functional
Unit_hipGraphNodeGetDependencies_Functional
Unit_hipGraphAddEventRecordNode_Functional_WithoutFlags
Unit_hipGraphMemcpyNodeSetParams_Functional
Unit_hipGraphExecChildGraphNodeSetParams_ChildTopology

Change-Id: I762776d33f27197bcc012951a1828d3d1d2b3e2e
2022-10-28 14:46:04 -04:00
sdashmiz 84fa61a39b SWDEV-363850 - fix a bug in mutual exclusive flags
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If7687b5bf7ec7ff1978991cbf7dafa0612912274
2022-10-27 11:23:35 -04:00
pghafari 895473e8d8 SWDEV-362280 - retur NotSupoorted for hip-vulkan
hip-vulkan semaphore on rocm is not supported

Change-Id: I6e01c4f5b192cfb17546a29a1cb17f320c4b1adc
2022-10-24 13:36:18 -04:00
German 52ff4368e5 SWDEV-363069 - Disable sync force for MT
hipMemcpyAsync doesn't require any forced sync even for sysmem

Change-Id: I83951f6118e84d79c74d5671df62678c5db085a8
2022-10-24 10:59:07 -04:00
German 413cc757af SWDEV-363602 - Notify cmd queue about callback wait
Remove extra barrier, since ROCR backend in DD mode blocks HW queue now when a callback is injected
Add a notificaiton for MT mode about possible waiter for a callback

Change-Id: Ifd70ce5597e1ba868e4197ad1850ace11a4f90ae
2022-10-24 10:56:20 -04:00
sdashmiz 4fc9df2a1a SWDEV-357917 - correct userobj for negative test cases
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6a2a74c763d2b938430ca53a14360f459af04665
2022-10-24 10:27:02 -04:00
German 8d2885f331 SWDEV-345024 - Restore break
Commit 60656d9fc9 accidently removed break for mempool property

Change-Id: Ica3cbec796ca6b2366583d3302d3226c73224177
2022-10-21 18:04:20 -04:00
Laurent Morichetti 19107858d6 SWDEV-361847 - Print 'char' parameters as 'integer'
When printing HIP API function parameters, use the integer format to
print 'char' arguments to avoid printing invalid ASCII characters
(value > 127).

Make sure the roctracer::hip_support::detail operator<< overloads are
used when printing arguments.

Change-Id: Id072c2ed19b1b4166108599e393d1cae6c54b6b0
2022-10-21 14:55:33 -04:00
Satyanvesh Dittakavi bded3d8d1f SWDEV-362371 - Uninitialized stream error checks
Change-Id: I7e04ef46f0cf2b0c45caf42d5b2ee31cb68e93eb
2022-10-20 21:57:11 -04:00
pghafari d7b27989b4 SWDEV-356557, SWDEV-356558 - matching cuda return
Change-Id: I3b7d50e07bd437bd23a495439d66940ff30f7f07
2022-10-19 09:17:28 -04:00
kjayapra-amd 1b902e1809 SWDEV-355727 - Change in AMDGCN format in bitcode.
Change-Id: Ic32a3e7b866b35a321d8ececc2f6c63f9b23121d
2022-10-13 14:19:03 -04:00
Saleel Kudchadker da88091ba4 SWDEV-359548 - Enqueue marker if fence is dirty
The marker would flush any caches.

Change-Id: I5f990285fb3c3a3e8d5d0b2a2d5a9f1fdcea435c
2022-10-13 07:53:01 -04:00
Anusha GodavarthySurya 039e26ee0f SWDEV-357759, SWDEV-360041, SWDEV-361145 Fix Stream end capture on forked streams
Change-Id: If0dc6242d2d3ca680e37e14a5dea5cf68dc295df
2022-10-12 13:00:05 -04:00
Tao Sang 56e7c8b3a0 SWDEV-318349 - Remove sync for null stream
Remove sync for null stream in  hipGraphExec::Run()

Change-Id: Ieaaed1c15b4d258193d8341d4b17d9f03a9e4783
2022-10-12 09:46:18 -04:00
pghafari 88c399a43d SWDEV-356570, SWDEV-356571, SWDEV-356572, SWDEV-356575 -
updating with current status of hipNotSupported and null checks

Change-Id: I3b1ce3d3e5ce9b69d1f5dacda35f5aa586714f5c
2022-10-11 23:45:27 -04:00