Commit Graph

64562 Commits

Author SHA1 Message Date
Jason Tang 01f01adedf SWDEV-500435 - Use raw strings for regular expression.
Starting from Python version 3.12, a backslash-character pair that
is not a valid escape sequence generates a SyntaxWarning, instead
of DeprecationWarning. Using raw strings fixes the warnings.

Change-Id: I6a9f35e2e2e5d9d09410dfb5964fdc19cf0bfa4a
2024-12-04 16:48:42 -05:00
Jason Tang 2c8312626e SWDEV-500435 - Use raw strings for regular expression.
Starting from Python version 3.12, a backslash-character pair that
is not a valid escape sequence generates a SyntaxWarning, instead
of DeprecationWarning. Using raw strings fixes the warnings.

Change-Id: I6a9f35e2e2e5d9d09410dfb5964fdc19cf0bfa4a


[ROCm/rocprofiler commit: 01f01adedf]
2024-12-04 16:48:42 -05:00
David Yat Sin 0544c2336b rocr: Avoid polling for SDMA signals
When all 64-bits of the signal value are 0, we can skip polling for that
signal.
We need to keep signals as 64-bit numbers as part of the spec. But most
users of ROCr do will never set the signal value to more than 32-bits.
When the dependent-signals are less than 32-bits, avoid adding extra
SDMA poll packet as this adds latency to the SDMA copies.

Change-Id: I37dca65fe3f060dc7164f49b98cb1985023663c4
2024-12-04 16:45:04 -05:00
David Yat Sin b7208786a2 rocr: Avoid polling for SDMA signals
When all 64-bits of the signal value are 0, we can skip polling for that
signal.
We need to keep signals as 64-bit numbers as part of the spec. But most
users of ROCr do will never set the signal value to more than 32-bits.
When the dependent-signals are less than 32-bits, avoid adding extra
SDMA poll packet as this adds latency to the SDMA copies.

Change-Id: I37dca65fe3f060dc7164f49b98cb1985023663c4


[ROCm/ROCR-Runtime commit: 0544c2336b]
2024-12-04 16:45:04 -05:00
Elwazir, Ammar 5ec8560fab CI: PC Sampling to be included in code coverage (#45)
* CI: PC Sampling to be included in code coverage

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

[ROCm/rocprofiler-sdk commit: eedee0fb96]
2024-12-04 14:33:09 -06:00
Elwazir, Ammar eedee0fb96 CI: PC Sampling to be included in code coverage (#45)
* CI: PC Sampling to be included in code coverage

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml
2024-12-04 14:33:09 -06:00
David Galiffi 741dd3ea2e Add test for ompt-target
[ROCm/rocprofiler-systems commit: 8f0282bb69]
2024-12-04 15:21:51 -05:00
David Galiffi 8f0282bb69 Add test for ompt-target 2024-12-04 15:21:51 -05:00
Saleel Kudchadker 7d7aa8b69c SWDEV-497145 - Use rocr copyOnEngine API for staged copies
- Refactor blit code and clean ASAN instrumentation
- Use unified function for rocr copy
- Enable shader copy path for unpinned writeBuffer/readBuffer paths
- Set GPU_FORCE_BLIT_COPY_SIZE=16 which means we will use BLIT copy for
  pinned copies or unpinned H2D/D2H copies < 16KB

Change-Id: I42045cca79234b340dbf53dafb93044199736ae4


[ROCm/clr commit: 7863eb92dc]
2024-12-04 13:38:13 -05:00
Saleel Kudchadker 7863eb92dc SWDEV-497145 - Use rocr copyOnEngine API for staged copies
- Refactor blit code and clean ASAN instrumentation
- Use unified function for rocr copy
- Enable shader copy path for unpinned writeBuffer/readBuffer paths
- Set GPU_FORCE_BLIT_COPY_SIZE=16 which means we will use BLIT copy for
  pinned copies or unpinned H2D/D2H copies < 16KB

Change-Id: I42045cca79234b340dbf53dafb93044199736ae4
2024-12-04 13:38:13 -05:00
Baraldi, Giovanni 145d94495a Fix use-after-free for ATT code objects (#35)
* Fix use-after-free for ATT code objects

* Formatting

* Temporary fix for last kernel

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: 21c577ba60]
2024-12-04 10:22:57 -08:00
Baraldi, Giovanni 21c577ba60 Fix use-after-free for ATT code objects (#35)
* Fix use-after-free for ATT code objects

* Formatting

* Temporary fix for last kernel

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2024-12-04 10:22:57 -08:00
German Andryeyev 6933aa7c29 SWDEV-501403 - Switch to std::shared_mutex for streamSetLock
Shared mutex allows to have access to the list of streams  from
multiple threads at the same time.

Change-Id: Ibee64b846cde03321d5b17dbee2829c0bab7e7d6


[ROCm/clr commit: efd3ea4b30]
2024-12-04 12:06:51 -05:00
German Andryeyev efd3ea4b30 SWDEV-501403 - Switch to std::shared_mutex for streamSetLock
Shared mutex allows to have access to the list of streams  from
multiple threads at the same time.

Change-Id: Ibee64b846cde03321d5b17dbee2829c0bab7e7d6
2024-12-04 12:06:51 -05:00
Marko Arandjelovic af278efe7d SWDEV-478998 - Add unit test for hipFreeHost
Change-Id: I85235243e0014ec6bd2b6a544222fdee8f0a7c68


[ROCm/hip-tests commit: 8736cabea3]
2024-12-04 11:56:44 -05:00
Marko Arandjelovic 8736cabea3 SWDEV-478998 - Add unit test for hipFreeHost
Change-Id: I85235243e0014ec6bd2b6a544222fdee8f0a7c68
2024-12-04 11:56:44 -05:00
Indic, Vladimir 1055ba96b4 Exclude PC sampling tests from non-MI2xx runners (#44)
[ROCm/rocprofiler-sdk commit: 85ad519ca7]
2024-12-04 10:55:22 -06:00
Indic, Vladimir 85ad519ca7 Exclude PC sampling tests from non-MI2xx runners (#44) 2024-12-04 10:55:22 -06:00
Jatin Chaudhary 5bc1cfa2d9 SWDEV-485945 - use union to convert values
this shows up in some compilers as warnings.

Change-Id: I862cd6baf2edb8161757adc54abb787530489481


[ROCm/clr commit: 063f7ef32a]
2024-12-04 11:15:03 -05:00
Jatin Chaudhary 063f7ef32a SWDEV-485945 - use union to convert values
this shows up in some compilers as warnings.

Change-Id: I862cd6baf2edb8161757adc54abb787530489481
2024-12-04 11:15:03 -05:00
Elwazir, Ammar d857134a70 Disable faulty tests in CI (#43)
* Disable faulty tests

* Update continuous_integration.yml

[ROCm/rocprofiler-sdk commit: 97f24c62eb]
2024-12-04 10:01:59 -06:00
Elwazir, Ammar 97f24c62eb Disable faulty tests in CI (#43)
* Disable faulty tests

* Update continuous_integration.yml
2024-12-04 10:01:59 -06:00
Jaydeep Patel 1540f7db7f SWDEV-487988 - Destroy event and free memory.
Change-Id: I95ceaac5b343132c0660de0dabba548fb6a29034


[ROCm/hip-tests commit: 80144befea]
2024-12-04 10:07:59 -05:00
Jaydeep Patel 80144befea SWDEV-487988 - Destroy event and free memory.
Change-Id: I95ceaac5b343132c0660de0dabba548fb6a29034
2024-12-04 10:07:59 -05:00
Jaydeep Patel bb285f0d43 SWDEV-488033 - Add dependency between memcpy node for child graph.
Since 29cc678d8d H2D can't be synced always so it's good to have dependency set.

Change-Id: I7d757a9b6afd3cf7064dc3b7014677cdf754125a


[ROCm/hip-tests commit: 8515ac9b2f]
2024-12-04 10:06:52 -05:00
Jaydeep Patel 8515ac9b2f SWDEV-488033 - Add dependency between memcpy node for child graph.
Since 29cc678d8d H2D can't be synced always so it's good to have dependency set.

Change-Id: I7d757a9b6afd3cf7064dc3b7014677cdf754125a
2024-12-04 10:06:52 -05:00
Jaydeep Patel 6fd086821b SWDEV-487997 - Kernel launch can return invalid config/value in case of thread/block is 0 & -ve.
Change-Id: I91fbe2361894f16c65236c9736bd677a6d5f1f61


[ROCm/hip-tests commit: 064d0398d8]
2024-12-04 10:06:36 -05:00
Jaydeep Patel 064d0398d8 SWDEV-487997 - Kernel launch can return invalid config/value in case of thread/block is 0 & -ve.
Change-Id: I91fbe2361894f16c65236c9736bd677a6d5f1f61
2024-12-04 10:06:36 -05:00
Jaydeep Patel 72534cd356 SWDEV-487992 - Free memory.
Change-Id: Ic4c7448d7e537953bcebc73210647f52de53b0ee


[ROCm/hip-tests commit: 0422d78c1b]
2024-12-04 09:07:29 -05:00
Jaydeep Patel 0422d78c1b SWDEV-487992 - Free memory.
Change-Id: Ic4c7448d7e537953bcebc73210647f52de53b0ee
2024-12-04 09:07:29 -05:00
Jimbo Xie 91a8ee1a96 SWDEV-485672 - LOG_INFO corrected to LOG_ERROR for errors
Change-Id: I8ab5f2117dfd7725bd4ed8b178e370096aa31018


[ROCm/clr commit: 6c755a4116]
2024-12-04 01:18:01 -05:00
Jimbo Xie 6c755a4116 SWDEV-485672 - LOG_INFO corrected to LOG_ERROR for errors
Change-Id: I8ab5f2117dfd7725bd4ed8b178e370096aa31018
2024-12-04 01:18:01 -05:00
Anusha GodavarthySurya b383c1e443 SWDEV-469422 - Always schedule graph nodes
Change-Id: Icc636527fa19e7bf3eb111bc4b1bb9a5f9acff73


[ROCm/clr commit: b89977d518]
2024-12-03 23:44:23 -05:00
Anusha GodavarthySurya b89977d518 SWDEV-469422 - Always schedule graph nodes
Change-Id: Icc636527fa19e7bf3eb111bc4b1bb9a5f9acff73
2024-12-03 23:44:23 -05:00
Chris Freehill f32e264933 rocr: Add gfx9-4-generic support
Change-Id: I4ebfbf0dcffa5b784d7fbfda7398d44dcc47aaef
2024-12-03 19:33:57 -05:00
Chris Freehill 2a492e6f04 rocr: Add gfx9-4-generic support
Change-Id: I4ebfbf0dcffa5b784d7fbfda7398d44dcc47aaef


[ROCm/ROCR-Runtime commit: f32e264933]
2024-12-03 19:33:57 -05:00
Choudhary, Rahul 41a8bc4cc1 Update PSDB.yml - adding synchronize and removing edited type for action trigger
[ROCm/rocprofiler-sdk commit: d3aa966faa]
2024-12-03 14:25:08 -08:00
Choudhary, Rahul d3aa966faa Update PSDB.yml - adding synchronize and removing edited type for action trigger 2024-12-03 14:25:08 -08:00
Mallya, Ameya Keshava 52c3ba9e83 Update KWS to point to correct location of reusable action (#41)
[ROCm/rocprofiler-sdk commit: 78cd4c9526]
2024-12-03 12:23:37 -08:00
Mallya, Ameya Keshava 78cd4c9526 Update KWS to point to correct location of reusable action (#41) 2024-12-03 12:23:37 -08:00
Baraldi, Giovanni ba5500c356 Fix for tests. Fix for merge conflict in buffered_output. (#34)
* Fix for tests. Fix for merge conflict in buffered_output.

* Formatting

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: 4a80ecbfb8]
2024-12-03 14:00:36 -06:00
Baraldi, Giovanni 4a80ecbfb8 Fix for tests. Fix for merge conflict in buffered_output. (#34)
* Fix for tests. Fix for merge conflict in buffered_output.

* Formatting

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2024-12-03 14:00:36 -06:00
Vladana Stojiljkovic 0c255ac97f SWDEV-453145 - Enable _sync tests on nvidia
* _sync tests that use warp match functions (__match_any_sync and __match_all_sync) were disabled for nvidia because those functions are supported only on devices with compute capability 7.x or higher. In this solution, tests are always build (with specifying appropriate compile flag) and in in the runtime it is decided weather they should be skipped or not.

Change-Id: Ifa9e55f3b47aa3a00027cb986cd6ae46aed45ebd


[ROCm/hip-tests commit: 9893726343]
2024-12-03 13:49:16 -05:00
Vladana Stojiljkovic 9893726343 SWDEV-453145 - Enable _sync tests on nvidia
* _sync tests that use warp match functions (__match_any_sync and __match_all_sync) were disabled for nvidia because those functions are supported only on devices with compute capability 7.x or higher. In this solution, tests are always build (with specifying appropriate compile flag) and in in the runtime it is decided weather they should be skipped or not.

Change-Id: Ifa9e55f3b47aa3a00027cb986cd6ae46aed45ebd
2024-12-03 13:49:16 -05:00
Saleel Kudchadker 957b460014 SWDEV-494149 - Improve hipGet/Set Device
Change-Id: If8975687a3ba9caadafc48a0066f19a4ebaab9e2


[ROCm/clr commit: 6611cc015d]
2024-12-03 13:36:38 -05:00
Saleel Kudchadker 6611cc015d SWDEV-494149 - Improve hipGet/Set Device
Change-Id: If8975687a3ba9caadafc48a0066f19a4ebaab9e2
2024-12-03 13:36:38 -05:00
Satyanvesh Dittakavi dcdfa4c367 SWDEV-499291 - Fix test failures due to nodiscard attibute
Change-Id: I7bd86f6506415a12940ed441556a35753fc0faa4


[ROCm/hip-tests commit: 455ec9d367]
2024-12-03 12:33:12 -05:00
Satyanvesh Dittakavi 455ec9d367 SWDEV-499291 - Fix test failures due to nodiscard attibute
Change-Id: I7bd86f6506415a12940ed441556a35753fc0faa4
2024-12-03 12:33:12 -05:00
gobhardw fe55de6bef Disabling kernel names matching test
Change-Id: I70d74c421599a38207943a59c424ae7681b9fdcb
2024-12-03 15:59:24 +05:30
gobhardw 1eae69c812 Disabling kernel names matching test
Change-Id: I70d74c421599a38207943a59c424ae7681b9fdcb


[ROCm/rocprofiler commit: fe55de6bef]
2024-12-03 15:59:24 +05:30