22b596dc32
implement rocprofv2 workaround for dispatch ids ( #336 )
...
* implement rocprofv2 workaround for dispatch ids
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* formatting
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: a1017b68e9
2024-04-01 14:30:21 -05:00
22e5069fc5
Adding documentation for global command line options
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 1a3bdad90a
2024-04-01 14:30:21 -05:00
5d15f4d6fa
Restore OMNIPERF_COLOR global to disable default log coloring
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 6cc8f0154f
2024-04-01 14:30:21 -05:00
091e796643
Extending log coloring to message text. Enable by default.
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b1d0b3905c
2024-04-01 14:30:21 -05:00
dc13c30d74
Remove superfluous logging statement
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 78c48eaed5
2024-04-01 14:30:21 -05:00
e170da2c39
Throw more helpful warning on missing csv in analyze mode ( #313 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f47b8d2547
2024-04-01 14:30:21 -05:00
e1470d7a38
Register TRACE loglevel ahead of parse_args to avoid error in --specs printout
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 706afa7f37
2024-04-01 14:30:21 -05:00
fa02efc962
Revert #333 deterministic ordering ( #337 )
...
* Revert "formatting"
This reverts commit e387561791898467371b6219921f10447d3486b3.
* Revert "Implement deterministic ordering of perfmon"
This reverts commit 2a24600a37c8002838145962a957cea447555b0c.
[ROCm/rocprofiler-compute commit: f7394bf272
2024-04-01 14:30:21 -05:00
ed86d5c64c
formatting
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: f6f6165379
2024-04-01 14:30:21 -05:00
3ff4117c4e
Implement deterministic ordering of perfmon
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 97af96e435
2024-04-01 14:30:21 -05:00
e55b9b1d34
Adding redirect to help button in standalone GUI
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3928f36d5e
2024-04-01 14:30:21 -05:00
fad337db06
Removing unused modules
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 33e763178e
2024-04-01 14:30:21 -05:00
8a9123d722
Documentation enhancements and removing watermark
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3d8b748924
2024-04-01 14:30:21 -05:00
4a1293b5d7
Adding comments to roofline and changing output file name for specificity
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 73ac6c9561
2024-04-01 14:30:21 -05:00
da0986846e
Implementing docs feedback with typos and minor enhancements
...
Co-authored-by: Jose Santos <josantos@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: cf36fb7fbf
2024-04-01 14:30:21 -05:00
033c4e8fc5
Correct typo in Mi100 metric defs for missing SQ_INSTS_VMEM
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 6cfdca93b9
2024-04-01 14:30:21 -05:00
2c8f4de5e4
Responding to first round of Ben R.'s docs feedback.\n\nThis round includes fixes for comments up to the 'Performance Model' section. I will need to work with our documentation group to respond to those higher level comments.
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 20670da2b7
2024-04-01 14:30:21 -05:00
58d876a2c2
Add timestamp override to rocprofv2 and format Python
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: dfdd8dd21d
2024-04-01 14:30:21 -05:00
a83ea5d582
Create general_options() func to reduce code in parser
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 482fd6f2ca
2024-04-01 14:30:21 -05:00
c693890216
Fix for #300 ( #331 )
...
On some versions of numpy/pandas, applying a str map to an empty series doesn't change the type.
As a result, when adding a float to a string, sometimes numpy dies with a uadd error.
We fix this by explicitly casting to a str first
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: d72ef52208
2024-04-01 14:30:21 -05:00
e64e8b5604
Updated links in documentation. ( #329 )
...
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
[ROCm/rocprofiler-compute commit: ddb5c0ccc9
2024-04-01 14:30:21 -05:00
376a86d2d0
Updated links in documentation. ( #328 )
...
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
[ROCm/rocprofiler-compute commit: f5712875aa
2024-03-21 10:14:37 -05:00
8943f686f5
Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg'
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 62221383a7
2024-03-18 14:28:14 -05:00
fbb88baa20
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 4fc30eb5c4
2024-03-15 16:40:13 -05:00
70fa822698
update doc watermark for release candidate
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 03ddba538d
2024-03-15 16:31:42 -05:00
19a9e0431c
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f4070e3654
2024-03-15 14:04:49 -05:00
104bf46b4b
Update docs for MI300 support
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b436415784
2024-03-15 12:48:00 -05:00
fa0cc81720
Update roofline distro_map for Ubuntu22.04 ( #319 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2dcad38028
2024-03-15 12:47:30 -05:00
a8dcdec00f
tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the
...
loglevel name in output, but without color
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69de978d35
2024-03-15 09:31:22 -05:00
ba4bccbe0f
tighten up [analyze] help to be consistent with [profile] help
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 357d225716
2024-03-15 09:31:22 -05:00
3a77ecadd3
bug fix for df tracing output - add more function demarcation
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: c29f28e25e
2024-03-15 09:31:22 -05:00
624606771f
enable more function demarcation for analyze tracing
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 76121f20a9
2024-03-15 09:31:22 -05:00
3dbe61f462
logger update: assign color for TRACE level
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 3438bc9d0f
2024-03-14 17:37:30 -05:00
8d6a8e3b06
update logging formatter handling for consistent behavior with error messsages
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69af2ffc83
2024-03-14 17:37:30 -05:00
c5408fb22b
fixup MI300 MFMA rate disagreement between SOL and pipeline ( #315 )
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: b610e1c27b
2024-03-14 10:41:35 -05:00
0b4ee818ba
Update doc samples for new logging output
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: bfef420099
2024-03-12 20:17:46 -05:00
b2c4c8a8cc
Found a bug in kernel filtering and fixed
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2acc8e98c1
2024-03-12 18:21:35 -05:00
63d52b2e4c
Python format
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: cac4b1aff5
2024-03-12 16:47:18 -05:00
1a27707a4d
Throw error if user analyzes two of same path ( #260 , #67 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: fa7c82de75
2024-03-12 16:46:36 -05:00
ff7751724b
Fix missing argv in console_warning()
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e7cc326d5a
2024-03-12 16:44:02 -05:00
bd4bc51cd4
change stubbed values to hbm bw ( #302 )
...
* change stubbed values to hbm bw
Signed-off-by: Jose Santos <josantos@amd.com >
* Reformat
Signed-off-by: Jose Santos <josantos@amd.com >
* Update analysis_webui.py
remove print statements
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: efb8f131ec
2024-03-12 16:08:30 -05:00
513ba356ae
Kernel no overwrite ( #303 )
...
* Removing kernel name shortener from profile
- Kernel name shortener now in analyze
- db import uses pymongo to import
Signed-off-by: Jose Santos <josantos@amd.com >
* collections now added using pymongo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* kernel_name_shortener shortens dataframes and not a workload
- argparser: --kernel-verbose to connection group
- analysis_cli, profiler_rocprof_v2: remove kernel_name_shortener, so that it doesnt overwrite workload
- db_import: demangle kernel_name dfs
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix db name in pymongo command
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* reformat
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix typo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* remove checker for verbose in profiler_base
Signed-off-by: Jose Santos <josantos@amd.com >
* kernel_name_shortener now called in create_df_kerenel_top_stats and
create_df_pmc
Signed-off-by: Jose Santos <josantos@amd.com >
* add kernel_verbose to analysis_webui, remove stubbed values
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* Update src/utils/kernel_name_shortener.py
keep console_debug
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/utils/kernel_name_shortener.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4424f320ad
2024-03-12 15:54:52 -05:00
4fb2f6e2b4
Update DB module for new sysinfo keys
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 706d3bb9f0
2024-03-12 12:24:49 -05:00
69d3de2549
apply formatting
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 458087b425
2024-03-12 09:09:46 -05:00
c9b6cb8f40
Throw error when we cannot read gfx942 details ( #310 )
...
* Throw error when we cannot read gfx942 details
Signed-off-by: colramos-amd <colramos@amd.com >
* Fixing my stupid typo
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 267f0842ec
2024-03-11 15:26:26 -05:00
28f027c7bf
move set_locale_encoding() to occur after logging is setup - allows
...
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083 )
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: e85037fdfb
2024-03-11 14:19:01 -05:00
6b0a36cb27
Update src/utils/utils.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 5e21dc35fd
2024-03-11 14:19:01 -05:00
d4015bd76b
Update src/utils/db_connector.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: ebc9108da0
2024-03-11 14:19:01 -05:00
f7fa0b6038
Update src/omniperf_profile/profiler_rocscope.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: e8ca48dc83
2024-03-11 14:19:01 -05:00
65c1e2cb9c
Update src/omniperf_profile/profiler_base.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 8856480808
2024-03-11 14:19:01 -05:00
Nick Curtis
coleramos425
Nicholas Curtis
David Galiffi
Karl W Schulz
JoseSantosAMD
Karl W. Schulz