Commit Graph

362 Commits

Author SHA1 Message Date
Ioannis Assiouras 2633e62801 SWDEV-381402 - Derive hip::Stream from amd::HostQueue
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8


[ROCm/clr commit: e3633dc8f4]
2023-02-21 18:12:03 -05:00
Rakesh Roy 9c51780b13 SWDEV-338733 - Implement hipArrayGet* APIs
- Add implementation for hipArrayGetInfo, hipArrayGetDescriptor &
  hipArray3DGetDescriptor APIs

Change-Id: I181a472066006bc3bd0d987408ea67e218310983


[ROCm/clr commit: 287d07ccd4]
2023-02-16 23:04:29 -05:00
Ioannis Assiouras 5007a5f15d SWDEV-381402 - convert host_device to host_context of type amd::Context*
Change-Id: Ic1cb9a3fa64e16699fad7e9ec6679f1d34b14bef


[ROCm/clr commit: 8b87ccb8cc]
2023-02-16 17:49:12 -05:00
kjayapra-amd 9c479ada12 SWDEV-376697 - Pass uncached memory flag when hipDeviceMallocUncached memory is requested.
Change-Id: Idc12948047fdb69876e31edf34a8bcda46c9c303


[ROCm/clr commit: 193c5e387e]
2023-02-16 14:05:54 -05:00
Jaydeep Patel 4b3f70a6b4 SWDEV-380405 - Make hipMemcpyPeer async w.r.t. host and let dst device wait till copy finishes by src device.
Change-Id: Idbe25404d0c31b93436e190b548f12f327f47a04


[ROCm/clr commit: 5f231c55e3]
2023-02-07 00:34:45 -05:00
pghafari 5fa035dbd4 SWDEV-369551 - invalid stream check in hipMemcpy
Change-Id: I6762af93cd566a38f7d04994b87a76e744b19043


[ROCm/clr commit: 76b0b4d635]
2023-01-18 20:02:28 -05:00
pghafari 5959057299 SWDEV-374361, SWDEV-374362, SWDEV-374364, SWDEV-374365 - error checking
Change-Id: I0b729976ed794239fa54e1ad2965133b319d2f5d


[ROCm/clr commit: a9cbff0a49]
2023-01-17 23:10:22 -05:00
German Andryeyev 36d240ff89 SWDEV-355281 - Use offset from FindMemObj
Change-Id: I53ce2c1ef2e3a580b8b12312b693c2476f0885d2


[ROCm/clr commit: 39db0ec297]
2023-01-17 10:01:49 -05:00
Jaydeep Patel d74f646173 SWDEV-374360 - Handle free for external memory.
Change-Id: Ibfaf30eef371499a3c1f931a73cce76c83d8f7f3


[ROCm/clr commit: 7eecbdd9db]
2023-01-16 13:07:01 -05:00
Jaydeep Patel ffcff763d2 SWDEV-375366 - SWDEV-375351 - Handle HtoH case for graph mem cpy impl.
Change-Id: I5a8c3c3c22db045f714b0443b8d70a8c6b4a8cea


[ROCm/clr commit: fdecc1b351]
2023-01-16 11:37:57 -05:00
German Andryeyev 9c811dc241 SWDEV-353281 - Initial support of memalloc in graph
Add memory allocation support in graph. Current implementation uses
cache from mempool  to hold the allocations which belong to the graph.
Also the resource tracking is disabled at this moment because mempool
operates with hip::Stream objects, but graph has execution with
amd::HostQueue objects.

Change-Id: I54fe3250126d24f5a26ada975f37d429bb4ef17b


[ROCm/clr commit: eef47ca24a]
2023-01-13 13:06:59 -05:00
Ajay 433f99686b SWDEV-369556 - Unit_hipMemGetAddressRange_Negative cases
- return value for invalid device ptr
- offset greater than size

Change-Id: I8bcf878c3c1c0a29836ea664bfb9048e1114b74e


[ROCm/clr commit: c6a7ce66bb]
2023-01-10 06:57:54 -05:00
kjayapra-amd 5057429e7a SWDEV-361374 - Adding support for hipPointerSetAttributes
Change-Id: I56710b808854acefca07b3b5898deebee38063e9


[ROCm/clr commit: 0c8c08cf51]
2023-01-09 12:36:57 -05:00
Jaydeep Patel f6a5cd9e33 SWDEV-374373 - Occupied size should be within range.
Change-Id: I20e24c628c51154c2f8f36dca0a6fa4ead1ee6d0


[ROCm/clr commit: 67792dd858]
2023-01-05 08:02:20 -05:00
Satyanvesh Dittakavi 47167d7e7a SWDEV-374371 - hipGraphAddMemsetNode should return error if width is 0
Change-Id: I1cd4be271f65c9cade8dddb6d00191e1b74c96bc


[ROCm/clr commit: 409f23d905]
2023-01-03 10:29:16 -05:00
Jaydeep Patel 2d25a60c1a SWDEV-374370 - Propogate element size to blit kernel.
Change-Id: I8a3355c62947265be34e6a2befd26f86b3dc6cd2


[ROCm/clr commit: f2b0542442]
2023-01-01 23:54:09 -05:00
Rakesh Roy 981137d2af SWDEV-374789 - Validate HostQueue before accessing it
- hip::getQueue will return nullptr when comgr fails to load blit kernels.

Change-Id: I3bea1f5c13301d4a35e40ab7c6faa73f9c6aecf4


[ROCm/clr commit: 95b2441cbc]
2022-12-28 01:04:10 -05:00
Ioannis Assiouras 49a3b0c6ba SWDEV-374393, SWDEV-373631 - Added input checks for hipMemcpy2D/3D
Change-Id: I5ae57326c35b599d9ecec05e2a22bc6086027322


[ROCm/clr commit: 1278cf555e]
2022-12-22 11:21:55 -05:00
Ioannis Assiouras 65f79be5f7 SWDEV-374355, SWDEV-374356, SWDEV-374357, SWDEV-374358, SWDEV-374359 - Added input sanity checks to hipExternalMemoryGetMappedBuffer
Change-Id: I61e43dece3fb9bd961e92db8e015f08170327538


[ROCm/clr commit: 99d2d016c1]
2022-12-22 10:46:10 +00:00
Jaydeep Patel 376f515547 SWDEV-374398 - Pitch should not be less than width for both src and dst.
Change-Id: Ib8fa8e3bd0c655f3de213b3798d369ba866b2f01


[ROCm/clr commit: c4003ef62a]
2022-12-21 23:08:55 -05:00
Ioannis Assiouras 0019cfdf7c SWDEV-374392 - Make hipMemCpy2/3DAsync synchronous for any HostToHost and DeviceToPageableHost
Change-Id: Iaa411681a49427a9e9b3a06e90abb0b32f5a6851


[ROCm/clr commit: d29a2e545d]
2022-12-21 14:59:39 -05:00
Jaydeep Patel e5a9c5b85b SWDEV-374394 - Correct hip error for invalid stream.
Change-Id: I96949c58e050cb3149ab8434aebe0f1a97a6e857


[ROCm/clr commit: 148f67a36d]
2022-12-20 21:27:56 -05:00
Jaydeep Patel bd59bad586 SWDEV-374395 - Correct rhs.
Change-Id: I433d60344a6d23bc48f4db58d5501af89bc1989c


[ROCm/clr commit: 027f71ccfb]
2022-12-20 11:38:11 +00:00
Ioannis Assiouras f3c412b183 SWDEV-369548 - Disallow opening an ipc mem handle in the originating process.
Change-Id: Icce5e41a220566141bd7d92b7199d477f60bed8e


[ROCm/clr commit: 30e740023b]
2022-12-14 04:52:21 -05:00
kjayapra-amd c3c4eb85d3 SWDEV-371904 - Adding pseudo fine grain flag to hsa memory allocation for device fine grained memory.
Change-Id: I8c605d6bc3ac905bfffc6de3a56911151ef0e663


[ROCm/clr commit: f7c194edf7]
2022-12-12 11:40:00 -05:00
Ioannis Assiouras e609c247ec SWDEV-369581 - Convey copy API metadata to ROCclr
Change-Id: I6fcd2c2dbec887199de538326a7826bd29a25ca0


[ROCm/clr commit: 337976febf]
2022-12-09 00:27:35 -05:00
Jaydeep Patel 2411eeba32 SWDEV-366086 - Validations for negative scinerios.
Change-Id: Icca87de775bf7f8c4d18f911f7bee21fafdcff55


[ROCm/clr commit: e2279b3869]
2022-12-06 21:27:37 -05:00
Rakesh Roy ff8d9d3c77 SWDEV-348820 - Fix hipPointerAttribute_t incompatibility
- Use hipPointerAttribute_t.type instead of hipPointerAttribute_t.memoryType

Change-Id: I3bf1c0758bdae987213ba7de62247dd420ef4cc9


[ROCm/clr commit: cbc3a0a652]
2022-11-29 00:53:24 -05:00
Maneesh Gupta 6594768a22 Revert "SWDEV-363069 - Disable sync force for MT"
This reverts commit e3f6a5fa0d.

Reason for revert: SWDEV-365075, SWDEV-367163, SWDEV-367164, SWDEV-367173

Change-Id: Id2924c60e46e9879038ded358f777c71cd95b2c1


[ROCm/clr commit: 1c45f257b9]
2022-11-17 01:04:44 -05:00
German Andryeyev 670266f94f SWDEV-364457 - Don't attempt adding duplicates into the memory map
KMD can enable hipHostRegister optimization  with HMM path.
That will make CPU and GPU pointers matching.

Change-Id: Iad96ceada5cfa3bada20452b906f744f9dbaebbe


[ROCm/clr commit: 55d085ca8c]
2022-11-03 10:04:12 -04:00
pghafari e67454dc70 SWDEV-362280 - retur NotSupoorted for hip-vulkan
hip-vulkan semaphore on rocm is not supported

Change-Id: I6e01c4f5b192cfb17546a29a1cb17f320c4b1adc


[ROCm/clr commit: 895473e8d8]
2022-10-24 13:36:18 -04:00
German e3f6a5fa0d SWDEV-363069 - Disable sync force for MT
hipMemcpyAsync doesn't require any forced sync even for sysmem

Change-Id: I83951f6118e84d79c74d5671df62678c5db085a8


[ROCm/clr commit: 52ff4368e5]
2022-10-24 10:59:07 -04:00
pghafari 18808d87a4 SWDEV-356557, SWDEV-356558 - matching cuda return
Change-Id: I3b7d50e07bd437bd23a495439d66940ff30f7f07


[ROCm/clr commit: d7b27989b4]
2022-10-19 09:17:28 -04:00
Ajay ca2235f671 SWDEV-353548 - assert with different behavior for Release vs Debug
assert statement behavior
-Debug: crashes tests with SIGABORT
-Release: continues silently without

Change-Id: I7578eb16a7391ff7f9d68f1cae3bcea7f8225579


[ROCm/clr commit: be80bf5406]
2022-10-11 14:00:28 -04:00
Sourabh Betigeri 8ceb2ac5d6 SWDEV-357246 - Fixes to return with a error code instead of segfault in alloc failure case
Change-Id: Ie18d50f2f7ef3f4b2c0153152fca057232c1f8a2


[ROCm/clr commit: aeeab1c975]
2022-10-04 09:38:42 -04:00
Jaydeep Patel 5053dbe40e SWDEV-351054 - Move validation for w & h to hipMemAllocPitch.
Change-Id: Ia624fc99e797baf88dc029d7e36bb80df1bd7d12


[ROCm/clr commit: e5dff9a140]
2022-09-07 01:00:49 -04:00
Jaydeep Patel 06501e696d SWDEV-351282 - Null check for desc.
Change-Id: I69d534b6f97442c69b66154476a2637e99c3df77


[ROCm/clr commit: cf57f20407]
2022-08-24 13:04:56 -04:00
Jaydeep Patel 72c93b2ddf SWDEV-351033 - Change error code to hipErrorHostMemoryNotRegistered
Change-Id: I930bb1e2787e284f335689d1900bdd08d328272e


[ROCm/clr commit: efadc772db]
2022-08-24 07:14:15 -04:00
Jaydeep Patel 66015baadc SWDEV-351220 - Revert 1752b3049e
Change-Id: I08a06307271d0eccdf4b4876dea5ec70ace07d39


[ROCm/clr commit: 349ade7b2e]
2022-08-24 00:08:53 -04:00
Sarbojit Sarkar 504af979fe SWDEV-2 - clean-up for hipMemset and other memset APIs
Change-Id: I0270be2843ee5f79c1c476cec7807c0b920869de


[ROCm/clr commit: b39a56be25]
2022-08-18 12:04:16 -04:00
Jaydeep Patel 71f44c6bc1 SWDEV-351285 - Change error.
Change-Id: Ia841a24cf774b2e2d8f6b6e37f3d8f43cb73f8df


[ROCm/clr commit: adfb40ed42]
2022-08-18 07:07:56 -04:00
Ajay 91a6c2da56 SWDEV-344168 - hipVmm functionality memory check fix
Change-Id: Ia1de96ac9dbcbfb6a94a234aec3bf6cb51961799


[ROCm/clr commit: 113cc9ae2a]
2022-08-16 11:04:56 -07:00
Jaydeep Patel 99b2f456e7 SWDEV-351200 - Validate desc.
Change-Id: Ic8690c9a2134ca42f4bec626ca787587a32856fb


[ROCm/clr commit: 5b6ffb6380]
2022-08-11 07:17:21 +00:00
Jaydeep Patel 29d27cdee0 SWDEV-351031 - Any bit other than the rightmost 4 bits shouldn't be set
Change-Id: I6c834f491ce393eb37259eabc603220c5b5f164e


[ROCm/clr commit: 35051e778d]
2022-08-10 23:30:22 -04:00
Jaydeep Patel 1752b3049e SWDEV-346382 - Don't fall back to sync for hipMemcpyAsync from host to device.
Change-Id: I5aab9041f87c549a03c86e95a39bfa437126a99b


[ROCm/clr commit: 366050b14f]
2022-08-05 02:32:55 -04:00
Sarbojit Sarkar 67f9e52ffb SWDEV-338732 - Made hipMemset* default async
Change-Id: I0ebf6473b6825162fc828bb8cac47743e14ffd19


[ROCm/clr commit: 0444d20e07]
2022-08-02 07:14:57 -04:00
sdashmiz ed46e236d2 SWDEV-346423 - avoid race condition
- move removing the array from array set earlier to avoid race condition

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I9003c991e3e0f47ed0509ddfdbeaa145b5a1e0f1


[ROCm/clr commit: d0b9e0a4ff]
2022-07-25 15:17:10 -04:00
Sarbojit Sarkar bf38d72e0b SWDEV-346461 - Fix for QMCPack tes failure
Change-Id: I92979f0c16766c28da6b14b6e17364749fe39fe3


[ROCm/clr commit: 7d23707817]
2022-07-19 02:13:07 -04:00
Jaydeep Patel 40fda3cfe9 SWDEV-343168 - Clean ihipMallocPitch
Change-Id: Iab1c10ac2aea635ca10cc8bc98141df409ec917c


[ROCm/clr commit: 6b3b62f49e]
2022-07-14 01:15:08 -04:00
sdashmiz b0cbdea221 SWDEV-345021 - add check for pointer
add check for pAllocateArray

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6c91295c1fe4cffdf22f6b8c07fe0a592c2f4f70


[ROCm/clr commit: 848ae2c06b]
2022-07-13 10:21:48 -04:00