Commit Graph

4136 Commits

Author SHA1 Message Date
Alex Voicu acc05cdff7 Remove leftover comment.
[ROCm/hip commit: 08f252e4bf]
2017-11-22 19:37:03 +00:00
Evgeny Mankov 52b93658a9 Merge pull request #263 from ChrisKitching/headers
[HIPIFY] Add hipify mappings for all CUDA headers that have HIP equivalents

[ROCm/hip commit: 4e92a034d0]
2017-11-22 21:24:21 +03:00
Alex Voicu d8db534805 Modify the set component of the memcpy test (unclear why there is a memset component to begin with).
[ROCm/hip commit: 4131b47134]
2017-11-21 17:52:01 +00:00
Rahul Garg 13879387e5 Fixed review comments
[ROCm/hip commit: 56862b1c35]
2017-11-21 21:19:06 +05:30
Alex Voicu d71132de7c This corrects how addresses are formed for symbols which reside in shared objects. For this case, the .value component of an ELF symbol holds the offset from the base VA where the shared object was loaded. Thus, to correctly obtain the VA of the object refered by the symbol, we must add the offset to the VA where the shared object is loaded. We were already doing this correctly for symbols denoting functions, but we were incorrect for those denoting objects.
[ROCm/hip commit: 5e16ee0d1f]
2017-11-21 13:15:13 +00:00
Rahul Garg 03552f2e94 Changed function hipMemcpy_2D to hipMemcpyParam2D
[ROCm/hip commit: 9866fa250d]
2017-11-21 12:36:24 +05:30
Alex Voicu 45ff3c31c4 Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
[ROCm/hip commit: 9d088d2283]
2017-11-21 02:40:34 +00:00
Alex Voicu e8ca14848e Clean-up some remaining noise in program_state.cpp.
[ROCm/hip commit: 1824fb7698]
2017-11-20 22:41:46 +00:00
Alex Voicu 69f8043d12 Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
[ROCm/hip commit: 7d5a45ac1a]
2017-11-20 16:33:52 +00:00
Alex Voicu 3c936777aa Re-sync with upstream.
[ROCm/hip commit: c5f2b22d0d]
2017-11-20 15:34:50 +00:00
Ben Sander 6e332812fc Merge pull request #264 from pzins/missing_end_marker
Fix missing MARKER_END

[ROCm/hip commit: e8ede28ec4]
2017-11-20 06:08:01 -06:00
Rahul Garg 97ee22c3f5 -Moved coGlobals in hipModule class (takes care of multi module case)
-Used mutex scope for updating coGlobals


[ROCm/hip commit: f97c5f9a64]
2017-11-20 16:23:18 +05:30
Maneesh Gupta d807f528e6 Merge pull request #266 from gargrahul/fix_half2_gfx900
Fixed half2 issue on gfx900

[ROCm/hip commit: db378fbc9e]
2017-11-20 07:28:41 +05:30
Maneesh Gupta 2bb78b3a69 Merge pull request #265 from phani544/nvccTests
[nvccTests]Enabled inline_asm_vadd on nvcc

[ROCm/hip commit: 1174534e85]
2017-11-20 07:28:29 +05:30
Ben Sander 1ec5bab716 Fix test on cuda
[ROCm/hip commit: 59956a57ca]
2017-11-19 15:31:02 -06:00
Ben Sander 64a169fd5c Merge branch 'feature_natural_indexing' of https://github.com/AlexVlx/HIP
[ROCm/hip commit: 5a7a28ad29]
2017-11-19 15:25:17 -06:00
Ben Sander dde41ae0aa Temporarily disable P2P on nvidia (fails on dual GPU)
[ROCm/hip commit: e0c3f684ae]
2017-11-19 15:21:37 -06:00
Rahul Garg 62f20c6dc8 Update hipModuleGetTexRef API
[ROCm/hip commit: c7d60a7a75]
2017-11-19 22:10:46 +05:30
Alex Voicu 962bf7bfda This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
[ROCm/hip commit: cffd0e14eb]
2017-11-19 01:54:12 +00:00
Alex Voicu 6de4a217c0 This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
[ROCm/hip commit: 6fa7adf077]
2017-11-18 01:16:31 +00:00
Alex Voicu d9ecde1b60 This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
[ROCm/hip commit: 153878e368]
2017-11-17 16:00:28 +00:00
Alex Voicu 6206ac6138 Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
[ROCm/hip commit: f93859cdc2]
2017-11-16 23:20:15 +00:00
Rahul Garg 5de28551c1 Fixed test case for GFX900
[ROCm/hip commit: 9af0f9cbc1]
2017-11-16 09:34:52 +05:30
Rahul Garg d0ee6e00fe Fixed half2 issue on gfx900
[ROCm/hip commit: fef496d4f1]
2017-11-15 18:52:59 +05:30
Rahul Garg e5aae56998 Removed redundant desc variable
[ROCm/hip commit: ae1eb7a03a]
2017-11-15 18:28:27 +05:30
Rahul Garg 58b37dce5f -Fixed texture driver API sample
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs


[ROCm/hip commit: 4b19c2aa0c]
2017-11-15 18:23:28 +05:30
Phaneendr-kumar Lanka 65a8021933 [nvccTests]Enabled inline_asm_vadd on nvcc
[ROCm/hip commit: 18f6e31d1d]
2017-11-14 16:37:59 +05:30
Rahul Garg 0263292087 Texture code reorganized
[ROCm/hip commit: 63680edd30]
2017-11-14 11:09:35 +05:30
Pierre d917c6b546 Fix missing MARKER_END
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"


[ROCm/hip commit: 6baaed8e48]
2017-11-13 16:13:19 -05:00
Chris Kitching 9ef5b7a506 Add an explicit check for proper rewriting of CUDA includes
[ROCm/hip commit: ab3debb2f9]
2017-11-13 21:02:42 +00:00
Chris Kitching 6e5f80b345 Add a preprocessor conditional to one of the tests
Hurrah, we can cope with ifdefs now (except for kernel launches)


[ROCm/hip commit: 2344ca89f3]
2017-11-13 20:58:55 +00:00
Chris Kitching 096136750c Use proper clang diagnostics for printing warnings
Much pretty. Very wow

This gives users all the usual power when it comes to manipulating
clang diagnostics. People can pass -Werror can have hipify fail if
it doesn't completely translate a file, for example. Much nicer
than reinventing the wheel.


[ROCm/hip commit: 6b767a59ba]
2017-11-13 20:58:55 +00:00
Chris Kitching 78cf713140 Use a custom FrontendAction to simplify identifier translation
Most of what hipify does is really just replacing CUDA idenitifers
with HIP ones. CUDA function calls, preprocessor macro calls,
enum references, types, etc.

This is problematic: calls/types/enum-refs require name resolution
for the AST matcher to work. This fails in the presence of code
deleted by the preprocessor, and in two-pass template compilation.

Instead, we can simply hook the lexer and have it rewrite the
identifiers for us.

This approach means identifier transformations will work correctly
regardless of where they appear (and we get to delete lots of code)

- Fixes #260
- Helps a bit with #207 - it will still fail to translate kernel
calls in preprocessor-ignored code, but everything except kerel
launches should translate correctly now, even in
preprocessor-deleted code.


[ROCm/hip commit: 24cdc5e1d3]
2017-11-13 20:58:54 +00:00
Chris Kitching c2d54f0154 Add hipify mappings for all CUDA headers that have HIP equivalents
I'm particularly running into issues with `device_types.h` in real
CUDA code...


[ROCm/hip commit: 23b5d26582]
2017-11-13 17:20:07 +00:00
Chris Kitching 1451d8fc89 Add a test that exposes #260
[ROCm/hip commit: 9165df3848]
2017-11-13 16:18:15 +00:00
Chris Kitching b13465cfdd Add a couple of missing CHECK directives to concurrentKernels.cu
[ROCm/hip commit: 4ab091ce1e]
2017-11-13 16:17:19 +00:00
Maneesh Gupta 0fd5239b14 Merge pull request #261 from gargrahul/fix_module_api_sample
Fix module_api sample

[ROCm/hip commit: 85975e719d]
2017-11-13 11:55:54 +05:30
Rahul Garg 93a390b9c2 Fix module_api sample
[ROCm/hip commit: 83adf6525e]
2017-11-13 08:56:39 +05:30
Alex Voicu aa34be6834 Add omitted changes in CMakeLists.txt.
[ROCm/hip commit: 819e72fba6]
2017-11-10 01:20:50 +00:00
Alex Voicu 7bc5d01aaa Update new tests so as to make them work with new variadic based launch mechanisms.
[ROCm/hip commit: bd78459690]
2017-11-10 00:14:34 +00:00
Alex Voicu f08f1efab8 Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
[ROCm/hip commit: f7726cd416]
2017-11-09 23:43:07 +00:00
Rahul Garg 2315ba55d6 Added texture 2D driver API usage example
[ROCm/hip commit: 68cc7766c6]
2017-11-09 22:35:29 +05:30
Rahul Garg 49a2c6468e Texture driver APIs support
[ROCm/hip commit: ef09c4918d]
2017-11-09 22:10:55 +05:30
Maneesh Gupta 56d3677499 Merge pull request #250 from AlexVlx/feature_add_agent_global_support
Support for agent globals

[ROCm/hip commit: 31bcb59f62]
2017-11-09 07:52:09 +05:30
Alex Voicu 4950373967 Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
# Conflicts:
#	tests/src/runtimeApi/stream/hipStreamSync2.cpp


[ROCm/hip commit: 3d248927e4]
2017-11-08 10:26:30 +00:00
Maneesh Gupta 6368c2abc7 Merge pull request #255 from AlexVlx/remove_some_trailing_whitespace
Clean up trailing whitespace so as to reduce noise in #246.

[ROCm/hip commit: ebd58d43fa]
2017-11-08 10:29:19 +05:30
Maneesh Gupta f71d0a049f Merge pull request #253 from mangupta/hit_add_cmakecmd
[hit] Add support for cmake commands as part of test infra

[ROCm/hip commit: caa7174652]
2017-11-08 09:50:29 +05:30
Alex Voicu 35d8af2001 Clean up trailing whitespace so as to reduce noise in #246.
[ROCm/hip commit: d8e323d4b5]
2017-11-08 00:08:55 +00:00
Ben Sander d6764bc6ba Merge pull request #254 from bensander/event_thread_safe
Event thread safe

[ROCm/hip commit: 9fd6c18ef8]
2017-11-07 17:59:51 +01:00
Maneesh Gupta 34943a2c40 Merge pull request #252 from phani544/newTests2
More tests for memory,stream & error APIs

[ROCm/hip commit: 247d563114]
2017-11-07 10:38:18 +05:30