Commit Graph

12161 Commits

Author SHA1 Message Date
Saleel Kudchadker 1c24072d13 Revert "SWDEV-241977 [ROCm QA] Random Soft hang observed while running TF and Caffe2 benchmarks"
This reverts commit ce038f3163.

Change-Id: Ib56493c92eca793f1dfb6f1cbefb32f0b4f65e89
2020-09-01 18:09:10 -04:00
Alex Xie 7e8f7b5927 SWDEV-249516 - [Lnx][Navi][rocm]conformance image read write tests data error
Change-Id: Ie1c4fda953198b49ed66fea9da23e62c686d9cea
2020-09-01 17:20:58 -04:00
Saleel Kudchadker 99f1830ed6 Fix hipPrintf* tests
The test needs to check dup2 syscall status and not the
errno val

Change-Id: Ic88eb2047b839adbc9e12965b098d8960cd7e2b8
2020-09-01 15:00:49 -04:00
Tao Sang 2332174c8a Replace private libelf with elfio
Change-Id: I59ae33f7cc55e73f6519af14be91dd9863b03af3
2020-09-01 10:29:11 -04:00
Chauncey Hui fb4904f6dc SWDEV-2 - Change OpenCL version number from 3190 to 3191 2020-09-01 03:00:02 -04:00
Rahul Garg f2d9d83a7c Revert "[dtest] Additional tests for Memcpy"
This reverts commit becc687747.

Reason for revert: All the PSDBs on the CI are failing with the below error and its been root caused to this commit:
......................................................................................... Passed 0.59 sec 99% tests passed, 1 tests
failed out of 211 Total Test time (real) = 287.02 sec The following tests FAILED: 139 - directed_tests/runtimeApi/memory/hipMemcpyNegativeMThrdMSize_Negative_tests.tst
(Child aborted) Errors while running CTest Restoring clocks to: auto

Change-Id: I4ea0e14ba5f92cd61677f4a3b9482fea00902310
2020-09-01 00:48:20 -04:00
Jatin Chaudhary 9d4bdd466a Adding dim3 conversion operator to __hip_builtin_threadIdx_t
Change-Id: Ib7f9e45872ec6d48c0e5b7fc93ccecaafaeac754
2020-08-31 21:30:14 -04:00
kjayapra-amd 4cc919fb66 SWDEV-245296 - Adding performance test for hipModuleLoad/hipModuleGetFunction
Change-Id: I4b66d33dc58430e88be4b9b39bc4037e4e53d11e
2020-08-31 13:43:58 -04:00
Tao Sang 9c5465f9e1 Fix OpenCL test crash on some devices
Replace constexpr with const in kernel source
codes because some kernel compiler doesn't
support constexpr.

Replace scheduler with __amd_rocclr_scheduler
due to name change.

Change-Id: I1ad4ddcdf1df5237b83e1ea2447eb39a19f7dc4a
2020-08-29 12:29:07 -04:00
Chauncey Hui bc5b9c853a SWDEV-2 - Change OpenCL version number from 3189 to 3190 2020-08-29 03:00:03 -04:00
Rahul Garg c8a32c932d Return error when mismatch in copy kind and ptrs
Change-Id: I70e4d06e850843697035b42c5d1d56287c874ac8
2020-08-27 20:53:48 -04:00
Vladislav Sytchenko 9998067174 Fix memory leak
getLastQueuedCommand(true) will implictly retain the last command, hence if we're not putting it in the waitlist, we should release it.

Change-Id: I1ad4ddcdf1df5237b83e1ea2447eb39a59f7dc3a
2020-08-26 12:45:18 -04:00
Tao Sang e986f5c820 Replace private libelf with elfio
Change-Id: I4c630d78f7bf23dda85ec8480bb2790864405657
2020-08-26 12:32:13 -04:00
Chauncey Hui 70139d6e34 SWDEV-2 - Change OpenCL version number from 3188 to 3189 2020-08-26 03:00:04 -04:00
Jason Tang 19d1497fa2 SWDEV-239502 - fix interop regression
When header==0, the legitimate packet->header is wiped out, so also add an assert.

Change-Id: I6b3037d4618719262b0d7c1792bd54f768a63660
2020-08-25 18:11:18 -04:00
Jenkins e25c9562c8 Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I801d75dba453bcf24fe0c6f36a6489c2e470231e
2020-08-25 17:10:30 -04:00
Aryan Salmanpour ba2036a60a [HipPerf] modifiy and move hipPerfMemcpy test to the new location for perf tests
SWDEV-245290

Change-Id: I84f03a3019fce48aab63dd4cc232ea3539a1af79
2020-08-25 16:52:14 -04:00
Aryan Salmanpour d2b9d267b2 SWDEV-248499 Fix a crash when printf is used with cooperative kernels
root cause - cooperative queue is not inserted into queuePool_ (HSA queues) of ROC device calss causing a crash when creating hostcall buffers for printf

Change-Id: I3f9aceb4e5fe6a7c7a2a549a4bb0a3511fe02799
2020-08-25 16:51:34 -04:00
Jenkins ee490fae12 Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I914aa748c92849f9f7ab796129a4617753d728db
2020-08-25 11:10:53 -04:00
Chauncey Hui 9110b09227 SWDEV-2 - Change OpenCL version number from 3187 to 3188 2020-08-25 03:00:04 -04:00
mshivama bfb54cc5e9 Support public apis for cooperative group types.
Change-Id: I01346afde485e82c34b7868b9241b34c542d0cf9
2020-08-25 10:50:38 +05:30
Rahul Garg 5fb155dbf5 Bump version to 3.9
Change-Id: I5dfc997336fac42f3b6b0998a4bb212462de38f9
2020-08-24 21:52:22 -04:00
Laurent Morichetti f10435a1ef Add missing storeload memory fences
There is no synchronize with relationship between the monitor micro-
lock and the onDeck microlock, so it is possible for an onDeck.load to
move above a contendersList.store, or a contendersList.load to move
above an ondeck.store.

To fix this issue a full memory fence (mm_mfence on x86) is needed
after the last store in the contendersList and onDeck critical regions.

Change-Id: I5beb7dfe0d21010c5bf00cd65d59b9c7af58e919
2020-08-24 18:03:37 -04:00
kjayapra-amd b9f8ab96ce SWDEV-249499 - Add message to Guarantee assert code in hip runtime.
Change-Id: I1850463675bbc3e6ff5e3cef8211b1fd40e55f96
2020-08-24 17:35:39 -04:00
Chauncey Hui e11ef5ecd4 SWDEV-2 - Change OpenCL version number from 3186 to 3187 2020-08-24 16:33:52 -04:00
Jason Tang 6c13a34a04 Remove refering to gfxipVersion_
Change-Id: I06e3fe5c10ddf50674c69d7de68f208bbfb83f2f
2020-08-24 14:38:16 -04:00
Jenkins 68cd6a2aee Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I2121bcceb5d3321fdc4248de337101d628411ab1
2020-08-23 21:09:31 +00:00
Yaxun (Sam) Liu 5e5fb829ed Fix hipcc for extracing clang version
On teamcity clang --version returns something like

clang version 12.0.0
Target: x86_64-unknown-linux-gnu

currently hipcc does not handle it correctly since [^ ] causes new line and Targe:
matched. \S will make sure only version string matched.

Change-Id: I3659d6daf89b709d2b001e6b8024d69d8b79efc0
2020-08-21 18:21:46 -04:00
Todd tiantuo Li a243a69e98 SWDEV-240803 - add hipFuncSetSharedMemConfig
Change-Id: I160b04677b3e7b99b3981ae7ecc84a0e3811d5e8
2020-08-20 18:18:24 -04:00
Jenkins dbc0dfe399 Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I4d7ded0a1316a469f0880490e563c3e3f00cc970
2020-08-20 21:09:41 +00:00
Lakhan singh Thakur becc687747 [dtest] Additional tests for Memcpy
APIs tested: hipMemcpy, hipMemcpyAsync, hipMemcpyHtoD, hipMemcpyHtoDAsync
             hipMemcpyDtoH, hipMemcpyDtoHAsync, hipMemcpyDtoD,
             hipMemcpyDtoDAsync

-Scenario-1:: The aim of this test case is to cover all the negative test cases
              for 8 hipMemcpy apis
-Scenario-2:: This test launches NUM_THREADS threads. Each thread in turn tests
              the working of 8 hipmemcpy apis
-Scenario-3:: This test case verifies the working of Memcpy apis for range of
              Memory sizes from smallest one unit transfer to 1GB.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Iace19cc54e865fae8450448d6f37abed88597f19
2020-08-20 16:41:57 -04:00
Sudheer Kumar 4a110ce7ed [dtest] Enhanced tests for hipSetDevice and hipGetDevice
SWDEV-238517 for enhancing hip unit tests

Change-Id: I4fe169c560ce2e1fb471df67f03263903b12463b
2020-08-20 13:52:05 -04:00
Sourabh Betigeri 90e4f2062a SWDEV-246104: Added new performance test to verify stream concurrency
Change-Id: Ieceaafd4d404b137936eb8aceecff27bbba42026
2020-08-20 13:42:55 -04:00
Aryan Salmanpour 29bca5b949 [HipPerf] add a test for measuring create/copy/destroy for hip streams
SWDEV-245290/SWDEV-247767

Change-Id: Id52e3d2f7afee52763da107eb5ed04627942d9f0
2020-08-20 13:28:36 -04:00
Jenkins 615e32a722 Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: Ibbb31c0a6d1d92e96a6c9abed0d4d4eb0b357008
2020-08-18 09:09:47 +00:00
Todd tiantuo Li 3ac8483124 move hipFuncSetCacheConfig from hip_device to hip_module
Change-Id: If5a930e1210e76531f5ba9a0e5f5ec98ad473a19
2020-08-17 17:39:01 -04:00
Aryan Salmanpour 359c0fbb76 SWDEV-248057 - fix the calculation of allGridSize used in multi_grid_group() API
Change-Id: Ib470094e28dcacaa4769dc5c7ab08924f5b7fa41
2020-08-17 12:52:40 -04:00
Jatin Chaudhary 628a308475 Adding Anyorder flag to HIP
Change-Id: Ie20931541b3febe23fa9ac36ebc0c90de75a5f0a
2020-08-17 08:46:52 -04:00
Jenkins 65f85f0b95 Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I56b40b684a8be0dfbf330d0d1ed1ad703fde8417
2020-08-16 09:09:40 +00:00
Rahul Garg ee3dbfac49 Fix hipDispatchEnqueueRateMT sample
Change-Id: I7ade0dcf8b32ac90a311022d12339740b2b3df44
2020-08-14 18:56:39 -04:00
Todd tiantuo Li fb43f21044 SWDEV-240803 - add hipFuncSetAttribute and hipFuncAttribute
Change-Id: I3f4d67b19d89fd348fa5b884af4a2542ee4aba60
2020-08-14 17:39:29 -04:00
Jason Tang c33470ab4d SWDEV-239502 - Create copyImageBuffer_ without flags
Change-Id: Ifcb5992d58f3419635d2aca2d51f2dacd7cd466d
2020-08-14 17:25:58 -04:00
kjayapra-amd ea15c75c55 SWDEV-237658 - Do not attach events to user invisible Marker.
Change-Id: I3a74fd2614d6e2e1d51543471bbd5ae51a713a47
2020-08-14 10:55:34 -04:00
agodavar e914f281ff SWDEV-245503 - Improve hipModuleLoad performance
Change-Id: Icbcd37d9b4e6d79f296cc8693edf25689b19fa11
2020-08-14 05:24:52 -04:00
Jenkins e1af6830ad Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I935fc8f681fad2df4e932407287a29a6a797351a
2020-08-14 09:09:52 +00:00
Freddy Paul 95729c31e8 Enable developers to build hip without CMAKE_PREFIX_PATH
With recent changes in ROCclr to take HSA cmake target it require
HIP to have CMAKE_PREFIX_PATH added for install location for HSA,
amd_comgr,llvm.

User can provide CMAKE_PREFIX_PATH if above
packages are built/installed at custom location as:
cmake -DCMAKE_PREFIX_PATH="<path_hsa> <path_amd_comgr> <path_llvm>"

For default ROCm installation adding a default path will help.

Change-Id: Iefa443dc198da76b57422a641c9821c63cde4922
2020-08-13 23:13:40 -04:00
Aryan Salmanpour de1e14b252 [HipPerf] relocating/renaming some hip perf tests
Change-Id: Ie85d242cd68cd14a858e07ed27875a5196014688
2020-08-13 17:28:11 -04:00
Aryan Salmanpour 1a2622dd60 [HipPerf] report performance based on wall time only for hipPerfDevMemReadSpeed/hipPerfDevMemWriteSpeed
Change-Id: I1fda2ec76da6fad6852d328e0a3fc39e28af57bb
2020-08-13 14:23:58 -04:00
Vlad Sytchenko 6780a9ac66 Remove unnecessary SVM commit
Change-Id: I5cb887ead166401a59b0c980f29fd615b19745be
2020-08-13 13:21:03 -04:00
Jason Tang db5a2d4c2d SWDEV-239502 - Fix image test regression
Change-Id: Iea35fb0f1964d09a35131b4a20ac8f6f82850a8e
2020-08-13 11:58:20 -04:00