28f87f7d2e
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00
7e8b39fc96
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
2017-10-30 17:58:48 +01:00
cf98d0e37d
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-27 01:18:28 -04:00
36c2795dd4
add a printf device function
2017-10-23 18:30:08 -04:00
ed85b15c3e
Update device properties.
...
- clear properties to defined initial state.
- enable some property flags which are now supported.
2017-10-20 15:52:13 +00:00
939fa02ade
Add [[nodiscard]] attribute to hipError_t in C++17 mode
...
This will yield a compiler warning any time you discard an error
return value from an API call.
2017-10-19 13:34:02 +01:00
132316fecf
Merge pull request #194 from bensander/fix_genco_math_path
...
Fix math ordering for --genco mode.
2017-10-03 16:17:34 +05:30
2e9b78c274
Fix math ordering for --genco mode.
2017-10-02 21:52:16 +00:00
71a5a0cb42
Fixed review comment
2017-10-02 17:29:08 +05:30
79a943e654
Fixed review comments
2017-10-02 10:57:25 +05:30
d92cfa44d2
Fixed build issue
2017-10-02 10:40:01 +05:30
e6725e2b7a
Fix texture support on HIP/NVCC path
2017-10-02 10:40:01 +05:30
bf6a3f4294
ensure the condition is evaluated before applying the negation operator
2017-09-20 01:38:28 -04:00
01163d327b
Merge pull request #155 from wsttiger/master
...
Modify hip headers such that they are more compatible with strict C compiler
2017-09-15 10:49:55 +05:30
846b0555b9
Fix typo in nvcc_detail/hip_runtime_api.h
2017-09-14 16:19:57 +05:30
096caca840
Merge pull request #175 from gargrahul/assert_support
...
Device side assert support
2017-09-14 16:08:00 +05:30
f6fda276ce
Add hipDevice[Get/Set]SharedMemConfig API on nvcc details
2017-09-14 16:03:19 +05:30
9dcf2ad751
Device side assert support
2017-09-07 20:45:27 +05:30
a6d1778fff
Update docs.
...
- Review unsupported comments and refresh.
- Review experimental tag in API.
2017-08-28 15:44:38 -05:00
8302138d57
Modify header such that it's compatible with strict C compiler
2017-08-15 13:23:09 -05:00
7933b3292d
Add missing CUDA tags
2017-08-15 13:22:20 -05:00
b6e22b5c93
implement __threadfence_system
2017-08-02 08:50:18 +00:00
702651fc85
Merge pull request #100 from weixingzhang/texture
...
HIP Texture Support
2017-07-26 19:28:15 -05:00
1bd1c6bea8
Renable frexp(f) device math function
...
Change-Id: I53c022b8ddf38cd17ddb42eba457b9020db66395
2017-07-20 14:41:30 +05:30
ccbd3b13fc
HIP Texture Support
2017-07-17 15:16:12 -04:00
0237aeab06
Remove explicit address spaces declarations
2017-07-07 12:46:29 -05:00
18660be8ce
Add hipdbPrintMem - wrapper for hcc memory tracker.
2017-07-03 15:05:30 -05:00
cbc98cc098
Fixed build error in hipDeviceGetByPCIBusId
...
Change-Id: I33be362910c4c5dca7435fb9c41f427b54f0e9a7
2017-07-01 07:56:30 +05:30
5e5b017b0d
Refactor hip_hcc.
...
Don't require setting __HIP_PLATFORM_HCC__ ; Instead check if compiler is HCC.
The functions here use HCC-specific functionality so only work with HCC.
ANd they work regardless of the __HIP_PLATFORM_HCC__ setting so don't
require that.
Also remove the "hcc_detail" extra hierarchy level for hip_hcc.h as
it is not necessary. Remove hcc_detail/hip_hcc.h.
2017-06-30 08:26:15 -05:00
467a2ba014
Fixed hipDeviceGetByPCIBusId
...
Change-Id: Ia36bb9425671ef7659541c9aeedae4098456a31b
2017-06-30 10:11:41 +05:30
38d48b5cf0
Fixed hipDeviceGetPCIBusId for HIP/NVCC
...
Change-Id: I662efa148257a710f09002850b41d57bef00dff3
2017-06-29 00:13:02 +05:30
a7c727f352
Fixed hipDeviceGetPCIBusId for HIP/HCC
...
Change-Id: I3688fa2476e1baada2d3c5fc3735cec3f15a1e21
2017-06-28 23:48:27 +05:30
3d2a729580
Remove some warning debug info and add weak attribute back to GGL __global__ define
...
Change-Id: I2021b107dda697b1262d44fa1506465e94a3916b
2017-06-27 14:15:16 -05:00
3043766899
fixed default args for symbol memcpy apis
...
Change-Id: Ie0b63f8b9c5535eb3946bd6af3f30fe71a015244
2017-06-23 19:05:44 -05:00
42882ddf9c
Clean up old USE_* and RELEASE.md notes.
2017-06-23 18:05:30 -05:00
0fd6b59e22
Added device side abort function in HIP/NVCC
...
Change-Id: I6ae35a72a8b9c34852619f02da1a046c8d3b2ed3
2017-06-20 09:38:56 +05:30
d9935cd089
Abort device function in HIP/HCC, need new HCC
...
Change-Id: I4195ab75e9b7b48c8b8128d6925ddc0fa5e9e009
2017-06-18 12:31:31 +05:30
34e14bb02d
removed bad copy constructor
...
Change-Id: I661991d9d43941a61848b0b8e9879c0bfa811b40
2017-06-16 09:02:26 -05:00
9bce2af76f
Additional GGL make_kernel_functor_* macros, contributed by Alex
...
Change-Id: I01aabb7d2b5418fcefb1bbf78eb5d1888dbc5c96
2017-06-14 11:10:52 -05:00
682dda4418
Fix error related to undefined reference of __get_dynamicgroupbaseptr().
...
Change-Id: I14951e1725e35dd5f5e53805f81cdb58661f59f2
2017-06-08 19:24:32 -05:00
5450021f93
Add clang version guard so the hip_fp16.h header won't be picked up by gcc
...
Change-Id: Ia21335a455bc93210901b44bc8c76a7f4a385b55
2017-06-08 19:24:32 -05:00
3b6a863eef
Improve HIP kernel names, attributes and codegen, contributed by Alex Voicu
...
Change-Id: I2cafbdc5a98e26c7f4fad84739c915e7dc09993c
2017-06-05 11:39:00 -05:00
823281dcba
Fix HIP_SYNC_NULL_STREAM=0 mode.
...
- Fix null-stream sync
- hipStreamDestroy of null stream returns hipErrorInvalidResourceHandle
- Update documentation.
- Add tests for null stream sync, hipEventElapsedTime.
- Rename internal enum hipEventStatusRecorded to hipEventStatusComplete
- refactor hipStreamWaitEvent to streamline control-flow
2017-06-05 08:50:22 -05:00
fdcc223842
added half data type and vector destructors
...
1. Added half data types to hip_fp16.h
2. Added destructor to vector data types
Change-Id: Id5ae76a663bb90a4bde2839ec79c58fbaee5072f
2017-06-02 11:19:33 -05:00
463c026976
[HIP] [HIPIFY] CUDA Driver API 8.0.44 JIT options support.
2017-05-31 18:55:29 +03:00
942ec0eff8
Add event controls for release fences.
...
Env var : HIP_EVENT_SYS_RELEASE
Event allocation flags : hipEventReleaseToDevice, hipEventReleaseToSystem
(remove hipEventDisableSystemRelease)
Update test for new functionality.
2017-05-27 16:02:34 -05:00
8dc968f036
Updates so hip compiles on CUDA.
2017-05-27 15:55:07 -05:00
dda70ae514
Add hipHostMallocCoherent, hipHostMallocNonCoherent
...
Provide per-allocation control over coherent/non-coherent mem.
These overrid the default HIP_COHERENT_HOST_ALLOC setting.
2017-05-24 00:48:10 -05:00
2523f8a492
fix GGL helper header file, reorder for C++17
...
Change-Id: I3d9ddfe670bf7e3e8e7bd85e52cc61f48c19c213
2017-05-22 08:52:43 -05:00
ae9f14ef9c
[HIP] [HIPIFY] [FIX] cuModuleLoadDataEx -> hipModuleLoadDataEx
...
https://github.com/GPUOpen-ProfessionalCompute-Tools/HIP/issues/81
1. Do not use JIT options on HCC path, call hipModuleLoadData instead.
2. NVCC path is unchanged, to call cuModuleLoadDataEx with all options.
3. Get rid of manual hipification, based on #ifdef #else for NVCC/HIP.
4. Update documentation accordingly.
2017-05-19 17:22:14 +03:00
Alex Voicu
Ben Sander
Siu Chi Chan
Chris Kitching
Maneesh Gupta
Rahul Garg
sriharikarnam
wsttiger
Weixing Zhang
Wen-Heng (Jack) Chung
Sun, Peng
Aditya Atluri
Evgeny Mankov