EPR #010002 - Change OpenCL version number from 1729 to 1730.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1476 edit
EPR #403782 - IOMMU2/SVM
- Reset desc.isAllocExecute so that it doesnt have random values
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#207 edit
[ROCm/clr commit: 252e1de747]
EPR #403782 - IOMMU2/SVM
- Reset desc.isAllocExecute so that it doesnt have random values
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#207 edit
EPR #414091 - Compiler Lib/HSAIL: Fix for -fno-bin-cg on multiple kernels
[Problem] If CL or BRIG contains multiple kernels, compilation with option -fno-bin-cg leads to finalizer error.
[Solution] Check that all kernels are finalized before deleting BRIG from BIF. Actual deletion occurs after finalizing the last kernel.
[Misc]
+ fix erroneous successful exit from finalizing BRIG -> ISA function when BRIG is not extracted successfully
+ string constants for symbol prefixes replaced on using findBIF30SymStruct
+ obsolete __AMP_ is removed from code
+ cosmetic changes in hsail_be
+ test for the fix is added: ursa.pl -t complib -M-fno-bin-cg-g_multiple_kernels
[Tests] pre check-in, make smoke, ursa complib, bingen test (from Benjamin Coquelle)
[Reviewers] Brian Sumner, Artem Tamazov, Matthew Arsenault
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#60 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.cpp#37 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.hpp#13 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g_multiple_kernels/MM_Kernels.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/complib.tlst#6 edit
[ROCm/clr commit: d68ce71f32]
EPR #414091 - Compiler Lib/HSAIL: Fix for -fno-bin-cg on multiple kernels
[Problem] If CL or BRIG contains multiple kernels, compilation with option -fno-bin-cg leads to finalizer error.
[Solution] Check that all kernels are finalized before deleting BRIG from BIF. Actual deletion occurs after finalizing the last kernel.
[Misc]
+ fix erroneous successful exit from finalizing BRIG -> ISA function when BRIG is not extracted successfully
+ string constants for symbol prefixes replaced on using findBIF30SymStruct
+ obsolete __AMP_ is removed from code
+ cosmetic changes in hsail_be
+ test for the fix is added: ursa.pl -t complib -M-fno-bin-cg-g_multiple_kernels
[Tests] pre check-in, make smoke, ursa complib, bingen test (from Benjamin Coquelle)
[Reviewers] Brian Sumner, Artem Tamazov, Matthew Arsenault
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#60 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.cpp#37 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.hpp#13 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g_multiple_kernels/MM_Kernels.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg/HelloWorld_Kernel_cl.cl#2 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/complib.tlst#6 edit
EPR #010002 - Change OpenCL version number from 1728 to 1729.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1475 edit
[ROCm/clr commit: 1c804f9643]
EPR #010002 - Change OpenCL version number from 1728 to 1729.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1475 edit
EPR #413091 - created backing store in the maptarget and move the commit SVM memory funciton into alloMaptarget function. Added sync funtion in map so that it can handle mGPU cases.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpumemory.cpp#116 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#205 edit
[ROCm/clr commit: e6c8a9a4bd]
EPR #413091 - created backing store in the maptarget and move the commit SVM memory funciton into alloMaptarget function. Added sync funtion in map so that it can handle mGPU cases.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpumemory.cpp#116 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#205 edit
EPR #413091 - created backing store in the maptarget and move the commit SVM memory funciton into alloMaptarget function. Added sync funtion in map so that it can handle mGPU cases.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpumemory.cpp#116 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#205 edit
[ROCm/clr commit: 12a7fe0d71]
EPR #413091 - created backing store in the maptarget and move the commit SVM memory funciton into alloMaptarget function. Added sync funtion in map so that it can handle mGPU cases.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpumemory.cpp#116 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#205 edit
EPR #010002 - Change OpenCL version number from 1727 to 1728.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1474 edit
[ROCm/clr commit: 4677869ab9]
EPR #010002 - Change OpenCL version number from 1727 to 1728.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1474 edit
EPR #413091 - fixed a bug in the gpukenerl processing, the svm memory object of a kernel argument also needs to be updated writer couting for mGPU support, if the memory object is writable for the kernel.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#276 edit
[ROCm/clr commit: c725bca7c1]
EPR #413091 - fixed a bug in the gpukenerl processing, the svm memory object of a kernel argument also needs to be updated writer couting for mGPU support, if the memory object is writable for the kernel.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#276 edit
EPR #010002 - Change OpenCL version number from 1726 to 1727.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1473 edit
[ROCm/clr commit: 654eccf977]
EPR #010002 - Change OpenCL version number from 1726 to 1727.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1473 edit
ECR #304775 - Back out changelist 1117184
- There is a hang on CPU in conversion test
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#67 edit
[ROCm/clr commit: 31ca701a3e]
ECR #304775 - Back out changelist 1117184
- There is a hang on CPU in conversion test
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#67 edit
EPR #010002 - Change OpenCL version number from 1725 to 1726.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1472 edit
[ROCm/clr commit: ef33fcfcff]
EPR #010002 - Change OpenCL version number from 1725 to 1726.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1472 edit
EPR #010002 - Change OpenCL version number from 1724 to 1725.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1471 edit
[ROCm/clr commit: 2a531ac0ea]
EPR #010002 - Change OpenCL version number from 1724 to 1725.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1471 edit
EPR #410989 - Set globalScratchBuf_ to NULL after it is deleted.
The issue is that scratch buffer will be destroyed again when the transfer queue is destroyed.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#492 edit
[ROCm/clr commit: 6ea7225039]
EPR #410989 - Set globalScratchBuf_ to NULL after it is deleted.
The issue is that scratch buffer will be destroyed again when the transfer queue is destroyed.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#492 edit
ECR #333753 - Compiler Lib/ORCA RT/Performance: BRIG in BIF is not needed anymore for finalizing & executing ISA (except cases with program scope global variables).
[Description] The feature is intended to minimize the binary size for execution.
This is half-hearted solution: If -fno-bin-cg is set, then after ISA finalization all BRIG sections are removed from the binary, but if there are program scope global variables in code, the option is ignored and all BRIG sections retain in binary for further globals allocation & initialization. The complete solution awaits Code Objects implementation.
+ Additionally change fixes Bug 10478.
+ Recompilation steps determination is changed in RT.
+ symBRIGLoaderMap is added to bif_section_labels.
+ RT_CONTAINS_LOADER_MAP is added for aclQueryInfo in order to check symBRIGLoaderMap existance in binary.
+ complib tests are added on -fbin-cg/-fno-bin-cg.
+ ocltst -t complib -M CLEnumCheck is updated.
[Side effects] performance improvement, memory consumption reduction
[TODO] Do the same on .hsa bits.
[Testing] pre check-in, make smoke, complib, ocltst: complib, compiler, runtime, binary
[Reviewer] German Andryeyev
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#59 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/brig_loader.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/hsail_be.hpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/gpu/scwrapper/scClientAPI.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/include/v0_8/aclEnums.h#16 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/bif_section_labels.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/compiler/loader/libloader/loader.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/aoc2/aoc2.cpp#64 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#188 edit
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg-g_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fbin-cg_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg-g_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/src/complib/options/-fno-bin-cg_globals/HelloWorld_Kernel_cl.cl#1 add
... //depot/stg/opencl/drivers/opencl/tests/hsa/tlst/complib.tlst#5 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/complib/CLEnumCheck.cpp#40 edit
[ROCm/clr commit: 84508bb5a4]
foreman
Yair Shachar
Oded Gabbay
Ben Goz