6 Commits

Author	SHA1	Message	Date
Maneesh Gupta	44de3f8309	Merge pull request #346 from scchan/fix_rhel_build ... use assign rather than insert	2018-01-26 06:59:25 +05:30
Siu Chi Chan	8acc8365fa	use assign rather than insert	2018-01-25 16:51:29 +00:00
Kent Knox	0497424978	Fixing rocblas build failure ... with ::Bundled_code_header constructor Disabling hipPrintfKernel test from CI	2018-01-25 10:29:40 -06:00
Alex Voicu	7c0b9a005b	Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.	2017-11-30 03:29:04 +00:00
Alex Voicu	89e9399427	Choose whether or not to use functional grid_launch based on the version of HCC used to compile.	2017-11-29 00:17:44 +00:00
Alex Voicu	c2482d1255	This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.	2017-11-01 15:09:59 +00:00