AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,016 Commits 3 Branches 0 Tags
303e04fa5550009ff3e77fbc329e91cf75e40508
Commit Graph

4311 Commits

Author SHA1 Message Date
Rahul Garg f79ffd587e Fix typo and colon in comment 
[ROCm/clr commit: d9179cbe70]
 2019-09-13 03:09:01 +05:30
Rahul Garg b7a06efb6c [HACK] Temporary fix for hipFree for hipManagedMalloc 
[ROCm/clr commit: 2e9b8e9d0d]
 2019-09-13 02:10:21 +05:30
foreman ebbf31efc0 P4 to Git Change 1997621 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/12 14:16:09 
SWDEV-145570 - Fixed some logging issues regarding hip(Ext)ModuleLaunchXXX.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#40 edit


[ROCm/clr commit: b0b5c92469]
 2019-09-12 14:35:36 -04:00
Evgeny Mankov ab1bbd7eca [HIPIFY] Add unsupported fp16 functions 
[ROCm/clr commit: 4b3889b47e]
 2019-09-12 18:51:25 +03:00
Evgeny Mankov 76cdd624ef [HIPIFY] Add more unsupported device functions 
[ROCm/clr commit: ece8a71bad]
 2019-09-12 17:53:25 +03:00
Evgeny Mankov 54ba179911 [HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h 
[ROCm/clr commit: 905c6383db]
 2019-09-11 18:07:09 +03:00
Evgeny Mankov 38c128b941 Merge pull request #1406 from emankov/master 
[HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)

[ROCm/clr commit: ede7e2a094]
 2019-09-11 15:49:46 +03:00
Evgeny Mankov 4cfb3aa7b7 [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl) 
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);


[ROCm/clr commit: 4e3845be83]
 2019-09-10 15:59:06 +03:00
Aditya Lad 4225ba4c8a Replacment of RENAME command in CMakeLists.txt (#1402) 
[ROCm/clr commit: 4a53718e10]
 2019-09-10 08:35:16 +00:00
foreman dd954b519f P4 to Git Change 1995672 by skudchad@skudchad_rocm on 2019/09/09 14:45:42 
SWDEV-199293 - Fix build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#4 edit


[ROCm/clr commit: 15d819d61f]
 2019-09-09 14:50:37 -04:00
foreman 427ec323d2 P4 to Git Change 1995665 by skudchad@skudchad_test2_win_opencl on 2019/09/09 14:36:57 
SWDEV-199293 - Implement hiprtcGetLoweredName

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17960/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#3 edit


[ROCm/clr commit: f0f4755aae]
 2019-09-09 14:42:47 -04:00
foreman fb96543a7d P4 to Git Change 1994974 by skudchad@skudchad_test2_win_opencl on 2019/09/06 19:09:36 
SWDEV-199293 - Implement some hipRTC apis.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17953/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#2 edit


[ROCm/clr commit: 9a839c46dc]
 2019-09-06 19:11:43 -04:00
Evgeny Mankov 755d1a9ea6 [HIPIFY] Add device functions support 
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.


[ROCm/clr commit: aec10d6ee1]
 2019-09-06 18:34:12 +03:00
foreman 95c0f07e54 P4 to Git Change 1994498 by skudchad@skudchad_test2_win_opencl on 2019/09/06 04:25:22 
SWDEV-202136 - Fix windows build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#26 edit


[ROCm/clr commit: 860615b64d]
 2019-09-06 04:33:24 -04:00
foreman 8eafceb663 P4 to Git Change 1994199 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/09/05 16:35:36 
SWDEV-202136 - Fix typos in `hip_hcc.def.in`.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#25 edit


[ROCm/clr commit: 0322bfd64f]
 2019-09-05 16:45:19 -04:00
foreman e5570ea1ca P4 to Git Change 1994120 by axie@axie-hip-pal on 2019/09/05 14:22:40 
SWDEV-201667 - Linker errors when using hipArrayCreate and hipMemcpyParam2D

	Tests:
	In Windows 10, the linker errors has been fixed with this code change.
	http://ocltc.amd.com:8111/viewModification.html?modId=125600&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17943/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#24 edit


[ROCm/clr commit: 53d56a3843]
 2019-09-05 14:34:47 -04:00
foreman 46e691878d P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44 
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.

	Tests:
	The sample code can be built without linkage error.
	http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17942/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit


[ROCm/clr commit: 599f0b1c93]
 2019-09-05 14:30:10 -04:00
foreman bcde771762 P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26 
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit


[ROCm/clr commit: cd5c37bb4a]
 2019-09-05 14:12:32 -04:00
Jeff Daily 42c49b6ba9 fix bug where HIP_DB=1 seg faults at startup (#1388) 
[ROCm/clr commit: 3d7c146296]
 2019-09-05 10:04:19 +00:00
mhbliao b55c3dba08 [hip] Stop using noduplicate and replace it with convergent. (#1390) 
[ROCm/clr commit: d511c3e363]
 2019-09-05 10:03:43 +00:00
Paul Fultz II a61aaacbca Use hcc when building with hcc compiler (#1225) 
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME


[ROCm/clr commit: d359cd4449]
 2019-09-05 10:03:04 +00:00
Evgeny Mankov b6c6ecab67 [HIPIFY][cmake][#1394] Fix 
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7


[ROCm/clr commit: a847247d9a]
 2019-09-05 12:08:56 +03:00
Evgeny Mankov 8dfefa1f9a [HIPIFY][perl] Code cleanup (preparation for generating) 
[ROCm/clr commit: f114a79462]
 2019-09-05 11:52:59 +03:00
foreman e3a5206b3e P4 to Git Change 1993529 by skudchad@skudchad_rocm on 2019/09/04 17:08:05 
SWDEV-199293 - Initial API checkin and sym export defines

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#1 add


[ROCm/clr commit: 132d10a98a]
 2019-09-04 17:16:03 -04:00
Evgeny Mankov a9d5b1e29e [HIPIFY][perl] Sync hipify-perl with hipify-clang 
Sync by means of semi-automatic generation: hipify-clang -perl


[ROCm/clr commit: 0ca6525d90]
 2019-09-04 17:07:45 +03:00
Evgeny Mankov 73e71db792 [HIPIFY][perl] Code cleanup and formatting 
[ROCm/clr commit: 7ab9afe513]
 2019-09-04 16:37:26 +03:00
Evgeny Mankov 790ab87461 [HIPIFY][perl][#259] Fix 
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );


[ROCm/clr commit: e26ec02a99]
 2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu 732c9829c1 Do not include cuda wappers for OMP for hip-clang (#1382) 
[ROCm/clr commit: e72346dc24]
 2019-09-03 05:13:59 +00:00
Rahul Garg 33af62d66e Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381) 
This reverts commit 4313f00563.

[ROCm/clr commit: d433f6fb58]
 2019-09-03 05:13:46 +00:00
Nicholas Malaya 85c3f035e4 Fix Broken Link in hip_porting_guide (#1376) 
The math library equivalents between CUDA-HIP are broken. This is a key feature for converting to AMD hardware. This fix corrects the broken link and moves the library equivalents to sit under the "Porting a New Cuda Project" header.

[ROCm/clr commit: 796b8aafd7]
 2019-09-03 05:13:35 +00:00
Sarbojit2019 e0f1719c1b Removed hipLaunchKernel macro got missed in Merge (#1374) 
[ROCm/clr commit: 4d270775c8]
 2019-09-03 05:13:07 +00:00
Evgeny Mankov 88a6eadbb6 [HIPIFY][doc] Update README.md (testing, versions) 
[ROCm/clr commit: d9b5e2f74a]
 2019-09-02 18:18:43 +03:00
Evgeny Mankov 12efe906e7 [HIPIFY][tests] Add occupancy test 
[ROCm/clr commit: 608331250e]
 2019-09-02 17:54:06 +03:00
Evgeny Mankov 46373a3631 [HIPIFY][fix] Fix for upcoming LLVM 10.0 
[ROCm/clr commit: 8eb7d53cec]
 2019-09-01 18:15:03 +03:00
Sameer Sahasrabuddhe 929b6d5f34 remove obsolete test for OCKL Asynchronous Streams 
The implementation for OCKL AS was recently removed from the device
library since that feature is now superseded by hostcall.


[ROCm/clr commit: 68c133bd78]
 2019-08-30 20:41:29 +05:30
foreman 9692cdb9f2 P4 to Git Change 1991227 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/29 17:26:37 
SWDEV-193938 - [HIP] Use fine grained pool for hipHostRegister

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#43 edit


[ROCm/clr commit: 8ea92c83f0]
 2019-08-29 17:35:38 -04:00
Evgeny Mankov 56b05d61e1 [HIPIFY][DNN] cuDNN 7.6.3 support 
[ROCm/clr commit: a0a98790f0]
 2019-08-29 19:55:38 +03:00
Evgeny Mankov 2b87d21227 Merge pull request #1372 from emankov/master 
[HIPIFY][#207][fix] Translate all preprocessor's conditional blocks

[ROCm/clr commit: 451721a821]
 2019-08-29 10:30:05 +03:00
Yaxun (Sam) Liu e5a61a51de Fix sample 11_texture_driver for hip-clang (#1370) 
[ROCm/clr commit: 793b18c0b1]
 2019-08-29 01:03:20 +00:00
Yaxun (Sam) Liu 0a81b64a19 Do not change opt level for -g for hip-clang (#1369) 
Currently hipcc uses -O3 for hip-clang by default but uses -O0 if -g is used. This
causes surprise for users since -g should not affect default opt level.

[ROCm/clr commit: 19a9b15306]
 2019-08-29 01:03:11 +00:00
Sarbojit2019 15b80a759d Updated hipErrorString and CUDAErrorTohipError (#1365) 
[ROCm/clr commit: b5ff9e71ed]
 2019-08-29 01:02:59 +00:00
Sarbojit2019 4d23e35532 [HIP] Reclaiming hipLaunchKernel API (#1353) 
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/clr commit: 1ae43cbeba]
 2019-08-29 01:02:41 +00:00
satyanveshd 0e4701d59f [sample] add new cookbook sample - occupancy (#1352) 
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments


[ROCm/clr commit: d2df21e58c]
 2019-08-29 01:01:49 +00:00
mshivama 757aa67a43 Device side support for Cooperative Group feature (#1202) 
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support


[ROCm/clr commit: f74903851e]
 2019-08-29 01:01:25 +00:00
Evgeny Mankov 65ba03dd4c [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks 
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly


[ROCm/clr commit: 32f22a0117]
 2019-08-28 21:17:35 +03:00
Evgeny Mankov 676c4b5bd4 [HIPIFY][cmake] Minor refactoring 
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions


[ROCm/clr commit: e3eb62ac4b]
 2019-08-28 20:40:10 +03:00
foreman 649d08488c P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36 
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit


[ROCm/clr commit: 534727cd01]
 2019-08-27 20:26:25 -04:00
Maneesh Gupta cb3803e423 [packaging] update soft-links that already exist (#1364) 
Change-Id: Ibe9840802b1765094ef998edf2210e95404cb989

[ROCm/clr commit: b92c16f4d9]
 2019-08-26 23:41:14 -04:00
foreman 9a2f5614de P4 to Git Change 1989149 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 15:30:45 
SWDEV-188177 - Adding ihipTexture APIs to hip_hcc.def.in

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#21 edit


[ROCm/clr commit: d0edeaf3cf]
 2019-08-26 15:44:58 -04:00
foreman b83152ea03 P4 to Git Change 1989089 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 14:24:21 
SWDEV-198194 - Delete vars at __hipUnregisterFatBinary.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#40 edit


[ROCm/clr commit: 441eefa78b]
 2019-08-26 14:32:48 -04:00