324a5519b9
SWDEV-563842 - Fix Memory Address Offset Bug ( #1749 )
...
* SWDEV-563842 - Fix Memory Address Offset Bug
* Revert "SWDEV-563842 - Fix Memory Address Offset Bug"
This reverts commit 477958dc48300ee1fe0166aa6f0d3d8125b91f5e.
* SWDEV-563842 - Fix Memcpy Address Offset Bug
* SWDEV-563842 - Find Memcpy Device Address Offset
* Revert "SWDEV-563842 - Find Memcpy Device Address Offset"
This reverts commit 6c75a9e5b58b7dfabb9e3f91fa3dd892d42639cc.
* Revert "SWDEV-563842 - Fix Memcpy Address Offset Bug"
This reverts commit 0b89072a988074aa4da4e8fc7ba04c554f31ed44.
* SWDEV-563842 - MemObjMap_ Offset Support
This patch fixes the buffer offset handling bug.
* Revert "SWDEV-563842 - MemObjMap_ Offset Support"
This reverts commit 37fce3382465e3420721e5277377f943ec2b30a1.
* SWDEV-563842 - External Memory Buffer View
2025-11-09 12:52:35 -08:00
7580052878
SWDEV-564318 - Add support for allocating uncached device memory ( #1670 )
2025-11-09 12:51:41 -05:00
99cab3500d
SWDEV-561284 - Fix use of uninitialized memory in Unit_hipMemVmm_Basic and Unit_hipMemVmm_Uncached ( #1677 )
2025-11-09 12:12:24 +00:00
738bb19835
clr: Increase kernelArg/managedBuffer size ( #1586 )
...
* Increase the buffer to 4MB. That can help kernel launches limited by a deep kernel pipeline
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com >
2025-11-08 18:32:43 -08:00
2f9017f706
Fix build failure with Clang 20. ( #1667 )
...
* Modified for Clang
* Updated timemory version so it compiles with Clang 20
* Using TBB version 2018.6 for both GCC and Clang builds
2025-11-08 11:36:12 -05:00
93947241d0
SWDEV-556684 - HSAIL cleanup ( #1657 )
2025-11-08 02:22:03 -08:00
5dd15e22ca
SWDEV-559514 - Add queue validation to submitMarker sync path ( #1308 )
2025-11-08 02:21:36 -08:00
f7ffcd1402
clr: SWDEV-547890 - Bump PAL API version to 954 ( #1680 )
...
* clr: Adjust call to ICmdBuffer::CmdCopyMemoryToImage for PAL >= 955
PAL starting versino 955 adds a new argument to
ICmdBuffer::CmdCopyMemoryToImage. Adjust teh callsite to account
fort his.
* clr: Handle new GpuUtil::TraceSessionState cases for PAL >= 939
Starting PAL API version 939, GpuUtil::TraceSessionState changes its
possible values. Adjust for it.
* clr: require PAL version 954
Bump the PAL required vesion to 954, as this is required for proper
debugger support.
2025-11-08 00:52:04 +00:00
0325de6538
[ROCm Systems Profiler] Path issue note added to Profiling python script ( #1766 )
...
* Note added to Profiling python script
* Doxygen reverted
* Update projects/rocprofiler-systems/docs/how-to/profiling-python-scripts.rst
Co-authored-by: David Galiffi <David.Galiffi@amd.com >
---------
Co-authored-by: David Galiffi <David.Galiffi@amd.com >
2025-11-07 18:49:23 -05:00
291ff6c468
SWDEV-558855 - Enable Interop Map Buffer on Windows ( #1748 )
...
* Support Windows HANDLE in interop_map_buffer
* Refactored Windows HANDLE in interop_map_buffer
* ROCr System Dependent Handle Type
* Fix for ROCr Handle Conversion Bug
* Remove Windows Header
2025-11-07 12:47:01 -08:00
2006a411e5
SWDEV-561611 - fix codeql errors by increasing printf buffer sizes ( #1507 )
...
* SWDEV-561611 - fix codeql errors by increasing printf buffer sizes
* Replace sprintf with snprintf to prevent potential buffer overflow
---------
Co-authored-by: cadolphe-amd <chris.adolphe@amd.com >
2025-11-07 15:42:56 -05:00
de3b7322f2
rocr/hsakmt: Fix asan compile errors - KFDQMTest ( #1638 )
...
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com >
2025-11-07 14:52:36 -05:00
48cb61f378
rocr: Separate Linux coredump implementation ( #1588 )
...
Remove libamdhsacode/win32/elf.h due to license restrictions.
Separate Linux coredump implementation because we do not have the ELF
definitions on Windows.
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com >
2025-11-07 14:52:08 -05:00
e6fc009b28
SWDEV-552584 fix racy null pointer exception for ompt_callback_task_schedule for ompt-task_early_fulfill tasks ( #980 )
...
* Fix for SWDEV-552584
Two calls to ompt_callback_task_scheduled were issued for the same
prior task. One of them was ompt_task_complete, which causes
internal storage to be release and a pointer zeroed. The other
was ompt_task_early_fulfill, which attempted to reference the
pointer. The callbacks could come in any order as they were
from different threads, thus causing a null pointer
dereference on occasion. The code was changed to do nothing
for the early_fulfill. Additional null pointer checks were
added.
* formatting
* Update ompt.cpp
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
---------
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-11-07 12:15:48 -06:00
d9b00da102
Add clean up of buffered_storage files ( #1738 )
...
* Add clean up of buffered_storage files
* Add step to workflows to test for remaining temp files after tests
* Applied suggestions from code review
* add deletion of all cache files
---------
Co-authored-by: David Galiffi <David.Galiffi@amd.com >
2025-11-07 11:51:09 -05:00
30785f8d18
rocr: Assume KFD in hsa_amd_interop functions ( #1138 )
2025-11-07 09:38:06 -06:00
a9082a7158
ROCpd schema fetching from rocprofiler-sdk ( #1501 )
...
- Integrate rocprofiler-systems with rocprofiler-sdk-rocpd to fetch schema
- If rocprofiler-sdk-rocpd is not availabe, use embedded schema files. With this we provide rocpd format support even if ROCm is not available
- Include detection in CMake if rocprofiler-sdk-rocpd package is available (and valid), and build database class upon that
- Update embedded schema that is used as a fallback.
- Update some validation tests to account for schema changes.
2025-11-07 09:45:29 -05:00
b299eece9b
Fix bug in rocprof-compute parsing ( #1664 )
...
Were not handling the case where the eval result is None e.g. some
columns have a peak value, but it is unused, so we use 'None', which
evaluates to the None object.
Return empty string in this case.
2025-11-07 09:33:43 -05:00
fabdab7aa4
[aqlprofile] Adding Strix Halo support ( #1477 )
...
* Adding Strix Halo support
* copilot review feedback
* Addressing feedback
2025-11-07 00:46:17 -06:00
06bf110c84
Adding counters support for strix halo ( #1358 )
...
* Adding counters support for strix halo
* Updated coutners list
* Added missing counter info
* Updated arch support
2025-11-07 00:45:03 -06:00
6e195ded9b
Update rocprofiler_config_interfaces.cmake to use different elf naming ( #1722 )
...
* Update rocprofiler_config_interfaces.cmake to use different elf naming
* try out conditional for libelf
* run cmake-format to fix formatting issue
* Remove libelf.patch file from therock-ci-windows.yml
* Remove libelf patch from therock-ci-linux.yml as well
2025-11-06 23:50:02 -05:00
590c6c3b4f
fix: null pointer after delete in get_stream_id ( #1720 )
2025-11-06 23:43:34 -05:00
90d5dc6b3a
SWDEV-564408 - Reduces hip-tests runtime Pt 1 ( #1695 )
...
* SWDEV-564408 - Reduces hip-tests runtime Pt 1
* Update cmd_options.hh
2025-11-06 13:45:36 -08:00
fdb557c88a
[Systems-Profiler] Officially unsupported OS removed ( #1740 )
...
* Fedora and CentOS removed
* David's feedback incorporated
Co-authored-by: David Galiffi <David.Galiffi@amd.com >
---------
Co-authored-by: David Galiffi <David.Galiffi@amd.com >
2025-11-06 16:06:28 -05:00
f4d0aeb8f3
Adjust host thread count for OpenMP-VV tests ( #1742 )
...
Reducing test time
2025-11-06 16:04:47 -05:00
3bb8c2ac50
SWDEV-564392 - Clean up image tests ( #1694 )
...
Remove unnecessary checking.
Enable all disabled tests.
Move Mipmap test files into Windows section.
2025-11-06 15:07:53 -05:00
37bbb58a19
[rocprof-compute] fix unit regex 'ns' in analyze mode ( #1689 )
...
* fix unit regex in analyze mode
* ruff format
2025-11-06 11:13:10 -05:00
0ad05ed515
SWDEV-556947 - Parse the HIP version from the Git tag ( #1135 )
2025-11-06 10:18:26 +01:00
478cee0f68
SWDEV-559525 - Add the HIP_POINTER_ATTRIBUTE_IS_LEGACY_HIP_IPC_CAPABLE attribute support ( #1647 )
...
* SWDEV-559525 - Add the HIP_POINTER_ATTRIBUTE_IS_LEGACY_HIP_IPC_CAPABLE attribute implementation
* Update indentation in hip_memory.cpp
2025-11-06 12:07:32 +05:30
ea31a0bf18
rocprofiler-sdk: fix per-record group_by_queue scoping ( #1676 )
...
* rocprofiler-sdk: fix per-record group_by_queue scoping
* added under resolved issues to CHANGELOG.md
---------
Co-authored-by: David Galiffi <David.Galiffi@amd.com >
2025-11-05 21:46:44 -05:00
c877be2afe
rocr: make sure the member variable is conctructed ( #1387 )
...
Signed-off-by: Alex Xie <AlexBin.Xie@amd.com >
2025-11-05 17:19:33 -05:00
280cda3196
clr: SWDEV-547890 - Maintain an MQD for the emulated AQL queue ( #1669 )
...
* clr: SWDEV-547890 - Maintain an MQD for the emulated AQL queue
To simplify the shader debugger implementation, maintain the relevant
parts of the emulated AQL queue's MQD (amd_queue_t): read_dispatch_id,
write_dispatch_id, compute_tmpring_size.
With this MQD, the shader debugger can handle the emulated AQL queue
the same way it does the real AQL queue, no specialization is required.
* clr: SWDEV-547890 - Conservatively update the MQD's read_dispatch_id
The read_dispatch_id cannot be smaller than the current aql_packet_id
- hsa_queue.size for the debugger to work correctly.
The read_dispatch_id really should be updated when the CmdBuf is marked
as complete. Left a FIXME to address it in a future commit.
---------
Co-authored-by: Laurent Morichetti <laurent.morichetti@amd.com >
2025-11-05 17:39:33 +00:00
8797bb0150
Revert "SWDEV-562996 - Build fix: Ubertrace callback calling convention mismatch on x86 ( #1587 )" ( #1717 )
...
This reverts commit 8d31383dfe
2025-11-05 11:48:02 -05:00
eded1f3529
rocrtst: Add check for SVM support in Runtime ( #1687 )
...
Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com >
Approved-by: David Yat Sin <David.YatSin@amd.com >
2025-11-05 11:36:38 -05:00
3b1c0c3464
SWDEV-558845 - Support image in rocr on Windows ( #1582 )
...
Enable image build in Windows.
Remove some useless codes that fail building in Windows.
Some minor improvement.
Temporarily exclude mipmap test files.
Prevent negative tests affect some tests.
Move some catch info log codes into failed cases.
2025-11-05 09:33:41 -05:00
16334bc15d
SWDEV-525244 - Additional graph validation test ( #584 )
...
* SWDEV-525244 - Additional graph validation test
* SWDEV-525244 - Change capture mode to relaxed
* SWDEV-525244 - Additional comments
---------
Co-authored-by: Vladana Stojiljkovic <Vladana.Stojiljkovic@amd.com >
2025-11-05 09:32:47 +01:00
18d4fc460b
SWDEV-541362 - Fix error code mismatch in test ( #1377 )
2025-11-05 09:31:30 +01:00
7d078b9875
SWDEV-553920 - Fix Unit_hipStreamCreateWithPriority_ValidateWithEvents ( #1622 )
2025-11-05 09:31:01 +01:00
8d31383dfe
SWDEV-562996 - Build fix: Ubertrace callback calling convention mismatch on x86 ( #1587 )
...
Co-authored-by: Rakesh Roy <137397847+rakesroy@users.noreply.github.com >
2025-11-05 10:37:45 +05:30
78e9e47852
SWDEV-551244 - Fixes CUDA 13 compilation issues ( #1237 )
2025-11-04 16:56:49 -08:00
fdbafd7757
Revert "SWDEV-554372 - Add 3 HIP_GET_PROC_ADDRESS_xxx flags ( #1057 )" ( #1690 )
...
Reverts ROCm/rocm-systems#1057
Suspected of breaking the build, see https://github.com/ROCm/rocm-systems/pull/1057#issuecomment-3487715129
Logs: https://github.com/ROCm/rocm-systems/actions/runs/19062134668/job/54444052479#step:12:315
```
[rocprofiler-sdk] FAILED: source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o
[rocprofiler-sdk] ccache /opt/rh/gcc-toolset-12/root/usr/bin/c++ -DAMD_INTERNAL_BUILD=1 -DGLOG_USE_GLOG_EXPORT -DROCPROFILER_DL=1 -DROCPROFILER_HAS_GHC_LIB_FILESYSTEM=1 -DROCPROFILER_SDK_USE_SYSTEM_RCCL=0 -DROCPROFILER_SDK_USE_SYSTEM_ROCDECODE=0 -DROCPROFILER_SDK_USE_SYSTEM_ROCJPEG=0 -DUSE_PROF_API=1 -DYAML_CPP_STATIC_DEFINE -D__HIP_PLATFORM_AMD__=1 -Drocprofiler_EXPORTS=1 -I/__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/source/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/yaml-cpp/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/ptl/source -I/__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/external/ptl/source -isystem /__w/rocm-systems/rocm-systems/TheRock/build/core/clr/dist/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/core/ROCR-Runtime/dist/include -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/filesystem/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/external/glog -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/glog/src -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/fmt/include -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/elfio -isystem /__w/rocm-systems/rocm-systems/TheRock/build/compiler/amd-comgr-stub/dist/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/libdrm/build/stage/lib/rocm_sysdeps/lib/pkgconfig/../../include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/libdrm/build/stage/lib/rocm_sysdeps/lib/pkgconfig/../../include/libdrm -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/elfutils/build/dist/lib/rocm_sysdeps/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -W -Wall -Wno-unknown-pragmas -faligned-new -rdynamic -fstack-protector-strong -Wstack-protector -MD -MT source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o -MF source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o.d -o source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o -c /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/abi.cpp
[rocprofiler-sdk] In file included from /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/abi.cpp:26:
[rocprofiler-sdk] /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/common/abi.hpp:62:27: error: static assertion failed: size of the API table struct has changed. Update the STEP_VERSION number (or in rare cases, the MAJOR_VERSION number)
[rocprofiler-sdk] 62 | sizeof(TABLE) == ::rocprofiler::common::abi::compute_table_offset(NUM), \
```
2025-11-04 14:29:58 -08:00
811609c0e1
SWDEV-523137 - Fix and enable a few negative tests on NV ( #1157 )
2025-11-04 23:28:11 +01:00
4b0fb2cdf5
Rename "corr_id" to "stack_id" in Perfetto annotations to match new n… ( #1618 )
...
* Rename "corr_id" to "stack_id" in Perfetto annotations to match new naming in schema.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
* correlation_id.ancestor was not added until ROCPROFILER_VERSION 1.0
---------
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
2025-11-04 14:20:11 -05:00
6356c179ff
[ROCm Systems Profiler] 7.1.0 Formatting updated for understanding rocpd output docs" ( #1663 )
...
* Formatting udpated for ROCm Systems rocpd docs"
* Minor change
* Formatting in profiler script fixed"
* Sphinx warnings and formatting fixes
* Formatting fixed
* Formatting fixed
* Collapsible code block added
* Dixygne change reverted
2025-11-04 12:48:02 -05:00
9d84958527
JSON profiler option removed ( #1649 )
2025-11-04 17:49:22 +01:00
757de39caa
Updated amdFileRead/Write in rocdevice to support windows build ( #1435 )
...
* Updated amdFileRead in rocdevice to support windows build
* Updated amdFileRead in rocdevice to support windows build
2025-11-04 10:03:03 -05:00
7573fa168d
SWDEV-554372 - Add 3 HIP_GET_PROC_ADDRESS_xxx flags ( #1057 )
2025-11-04 00:16:12 -08:00
fb006546d0
SWDEV-1 - Fix a typo ( #1615 )
...
* SWDEV-1 - Fix a typo
Fix a typo.
Remove unnecessary log.
* Removing patch
---------
Co-authored-by: geomin12 <geomin12@amd.com >
Co-authored-by: Scott Todd <scott.todd0@gmail.com >
2025-11-03 12:59:00 -08:00
d411d101fb
SWDEV-557363 - Fix and enable Unit_hipWallClock64_Positive_Basic ( #1223 )
2025-11-03 21:08:33 +01:00
1ccc0ce2e4
SWDEV-555299 - Fix and enable Unit_Device_modf_modff_Negative_RTC ( #1012 )
2025-11-03 21:08:09 +01:00
Jin Jung
Victor Zhang
Gerardo Hernandez
SaleelK
ajanicijamd
Pengda Xie
lancesix
Pratik Basyal
Jimbo
David Yat Sin
Larry Meadows
Milan Radosavljevic
Yiannis Papadopoulos
Ben Richard
Gopesh Bhardwaj
Jason Bonnell
habajpai-amd
Sourabh U Betigeri
Kian Cossettini
MachineTom
jamessiddeley-amd
marandje
Satyanvesh Dittakavi
Xie, AlexBin
Rakesh Roy
Apurv Mishra
systems-assistant[bot]
vstojilj
pcritchl-amd
Scott Todd
David Galiffi
Sam Ruscica
Todd tiantuo Li