Commit-Graf

12005 Incheckningar

Upphovsman SHA1 Meddelande Datum
Todd tiantuo Li 3445b57a43 SWDEV-438503 - Always report hipDeviceAttributeUnifiedAddressing as true.
Change-Id: I3119bd8f99c079280bde1ba32b3d26b474899e7d


[ROCm/clr commit: 60549b101c]
2024-02-05 05:08:11 +00:00
Ioannis Assiouras 9c47344647 SWDEV-443109 - Fix for CXX compiler check in hip-config-amd.cmake
Change-Id: Ib6b8bc59a889ad2e4f440e847d9f2e7e8fb2cda2


[ROCm/clr commit: f28b1f1f1d]
2024-02-05 05:08:11 +00:00
German Andryeyev 8b3c505b6f SWDEV-440746 - Remove pending dispatch check for SDMA P2P
Change-Id: I7290345cfc60cd878fb39a06b03105441793c27b


[ROCm/clr commit: 842eda5e7f]
2024-02-05 05:08:11 +00:00
German Andryeyev 650978eccc SWDEV-404889 - Switch to FreezeExecutable()
Debugger support requires FreezeExecutable() call inside the loader interface.

Change-Id: Iff01840a5980500d8d51da8d73c3f24b2960c44a


[ROCm/clr commit: dcd2fcff16]
2024-02-05 05:08:11 +00:00
Sameer Sahasrabuddhe ebcecf1f4f SWDEV-295298: hide warp sync builtins with a macro in ROCm 6.1
Change-Id: Ie2efd233c0bcf8ad0e06223ee854fe4bd1060443


[ROCm/clr commit: d80168eb87]
2024-02-05 05:08:11 +00:00
cadolphe bd399106ae SWDEV-368741 - Check for uninstalled hsa-amd-aqlprofile to avoid Segmentation Fault
Change-Id: I0c0c7a2ea7c35237332ddd7c2461e4d9ff8e2f1c


[ROCm/clr commit: 243b86dd23]
2024-02-05 05:08:11 +00:00
Satyanvesh Dittakavi f6ea7f732b SWDEV-440029 - Fix hipMemcpyFrom/ToSymbol directions allowed
Change-Id: Ib0b3d737cd5d297ac2d3c1ba549902b96e29c18c


[ROCm/clr commit: 9fd8b4d3f1]
2024-02-05 05:08:11 +00:00
Ajay ca50750dae SWDEV-440718 - Suffix hip bin name with _6.
Link to amd_comgr_2.dll

Change-Id: I5d21af0cc91f2082099273f75ebe1c3279b6365d


[ROCm/clr commit: b53fcb4d02]
2024-02-05 05:08:11 +00:00
Anusha GodavarthySurya 3dc533e1e1 SWDEV-439628 - hipGraphExecKernelNodeSetParams to update graph kernel node params with graph performance optimizations.
During hipGraphExecKernelNodeSetParams kernel function can also be updated.
Hence size required for kernel parameters differs from what is allocated during graphInstantiation.
So, create new 128KB kernel pool and allocate kernel args from the pool.
If the pool is full create new 128KB pool. Release kernel pools when graph exec object is destroyed.

Change-Id: I9567946d63400c79cbfd4c5439c654c92557ceae


[ROCm/clr commit: e9957151f3]
2024-02-05 05:08:11 +00:00
Anusha GodavarthySurya 401a2635ba SWDEV-439637 - Fix undefined symbol error(github id- #3382)
Change-Id: Ic7812e21618f48c737ce2c51b22a153099cc5d66


[ROCm/clr commit: 242132caa7]
2024-02-05 05:08:11 +00:00
Jatin Chaudhary c0c2767eba SWDEV-425605 - remove exe_options, it was unused
Change-Id: I0651f6a836d2f063caf651520de96d7675428771


[ROCm/clr commit: aacdb00759]
2024-02-05 05:08:11 +00:00
German Andryeyev 411efd9ddf SWDEV-441482 - Add missing entry point
hipDestroyExternalSemaphore_fn was missing initialization

Change-Id: Ieab019afd0a0c62a2aa534fb262436edda3499db


[ROCm/clr commit: 2dac58e372]
2024-02-05 05:08:11 +00:00
Jatin Chaudhary 0711781d2d SWDEV-425605 - Add new comgr compile to reloc
use AMD_COMGR_ACTION_COMPILE_SOURCE_TO_RELOCATABLE action
to compile source to realoc. Currently we have source->bc,
link->bc and bc->realoc. This new action replaces the
three steps with one.

Change-Id: I8089cbef681e079702fefc2d2085a23bc3578d02


[ROCm/clr commit: f017777a97]
2024-02-05 05:08:11 +00:00
German Andryeyev cffd87fc79 SWDEV-311271 - Move mempool clean-up into hipEventSynchronize
Generic event synchronize can be called from mempool implementation directly.

Change-Id: Id66ab9cdab486390df4dd405a4ac291eb0bb568f


[ROCm/clr commit: 140a075b6a]
2024-02-05 05:08:11 +00:00
Ranjith Ramakrishnan c1eb5bccfb SWDEV-441937 - Use the disable linemarker option for generating the precompiled header file hipRTC
The precompiled header files have hard coded paths in comments. Using the disable linemarker option(-P) will skip the generation of comments

Change-Id: Ifb134052996c343f5405e954784b4b2c286c36b1


[ROCm/clr commit: f9545675cb]
2024-02-05 05:08:11 +00:00
Alex Xie 2fa724e0bd SWDEV-433820 - Optimize queue initialization (ROCM)
Change-Id: I0619a9f66ae3d64a0f3fc36384f46adb302e725d


[ROCm/clr commit: 5e1de3cc26]
2024-02-05 05:08:11 +00:00
German Andryeyev 7e7e4b93ee SWDEV-311271 - Add extra logic to reduce memory usage
Add logic to prevent significant grow of reserved memory in mempool.

Change-Id: If034433c26e904e3037200a593ef338896d7f16d


[ROCm/clr commit: cd59d971f0]
2024-02-05 05:08:11 +00:00
Ioannis Assiouras e97c777df1 SWDEV-442421 - Fixed case where hipIpcGetMemHandle erroneously returns hipSuccess
Change-Id: Ie322a1a0165111d2ca129e68f49b54fe93aa088e


[ROCm/clr commit: b5fadf9cd1]
2024-02-05 05:08:11 +00:00
Vikram 8c3ab15f37 SWDEV-420140 - Prefer forward slashes for path seperators in compiler RT path with windows
Certain build systems such as NMake seem to interpret backslashes as escapes.

Change-Id: Ifc04d9427148e83084efb1af94a1ce85cb2a6c4e


[ROCm/clr commit: cec5f0b704]
2024-02-05 05:08:11 +00:00
Ioannis Assiouras a6ae01bcd1 SWDEV-433312 - Return invalidArgument in cuMemSetAccess for hipMemAccessFlagsProtRead
Change-Id: I8e5c460ac310ad32849359720a40fc5131d4f32c


[ROCm/clr commit: 853b293983]
2024-02-05 05:08:11 +00:00
Jatin Jaikishan Chaudhary 3e3ca21c09 Revert "SWDEV-425605 - Add new comgr compile to reloc"
This reverts commit b26fdcc77c2aa20f39f7dec9afa24e755d2c03f5.

Reason for revert: breaks windows-psdb

Change-Id: I8b2fcaf0d0be09a9364e386127cabafb68a67e0d


[ROCm/clr commit: baf61b6a02]
2024-02-05 05:08:11 +00:00
Ioannis Assiouras 4e5d704c0c SWDEV-442126 - Fix use_after_free case in ExtractFatBinaryUsingCOMGR
Change-Id: Ie07cf82025b65e4f95d4ce3cf46a6b8081f29b6a


[ROCm/clr commit: c4b9442fc4]
2024-02-05 05:08:11 +00:00
kjayapra-amd 9bff044c87 SWDEV-437832 - Adding device property to check if the device is accelerator.
Change-Id: I8349e99c03422c268bbb60a8c143bd492d9cec09


[ROCm/clr commit: b366a7c992]
2024-02-05 05:08:11 +00:00
Anusha GodavarthySurya 49e684361f SWDEV-422207 - Added debug env to dump graph during Instantiation
Change-Id: Ibde2ae5b8d240f3986bcd168facc513a319c0f17


[ROCm/clr commit: 0a055f874b]
2024-02-05 05:08:11 +00:00
Jatin Chaudhary 624a548b9a SWDEV-425605 - Add new comgr compile to reloc
use AMD_COMGR_ACTION_COMPILE_SOURCE_TO_RELOCATABLE action
to compile source to realoc. Currently we have source->bc,
link->bc and bc->realoc. This new action replaces the
three steps with one.

Change-Id: I6ba551b8d04c7e06f41c4324026e4dcd2db1970f


[ROCm/clr commit: ea1487d84d]
2024-02-05 05:08:11 +00:00
Lang Yu 2860991fb4 SWDEV-439419 - Unlock host ptr when device ptr equals host ptr
hsa_amd_memory_lock_to_pool() and hsa_amd_memory_unlock()
should be called balanced.

Change-Id: I8b1549861bff752aabbb6399d717d1e346079a38
Signed-off-by: Lang Yu <Lang.Yu@amd.com>


[ROCm/clr commit: cc29df873a]
2024-02-05 05:08:11 +00:00
Ioannis Assiouras e79d60996c SWDEV-441201,SWDEV-441727 - Move BlitProgram creation after trap handler build
Change-Id: I89199ccc4bdf79940dc6693e07c03115c52bf613


[ROCm/clr commit: 5d322c027a]
2024-02-05 05:08:11 +00:00
Lang Yu b1584ed8d1 SWDEV-441065 - Fix device accessable host memory copy path
Change-Id: Ia6b9a428da7b54819fb3be928a33cdffcd04ecdf
Signed-off-by: Lang Yu <Lang.Yu@amd.com>


[ROCm/clr commit: 6af1c419ce]
2024-02-05 05:08:11 +00:00
Jatin Chaudhary f6fe357508 SWDEV-431367 - fix float compare for atomicMax/Min where -0.0 < +0.0
Change-Id: Ief99aac3775b0a0c6372215e5a0a9ecbbdca4ca5


[ROCm/clr commit: a01257f000]
2024-02-05 05:08:11 +00:00
Ioannis Assiouras b72a7113fb SWDEV-432599 - Added null checks for rocMemory ptrs in copyMemory
Change-Id: I8ccda2c915dad22c4ea67556dfaab9ba47770069


[ROCm/clr commit: 28743d8dbd]
2024-01-18 15:48:30 -05:00
Satyanvesh Dittakavi 62fbe82c51 SWDEV-435750 - Make threadIdx, blockIdx compatible with CUDA
Change-Id: If0bd2c2c72e8418e30b5a202d9c10da334eff75e


[ROCm/clr commit: 0f9f8b52da]
2024-01-18 02:16:15 -05:00
Jaydeepkumar Patel 5b6349bb60 Revert "SWDEV-359287 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options."
This reverts commit 1b05247a03.

Reason for revert: Waiting for staging results before finally merging it.

Change-Id: Iaabb510325f50147f368108e98531291217627c0


[ROCm/clr commit: 77be355fd9]
2024-01-18 01:29:31 -05:00
Rahul Manocha 3b42f3c995 SWDEV-421025 - Graph Kernel Node priority Attribute Set/Get
Change-Id: I5c422728aa694c8dabb5cf9bade441101512a249


[ROCm/clr commit: f40c380cdb]
2024-01-17 12:44:35 -05:00
Jaydeep Patel 1b05247a03 SWDEV-359287 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options.
Change-Id: I8d3a9a6ed1c3bddaaa86f7cdc242a45e6a1d09f6


[ROCm/clr commit: ea25e65834]
2024-01-17 04:42:52 -05:00
Jaydeep Patel baaad8b45a SWDEV-398109 - Enable smid support for CU mode for gfx10+.
Change-Id: Ief1e7c952c3de7e4a547bbdcc9817f51aa4d5d36


[ROCm/clr commit: fb2c100d8c]
2024-01-16 20:13:23 -05:00
pghafari 0fe462b63e SWDEV-441258 - remove full path for HIP LOG windows
Change-Id: Ibad6e9542c0cede38f5a114dcd352356ddedf019


[ROCm/clr commit: 0cff14c9e1]
2024-01-16 15:26:06 -05:00
German 37ed51c99c SWDEV-440746 - Enable hipExtAnyOrderLaunch extension for PAL
Extension allows to execute the kernels without a wait barrier and L1
invalidation.

Change-Id: I96c485204303f54a0240b93134f4560673e4bd17


[ROCm/clr commit: 13c6f56ca9]
2024-01-16 15:20:39 -05:00
kjayapra-amd b457d0ba82 SWDEV-413997 - Physical address size could be more than mapped size, only virtual address needs to be match the size of unmap request.
Change-Id: If0e973149d8ce1b6f01000ab951cf6e9f4b38e97


[ROCm/clr commit: 0f9c624f4c]
2024-01-16 07:09:50 -05:00
Maneesh Gupta ad499128d6 SWDEV-1 - Temporarily disable rocprofiler-register support
Change-Id: I2e4b4c5f6c0640fc4e1378dd920b080b88583921


[ROCm/clr commit: 4b6912031b]
2024-01-16 04:15:05 +00:00
Saleel Kudchadker 34fd1b7fe5 SWDEV-301667 - Remove resetFenceDirty
Dont track the status of fence_dirty_ flag on the host, instead clear it
when we submit a barrier on the respective stream.

Change-Id: I4d98dbf20c81379c9c5da9f5b67629a8f9f6dfcd


[ROCm/clr commit: 0b0df605d4]
2024-01-15 15:43:14 -05:00
Jonathan R. Madsen 3c5da3e666 Add rocprofiler-register support
- Add API table versioning defines to hip_api_trace.hpp
- Add rocprofiler-register implementation in hip_api_trace.cpp
  - created ToolInit implementation
  - moved some local functions into anonymous namespace
  - renamed some function to be overloads
  - made most of the initialization code templated (reduced code duplication)
  - enforce ABI
- Updated hipamd/src/CMakeLists.txt
  - find rocprofiler-register package (enabled by default but not required)
- Address review comments
  - simplify size calculation for dispatch table
  - remove setting .size field in GetDispatchTableImpl
- Fix windows build
- Do not enforce ABI on Windows

Change-Id: I08766e8a083528a1236996274bf4522e0e8a1b9f


[ROCm/clr commit: 0f1fdc7794]
2024-01-13 01:02:59 -06:00
German 339523c475 SWDEV-440746 - Limit WG for compute P2P
Use only 16 workgroups for compute P2P copies.
That should be enough to utilize XGMI bandwidth.

Change-Id: I60dfe019279bb95f93c8874244c1738aad1896d8


[ROCm/clr commit: 31101c6219]
2024-01-12 14:56:29 -05:00
sdashmiz 29eba6df09 SWDEV-421027 - Add hipGraphAddNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ic8cf293ff483ee2547b52d2975062bcb9a6f5d17


[ROCm/clr commit: d23835ffbe]
2024-01-12 11:36:30 -05:00
Jatin Chaudhary a65d07302f SWDEV-438181 - check stream associated with event
...before we dereference it. It might have been deleted.

Change-Id: Ief832ee0907658a40ca42b9d78d19658153a05dd


[ROCm/clr commit: 2cfb8bc3c1]
2024-01-12 10:39:20 -05:00
Sameer Sahasrabuddhe 2dba215643 SWDEV-295298: introduce warp sync functions
The following builtins from the CUDA spec are implemented:

  - __all_sync, __any_sync, __ballot_sync and __activemask
  - __match_any_sync and __match_all_sync
  - __shfl_sync, __shfl_up_sync, __shfl_down_sync, and __shfl_xor_sync

The following builtins are NOT implemented, pending support in the compiler:

  - __reduce_add_sync, __reduce_min_sync, __reduce_max_sync
  - __reduce_and_sync, __reduce_or_sync, __reduce_xor_sync

Change-Id: I07dedbbfe5449f4b5c9b040bed59f5603ccec8c3


[ROCm/clr commit: c5ab5680b4]
2024-01-11 22:31:27 -05:00
Saleel Kudchadker 9864d6e56c SWDEV-301667 - Missing marker for hipExtLaunch* optimization
- Use isFenceDirty() check in hipStreamQuery.
In case if there is a stopEvent for hipExtLaunch* API we avoid system
scope if there are consecutive hipExtLaunch* and replace them with agent
scope, but then if one uses hipStreamQuery it should detect we need a
barrier with system scope.

Change-Id: I539810f659d4e1c49104e3a0da6ff2803c6b3dee


[ROCm/clr commit: 4b3c4709ff]
2024-01-11 18:19:30 -05:00
jujiang 898e647f84 SWDEV-410522 - Fix a doxygen warning in a header in AMD platform
Change-Id: I29cd222af453c42a5d472081747bacf0c3f8d17c


[ROCm/clr commit: 2a2fea6c07]
2024-01-11 13:40:25 -05:00
Konstantin Zhuravlyov b98c4c2873 Revert "Removed some options"
This reverts commit 4abdfe5489.

Reason for revert: multiple tickets filed. i will re-instate this change after fixing those.

Change-Id: I66152e3643c73ec1d240d0fcddf2119f8f4848a8


[ROCm/clr commit: 5f7ebda6aa]
2024-01-10 13:35:42 -05:00
Saleel Kudchadker a87782e941 SWDEV-439242 - Fix perf regression
This issue is due to the fact that we set fence_dirty_ flag for every
kernel launch. Whenever any next HIP API is caused, the stream logic
assumes fence is dirty and queues a marker, when its not needed.

Change-Id: I10a49ee951daa92221aa6be75e2334849579a45d


[ROCm/clr commit: d6b4892600]
2024-01-10 11:45:02 -05:00
German ab59c1e7fa SWDEV-301667 - Fix HSAIL compilation path for Blit
Recently some unused compiler options for HSAIL path were removed,
 but it affected blit kernels compilation. Hence, remove those options.
Also delete assert for device to device copy in SDMA path for now.

Change-Id: Ib5d7f063af2ab4a3fc5d73d426e39c391b1011ac


[ROCm/clr commit: eaa61fc740]
2024-01-09 17:51:30 -05:00