Commit Graph

283 Commits

Author SHA1 Message Date
German Andryeyev 593844fdd6 SWDEV-328670 - Pass the size of allocation
The actual size of allocation can be different from the original
request due to alignments. Pass the size of the original request
for validation during the arena object look-up

Change-Id: I30000046b1ec56abe743e43113046144fd3edbc6


[ROCm/clr commit: fb835c6f3e]
2022-04-01 11:18:55 -04:00
Satyanvesh Dittakavi cb4625e5b7 SWDEV-329082 - Return right error code for hipHostUnregister
hipErrorHostMemoryNotRegistered should be returned when an
unregistered pointer is passed to hipHostUnregister

Change-Id: Ie76086b602bde2cd7a7a2b049cd03d29454ff306


[ROCm/clr commit: ed4014e519]
2022-03-28 07:24:25 -04:00
sdashmiz c308cf0951 SWDEV-303187: find the device pointer is for
- the pointer attribute is fetched for might not be the current device

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ibcea92b52da31adba5f62baae25b55671704c005


[ROCm/clr commit: ae506b40c0]
2022-03-22 10:55:28 -04:00
Satyanvesh Dittakavi 6a849eb690 SWDEV-327967 - Fix Segmentation fault in hipFree
Queue creation and release fails during hipFree causing seg fault
if the null queue was not created until then and there is no
device memory left.

Change-Id: I118b86b58e777dac5415bc9ba0c4e23c986efa7d


[ROCm/clr commit: 4a90c3ccaf]
2022-03-22 00:34:40 -04:00
Satyanvesh Dittakavi 90e339cf95 SWDEV-324016 - Refactor hipDrvPointerGetAttributes
Addresses the negative scenarios and assigns default NULL values to
the queried attributes when the pointer encountered is not valid.
This is to match the corresponding API's behavior in CUDA.

Change-Id: I4ce400b02416d455ec9649f731af2e327dccfe71


[ROCm/clr commit: a554d03b9a]
2022-03-16 05:30:28 -04:00
Sourabh Betigeri 7649115859 SWDEV-326791 - Fixes hipHostRegister's inconsistent behavior when invalid parameter is passed
Change-Id: I5d5d979485cfd99908f84cc92648177cb8a569c7


[ROCm/clr commit: 0a76232c97]
2022-03-11 12:24:35 -05:00
Sourabh Betigeri 9a25ec266b SWDEV-326380 - Fixes a regression by verifying the device virtual address already exists in the memObjMap
Change-Id: Ibe29f3c6b77385a8e264ab523cafa4b5d2b41325


[ROCm/clr commit: 85a25a4be2]
2022-03-09 20:52:45 -05:00
Satyanvesh Dittakavi 98fef69edd SWDEV-313867 - SWDEV-314101 - Address Negative scenarios with hipGraphAddMemcpyNode and hipGraphAddMemsetNode
Change-Id: I51527ce6953aee9a3ef7d821754819b6c8087939


[ROCm/clr commit: c58ba64a0b]
2022-03-05 07:37:46 -05:00
Sourabh Betigeri eca06b35b9 SWDEV-273026 - Fixes a bug that skipped looping through all devices to book keep its corresponding memory in roclr
Change-Id: I404f6d2bcd0c0e31b9b0237903f26f0af19bc735


[ROCm/clr commit: 545cfaf428]
2022-03-02 20:26:28 -05:00
Saleel Kudchadker 49a1d54a5d SWDEV-321723 - Refactor hipHostMalloc flags
Always choose fing grain memory pool for hipHostMalloc
Choose coarse grain only if hipHostMallocNonCoherent is passed.

Change-Id: I9a67ba77335d4f373d32fea4ecd7848c77f9c190


[ROCm/clr commit: 0da908ec79]
2022-03-02 16:24:40 -05:00
Saleel Kudchadker 57b1cd0cf2 SWDEV-321723 - Pass correct flags
Pass CL_MEM_SVM_ATOMICS with hipHostMallocNumaUser.

Change-Id: I7b8010c5584ffd2fbebb964832dcfa270d430830


[ROCm/clr commit: a3f4d9410c]
2022-02-23 18:23:35 -08:00
Julia Jiang e6f8c4dc23 SWDEV-321654 - fix hipPointerGetAttribute API
Change-Id: Icafdda147eb16e08048d6c435c0c5714f3f8d143


[ROCm/clr commit: dabed031a0]
2022-02-22 21:32:28 -05:00
Payam 01bd9ba844 SWDEV-316050, SWDEV-316292 - Graph api matching error with Cuda
Change-Id: I80c9358e9ad3a2d57fca53e6ff7679f1e3953328


[ROCm/clr commit: c0b859641f]
2022-02-21 16:29:50 -05:00
Satyanvesh Dittakavi 51f8fc06e1 SWDEV-306940 - Fix hipamd errors/warnings found by CppCheck
Change-Id: Ia93d4f5262ea4269d8031edbfd27033b887e5300


[ROCm/clr commit: 6e562f4d83]
2022-02-05 08:42:47 -05:00
Satyanvesh Dittakavi 6bbcf08fc8 SWDEV-292714 - Added support for hipPointerGetAttribute and
hipDrvPointerGetAttributes

Change-Id: I44a0b5c5d9eb5a9a63406b11e8de83e5cb245a59


[ROCm/clr commit: 760f275861]
2022-02-02 05:33:07 -05:00
Ajay 91ba078604 SWDEV-313082 - hipGraphMemsetNodeSetParams invalid params
Change-Id: Ibe57df8d7d583daf9ba9c7a86863eacca4868f3a


[ROCm/clr commit: cb79dc7486]
2022-01-28 19:27:32 -05:00
Maneesh Gupta 501b613442 Revert "SWDEV-316155 - Fix for P2P sample failure"
This reverts commit 74269eb547.

Reason for revert: Fixed via a different patch

Change-Id: I1743afdd7b8516b39501839d74bbed6bdb797e0c


[ROCm/clr commit: ff1f1ba867]
2022-01-13 02:27:47 -05:00
Sarbojit Sarkar 641d0b9d6f SWDEV-315545 - Fix for hipMemsetAsync crash
Change-Id: I39ad0dacf4357aa6f9d0c6cf92a6a7d14bd219c0


[ROCm/clr commit: c4f6037ae8]
2022-01-10 06:48:10 -05:00
Sarbojit Sarkar 74269eb547 SWDEV-316155 - Fix for P2P sample failure
Change-Id: I95a70d44949c59319a9a09f84be771740c3f0521


[ROCm/clr commit: 845b923507]
2022-01-06 06:35:15 -05:00
Satyanvesh Dittakavi 74bd37bd34 SWDEV-309286 - Add check to limit host malloc upto system memory size
Change-Id: I4a0f55d6f7faa323b16d9b8fb12e876900da1bbc


[ROCm/clr commit: c9532093ce]
2021-12-07 12:02:29 -05:00
Sarbojit Sarkar b1ac216804 SWDEV-310181 - Fix for hipMemcpy2DFromArray dtest failure
Change-Id: I4284cc543c5ebd5f09254d570230a25742e9dc3c


[ROCm/clr commit: 2cbdadd037]
2021-11-29 22:56:09 -05:00
anusha GodavarthySurya 5e8ecdf9f9 SWDEV-240806 - Fix compilation warning
Change-Id: I1b540059b1e386bc7b6f4493226c45199542bfc3


[ROCm/clr commit: d2f202b116]
2021-11-19 20:46:18 -05:00
anusha GodavarthySurya 71215f1231 SWDEV-240806 - hip stream capture handling for memory APIs
Change-Id: Ie29493cd09421175c3ce5a198f8c2c299739f997


[ROCm/clr commit: 3e2c2dfb71]
2021-11-17 00:15:13 -08:00
kjayapra-amd a1917d6593 SWDEV-310194 - Return hipSuccess early if fill_size is 0.
Change-Id: I79d8c94b099d441f14f938205e007ae521649672


[ROCm/clr commit: 2f87d24dd2]
2021-11-09 09:28:25 -05:00
anusha GodavarthySurya ad0dc7dd0e SWDEV-307642 - Fix memcpy directed tests failure
Change-Id: I7a835a5a519b35fcda813c2acc1ac3cf5d0b5f23


[ROCm/clr commit: 63c6799130]
2021-10-26 00:15:11 -04:00
Satyanvesh Dittakavi 933df7235b SWDEV-305163 - Do not limit hipHostMalloc upto max GPU memory available
Change-Id: Iea934088bcbef6cbd5c3f9f97767042fcaf71062


[ROCm/clr commit: 1da4bb21b9]
2021-10-20 01:33:44 -04:00
kjayapra-amd 7c4dfc27a7 SWDEV-232903 - Move hipmemset dword optimization into ROCclr.
Change-Id: I1af437de2771f6a48d06ce643ade6b79f551a55c


[ROCm/clr commit: 4d1195f0a7]
2021-10-13 11:32:00 -04:00
anusha GodavarthySurya be487b261b SWDEV-24806 - Added support for memcpy related graph APIs
hipGraphMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams, hipGraphAddMemcpyNodeFromSymbol, hipGraphMemcpyNodeSetParamsFromSymbol, hipGraphExecMemcpyNodeSetParamsFromSymbol, hipGraphAddMemcpyNodeToSymbol, hipGraphMemcpyNodeSetParamsToSymbol, hipGraphExecMemcpyNodeSetParamsToSymbol

Change-Id: I6896144f340867d938aa1777880c78c46ca6f893


[ROCm/clr commit: c4eda85835]
2021-10-05 22:43:49 -07:00
Ajay 48316f63e9 SWDEV-301069 - save device id during hipHostRegister
Change-Id: I789b2252fa1a131ed1924b47718e355cb4fc9037


[ROCm/clr commit: 361dec890c]
2021-10-04 12:07:29 -04:00
Sarbojit Sarkar 8923e6d97d SWDEV-301823 - Optimized hipMemset2D/3D
Change-Id: I1e817ab135bfdf9b8f9af18c1bf2cd2e926db729


[ROCm/clr commit: 98c172c2e4]
2021-09-28 00:05:33 -04:00
Ajay 918575f762 SWDEV-301069 - null ptr check before calling getUserData
Change-Id: Iaff3acd44d89a9629efe0672cb45138942d7fa28


[ROCm/clr commit: 198530143c]
2021-09-17 19:25:24 -04:00
agunashe 0cf25d1fd3 SWDEV-301069 - current device id saved while allocating memory
Change-Id: I57045119e7adf915074c547cbe76349a4cfd72d9


[ROCm/clr commit: 29adfcd3c0]
2021-09-14 12:19:44 -04:00
Sarbojit Sarkar 87862528be SWDEV-276319 - Added missing null check
Change-Id: I0fcaa55b9a793cbb6c1d2f3022edf288dabea757


[ROCm/clr commit: 88186db4cd]
2021-09-08 06:53:02 -04:00
anusha GodavarthySurya 64799f183f SWDEV-300471 - updated hipFree to wait for all streams to finish
Change-Id: I4983ef48a9e720ed03128d83a8d23ad11024fd8f


[ROCm/clr commit: c9d9fd992a]
2021-09-02 00:45:24 -04:00
Julia Jiang 6883ccde42 SWDEV-286322 - Remove execution permission
Change-Id: I96e603fc8d407c3a76fa1053bad81e45744b59ad


[ROCm/clr commit: 8835b897d5]
2021-08-05 14:04:06 -04:00
agunashe fae697b4d6 SWDEV-293742 - Update copyrights end year for hipamd
Change-Id: I08f620f84563a9214b59f1b943ed091b67229eab


[ROCm/clr commit: d9d9e81acb]
2021-07-09 12:08:39 -04:00
Sarbojit Sarkar b21a5c64f6 SWDEV-286147 - Added image support check before using
Change-Id: I4b8ae854bf3488ef2418f0864a15b2fef0a889da


[ROCm/clr commit: 4c5c0419be]
2021-06-11 11:51:08 -04:00
Rahul Garg dd95d3d23c ROCMOPS-1956 - Push restructured code to hipamd
hipamd will have AMD's ROCCLR based HIP backend implementation

Change-Id: Id7de9634519b4ce46fca71a1b61f3d5b1e3fc459


[ROCm/clr commit: 19c84bc604]
2021-06-07 21:42:44 +00:00
Tao Sang 6227f3fae2 Remove hip-hcc codes: Part one
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd


[ROCm/clr commit: 1cba7ec965]
2020-12-09 15:49:47 -05:00
Yaxun (Sam) Liu 2406fa8a3d Disable device side malloc (#2009)
* Disable device side malloc

Currently device side malloc is not working and takes excessive
device memory.

Disable it for now until a working malloc is implemented.

Change-Id: I1ad908c1c53a83752383b4be96688a848642c699

[ROCm/clr commit: d556c3425b]
2020-04-14 16:07:14 +05:30
Aryan Salmanpour 2d45fcc1b4 [HIP] add support for NoPreSync/NoPostSync flags for Cooperative MultiDevice launch API (#1990)
[ROCm/clr commit: 4d05b4dce7]
2020-04-13 14:02:52 +05:30
satyanveshd 672462fcfc fix hipIpcOpenMemHandle (#1998)
[ROCm/clr commit: 20d9986548]
2020-04-06 15:39:49 +05:30
Rahul Garg aae8a4080d Fix 2D and 3D memset (#1987)
[ROCm/clr commit: 017a27214c]
2020-04-06 15:35:59 +05:30
Sarbojit2019 7e05ef29eb Fix for segfault seen in hipMemcpyDtoD (#1964)
* Fixes SWDEV-227444.

[ROCm/clr commit: b55775a49e]
2020-03-28 17:29:49 +05:30
satyanveshd fbc9771f63 [dtests] Added few Negative tests (#1735)
[ROCm/clr commit: 4554bbd9f9]
2020-03-27 14:10:12 +05:30
Sarbojit2019 4f8c29f7dc Fix for segfault seen if invalid kind is passed to hipMemcpy (#1937)
Fixes SWDEV-224941

[ROCm/clr commit: 12448996e3]
2020-03-26 17:04:43 +05:30
srinivamd 195abb8a18 return hipSuccess when count is zero (#1900)
[ROCm/clr commit: 32960ab8f9]
2020-03-11 14:32:54 +05:30
Alex Voicu 6a37ef97c4 Address post-staging issues in #1809 (#1894)
Fixes SWDEV-223910 and SWDEV-223663

[ROCm/clr commit: cea5489f00]
2020-02-27 16:21:12 +05:30
Alex Voicu 3057a52be5 Tweak synchronous memcpy implementation (#1809)
The existing one can have issues on certain systems, therefore this limits use of direct memcpy via largeBAR to sizes where it is unequivocally better.

Also addresses SWDEV-220030 and SWDEV-222237.

[ROCm/clr commit: 730f23829e]
2020-02-18 20:50:27 +05:30
Rahul Garg 6f1d14c96d Fix hipMemcpy3D (#1798)
Fixes #1790 and #1791. hipMemcpy3D still requires further refactoring for different input and output combinations.

[ROCm/clr commit: ec84c16d75]
2020-02-17 19:35:35 +05:30