 Alex Voicu
|
37e40fcd40
|
This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
[ROCm/clr commit: e186bd9533]
|
2017-12-03 23:09:06 +00:00 |
|
|
Alex Voicu
|
1ba0d0ca14
|
Remove stray leftover comment.
[ROCm/clr commit: 954b7dadf7]
|
2017-12-02 00:03:10 +00:00 |
|
|
Alex Voicu
|
6bdde982ff
|
Replace archaic use of homebrew functionality with calls to the HC maths library. This fixes a hang observed when building hipTestDeviceDouble.
[ROCm/clr commit: b8c80bd0b2]
|
2017-12-02 00:01:47 +00:00 |
|
 Ben Sander
|
2ffc9d221b
|
Merge pull request #246 from AlexVlx/feature_use_module_based_dispatch_instead_of_pfe
Use natural dispatch syntax
[ROCm/clr commit: 1a6727e2fc]
|
2017-12-01 14:21:25 -06:00 |
|
|
Alex Voicu
|
76336d46b4
|
Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter.
[ROCm/clr commit: 33bb425013]
|
2017-11-30 03:29:04 +00:00 |
|
|
Alex Voicu
|
c1c4f454d8
|
Add missing space (the final frontier).
[ROCm/clr commit: 2e39534377]
|
2017-11-29 21:50:43 +00:00 |
|
|
Alex Voicu
|
a27fa25d76
|
Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions."
This reverts commit 1cd6416
[ROCm/clr commit: 4966518846]
|
2017-11-29 21:49:10 +00:00 |
|
|
Alex Voicu
|
e0a41791c8
|
Use a much simpler guard for version 1.6, which allows for direct CUDA indexing to be used.
[ROCm/clr commit: 92e80f0943]
|
2017-11-29 21:47:04 +00:00 |
|
|
Alex Voicu
|
1cd6416492
|
Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions.
[ROCm/clr commit: 4792475d01]
|
2017-11-29 21:01:28 +00:00 |
|
 Maneesh Gupta
|
98ec873ede
|
Bumped HIP version to 1.5 and updated summary in HIP release notes
Change-Id: I4b612da88236674fac2c585ab6891bdd495511b0
[ROCm/clr commit: 2d5e0274ef]
|
2017-11-29 13:56:17 +05:30 |
|
|
Alex Voicu
|
4d18ad9ebe
|
Fix compiler version check.
[ROCm/clr commit: 93e595c267]
|
2017-11-29 03:05:53 +00:00 |
|
|
Alex Voicu
|
0636d6a976
|
Add missing file.
[ROCm/clr commit: e305d3fc94]
|
2017-11-29 02:16:44 +00:00 |
|
|
Alex Voicu
|
6b21218303
|
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
[ROCm/clr commit: 37c1811b2a]
|
2017-11-29 01:37:52 +00:00 |
|
|
Alex Voicu
|
cdac21c81a
|
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
[ROCm/clr commit: c6ab6f292b]
|
2017-11-29 00:17:44 +00:00 |
|
|
Alex Voicu
|
e85f49a57e
|
Remove leftover agent allocated globals.
[ROCm/clr commit: 45a9f4f7b1]
|
2017-11-28 19:56:04 +00:00 |
|
|
Alex Voicu
|
abf92dd6e7
|
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
[ROCm/clr commit: d5c8de3f41]
|
2017-11-28 19:45:47 +00:00 |
|
|
Alex Voicu
|
914acbe88f
|
Re-sync with upstream and re-factor platform global management for texture references.
[ROCm/clr commit: 6a0efb7ed2]
|
2017-11-28 19:15:29 +00:00 |
|
|
Alex Voicu
|
579a3187da
|
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
# Conflicts:
# src/hip_module.cpp
[ROCm/clr commit: d37a5a6008]
|
2017-11-28 17:29:11 +00:00 |
|
|
Maneesh Gupta
|
621cc5e5ca
|
Fix float2int rounding functions
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
[ROCm/clr commit: cc418da654]
|
2017-11-28 17:23:43 +00:00 |
|
|
Alex Voicu
|
a59daf78d6
|
This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
[ROCm/clr commit: bb35299560]
|
2017-11-28 17:23:06 +00:00 |
|
|
Alex Voicu
|
0de6e0be2b
|
This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
[ROCm/clr commit: 4b7cb0624e]
|
2017-11-28 17:23:06 +00:00 |
|
 Chris Kitching
|
8042277672
|
Add hipify mappings for all CUDA headers that have HIP equivalents
I'm particularly running into issues with `device_types.h` in real
CUDA code...
[ROCm/clr commit: 7761f63bbc]
|
2017-11-28 17:23:06 +00:00 |
|
|
Ben Sander
|
0de96b6e3e
|
Merge pull request #256 from gargrahul/texture_driver_api_support
Texture driver APIs support
[ROCm/clr commit: e93a24bdbe]
|
2017-11-27 13:52:39 -06:00 |
|
 Rahul Garg
|
37ceb9a1a8
|
Added note in Release notes for texture driver APIs
[ROCm/clr commit: 6c18df987d]
|
2017-11-27 22:06:50 +05:30 |
|
 Evgeny Mankov
|
2df33086a8
|
Merge pull request #262 from ChrisKitching/frontendaction
[HIPIFY] Mostly fix preprocessor-or-template induced issues
[ROCm/clr commit: b25d199111]
|
2017-11-27 17:30:11 +03:00 |
|
|
Rahul Garg
|
896c146fef
|
Porting guides update for texture APIs usage
[ROCm/clr commit: 3e9a4cfdd1]
|
2017-11-24 12:00:55 +05:30 |
|
|
Ben Sander
|
84802e5d68
|
Merge pull request #273 from mangupta/swdev-129574
Fix float2int rounding functions
[ROCm/clr commit: 77de4b96cf]
|
2017-11-23 12:04:36 -06:00 |
|
|
Maneesh Gupta
|
05963822e7
|
Fix float2int rounding functions
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
[ROCm/clr commit: 822743845c]
|
2017-11-23 09:57:24 +05:30 |
|
|
Alex Voicu
|
36951c298d
|
Remove leftover comment.
[ROCm/clr commit: dfa532db98]
|
2017-11-22 19:37:03 +00:00 |
|
|
Evgeny Mankov
|
d7e1419d8b
|
Merge pull request #263 from ChrisKitching/headers
[HIPIFY] Add hipify mappings for all CUDA headers that have HIP equivalents
[ROCm/clr commit: 6bddac1cfa]
|
2017-11-22 21:24:21 +03:00 |
|
|
Alex Voicu
|
f9b177c0b3
|
Modify the set component of the memcpy test (unclear why there is a memset component to begin with).
[ROCm/clr commit: 0755f1fc26]
|
2017-11-21 17:52:01 +00:00 |
|
|
Rahul Garg
|
212afdf56b
|
Fixed review comments
[ROCm/clr commit: 38029f2849]
|
2017-11-21 21:19:06 +05:30 |
|
|
Alex Voicu
|
31deac0768
|
This corrects how addresses are formed for symbols which reside in shared objects. For this case, the .value component of an ELF symbol holds the offset from the base VA where the shared object was loaded. Thus, to correctly obtain the VA of the object refered by the symbol, we must add the offset to the VA where the shared object is loaded. We were already doing this correctly for symbols denoting functions, but we were incorrect for those denoting objects.
[ROCm/clr commit: fb1021cc0a]
|
2017-11-21 13:15:13 +00:00 |
|
|
Rahul Garg
|
dc2c56c43d
|
Changed function hipMemcpy_2D to hipMemcpyParam2D
[ROCm/clr commit: 24307fe5c4]
|
2017-11-21 12:36:24 +05:30 |
|
|
Alex Voicu
|
1366b2d5ae
|
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
[ROCm/clr commit: f8c1c1b38e]
|
2017-11-21 02:40:34 +00:00 |
|
|
Alex Voicu
|
98ea26e613
|
Clean-up some remaining noise in program_state.cpp.
[ROCm/clr commit: 24f8a93ff7]
|
2017-11-20 22:41:46 +00:00 |
|
|
Alex Voicu
|
f27cd5ad33
|
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
[ROCm/clr commit: 27bc487635]
|
2017-11-20 16:33:52 +00:00 |
|
|
Alex Voicu
|
9cf73ef515
|
Re-sync with upstream.
[ROCm/clr commit: 30d90dab38]
|
2017-11-20 15:34:50 +00:00 |
|
|
Ben Sander
|
fdb4ea06f7
|
Merge pull request #264 from pzins/missing_end_marker
Fix missing MARKER_END
[ROCm/clr commit: a1e0c96689]
|
2017-11-20 06:08:01 -06:00 |
|
|
Rahul Garg
|
9cee9705dc
|
-Moved coGlobals in hipModule class (takes care of multi module case)
-Used mutex scope for updating coGlobals
[ROCm/clr commit: eff09fcd86]
|
2017-11-20 16:23:18 +05:30 |
|
|
Maneesh Gupta
|
02cbb93ec1
|
Merge pull request #266 from gargrahul/fix_half2_gfx900
Fixed half2 issue on gfx900
[ROCm/clr commit: 4477d3d314]
|
2017-11-20 07:28:41 +05:30 |
|
|
Maneesh Gupta
|
9498ff3cae
|
Merge pull request #265 from phani544/nvccTests
[nvccTests]Enabled inline_asm_vadd on nvcc
[ROCm/clr commit: 29c0ab8401]
|
2017-11-20 07:28:29 +05:30 |
|
|
Ben Sander
|
809f575305
|
Fix test on cuda
[ROCm/clr commit: aeadc3f18f]
|
2017-11-19 15:31:02 -06:00 |
|
|
Ben Sander
|
80021d3c68
|
Merge branch 'feature_natural_indexing' of https://github.com/AlexVlx/HIP
[ROCm/clr commit: a43262e699]
|
2017-11-19 15:25:17 -06:00 |
|
|
Ben Sander
|
6b1fb439f6
|
Temporarily disable P2P on nvidia (fails on dual GPU)
[ROCm/clr commit: fc34fd6f03]
|
2017-11-19 15:21:37 -06:00 |
|
|
Rahul Garg
|
7453c8b25c
|
Update hipModuleGetTexRef API
[ROCm/clr commit: 76f174b536]
|
2017-11-19 22:10:46 +05:30 |
|
|
Alex Voicu
|
af0ae5421c
|
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
[ROCm/clr commit: 0cc921f103]
|
2017-11-19 01:54:12 +00:00 |
|
|
Alex Voicu
|
3b413e7ee7
|
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
[ROCm/clr commit: 45ac5b70df]
|
2017-11-16 23:20:15 +00:00 |
|
|
Rahul Garg
|
b0461a2176
|
Fixed test case for GFX900
[ROCm/clr commit: cfc9f87465]
|
2017-11-16 09:34:52 +05:30 |
|
|
Rahul Garg
|
c3ba309562
|
Fixed half2 issue on gfx900
[ROCm/clr commit: 20947f80fb]
|
2017-11-15 18:52:59 +05:30 |
|