AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,161 Commits 3 Branches 0 Tags
37e40fcd409705fd49d9940a0f8a5ce36d511aac
Commit Graph

610 Commits

Author SHA1 Message Date
Alex Voicu 37e40fcd40 This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail. 
[ROCm/clr commit: e186bd9533]
 2017-12-03 23:09:06 +00:00
Alex Voicu 76336d46b4 Fix legacy mode detection of the address of an agent allocated variable. In this mode, there exist two executables per each code object, one created by HCC and one created by HIP. Since we dispatch through HCC in legacy mode, we should obtain the address for an agent allocated variable from the latter's executable. Also add two omitted validity checks, whose absence could lead to segfaults when the current process had no .kernel section and / or when an invalid or empty blob was extracted from the latter. 
[ROCm/clr commit: 33bb425013]
 2017-11-30 03:29:04 +00:00
Alex Voicu c1c4f454d8 Add missing space (the final frontier). 
[ROCm/clr commit: 2e39534377]
 2017-11-29 21:50:43 +00:00
Alex Voicu a27fa25d76 Revert "Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions." 
This reverts commit 1cd6416


[ROCm/clr commit: 4966518846]
 2017-11-29 21:49:10 +00:00
Alex Voicu e0a41791c8 Use a much simpler guard for version 1.6, which allows for direct CUDA indexing to be used. 
[ROCm/clr commit: 92e80f0943]
 2017-11-29 21:47:04 +00:00
Alex Voicu 1cd6416492 Revert adoption of CUDA indexing in general - this can only work with later versions of the compiler, just like module based dispatch, and thus must be guarded against usage in earlier (e.g. 1.6) versions. 
[ROCm/clr commit: 4792475d01]
 2017-11-29 21:01:28 +00:00
Alex Voicu 4d18ad9ebe Fix compiler version check. 
[ROCm/clr commit: 93e595c267]
 2017-11-29 03:05:53 +00:00
Alex Voicu 6b21218303 Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component. 
[ROCm/clr commit: 37c1811b2a]
 2017-11-29 01:37:52 +00:00
Alex Voicu cdac21c81a Choose whether or not to use functional grid_launch based on the version of HCC used to compile. 
[ROCm/clr commit: c6ab6f292b]
 2017-11-29 00:17:44 +00:00
Alex Voicu abf92dd6e7 Change memset kernel to use memcpy instead of placement new. Simplify indexers. 
[ROCm/clr commit: d5c8de3f41]
 2017-11-28 19:45:47 +00:00
Alex Voicu 914acbe88f Re-sync with upstream and re-factor platform global management for texture references. 
[ROCm/clr commit: 6a0efb7ed2]
 2017-11-28 19:15:29 +00:00
Alex Voicu 579a3187da Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe 
# Conflicts:
#	src/hip_module.cpp


[ROCm/clr commit: d37a5a6008]
 2017-11-28 17:29:11 +00:00
Ben Sander 0de96b6e3e Merge pull request #256 from gargrahul/texture_driver_api_support 
Texture driver APIs support

[ROCm/clr commit: e93a24bdbe]
 2017-11-27 13:52:39 -06:00
Alex Voicu 36951c298d Remove leftover comment. 
[ROCm/clr commit: dfa532db98]
 2017-11-22 19:37:03 +00:00
Rahul Garg 212afdf56b Fixed review comments 
[ROCm/clr commit: 38029f2849]
 2017-11-21 21:19:06 +05:30
Rahul Garg dc2c56c43d Changed function hipMemcpy_2D to hipMemcpyParam2D 
[ROCm/clr commit: 24307fe5c4]
 2017-11-21 12:36:24 +05:30
Alex Voicu 1366b2d5ae Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch. 
[ROCm/clr commit: f8c1c1b38e]
 2017-11-21 02:40:34 +00:00
Alex Voicu f27cd5ad33 Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism. 
[ROCm/clr commit: 27bc487635]
 2017-11-20 16:33:52 +00:00
Alex Voicu 9cf73ef515 Re-sync with upstream. 
[ROCm/clr commit: 30d90dab38]
 2017-11-20 15:34:50 +00:00
Rahul Garg 7453c8b25c Update hipModuleGetTexRef API 
[ROCm/clr commit: 76f174b536]
 2017-11-19 22:10:46 +05:30
Alex Voicu af0ae5421c This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility. 
[ROCm/clr commit: 0cc921f103]
 2017-11-19 01:54:12 +00:00
Rahul Garg a0f838a75e -Fixed texture driver API sample 
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs


[ROCm/clr commit: edbfeeb141]
 2017-11-15 18:23:28 +05:30
Rahul Garg c154921e10 Texture code reorganized 
[ROCm/clr commit: e536eb038d]
 2017-11-14 11:09:35 +05:30
Rahul Garg bb8c31c198 Texture driver APIs support 
[ROCm/clr commit: 1851c153f6]
 2017-11-09 22:10:55 +05:30
Alex Voicu 142213a52b Clean up trailing whitespace so as to reduce noise in #246. 
[ROCm/clr commit: 0ad1308efd]
 2017-11-08 00:08:55 +00:00
Alex Voicu b738633bcb This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own. 
[ROCm/clr commit: 28f87f7d2e]
 2017-11-01 15:09:59 +00:00
Ben Sander fd5b9cb650 Merge pull request #222 from bensander/fix_device_prop 
Fix device prop

[ROCm/clr commit: 7e8b39fc96]
 2017-10-30 17:58:48 +01:00
Siu Chi Chan bec0ff43e0 Merge remote-tracking branch 'origin/master' into HEAD 
[ROCm/clr commit: cf98d0e37d]
 2017-10-27 01:18:28 -04:00
Siu Chi Chan 1e4a2a7dd0 add a printf device function 
[ROCm/clr commit: 36c2795dd4]
 2017-10-23 18:30:08 -04:00
Ben Sander 2774542487 Update device properties. 
- clear properties to defined initial state.
- enable some property flags which are now supported.


[ROCm/clr commit: ed85b15c3e]
 2017-10-20 15:52:13 +00:00
Chris Kitching c3f743a763 Add [[nodiscard]] attribute to hipError_t in C++17 mode 
This will yield a compiler warning any time you discard an error
return value from an API call.


[ROCm/clr commit: 939fa02ade]
 2017-10-19 13:34:02 +01:00
Maneesh Gupta e80a4ee235 Merge pull request #194 from bensander/fix_genco_math_path 
Fix math ordering for --genco mode.

[ROCm/clr commit: 132316fecf]
 2017-10-03 16:17:34 +05:30
Ben Sander e5bb8f73d0 Fix math ordering for --genco mode. 
[ROCm/clr commit: 2e9b78c274]
 2017-10-02 21:52:16 +00:00
Rahul Garg bc675b15b8 Fixed review comment 
[ROCm/clr commit: 71a5a0cb42]
 2017-10-02 17:29:08 +05:30
Rahul Garg f32bb0e089 Fixed review comments 
[ROCm/clr commit: 79a943e654]
 2017-10-02 10:57:25 +05:30
Rahul Garg 59fce18f03 Fixed build issue 
[ROCm/clr commit: d92cfa44d2]
 2017-10-02 10:40:01 +05:30
Rahul Garg c1cb518025 Fix texture support on HIP/NVCC path 
[ROCm/clr commit: e6725e2b7a]
 2017-10-02 10:40:01 +05:30
Siu Chi Chan 063dae2c46 ensure the condition is evaluated before applying the negation operator 
[ROCm/clr commit: bf6a3f4294]
 2017-09-20 01:38:28 -04:00
Maneesh Gupta e3aa4edf79 Merge pull request #155 from wsttiger/master 
Modify hip headers such that they are more compatible with strict C compiler

[ROCm/clr commit: 01163d327b]
 2017-09-15 10:49:55 +05:30
Maneesh Gupta c443f3814f Fix typo in nvcc_detail/hip_runtime_api.h 
[ROCm/clr commit: 846b0555b9]
 2017-09-14 16:19:57 +05:30
Maneesh Gupta bb818d9c74 Merge pull request #175 from gargrahul/assert_support 
Device side assert support

[ROCm/clr commit: 096caca840]
 2017-09-14 16:08:00 +05:30
sriharikarnam f65fb4755e Add hipDevice[Get/Set]SharedMemConfig API on nvcc details 
[ROCm/clr commit: f6fda276ce]
 2017-09-14 16:03:19 +05:30
Rahul Garg 2725242ba4 Device side assert support 
[ROCm/clr commit: 9dcf2ad751]
 2017-09-07 20:45:27 +05:30
Ben Sander dcd8961a9d Update docs. 
- Review unsupported comments and refresh.
- Review experimental tag in API.


[ROCm/clr commit: a6d1778fff]
 2017-08-28 15:44:38 -05:00
wsttiger ef8c6a67fc Modify header such that it's compatible with strict C compiler 
[ROCm/clr commit: 8302138d57]
 2017-08-15 13:23:09 -05:00
wsttiger 5ba2f6ea57 Add missing CUDA tags 
[ROCm/clr commit: 7933b3292d]
 2017-08-15 13:22:20 -05:00
Siu Chi Chan 6598eabd24 implement __threadfence_system 
[ROCm/clr commit: b6e22b5c93]
 2017-08-02 08:50:18 +00:00
Ben Sander a5b3f825c2 Merge pull request #100 from weixingzhang/texture 
HIP Texture Support

[ROCm/clr commit: 702651fc85]
 2017-07-26 19:28:15 -05:00
Maneesh Gupta f29245a846 Renable frexp(f) device math function 
Change-Id: I53c022b8ddf38cd17ddb42eba457b9020db66395


[ROCm/clr commit: 1bd1c6bea8]
 2017-07-20 14:41:30 +05:30
Weixing Zhang d9abb032f7 HIP Texture Support 
[ROCm/clr commit: ccbd3b13fc]
 2017-07-17 15:16:12 -04:00