EPR #419065 - [CQE OCL][ISV][QR][G] FAHBenchmark application is crashing.
Two issues:
1. Remove clearing of profileEnabled_ since it may cause incorrect kernel execution time measurement.
2. Blit kernels causes assertion in getWavesPerSH since they do not have wave limiters. Remove the assert. If a kernel has no wave limiter, returns 0 in getWavesPerSH.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#361 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#5 edit
[ROCm/clr commit: 7a956a4aa7]
EPR #010002 - Change OpenCL version number from 1797 to 1798.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1544 edit
[ROCm/clr commit: e827176b32]
EPR #010002 - Change OpenCL version number from 1796 to 1797.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1543 edit
[ROCm/clr commit: 7ed79b8ced]
EPR #010002 - Change OpenCL version number from 1795 to 1796.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1542 edit
[ROCm/clr commit: 589971f855]
EPR #010002 - Change OpenCL version number from 1794 to 1795.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1541 edit
[ROCm/clr commit: 4cad8af890]
EPR #010002 - Change OpenCL version number from 1793 to 1794.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1540 edit
[ROCm/clr commit: 02e5c725c0]
ECR #304775 - Wave limiter: Fix bug in adaptation.
Dumped waves/simd value is incorrect.
Should exit adptation only after the changed waves/simd value is applied.
Added wave limiter manager to handle situation that one kernel is enqueued to more than one queues. Create wave limiter for each virtual device.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#245 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#283 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.hpp#109 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#360 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#76 edit
[ROCm/clr commit: 51efa976bf]
EPR #010002 - Change OpenCL version number from 1792 to 1793.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1539 edit
[ROCm/clr commit: 3fd2754073]
EPR #010002 - Change OpenCL version number from 1791 to 1792.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1538 edit
[ROCm/clr commit: 5c39773984]
EPR #410821 - Reduced the maxMemAlloc and global memory size on APUs to 75% of uncachedRemoteRAM.
http://ocltc.amd.com/reviews/r/7425/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#509 edit
[ROCm/clr commit: 51f8154b23]
EPR #010002 - Change OpenCL version number from 1790 to 1791.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1537 edit
[ROCm/clr commit: ffa4be327e]
EPR #010002 - Change OpenCL version number from 1789 to 1790.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1536 edit
[ROCm/clr commit: ba9774d7f2]
EPR #010002 - Change OpenCL version number from 1788 to 1789.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1535 edit
[ROCm/clr commit: e203793ad8]
EPR #010002 - Change OpenCL version number from 1787 to 1788.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1534 edit
[ROCm/clr commit: 4e40237478]
ECR #304775 - Wave limiter: Fix crash in CompuBenchCL video composition due to profiling data not collected correctly.
Gpuvirtual.cpp only collects profiling data when all events have profiling enabled. Fixed it by adding a member to indicate at least one event has profiling enabled and collect profiling data.
Improved adptation by changing waves/simd only when the last change has been enforced. Also detecting discontinuities in measured data and discard them.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#359 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.hpp#129 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#230 edit
[ROCm/clr commit: b5a5c65e53]
EPR #010002 - Change OpenCL version number from 1786 to 1787.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1533 edit
[ROCm/clr commit: f71848412d]
ECR #304775 - Fix offline compilation for Hawaii with -cl-fp32-correctly-rounded-divide-sqrt flag
- check for cl-fp32-correctly-rounded-divide-sqrt support uses device info, but device info was never fully updated for offline devices. This change will update device info structure for offline devices as well.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#508 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.hpp#143 edit
[ROCm/clr commit: 8c00d76f96]
EPR #010002 - Change OpenCL version number from 1785 to 1786.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1532 edit
[ROCm/clr commit: 73e2723ad9]
EPR #010002 - Change OpenCL version number from 1784 to 1785.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1531 edit
[ROCm/clr commit: 39614d00f4]
ECR #304775 - Wave limiter: fix bug about some variables not initialized before being used.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#2 edit
[ROCm/clr commit: 5cb151c778]
EPR #010002 - Change OpenCL version number from 1783 to 1784.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1530 edit
[ROCm/clr commit: c5c2b34adf]
EPR #416903 - reduce maximum work load time to avoid BSOD/TDR when running the FlopsCL benchmarks on Kaveri
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#309 edit
[ROCm/clr commit: a52449cc34]
EPR #010002 - Change OpenCL version number from 1782 to 1783.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1529 edit
[ROCm/clr commit: a69c6e8be5]
EPR #010002 - Change OpenCL version number from 1781 to 1782.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1528 edit
[ROCm/clr commit: 74ec967de2]
EPR #010002 - Change OpenCL version number from 1780 to 1781.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1527 edit
[ROCm/clr commit: 71a3d49e32]
EPR #010002 - Change OpenCL version number from 1779 to 1780.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1526 edit
[ROCm/clr commit: e523b4cc1a]
EPR #010002 - Change OpenCL version number from 1778 to 1779.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1525 edit
[ROCm/clr commit: 964c612626]
EPR #010002 - Change OpenCL version number from 1777 to 1778.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1524 edit
[ROCm/clr commit: 31bc55d7e7]
EPR #010002 - Change OpenCL version number from 1776 to 1777.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1523 edit
[ROCm/clr commit: efe6af9915]
EPR #010002 - Change OpenCL version number from 1775 to 1776.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1522 edit
[ROCm/clr commit: 96dbe1df79]
ECR #399840 - OpenCL Runtime HW Debug support development - resolve the TDR issues on Kaveri.
1. update the resource descriptors in the runtime trap handler to match those in the HSA HW debug implementation
2. force to use SDMA for device memory map function, which is called when using clHwDbgSetGlobalMemoryAMD() and clEnqueueMapImage() functions, for HW debug
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuresource.cpp#214 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gputrap.hpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#358 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#115 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.h#47 edit
[ROCm/clr commit: 28a35ae54d]
EPR #412821 - Disable ThreadTrace for SI for now.
There's hang on some SI (Verde). So only enable ThreadTrace for CI+ for now.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#308 edit
[ROCm/clr commit: 91849cb26d]
ECR #333753 - ORCA RT: aclCompilerInit usage fix
Passing pointers on CRT memory management functions to dynamically loaded library is unsafe and may lead to memory corruption. But actually the pointers aren't actually passed.
They are cut off by the struct size: sizeof(aclCompilerOptions_0_8) and hence never being called.
P.S.
If it was aclCompilerOptions_0_8_1 the pointers would be taken into account and a heap corruption would occur. So the change intended to liquidate possible misunderstanding of malloc & free functions usage, and doesn't change the behaviour of aclCompilerInit function at all.
Testing: pre check-in
Reviewers: German Andreev, Stanislav Mekhanoshin
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpudevice.cpp#271 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#507 edit
[ROCm/clr commit: 45fd651d2f]
EPR #010002 - Change OpenCL version number from 1774 to 1775.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1521 edit
[ROCm/clr commit: fbfb129ae9]
EPR #010002 - Change OpenCL version number from 1773 to 1774.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1520 edit
[ROCm/clr commit: 5e013ada4b]
EPR #403782 - IOMMU2/SVM
- Handle case of only one DMA engine available, for example with SVM.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/7284/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#506 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.hpp#142 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#357 edit
[ROCm/clr commit: 32c073c558]
ECR #304775 - Some code clean-up
- Remove amd::Context reference from the event object. Runtime can use queue to get the context for the limited number of use cases
- User/GL events will keep the context as a member
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_event.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#75 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.cpp#120 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.hpp#91 edit
[ROCm/clr commit: 458cca25ce]
EPR #010002 - Change OpenCL version number from 1772 to 1773.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1519 edit
[ROCm/clr commit: c4bbb00b35]
EPR #010002 - Change OpenCL version number from 1771 to 1772.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1518 edit
[ROCm/clr commit: 1d86140b9a]
EPR #010002 - Change OpenCL version number from 1770 to 1771.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1517 edit
[ROCm/clr commit: fd97e52530]
foreman