SWDEV-2 - Change OpenCL version number from 2500 to 2501.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2248 edit
SWDEV-120036 - Supporting the cl_amd_device_attribute_query on the ROC device - Back out changelist 1459984
- not all device attributes are supported, will re-submit the changes when every attribute is supported.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#64 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.cpp#26 edit
SWDEV-111439 - Add query for preferred constant size
- fixed a mistake of using 64KiB for the size, which should be 16KiB.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#576 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#62 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#63 edit
SWDEV-2 - Change OpenCL version number from 2499 to 2500.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2247 edit
SWDEV-2 - Change OpenCL version number from 2498 to 2499.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2246 edit
SWDEV-129129 - [[CQE OCL][Vega vs Fiji] Upto 12% Performance drop observed on VEGA10 compared to FIJI while running BlackMagic Davinci Resolve
More benchmark tuning:
- Keep system memory locked in the resource cache. That removes huge amount of lock/unlock calls to OS due to the resource creation and destruciton
- Reduce the command buffer size to 256 commands and incrrease the amount of CBs to 16
- Increase the amount of resident resources to 2048
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#574 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#58 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#31 edit
SWDEV-2 - Change OpenCL version number from 2497 to 2498.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2245 edit
SWDEV-132238 - [CQE OCL][Vega10][DTB-Blocker][QR] 'Allocation (Single)' test of WF Conformance is failing; Faulty CL# 1451444
- Disable reporting extra HBCC memory by default. Reporting extra memory can be reenabled with GPU_ADD_HBCC_SIZE=1
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#60 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#280 edit
SWDEV-2 - Change OpenCL version number from 2496 to 2497.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2244 edit
SWDEV-130808 - set the local sizes to preferredWorkGroupSize_ when clEnqueueNDRange is not given and the kernel does not have required workgroup sizes.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#320 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#411 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#56 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#43 edit
SWDEV-130722 - Channel order in an interop buffer from OpenCL to OpenGL is flipped on Vega
Follow up for CL#1456230. Adding a new table that maps the OGL surface formats (hData.format) returned by wglResourceAttachAMD function into the OCL image format. The hData.format is the internal image surface format created for an interop by OGL and should be used by OCL for cl_gl interop.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/13421/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevicegl.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#36 edit
SWDEV-122517 - DVR toolbar and timer are corrupted when recording in fullscreen with portrait oriented monitors using Eyefinity.
Fixed by obtaining the rotation information from OGL driver and set tha displayable attribute accordingly. (For OCL RT changes)
- fix the type casting issue that causes build error
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDeviceGL.cpp#31 edit
SWDEV-122517 - DVR toolbar and timer are corrupted when recording in fullscreen with portrait oriented monitors using Eyefinity.
Fixed by obtaining the rotation information from OGL driver and set tha displayable attribute accordingly. (For OCL RT changes)
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDeviceGL.cpp#30 edit
SWDEV-2 - Change OpenCL version number from 2495 to 2496.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2243 edit
SWDEV-130808 - Add support of two new queries: CL_DEVICE_PREFERRED_WORK_GROUP_SIZE_AMD, CL_DEVICE_MAX_WORK_GROUP_SIZE_AMD.
- Restore the original behavior when setting GPU_MAX_WORKGROUP_SIZE.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpusettings.cpp#356 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#33 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocsettings.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#279 edit
SWDEV-2 - Change OpenCL version number from 2494 to 2495.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2242 edit
SWDEV-129129 - [[CQE OCL][Vega vs Fiji] Upto 12% Performance drop observed on VEGA10 compared to FIJI while running BlackMagic Davinci Resolve
- Force tiny read_only buffers into USWC memory. That will avoid expensive tiny data uploads, which occur every frame.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#59 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#278 edit
SWDEV-130808 - Add support of two new queries: CL_DEVICE_PREFERRED_WORK_GROUP_SIZE_AMD, CL_DEVICE_MAX_WORK_GROUP_SIZE_AMD.
- Initialize the "preferredWorkGroupSize_" for CPU device so that CL_MAX_WORK_GROUP_SIZE correctly reports CPU_MAX_WORKGROUP_SIZE.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpudevice.cpp#281 edit
SWDEV-2 - Change OpenCL version number from 2493 to 2494.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2241 edit
SWDEV-130305 - For Vega CF configuration on specific chipset (AMD Ryzen 7 1800X) slave ASIC comes out of BACO when ReLive is enabled
- Finalize() in PAL shouldnt be called during enumeration. This creates a paging queue in WDDM which causes the second GPU to come out of BACO. Move Finalize to initializeHeapResources.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/13410/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#56 edit
SWDEV-130722 - Channel order in an interop buffer from OpenCL to OpenGL is flipped on Vega
OCL calls glGetTexLevelParameteriv_ function to get the internal GL format but this format is the one chosen by app in OGL API such as glTexImage2D.
The issue is that OGL sometimes selects a different format than defined in the glTexImage2D and this causes some issues in cl_gl interop. One example is shown below
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA/**internal format**/, width, height, 0, GL_BGRA/**external format**/, GL_UNSIGNED_BYTES, NULL);
in this case GL_RGBA is selected by app as the internal format but OGL switches to BGRA8 internally and causes an issue later in cl_gl interop (i.e., R and B channels are swapped) because OCL gets GL_RGBA as the internal format in the glGetTexLevelParameteriv_ call.
To avoid this issue, OCL needs to query the real internal gl format in wglResourceAttachAMD and adjusts the CL format accordingly.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/13408/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevicegl.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#35 edit
SWDEV-2 - Change OpenCL version number from 2492 to 2493.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2240 edit
SWDEV-131497 - [CQE OCL][Vega10][OclTst][QR][DTB-Blocker] 'Spir' test of OCLTST is crashing randomly 3/10 times; Faulty CL# 1451293
- The test doesn't release command queues, which may cause a crash on the device destruction. Force the app's queue destruction if the app didn't release them.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#54 edit
SWDEV-2 - Change OpenCL version number from 2491 to 2492.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2239 edit
SWDEV-79278 - [OCL][PAL] refactoring PAL Null device create function to account for creating all the gfx9+ subtarget devices such as gfx901/gfx902/etc
ReviewboardURL = http://ocltc.amd.com/reviews/r/13378/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#53 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.hpp#18 edit
SWDEV-131493 - [CQE OCL][Vega10][QR][DTB-Blocker] Soft Hang is observed while running 'Mipmaps-clCopyImage' tests of WF Conformance due to Faulty CL# 1451293
Multiple runtime locks could conflict each other:
- Remove PAL lock from the resource creation/destruction. PAL should be thread safe for those operations.
- Avoid queue execution lock for a mipmap view destruction in submitUnmapMemory
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#34 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#55 edit
SWDEV-79278 - [OCL] Dont add gfx9+ devices into offline devices list in orca path as they will be added in pal.
ReviewboardURL = http://ocltc.amd.com/reviews/r/13396/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#569 edit
SWDEV-131312 - [CQE OCL][DTB][DTB-BLOCKER][Perf][QR][VEGA] Compubench test are not completing due to faulty CL#1451293
- Mark active vgpu only for pinned memory
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.cpp#16 edit
SWDEV-131311 - [CQE OCL][DTB][DTB-BLOCKER][Perf][QR][VEGA] BasemarkCL test are not completing due to faulty CL#1451293
- After a view destruction the original object is no longer can be associated with a vgpu
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#33 edit
SWDEV-2 - Change OpenCL version number from 2490 to 2491.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2238 edit
SWDEV-2 - Change OpenCL version number from 2489 to 2490.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2237 edit
SWDEV-86035 - Code clean-up
- Use TS check first to avoid LogError
- Reset VirtualGPU reference if resource was cached
- Lock active VirtualGPU on release, since a cached resource can have access to that queue from another thread
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#54 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#30 edit
SWDEV-79278 - [OCL][NV10] adding Pal::GfxIpLevel::GfxIp10 into couple of places and fixing a typo in GfxIpDeviceInfo table (gfx801 should be 810)
ReviewBoardURL = http://ocltc.amd.com/reviews/r/13369/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#28 edit
SWDEV-2 - Change OpenCL version number from 2488 to 2489.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2236 edit
SWDEV-128844 - OpenCL conformance test 2.0/gl/test_gl.exe fails to run on Vega10
Before switching to PAL on gfx9, we didnt need to pass any argument for running Conformance tests and the first GPU device was selected automatically to run the tests.
But after switching to PAL, we need to explicitly pass either gpu or GPU_DEVICE_TYPE_GPU as an argument to run Conformance tests otherwise the tests are failing (clGetDeviceIDs failure)
The reason for this issue is that the logic for creating device and null devices (offline devices) changed after switching to PAL for gfx9+ devices.
To fix this issue, dont assign an offline device as "default" device.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/13360/diff/2/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#212 edit
SWDEV-2 - Change OpenCL version number from 2487 to 2488.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2235 edit
SWDEV-2 - Change OpenCL version number from 2486 to 2487.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2234 edit
SWDEV-2 - Change OpenCL version number from 2485 to 2486.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2233 edit
foreman