SWDEV-76870 - Add write feature to AMD extension (Merging //depot/rel/r6/15.30.1023/stream/opencl/... to //depot/stg/opencl/drivers/opencl/...)
Add clEnqueueReadBufferToFileAMD function to AMD extension (added declaration in cl_context.cpp)
1. Added clEnqueueReadBufferToFileAMD_fn function declaration to cl_ext.h
2. Added LiquidFlashFile::writeBlock method who implements transfer from GPU to SSD. In order to avoid code duplication LiquidFlashFile::readBlock and LiquidFlashFile::writeBlock is called from new method LiquidFlashFile::transferBlock (changes in cl_lqdflash_amd.cpp)
3. clEnqueueWriteBufferFromFileAMD and clEnqueueWriteBufferFromFileAMD call internal function EnqueueTransferBufferFromFileAMD who makes the same preparations as clEnqueueWriteBufferFromFileAMD in the prvious release
4. WriteBufferFromFileCommand class is renamed to TransferBufferFromFileCommand and new class makes the same preparation except assigning transfer direction (read or write)
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_context.cpp#48 integrate
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_lqdflash_amd.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_lqdflash_amd.h#4 integrate
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/headers/opencl2.0/CL/cl_ext.h#24 integrate
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#267 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#396 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.hpp#138 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#74 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#81 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.hpp#96 edit
SWDEV-2 - Change OpenCL version number from 2042 to 2043.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1789 edit
SWDEV-2 - Change OpenCL version number from 2041 to 2042.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1788 edit
SWDEV-2 - Change OpenCL version number from 2040 to 2041.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1787 edit
SWDEV-2 - Change OpenCL version number from 2039 to 2040.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1786 edit
SWDEV-2 - Change OpenCL version number from 2038 to 2039.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1785 edit
SWDEV-2 - Change OpenCL version number from 2037 to 2038.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1784 edit
SWDEV-2 - Change OpenCL version number from 2036 to 2037.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1783 edit
SWDEV-2 - Change OpenCL version number from 2035 to 2036.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1782 edit
SWDEV-2 - Change OpenCL version number from 2034 to 2035.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1781 edit
SWDEV-2 - Change OpenCL version number from 2033 to 2034.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1780 edit
SWDEV-78299 - Back out changelist 1236441 since OCLCreateBuffer fails.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#541 edit
SWDEV-78299 - [Brahma] Setting max single allocation size by comparing cardMemAvailableBytes with cardExtMemAvailableBytes on Brahma.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#540 edit
SWDEV-2 - Change OpenCL version number from 2032 to 2033.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1779 edit
SWDEV-2 - Change OpenCL version number from 2031 to 2032.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1778 edit
SWDEV-68792 - [OpenCL][HWS/CWSR] Adding support for Hardware Scheduler and Compute Wave Save restore (CWSR) feature on ORCA
Adding a temporary w/a for a CP uCode bug in HWS mode. Due to this bug, CP uCode loops through a RUNLIST unless there is a submission on all queues in HWS mode. This causes some overhead and performance drop in PCMark8 on CZ in HWS mode. To work around this issue, it was suggested to submit a dummy packet during initialization on all available queues on HWS mode so that CP uCode can break the loop. This w/a should be removed once CP uCode provides a final fix for this issue.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/9616/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#160 edit
SWDEV-2 - Change OpenCL version number from 2030 to 2031.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1777 edit
SWDEV-86836 - Enhance caching library class to prepare one-stage kernel caching by:
0. Moving cache storage setup into constructor
1. Controlling cache storage size
2. Explicit cache cleanup
a. -kcache-wipe is off by default; when turned on, the caching directory would be wiped off
b. Here it's just an option. The implementation (the call of wipeCacheFolders()) will be added in the compiler library
3. Enforcing cache miss (actual compilation enforcing and adding a new entry to the cache storage).
a. -kcache-enforce-miss is off by default; when turned on, the real compilation will be enforced
b. Here it's just an option. The implementation will be added in the compiler library
ReviewBoardURL = http://ocltc.amd.com/reviews/r/9726/
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/OPTIONS.def#134 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/caching/cache.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/compiler/tools/caching/cache.hpp#7 edit
SWDEV-2 - Change OpenCL version number from 2029 to 2030.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1776 edit
SWDEV-2 - Change OpenCL version number from 2028 to 2029.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1775 edit
SWDEV-2 - Change OpenCL version number from 2027 to 2028.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1774 edit
SWDEV-86885 - [CQE OCL][2.0][QR][CFX] Few SDK 64 and 32 bit Samples resulting in Soft/hard hangs with faulty cl: 1233743
Unsubmit CL1233743 because of problems with CFX.
I have not been able to figure out how Cl1233743 would cause a problem. It sets a flag, to disable new code... I would expect the new code to be the problem, not the disable.
So, in case this unsubmit does not elminate the problem, CL1233686 is shelved, to use #ifndef CAL_SUPPORT around the new code in CL1226184.
CL1233743 was submitted for:
SWDEV-86253 - [QR] 6 to 7% performance drop is observed in BasemarkCL test
CL1226184 adds serialization to LHIO, because pxproxy accesses global state, without locks, leading to crash, etc.
To fix OpenCL perf regressions, allow unserialized access to pxproxy. It may be that OpenCL design leads away from racy behavior, so it may be safe. This was checked in to gather information. What software gets perf drops? Does any software get fixed?
The dangerous functions are CreateDevice, CreateContext, because the handles from the OS are saved in global caches, and if those global caches are modified in one thread, while other threads are looking-up from the caches - that is a problem.
CL1226184 was submitted for:
SWDEV-80442 - [QR][Adobe Premier Pro CS6] TDR/App Crash observed while resizing the video window within workspace
TC: http://ocltc:8111/viewModification.html?modId=66278&personal=true
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#159 edit
SWDEV-2 - Change OpenCL version number from 2026 to 2027.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1773 edit
SWDEV-2 - Change OpenCL version number from 2025 to 2026.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1772 edit
SWDEV-2 - Change OpenCL version number from 2024 to 2025.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1771 edit
SWDEV-86253 - [QR] 6 to 7% performance drop is observed in BasemarkCL test
CL1226184 adds serialization to LHIO, because pxproxy accesses global state, without locks, leading to crash, etc.
To fix OpenCL perf regressions, allow unserialized access to pxproxy. It may be that OpenCL design leads away from racy behavior, so it may be safe. This was checked in to gather information. What software gets perf drops? Does any software get fixed?
The dangerous functions are CreateDevice, CreateContext, because the handles from the OS are saved in global caches, and if those global caches are modified in one thread, while other threads are looking-up from the caches - that is a problem.
TC: http://ocltc:8111/viewModification.html?modId=66278&personal=true
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#158 edit
SWDEV-2 - Change OpenCL version number from 2023 to 2024.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1770 edit
SWDEV-2 - Change OpenCL version number from 2022 to 2023.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1769 edit
SWDEV-2 - Change OpenCL version number from 2021 to 2022.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1768 edit
SWDEV-2 - Change OpenCL version number from 2020 to 2021.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1767 edit
SWDEV-2 - Change OpenCL version number from 2019 to 2020.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1766 edit
SWDEV-2 - Change OpenCL version number from 2018 to 2019.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1765 edit
SWDEV-85649 - The return of owner() needs to be casted to get amd::Image.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpumemory.cpp#125 edit
SWDEV-79308 - Use 64-bit to calculate the scratch buffer size for OCL. We observed that the computed scratch buffer size could be > 4G when compilier optimization option is not used.
Cross branch change - requires CL1231547.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLDevice.cpp#157 edit
SWDEV-2 - Change OpenCL version number from 2017 to 2018.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1764 edit
SWDEV-2 - Change OpenCL version number from 2016 to 2017.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1763 edit
SWDEV-2 - Change OpenCL version number from 2015 to 2016.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1762 edit
SWDEV-2 - Change OpenCL version number from 2014 to 2015.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1761 edit
SWDEV-2 - Change OpenCL version number from 2013 to 2014.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#1760 edit
foreman