Commit Graph

122 Commits

Author SHA1 Message Date
Jiabao Xie 3ab54974dc SWDEV-374375 - moving nullptr check into hipGraphNode::isValidNode
Change-Id: Ic9264521d6f0b36ffc948ca9feeaa70eb6e98eb6


[ROCm/clr commit: 03200953e5]
2023-01-09 16:27:38 -05:00
Jiabao Xie 078f931d73 SWDEV-374375 - Added checks to see if hip graph nodes are valid
Change-Id: I9e6eabf0e4a9100de6f9d26bf5b815957f12d4f2


[ROCm/clr commit: e5490697cc]
2023-01-06 16:58:56 -05:00
Jaydeep Patel f9574cd645 SWDEV-374372 - Return invalid value if pitch is less than width in bytes.
Change-Id: I33806d747cd344250d02e217de8e9b6d5a7f83c1


[ROCm/clr commit: 7c32f66e67]
2023-01-05 10:40:14 -05:00
sdashmiz 09a1db7005 SWDEV-370309 - GetNodes should do levelorder
- GetNode should retrun nodes based on the dependency between them

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie8ecdd976f8dc9d9b5dc2adc6ae8f879912c8169


[ROCm/clr commit: ce60d47b61]
2023-01-03 04:54:55 -05:00
Jaydeep Patel 5bc671c8c6 SWDEV-374382 - Change hip error type to context is destroyed instead for invalid stream.
Change-Id: I5ed22463204d7bff3741599eeced3d030da78fc4


[ROCm/clr commit: 845bf0adb4]
2022-12-21 12:54:39 +00:00
sdashmiz 6a661a9f15 SWDEV-367833 - return success for null stream
- return success for query on null stream

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ifc2cf705e1962565c68de7b1777f870c5a4d56cf


[ROCm/clr commit: fefff25364]
2022-12-08 11:41:37 -05:00
pghafari ed6108c2d6 SWDEV-368166 - hipGraphAddMemcpyNode1D paramcheck
adding parameter check for hipGraphAddMemcpyNode1D

Change-Id: I94dc944bd55ea04b8e9288a27c8f58dd3720161b


[ROCm/clr commit: 5acc2cdcc2]
2022-12-07 18:29:11 -05:00
Anusha GodavarthySurya 38b4f50f9c SWDEV-371206, SWDEV-371163 - Fix hipGraphNodeGetEnabled/SetEnabled negative scenarios
Change-Id: Icf4bcca743c2188ee89dbdc8eb32d9d727b95227


[ROCm/clr commit: ac0db17b54]
2022-12-01 12:28:29 -05:00
sdashmiz 7c73bbece6 SWDEV-366974 - return implicit capture for null stream
- return implicit error if null sream is passed while blocing stream is
  in operation

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4d867a0bddd855e2c0d3eb9b769d5d36412c20c0


[ROCm/clr commit: f93dfb2a4e]
2022-11-30 13:45:26 -05:00
Anusha GodavarthySurya e7fa085afe SWDEV-325711 - Correct formatting
Change-Id: Ie26159e0bb3315cf7c3de1eb682f23ef343df0f2


[ROCm/clr commit: 16b31b0c54]
2022-11-30 05:15:01 +00:00
Anusha GodavarthySurya 5780c7066f SWDEV-325711 - Added graph API hipGraphUpload
Change-Id: I7e4c8c997a5ef940000d599ded9d317d62b8826b


[ROCm/clr commit: 596b16da5a]
2022-11-30 04:40:17 +00:00
Anusha GodavarthySurya f97723d118 SWDEV-325711 - Added implementation for graph API hipGraphKernelNodeCopyAttributes
Change-Id: I576d0e81c69097fe881556f6d022bb7c7ca3287b


[ROCm/clr commit: 3a9621574c]
2022-11-29 02:53:14 +00:00
Anusha GodavarthySurya 58201c1b92 SWDEV-325711 - Added implementation for graph APIs GetEnabled & SetEnabled
Change-Id: I15a165b3dc548d00b7f5458e1b322b192b8c0d76


[ROCm/clr commit: 1ab46fe7ae]
2022-11-28 21:50:36 -05:00
Anusha Godavarthy Surya a13afd3aca SWDEV-366653 - Added Implemention of DOT file generation for graph
Change-Id: I5ab6a58e49451b5e04f2e93bf594b985ac58cc8d


[ROCm/clr commit: 08c4619fab]
2022-11-24 11:02:21 -05:00
sdashmiz bafdaa4f31 SWDEV-365587 - reuse the id from capturing stream
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I65f5be3fcc4cffcf3eb5762fd0b43fd051c145c2


[ROCm/clr commit: b665b9a6e8]
2022-11-24 10:35:14 -05:00
Anusha GodavarthySurya 0645ad4576 SWDEV-366653 - Added new graph APIs - Fix windows build
Change-Id: I580133bddcbab5529aecfb70bc9776e8c40de697


[ROCm/clr commit: 78eef7f173]
2022-11-23 08:57:49 +00:00
sdashmiz dc97f3719e SWDEV-366974 - add proper error
- Null stream correct error when blocing stream is being captured

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0d902a4f4ef02736a6db60ba7bffa7c20011bc84


[ROCm/clr commit: c5e7b56463]
2022-11-21 10:39:21 -05:00
sdashmiz 234dc08f7c SWDEV-361592 - allow nullptr for userdata in hiphostfunc
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I91728d363846ac6417d4a59920509ffacd4c9a58


[ROCm/clr commit: 9c83b3e0b2]
2022-11-04 13:37:17 -04:00
sdashmiz a75852fb97 SWDEV-357917 - correct userobj for negative test cases
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6a2a74c763d2b938430ca53a14360f459af04665


[ROCm/clr commit: 4fc9df2a1a]
2022-10-24 10:27:02 -04:00
Anusha GodavarthySurya a0981e4ccd SWDEV-357759, SWDEV-360041, SWDEV-361145 Fix Stream end capture on forked streams
Change-Id: If0dc6242d2d3ca680e37e14a5dea5cf68dc295df


[ROCm/clr commit: 039e26ee0f]
2022-10-12 13:00:05 -04:00
Rakesh Roy f149b21399 SWDEV-351969 - TLS Optimization
- Aggregate all TLS(Thread Local Storage) variables into a single class
- This is to improve cache accesses per thread

Change-Id: Ic8361eaeae290fff00254684e309471958365eb9


[ROCm/clr commit: 8b391ef18c]
2022-10-09 22:08:14 -04:00
Tao Sang 2be45a82ec SWDEV-318349 - Fix hipGraphKernelNode and hipGraphMemcpyNode
For hipGraphKernelNode, remove func_;
and reorganize functions to naturely support mGPU;
For hipGraphMemcpyNode, make EnqueueCommands() support different
queues' sync
Change-Id: I22708923f454adf4456ff99d25559daffed8c20d


[ROCm/clr commit: f83ba8cd23]
2022-10-07 09:07:56 -04:00
Anusha Godavarthy Surya 459e9539b2 SWDEV-354717 - Fix hipExtLaunchKernel as part of stream capture
Change-Id: Ic29d7403dfa38f01bec423aa1df7aa75c60a86e2


[ROCm/clr commit: 7f4c711ac1]
2022-09-01 19:26:14 +00:00
Anusha Godavarthy Surya ed2f9051fa SWDEV-354717 - Add support for hipExtLaunchKernel as part of stream capture
Change-Id: I22708923f454a0f4456ff99d25559daffe08c208


[ROCm/clr commit: 2b322a9087]
2022-09-01 05:02:20 +00:00
Anusha Godavarthy Surya 67706897e0 SWDEV-352951 - Add capture support for hipModuleLaunchKernel
Change-Id: Iced0846c9f753ecbb87e3f7aec2bfd72137d8c00


[ROCm/clr commit: c72942964d]
2022-08-31 22:15:02 -04:00
sdashmiz 66ed5e2057 SWDEV-352290 - correct params checks
- correct condition for flags

- remove check for num of dependency

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6efd918e203b57c840d74ee0243f24b0c2c80e21


[ROCm/clr commit: a10df01f81]
2022-08-24 14:09:51 -04:00
sdashmiz 72703ab50f SWDEV-352290 - remove the static list for user obj
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I8d7542ad5aacdda4e817c6aaed78c9cac4562efd


[ROCm/clr commit: ce5103ac97]
2022-08-24 12:01:41 -04:00
Anusha Godavarthy Surya 0e1f53bf87 SWDEV-350474 - Added hipExtModuleLaunchKernel API support as part of stream capture
Change-Id: I90a880ae0d3a85a0cc8380d2cb21e4759ea8151b


[ROCm/clr commit: 0d6e8e378e]
2022-08-24 11:20:22 -04:00
sdashmiz 213aad7615 SWDEV-325711: Add userobject functions for graph
- add user obj APIs for creating release and retain of user onbjects

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0bf2999c77e44269565b27c31c7c1461f8a160a2


[ROCm/clr commit: 2c010dec17]
2022-08-17 14:31:43 -04:00
Ajay e6565f3209 SWDEV-327563 - Unit_hipGraphAddKernelNode_Negative null kernelparams fix
Change-Id: Id05f8944f41c04036b310b23358c908a8efb5a5b


[ROCm/clr commit: 4274863f5d]
2022-07-12 12:41:28 -04:00
Sarbojit Sarkar c9226df336 SWDEV-323441 - Phase-II : per thread default stream
Change-Id: I3c796ddaebcf0223d7faf50c425c1674de215f9d


[ROCm/clr commit: e9961fedd8]
2022-07-11 12:22:23 -04:00
Sourabh Betigeri a4b6127a80 SWDEV-273026 - Fixes to retrieve valid device memory data when device context is changed and p2p is enabled
Change-Id: Ie3f0b81f7fc6de8df65ccff35f9aefb8f6abdfbe


[ROCm/clr commit: 8d48e0e6be]
2022-07-08 01:45:49 -04:00
sdashmiz 57a0d997d3 SWDEV-325711 - add Graph memory APIs skeleton
- hipDeviceGet/SetGraphMemAttr

- hipDeviceGraphMemTrim

- there is no memory pool for graphs currently

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I11db76ea7ea1c7732175fc93264448052357e8dc


[ROCm/clr commit: e8194dca76]
2022-06-15 14:47:16 -04:00
Sourabh Betigeri 2c9c07aaa8 SWDEV-331301 - Fixes to return error if the childGraph topologies of instantiated childGraphNode and to-be updated childGraphNode do not match
Change-Id: I372317a4df13e5cd352f46525d820246fe4ca8f2


[ROCm/clr commit: c3db564e94]
2022-06-15 13:39:15 -04:00
Sourabh Betigeri 5d26e66ed7 SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3


[ROCm/clr commit: 5549c8cd1b]
2022-06-14 18:06:21 -04:00
Sourabh Betigeri f3d7a42714 SWDEV-340453 - Fixes coding error. Missing condition in a negative scenario
Change-Id: Ic4b71e143ec883ca73a2511a367ac034444ec7de


[ROCm/clr commit: 2f9e92757c]
2022-06-14 12:24:10 -04:00
agunashe af679a5f1c SWDEV-337331 - Windows graph fixes iteration2
API fixed hipGraphAddDependencies

Change-Id: I1248c00d788c392c71e64c5070fe09653125bb34


[ROCm/clr commit: 9e7b44511a]
2022-06-10 16:42:54 -04:00
sdashmiz 3f588bf604 SWDEV-318833 - Get and Set attribute for kernel nodes
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>


[ROCm/clr commit: efd2d55e9d]
2022-06-09 09:47:05 -04:00
Rakesh Roy f80bffb4ab SWDEV-337776 - Fix hipStreamEndCapture API
- Return hipErrorInvalidValue when pGraph is nullptr

Change-Id: I8846f4448eb15117f98421632885330f132c4fce


[ROCm/clr commit: e2874d5e22]
2022-06-01 00:20:23 -04:00
Sourabh Betigeri ea9847c1fd SWDEV-320640 - Fixes to return right error codes in hipStreamUpdateCaptureDependencies() for negative scenarios
Change-Id: I3c4c54f8955fa9bb17eb595544005fe9f0e8a5f0


[ROCm/clr commit: 5a057af564]
2022-05-31 14:09:22 -04:00
kjayapra-amd 9bc0d08679 SWDEV-290384 - Add Linker API support in hiprtc
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0


[ROCm/clr commit: 84f94fd134]
2022-05-24 09:16:14 -04:00
pghafari b2188142d9 SWDEV-336576 - updated graph check
hipGraphExecMemcpyNodeSetParamsFromSymbo was not working in functional
case

Change-Id: I2ad04f6f91519efa075c36fe737a695fa1bc127a


[ROCm/clr commit: bb9e52ab9f]
2022-05-17 17:36:10 -04:00
Sourabh Betigeri 1171423bcf SWDEV-329829 - Fixes to return right error codes for respective negative scenarios
Change-Id: Icb615a336bb846df1cf2811316d88a0e88381da8


[ROCm/clr commit: 5fa514fea0]
2022-05-10 12:56:20 -04:00
Sourabh Betigeri 9caddbf38a SWDEV-331301 - Fixes error code mismatch
Change-Id: I8dda98609b16ea5c1ce4d9db9471e61e5fb0c12c


[ROCm/clr commit: bd851550bd]
2022-04-13 18:51:06 -07:00
Sourabh Betigeri 89ca29819e SWDEV-329848 - Fixes error code mismatch between CUDA and HIP
Change-Id: Ic48de159ca7bdb4b91dadb915972e535518635ae


[ROCm/clr commit: 345e02358c]
2022-04-12 15:00:44 -04:00
Sarbojit Sarkar 85f6f2a0c7 SWDEV-331126 - Fix to Cuda return type
Change-Id: Iea8e7735ef0c58c1244c92338038d91e61d62c16


[ROCm/clr commit: 8657c40721]
2022-04-11 23:35:04 -04:00
Payam 8a6fd0bd65 SWDEV-316819 - graph check ChildGraphNodeGetGraph
Change-Id: Id3a4fb64e6fb5ce37e97f1f3518e09c8bd9a2d0c


[ROCm/clr commit: 8618b1cd07]
2022-04-05 01:24:36 -04:00
Payam Ghafari 37fa31aaa8 Revert "SWDEV-316819 - adding graph checks"
This reverts commit eff4583118.

Reason for revert: Catch2 test fails

Change-Id: If0ea0eab16b50f27c9acbc471530266917773ff1


[ROCm/clr commit: d888c0a9bf]
2022-03-23 15:23:00 -04:00
Ajay ff6fb01aa1 SWDEV-315567 - hipGraphNodeTypeEventRecord node type get/set fixes
Change-Id: I76e866990a153fb254e1187e7fabcc1f93806469


[ROCm/clr commit: ed487980cd]
2022-03-23 14:05:31 -04:00
Sourabh Betigeri 636464ff5f SWDEV-316991 - Returns hipErrorInvalidValue when a wrong node type is passed to hipGraphExecEventWaitNodeSetEvent and hipGraphExecEventRecordNodeSetEvent APIs
Change-Id: Ic80b0b2b154e017b41af617f5049e037a1b66183


[ROCm/clr commit: f73ff54fda]
2022-03-22 18:09:10 -04:00