Commit Graph

2113 Commits

Author SHA1 Message Date
Julia Jiang 3c7ae28776 SWDEV-472710 - Adding gitattributes and remove trailing spaces
Change-Id: Ic8ad2071745f0ffe6a2e120bfebb6d90bf270f87


[ROCm/clr commit: dd30e0e893]
2024-07-15 12:39:56 -04:00
sdashmiz ba07492b20 SWDEV-421021 - Add APIs cuMemcpyNodeGet/Set params
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I24bc0da56aad34c9d5876a3d83b59515f11dc3ea


[ROCm/clr commit: 57e79802cd]
2024-07-10 12:53:01 -04:00
Ioannis Assiouras 376da06e2f SWDEV-469825 - Modified the kernel argument readback to use a pointer to volatile
This change modifies the readback mechanism to use a pointer to volatile
instead of a volatile pointer. This ensures that the compiler does not
optimize away the read operation.

Change-Id: I79ff925d615aa8cc4f950e8ff4b7e608fcb179a4


[ROCm/clr commit: ea50d2c0c2]
2024-07-09 17:28:47 -04:00
sdashmiz 0678768fd3 SWDEV-429053 - Add more check for hipStreamLegacy
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Iaf802372b160b09e5e8451074af1731e4f1d410a


[ROCm/clr commit: 7257f56c60]
2024-07-08 13:55:54 -04:00
Jaydeep Patel 130b72302a SWDEV-457316 - Return invalid val from add mem free node if corresponding mem alloc node is missing.
Change-Id: Ib0c346a439fc38ebfd106bcbdf75bd10bfd2f090


[ROCm/clr commit: cf0320a0b9]
2024-07-04 13:09:46 -04:00
Saleel Kudchadker ff12be080d SWDEV-465602 - Fix random segfault
- Introduce a lock when checking isUserObjectValid. We need a lock
here as one can remove the userObject T2, leading to buffer overflow
when checking ranges in T1.

Change-Id: I058144b8cc463c90ab6bf5cf96bf937897742917


[ROCm/clr commit: 6ac67afdd5]
2024-07-03 18:57:23 -04:00
Jaydeep Patel e08f11ca8e SWDEV-465088 - Bypass memcpy kind check for H2H memcpy if XNACK is enabled.
Change-Id: I3e9b23dfb1aedeaf5ea0f26668caddb277ead809


[ROCm/clr commit: 7d7db316b3]
2024-07-01 01:03:42 -04:00
Anusha GodavarthySurya af6dd5d865 SWDEV-469331 - Fix issue of graph sync.
If graph has multiple branches, End command is enqueued on launch stream which
makes sure all the internal parallel streams are finsihed.

When node is removed from the graph, indegree and outdegree are not getting update correctly for parent, child nodes and
resulting in endNode not having deps on parallel commands. Resulting in graph sync issues.

Change-Id: I33cc2f21220e1c017d88099b29b542e05b683f73


[ROCm/clr commit: 9ad7e79e50]
2024-06-28 02:11:44 -04:00
Ioannis Assiouras c407812add SWDEV-468381 - Fixed use of vaddr_sub_obj in GraphMemFreeNode
Resolved an issue where a freed virtual buffer was incorrectly
added to the global mapping causing an assertion error during
teardown process.

Change-Id: I4801157a28603ce9be1ca0131982b700ff884f7a


[ROCm/clr commit: 1c6b92627d]
2024-06-27 16:20:47 -04:00
Saleel Kudchadker 17a46aa40b SWDEV-465602 - Refactor kernel arg pool allocation for graphs
- Allocate additional argument space to accomodate for kernel node
param updates

Change-Id: I2d4ea8bddd716f1191f3cbea807920d0248f8c4e


[ROCm/clr commit: 17313ec99d]
2024-06-25 18:28:03 -04:00
Rahul Manocha 0784937e1e [SWDEV-468553] - Add stream validation checks for memcpy APIs
Change-Id: Ic4495d10c8b2d2ac90f7093a08209d9cb373d2a6


[ROCm/clr commit: f309d49b32]
2024-06-24 12:47:31 -04:00
Ioannis Assiouras f07198d7e5 SWDEV-469138 - Added fix for find_package(LLVM)
Changed find_package call to prioritize the package that is
found under the rocm installation over other system locations

Change-Id: Ice93c94bbb9cdebd467d3e88bb2e4bfb7a1e76d9


[ROCm/clr commit: 6b9e89fe0c]
2024-06-20 11:03:08 -04:00
Ioannis Assiouras 0a42617f58 SWDEV-465236 - Changed RTCProgram::findIsa to not dlopen amdhip64 for static build
Change-Id: I322ef4ca96ea426a0953f1234e60db6cebb09886


[ROCm/clr commit: 7b0259c4b7]
2024-06-20 10:55:57 -04:00
Ioannis Assiouras 455ada60a2 SWDEV-468133 - Fixed hipDeviceGetLimit for hipLimitMallocHeapSize
Change-Id: I91bede414ebe46831509cbd24ffb53cf129d6a40


[ROCm/clr commit: 2aed4cf401]
2024-06-20 10:55:15 -04:00
taosang2 83eb6e766d SWDEV-465162 - Fix some issue with image support
Fix some small issues regarding image and mipmap support

Change-Id: I8e64223d44f37c2dbb115cbb343441a48021ba7b


[ROCm/clr commit: 1566ff7639]
2024-06-18 16:38:24 -04:00
Anusha GodavarthySurya 291f079669 SWDEV-467102 - Hidden heap init for graph capture
If the graph has kernels that does device side allocation,  during packet capture, heap is
allocated because heap pointer has to be added to the AQL packet, and initialized during
graph launch.

Handle race with wait when 2 kernels with device heap are enqueued on multiple streams.

Change-Id: I45933b77fcaf7bc8fdf1bc906462e32b5d8d3688


[ROCm/clr commit: 57156c524d]
2024-06-17 02:07:25 -04:00
Branislav Brzak c2128d0af9 SWDEV-465203 - Treat 0 elf length images as invalid
This addresses:
SWDEV-465203
SWDEV-465202

Change-Id: I49fcdd537fd07585e25c5fdef37cd10815466f79


[ROCm/clr commit: f014124527]
2024-06-14 04:56:43 -04:00
Marko Arandjelovic 8b557c7318 SWDEV-441296 - Fixes related to hipTexObjectCreate unit test
- Avoid potential division by zero
 - Nullptr check

Change-Id: Ic857eb4fe968173c852eb7a67934e33fc74c055f


[ROCm/clr commit: d12af175af]
2024-06-14 03:58:34 -04:00
Ioannis Assiouras dfe46a3093 SWDEV-467069 - Added safety check in activity prof for accumulate command
Adding a safety check prevents an invalid memory access
if timestamps and kernelNames vectors are of different size.

The patch also moves the addKernelNames for the accumulate command
into dispatchAqlPacket function.

Change-Id: Iea0927e1253800403a1ae3f3d72de1e7d96476c3


[ROCm/clr commit: d44f44a5b1]
2024-06-12 21:53:03 +01:00
Ioannis Assiouras af089a2171 SWDEV-463865 - namespace changes to prevent symbol conflicts in static builds
Change-Id: I09ceb5962b7aa19156909f47167c87d6887c9cd1


[ROCm/clr commit: 3edf1501cc]
2024-06-12 16:22:27 -04:00
Anusha GodavarthySurya 44ef705022 SWDEV-461072 - Add reference to function parameter
Change-Id: I9ad5dafc6d697d12fbd1675f19f88f83ad2d7b9c


[ROCm/clr commit: 3a5cbb91b9]
2024-06-12 01:20:28 -04:00
Jaydeep Patel 2897632ad9 SWDEV-457316 - Other graph can free mem alloc node and return invalid val only if there is double mem free node in all captured graphs.
Change-Id: Icf12164bf0ecd171a4673ff4f384528e7671f944


[ROCm/clr commit: 5c77e30b18]
2024-06-12 00:44:50 -04:00
Ioannis Assiouras efba3545ca SWDEV-466601 - Fix invalid mem acccess in kernarg readback path
Change-Id: I4654ae592adc8cf9c687136d45eb1b28d99c7ae1


[ROCm/clr commit: 055e05a12a]
2024-06-10 15:13:05 +01:00
Satyanvesh Dittakavi 30c4d5805e SWDEV-464927 - Update the Get by PCI BusId logic and Hop count
- Update the intra socket weight for partitions within single socket as
it is changed to 13 by the driver.
- Use the PCIe function to distinguish the partitions of the same device
such as TPX mode in gfx942.

Change-Id: I8e64023d44e37c2dbb105cbb343441a48021ba7b


[ROCm/clr commit: 1815fc808d]
2024-06-10 04:46:50 -04:00
Ioannis Assiouras 75104df3b2 SWDEV-464648 - code and comment cleanups
Change-Id: I5ba3f1bff500b3cd5903c2f441017735e688f83f


[ROCm/clr commit: 8f42ad6aa3]
2024-06-07 22:38:09 +01:00
kjayapra-amd 41cb6dadf9 SWDEV-460948 - Changes to alloc, set, capture under single function.
Change-Id: I7b2d40e99e812b97c53535c5e63c41ad64a8f543


[ROCm/clr commit: 892071aeb2]
2024-06-06 16:57:53 -04:00
Ioannis Assiouras 0e023d1a0a SWDEV-463865 - symbol renamings to prevent conflicts in static build
Change-Id: Id7fbb638c1088c23df52fee877cd790d637b1ffb


[ROCm/clr commit: b8c2ac4de4]
2024-06-06 04:05:55 -04:00
Jaydeep Patel 47b1a7b98b SWDEV-465461 - Use command's queue instead as it might be changed while constructing memcpy command on MGPU.
Change-Id: Ia6ac40289e1eea320925203cbd52b30f3b64ad2b


[ROCm/clr commit: 774a10201f]
2024-06-05 06:47:49 +00:00
kjayapra-amd 6f2179d9d8 SWDEV-458026 - Check for hsa_handle/svm_ptr before removing from MemObjMap.
Change-Id: I967735c01c6321eeb768963ecb88667dbbe92f08


[ROCm/clr commit: fa4c1a0206]
2024-06-01 17:50:54 -04:00
Tao Sang 7bf8d102fc SWDEV-433371 - Support new comgr unbundling action
Support new comgr unbundling action api to extract codebjects
in compressed and uncompressed modes.

Create HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION ENV to
toggle new path and old path.
If HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION=false(default),
   uncompressed codeobject will go old path for better perf,
   compressed   codeobject will go new path.
If HIP_ALWAYS_USE_NEW_COMGR_UNBUNDLING_ACTION=true,
   both uncompressed and compressed codeobjects will go new
   path.

Add comgr wrapper for
   amd_comgr_action_info_set_bundle_entry_ids()

Change-Id: I79952f132fe21249296685ee12cae05a4f9aec32


[ROCm/clr commit: d0050ce309]
2024-05-28 06:31:10 +00:00
Ajay 5b731168ca SWDEV-439581 - hip event flags clean up
Change-Id: I2197762d912da41a8b53b32b3446f0a958c988a6


[ROCm/clr commit: 6ec5074d74]
2024-05-28 06:31:10 +00:00
Jaydeep Patel af30acd46a SWDEV-461274 - Use GetDeviceById method.
Change-Id: I82a3feb8ecb5f151e09d0dae814b518fb84426e6


[ROCm/clr commit: f682ea7b3b]
2024-05-28 06:31:10 +00:00
Ranjith Ramakrishnan 43aeeaf836 SWDEV-442738 - Link amdhip64 and hiprtc static library with dependent libraries
comgr, hsa-runtime and other libraries are linked to amdhip64 and hiprtc static library

Change-Id: I1940d8616dcb6a0f8633db3878327fa55b516a1b


[ROCm/clr commit: b9fbc98dad]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras be39d61344 SWDEV-462570 - synchronize the streams before ipcDetach
Change-Id: Ic007be31913496af0414d983f906b704c32ac02c


[ROCm/clr commit: 0eb4ba9883]
2024-05-28 06:31:10 +00:00
Ajay cea4f4290a SWDEV-439581 - hipEventBlockingSync flag for hip events
Change-Id: I0d7785a568f8007f82f999776a7ad23d0acc81b7


[ROCm/clr commit: a5a4b78606]
2024-05-28 06:31:10 +00:00
Jaydeep Patel 24a3ca5f94 SWDEV-457316 - Some validations related to Graph Node.
Free node should be added in same graph and once.
Graph clone containing mem alloc/mem free node not supported.
Destroy mem alloc/mem free node is not supported if already added in graph.

Change-Id: I40459e66d7dd84f3b5298617990313b41458c804


[ROCm/clr commit: ca3c2ac185]
2024-05-28 06:31:10 +00:00
Anusha GodavarthySurya 3b85ba70df SWDEV-461072 - Extend AQL Optimization for child graph nodes
Change-Id: I6baf906add7240b29ea653020a9a0b56206ee2a7


[ROCm/clr commit: 243dad92c9]
2024-05-28 06:31:10 +00:00
sdashmiz 2889266aeb SWDEV-429053 - Add check for StreamLegacy
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I402185a3b81935aaa1c8c4963407b8de21c72d8a


[ROCm/clr commit: 627ccfa502]
2024-05-28 06:31:10 +00:00
Vladana Stojiljkovic bf817aeaa3 SWDEV-454681 - Add nullptr check for memsetParams in hipDrvGraphAddMemsetNode
Change-Id: Ife8784b23179c5613c29cde27dd2975cb729aaae


[ROCm/clr commit: d543ab6a0b]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker 2969f2476b SWDEV-301667 - Better log
- Print kernelname for graph launches, its hard to correlate packets
otherwise
- Print correlation_id if any

Change-Id: Ib8db7a00e4e7c98f570e71029e61d86f5dccc2ed


[ROCm/clr commit: 72d23a02c5]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker efc2de44f0 SWDEV-451594 - Fix HDP reg readback
Change-Id: I478a968330f85c3b60ff39fb40bf3cd91acd610e


[ROCm/clr commit: 1ba74c3ce3]
2024-05-28 06:31:10 +00:00
Ranjith Ramakrishnan 98fd53c2ef SWDEV-442738 - Static package generation for hip
Generate static package by combining binary and dev components.
Binary and dev component dependencies are added to the static package dependencies
Package name will have suffix static-dev/devel

Change-Id: I7eb187ceaf2af7dfaf6ff9f56de20dac72881a12


[ROCm/clr commit: 2ce57184d3]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras b8af347e8e SWDEV-445072 - Disable rocprofiler register for static libs
Change-Id: I38f4cc31ea196156aad65ca743787b27c02823ac


[ROCm/clr commit: 7d901666b8]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras c36eeeb0ec SWDEV-455444 - Add the hiprtc sources to hiprtc library for static builds
Change-Id: Ic17f22831376be37fe998aa1ec9a754738c9a147


[ROCm/clr commit: 6c8ca0b3aa]
2024-05-28 06:31:10 +00:00
Tao Sang 5bf67d7da7 Revert "SWDEV-433371 - use comgr to unbundle code objects"
This reverts commit c0ee0ffa1c.

Reason for revert: <INSERT REASONING HERE>
New comgr unbundling action leads to perf drop for uncompressed code object.   Will create a new patch to use old path for uncompressed , new unbundling api for compressed . 

Change-Id: I41ef53b71fc9f7aaa8cf231d4d70945f1117db52


[ROCm/clr commit: a1350fe8c1]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras a81f82931b SWDEV-449620 - Added hipExternalMemoryGetMappedMipmappedArray in the dispatch table
Change-Id: I79952f131dea1949296685ee92cae05a4f9aec30


[ROCm/clr commit: 7b46701142]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker 0b3e421451 SWDEV-301667 - Refactor graph code
- Remove Last graph node optimization and instead submit a barrier NOP
packet always. This simplifies the code.

Change-Id: Ied443173ba47a08b6df148ac7e3ead712acda11c


[ROCm/clr commit: badf2b0880]
2024-05-28 06:28:17 +00:00
shadi 19ce99d104 SWDEV-421027 - Add more Graph APIs
Signed-off-by: shadi <shadi.dashmiz@amd.com>
Change-Id: I0a1fc284e48317a49ca88d4ed4e3a10e752efd58


[ROCm/clr commit: e705e5e0d9]
2024-05-28 06:28:17 +00:00
kjayapra-amd 4ebecc5b98 SWDEV-459325 - Remove hiprtc sources from libhipamd64 compilation.
Change-Id: Ic70206c5936fb36a23c122e67110b91ae7e95e09


[ROCm/clr commit: 31935b1d39]
2024-05-28 06:28:17 +00:00
kjayapra-amd 0f6b315ca7 SWDEV-445072 - Fixing error on static library for hip package.
Change-Id: I96d2b9000e290739870e201b599bdef8859b971a


[ROCm/clr commit: 2cfc42368e]
2024-05-28 06:28:17 +00:00