SWDEV-79445 - OCL generic changes and code clean-up
- Keep the body of all methods in the Program interface
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#97 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#44 edit
SWDEV-79445 - OCL generic changes and code clean-up
- Move the constructor body of LightningProgram to the header
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#96 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#43 edit
SWDEV-2 - Change OpenCL version number from 2805 to 2806.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2553 edit
SWDEV-2 - Change OpenCL version number from 2804 to 2805.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2552 edit
Header files in those dirs are an integral part of clang, which includes wrapper headers for CUDA.
There is no need in checking those dirs.
[Reasons]
1. clang will not take into account empty or irrelevant include dirs;
2. Packages for different clang versions will have different header files in the above dirs.
[Reasons]
+ We don't compile kernel code at least for now as HIP kernel syntax is almost equal CUDA's;
+ clang always includes PTX in its binaries, so e.g. a binary compiled with --cuda-gpu-arch= would be forwards-compatible with e.g. sm_35 GPUs.
+ Due to latest Windows SDK implementation based on c++14 features, '-std+c++14' is a must;
+ Doesn't affect older versions of MSVC 2017, 2015 (the latest supported is MSVC 2015);
+ On linux still '-std=c++11' is a must;
+ Exclude '-std=' from lit config.
[Reasons]
+ File is opened further by clang
+ There is a regression with LLVM 5.x, when system error occurs: temporary file couldn't be renamed - permission denied.
SWDEV-2 - Change OpenCL version number from 2803 to 2804.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2551 edit
Option -o-dir for output directory:
+ if not specified source file(s) directory is used;
+ creates the directory if the directory doesn't exist (only one level in a tree);
+ if -o and -o-dir both are specified the hipified file is placed to "-o-dir" + "-o";
+ reports an error in case of a wrong directory specified, in case of necessity of creating a tree of subfolders, or in case of a filename specified.
SWDEV-2 - Change OpenCL version number from 2802 to 2803.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2550 edit
SWDEV-2 - Change OpenCL version number from 2801 to 2802.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2549 edit
SWDEV-2 - Change OpenCL version number from 2800 to 2801.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2548 edit
1. Option -temp-dir for temporary directory:
+ if not specified system temp is used;
+ creates the directory if the directory doesn't exist (only one level in a tree);
+ reports an error in case of a wrong directory specified, in case of necessity of creating a tree of subfolders, or in case of a filename specified.
2. Option -save-temps for preserving temporary files:
+ if specified temporary files are not being deleted from system temps and user temps as well.
3. Work with files in terms of calculated absolute paths by collapsing all '.' and '..' patterns, resolving symlinks and expanding '~' expression to the user's home directory:
+ to produce correct include paths;
+ to avoid possible errors on file routines.
SWDEV-2 - Change OpenCL version number from 2799 to 2800.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2547 edit
SWDEV-174551 - [CQE OCL][QR][DTB-Blocker] 7 tests are failing in Conformance | Faulty CL#1720236
- Back out changelist 1720236. Conformance swaps RGB to BGR components and fails if real RGB is used. OCL can't switch to RGB until a fix into the conformance tests will be applied.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#46 edit
foreman
Maneesh Gupta
Alex Voicu
Yaxun Sam Liu
Evgeny Mankov
Jenkins