AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
13,557 Commits 3 Branches 0 Tags
3cd3b3ffc5eba1def2b7a2b39ea9785dbdeddba7
Commit Graph

13557 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Maneesh Gupta 4477d3d314 Merge pull request #266 from gargrahul/fix_half2_gfx900 
Fixed half2 issue on gfx900
 2017-11-20 07:28:41 +05:30
Maneesh Gupta 29c0ab8401 Merge pull request #265 from phani544/nvccTests 
[nvccTests]Enabled inline_asm_vadd on nvcc
 2017-11-20 07:28:29 +05:30
Ben Sander aeadc3f18f Fix test on cuda 2017-11-19 15:31:02 -06:00
Ben Sander a43262e699 Merge branch 'feature_natural_indexing' of https://github.com/AlexVlx/HIP 2017-11-19 15:25:17 -06:00
Ben Sander fc34fd6f03 Temporarily disable P2P on nvidia (fails on dual GPU) 2017-11-19 15:21:37 -06:00
Rahul Garg 76f174b536 Update hipModuleGetTexRef API 2017-11-19 22:10:46 +05:30
Alex Voicu 0cc921f103 This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility. 2017-11-19 01:54:12 +00:00
Alex Voicu 07c9337f57 This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands. 2017-11-18 01:16:31 +00:00
Alex Voicu d7d77cfbe1 This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution. 2017-11-17 16:00:28 +00:00
foreman d0a0f6575e P4 to Git Change 1483566 by gandryey@gera-lnx-rcf on 2017/11/16 18:12:27 
SWDEV-79445 - Remove unused fields

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_gl_amd.hpp#19 edit
 2017-11-16 18:22:09 -05:00
Alex Voicu 45ac5b70df Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe 2017-11-16 23:20:15 +00:00
foreman d0c3f25bf9 P4 to Git Change 1483131 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/16 03:00:04 
SWDEV-2 - Change OpenCL version number from 2539 to 2540.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2287 edit
 2017-11-16 03:07:49 -05:00
Rahul Garg cfc9f87465 Fixed test case for GFX900 2017-11-16 09:34:52 +05:30
foreman 5ec0d059a3 P4 to Git Change 1483021 by lmoriche@lmoriche_opencl_dev2 on 2017/11/15 21:49:30 
SWDEV-118564 - [OCL-LC-ROCm] Disable HSAILProgram and HSAILKernel if the compiler library is not available.

Affected files ...

... //depot/stg/opencl/drivers/opencl/opencldefs#222 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#214 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccompiler.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#76 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#18 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#76 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#89 edit
 2017-11-15 21:58:49 -05:00
foreman 88783fe59b P4 to Git Change 1482981 by skeely@skeely_HSA_linux on 2017/11/15 18:17:38 
SWDEV-136633 - Remove correlation handle.

	Not used by debugger or profiler, dead code.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#47 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#15 edit
 2017-11-15 18:24:51 -05:00
foreman 0e9cee7205 P4 to Git Change 1482914 by wchau@wchau_OCL_boltzmann on 2017/11/15 16:12:45 
SWDEV-137374 - Collecting counters from some TCC, TCP and TA block instances causes kernel to hang
	- fixed by using the new AQLProfile feature to obtain precise size for command/data buffers

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccounters.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#46 edit
 2017-11-15 16:22:18 -05:00
Rahul Garg 20947f80fb Fixed half2 issue on gfx900 2017-11-15 18:52:59 +05:30
Rahul Garg e2e499461a Removed redundant desc variable 2017-11-15 18:28:27 +05:30
Rahul Garg edbfeeb141 -Fixed texture driver API sample 
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
 2017-11-15 18:23:28 +05:30
Phaneendr-kumar Lanka 9fa3ed4f6f [nvccTests]Enabled inline_asm_vadd on nvcc 2017-11-14 16:37:59 +05:30
foreman 0e891db6e4 P4 to Git Change 1482174 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/14 03:00:05 
SWDEV-2 - Change OpenCL version number from 2538 to 2539.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2286 edit
 2017-11-14 03:13:39 -05:00
Rahul Garg e536eb038d Texture code reorganized 2017-11-14 11:09:35 +05:30
Pierre e60a95d7dd Fix missing MARKER_END 
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"
 2017-11-13 16:13:19 -05:00
Chris Kitching 642af94492 Add an explicit check for proper rewriting of CUDA includes 2017-11-13 21:02:42 +00:00
Chris Kitching e8c1e7bb11 Add a preprocessor conditional to one of the tests 
Hurrah, we can cope with ifdefs now (except for kernel launches)
 2017-11-13 20:58:55 +00:00
Chris Kitching 506deca07f Use proper clang diagnostics for printing warnings 
Much pretty. Very wow

This gives users all the usual power when it comes to manipulating
clang diagnostics. People can pass -Werror can have hipify fail if
it doesn't completely translate a file, for example. Much nicer
than reinventing the wheel.
 2017-11-13 20:58:55 +00:00
Chris Kitching 7a441aef10 Use a custom FrontendAction to simplify identifier translation 
Most of what hipify does is really just replacing CUDA idenitifers
with HIP ones. CUDA function calls, preprocessor macro calls,
enum references, types, etc.

This is problematic: calls/types/enum-refs require name resolution
for the AST matcher to work. This fails in the presence of code
deleted by the preprocessor, and in two-pass template compilation.

Instead, we can simply hook the lexer and have it rewrite the
identifiers for us.

This approach means identifier transformations will work correctly
regardless of where they appear (and we get to delete lots of code)

- Fixes #260
- Helps a bit with #207 - it will still fail to translate kernel
calls in preprocessor-ignored code, but everything except kerel
launches should translate correctly now, even in
preprocessor-deleted code.
 2017-11-13 20:58:54 +00:00
Chris Kitching 9014c89f04 Add hipify mappings for all CUDA headers that have HIP equivalents 
I'm particularly running into issues with `device_types.h` in real
CUDA code...
 2017-11-13 17:20:07 +00:00
Chris Kitching 0afc6b2e95 Add a test that exposes #260 2017-11-13 16:18:15 +00:00
Chris Kitching 4353fc06d7 Add a couple of missing CHECK directives to concurrentKernels.cu 2017-11-13 16:17:19 +00:00
Jenkins 5d03b99851 Merge 'master' into 'amd-master' 
Change-Id: I2d2b621a937a8a645072fe76c371ccb36f059a6e
 2017-11-13 04:11:00 -06:00
Maneesh Gupta 7f3653af7a Merge pull request #261 from gargrahul/fix_module_api_sample 
Fix module_api sample
 2017-11-13 11:55:54 +05:30
Rahul Garg e434a23be5 Fix module_api sample 2017-11-13 08:56:39 +05:30
foreman d2eeaeee14 P4 to Git Change 1481529 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/12 03:00:05 
SWDEV-2 - Change OpenCL version number from 2537 to 2538.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2285 edit
 2017-11-12 03:08:35 -05:00
foreman 88ba77a1b4 P4 to Git Change 1481396 by lmoriche@lmoriche_opencl_dev2 on 2017/11/10 16:12:29 
SWDEV-118564 - [OCL-LC-ROCm] Refactor the Lightning Compiler program manager to allow the compiler library API and the ROCm-OpenCL-Driver to coexist in the same platform.
	- Default compiler is the Lightning Compiler
	- Fall back to the HSAIL compiler if the amdoclcl compiler library is in the PATH and the -legacy option is specified (or app-detect)

Affected files ...

... //depot/stg/opencl/drivers/opencl/Makefile#59 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/build/Makefile.api#168 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/acl.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclLoaders.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/build/Makefile.complib#98 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/loaders/elf/elf.hpp#26 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/OPTIONS.def#137 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/build/Makefile.utils#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/cpu/cpuprogram.cpp#71 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#213 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#292 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#235 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#49 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/build/Makefile.oclrocm#20 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccompiler.cpp#38 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccompilerlib.cpp#8 delete
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccompilerlib.hpp#6 delete
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#75 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#30 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.hpp#17 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#75 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#30 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#88 edit
 2017-11-10 16:21:49 -05:00
foreman d779c69dfa P4 to Git Change 1481252 by gandryey@gera-lnx-rcf on 2017/11/10 12:11:16 
SWDEV-133810 - PAL support for Linux Pro w/OpenCL 1.2 support
	- Fix a crash in offline compilation. Increase the alignment for sysmem allocation.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#48 edit
 2017-11-10 12:38:37 -05:00
foreman 0cf1fd6eae P4 to Git Change 1481211 by gandryey@gera-lnx-rcf on 2017/11/10 11:23:52 
SWDEV-133810 - PAL support for Linux Pro w/OpenCL 1.2 support
	- Fix a crash in multiple device/context test

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#64 edit
 2017-11-10 11:30:16 -05:00
Jenkins f91c47167b Merge 'master' into 'amd-master' 
Change-Id: If635fe33b97998b22c4a00c0e9a5e041ef332d82
 2017-11-10 04:48:30 -06:00
foreman f374b5b0d4 P4 to Git Change 1481057 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/10 03:00:05 
SWDEV-2 - Change OpenCL version number from 2536 to 2537.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2284 edit
 2017-11-10 03:12:42 -05:00
Alex Voicu bdd2d6d602 Add omitted changes in CMakeLists.txt. 2017-11-10 01:20:50 +00:00
Alex Voicu 8c62d0fbc4 Update new tests so as to make them work with new variadic based launch mechanisms. 2017-11-10 00:14:34 +00:00
Alex Voicu 1518611976 Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe 2017-11-09 23:43:07 +00:00
Rahul Garg 3711136e46 Added texture 2D driver API usage example 2017-11-09 22:35:29 +05:30
Rahul Garg 1851c153f6 Texture driver APIs support 2017-11-09 22:10:55 +05:30
foreman 2423e81f6f P4 to Git Change 1480493 by johtaylo@johtaylo-jtincrementor2-increment on 2017/11/09 03:00:05 
SWDEV-2 - Change OpenCL version number from 2535 to 2536.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2283 edit
 2017-11-09 03:11:16 -05:00
Maneesh Gupta 925f97fac7 Merge pull request #250 from AlexVlx/feature_add_agent_global_support 
Support for agent globals
 2017-11-09 07:52:09 +05:30
foreman 44800c3b0c P4 to Git Change 1480412 by eyu1@evelyn-dbg1666 on 2017/11/08 21:13:05 
SWDEV-133985 -  Unigine Heaven 4.0 OpenGL serious performance lag Vs NVidia GTX 750 Ti
	    CL1480411 changed TextureResourceObject::setMemObject interface, need to change ocl setMemObject.
	by Evelyn
	ReviewBoardURL = http://ocltc.amd.com/reviews/r/13789/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gslbe/src/rt/GSLContext.cpp#82 edit
 2017-11-08 21:22:07 -05:00
Alex Voicu f7919a8321 Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe 
# Conflicts:
#	tests/src/runtimeApi/stream/hipStreamSync2.cpp
 2017-11-08 10:26:30 +00:00
Maneesh Gupta 6f1298d9f6 Merge pull request #255 from AlexVlx/remove_some_trailing_whitespace 
Clean up trailing whitespace so as to reduce noise in #246.
 2017-11-08 10:29:19 +05:30
Maneesh Gupta 86f5934beb Merge pull request #253 from mangupta/hit_add_cmakecmd 
[hit] Add support for cmake commands as part of test infra
 2017-11-08 09:50:29 +05:30