Vladislav Sytchenko
86d0c5fa5a
hipMemset2D and hipMemset3D tests should be passing by default.
2019-10-16 11:02:38 -04:00
Evgeny Mankov
0a20048759
[HIPIFY] Refactor a couple of matcher functions
...
+ Separate out GetSubstrLocation function for finding substr SourceLocation in a given SourceRange
2019-10-16 13:43:56 +03:00
Evgeny Mankov
5555d46e66
[HIPIFY][CUB][ #1460 ] Implement cubFunctionTemplateDecl matcher
...
+ Add cub_02.cu test
+ Partial fixes #1460
2019-10-16 13:08:11 +03:00
kjayapra-amd
9d571e3c9e
Use the correct return type in runTest in 11_texture_driver sample. ( #1546 )
...
Fixes SWDEV-203394.
Currently in runTest() returns true, even if the texture reference copy does not happen. Using the existing testResult Flag to return from runTest().
2019-10-16 10:52:15 +05:30
vsytch
c2aadd4d12
Update hipMathFunctions, hipTestHalf and hipTestNativeHalf tests to support Navi10 and Navi14. ( #1545 )
2019-10-16 10:51:48 +05:30
kpyzhov
9773f94c71
[hipcc] Temporary add -D_OPENMP to clang options to workaround cmake issue ( #1540 )
...
* Temporary add -D_OPENMP to clang options in hipcc to allow using CMake OpenMP detection with hip-clang (until updated CMake version is available).
2019-10-16 10:51:28 +05:30
Nick Curtis
d16963c9d5
Guard against division by zero for no VGPR usage (e.g., in an empty kernel) ( #1528 )
...
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)
* fix bracket format
* clean up parenthesis
2019-10-16 10:49:56 +05:30
Jatin Chaudhary
b3351561c5
Adding code object manager to rtc ( #1526 )
...
Adding Code Object Manager file to rtc to resolve address of Bundled_code_object in libhiprtc.so
2019-10-16 10:49:16 +05:30
Xiaozhu Meng
f9b8a01c77
Fix struct declaration for C ( #1524 )
...
This change is necessary for HPCToolkit to use Roctracer to produce code centric profiling view.
2019-10-16 10:48:55 +05:30
Yaxun (Sam) Liu
739530d53b
Add -fhip-new-launch-api to hipcc for HIP/VDI
2019-10-15 21:47:33 -04:00
foreman
c6c16b8ebd
P4 to Git Change 2013937 by kjayapra@1_HIPWS_LNX1_PAL on 2019/10/15 17:40:44
...
SWDEV-203394 - Setting Array Channel Desc in hipArrayCreate.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#77 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#22 edit
2019-10-15 16:43:10 -05:00
Vladislav Sytchenko
cc5abec092
In the hipMemset2D and hipMemset3D tests synchronize with the default stream after performing an async memset.
2019-10-15 17:15:49 -04:00
Vladislav Sytchenko
f402b6d01a
Update indentation in the hipMemset3D test. Replace all tabs with four spaces.
2019-10-15 15:29:14 -04:00
Vladislav Sytchenko
c83b6adb33
Add async subtest to hipMemSet3D
2019-10-15 14:24:04 -04:00
Vladislav Sytchenko
39e42d4056
hipMemset2D test should pass only if both async and sync subtests pass.
2019-10-15 14:20:14 -04:00
Vladislav Sytchenko
0200aa3a21
Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description.
2019-10-15 14:18:42 -04:00
Evgeny Mankov
aa4e34cfcf
Merge pull request #1541 from emankov/doc
...
[HIPIFY][cmake] Make CMakeLists.txt compatible with default cmake 3.5.2 for Ubuntu 16.04
2019-10-15 17:11:39 +03:00
Evgeny Mankov
c0f7d02ced
[HIPIFY][tests] Exclude tests for the libs, which are not defined in cmake command line
...
+ affects cuDNN and CUB tests, paths to libraries of which are defined by CUDA_DNN_ROOT_DIR and CUDA_CUB_ROOT_DIR
+ Warn about excluding and why, for instance:
"WARN: cuDNN tests are excluded due to unset CUDA_DNN_ROOT_DIR"
2019-10-15 14:20:23 +03:00
Evgeny Mankov
5dae577d67
[HIPIFY][cmake] Make CMakeLists.txt compatible with default cmake 3.5.2 for Ubuntu 16.04
...
+ Update README.md accordingly
2019-10-15 11:26:03 +03:00
Anusha Godavarthy Surya
20cfe17805
Added unbind texture to samples and tests
2019-10-15 11:34:15 +05:30
Evgeny Mankov
0025c24fe9
[HIPIFY] HipifyAction code clean-up
2019-10-14 18:08:29 +03:00
Evgeny Mankov
01ae988fab
[HIPIFY][build fix] Add missing new source file
2019-10-14 16:32:57 +03:00
Evgeny Mankov
7f24109cf2
Merge pull request #1534 from emankov/hipify-clang
...
[HIPIFY][CUB] Initial support (hipify-clang only)
2019-10-14 15:57:09 +03:00
Evgeny Mankov
0dfe8423e7
[HIPIFY][CUB] Add missing unit test
2019-10-14 12:03:20 +03:00
Evgeny Mankov
97df38903a
[HIPIFY][CUB] Initial support (hipify-clang only)
...
+ Add one matcher (will be more)
+ Update Maps and Statistics
+ Add cub_01.cu unit test
+ Update lit harness to support standalone CUB
+ Update README.md
+ Update hipify-perl (only CUB header is supported for now)
[IMPORTANT]
clang (and hipify-clang) works correctly only with official NVLabs version on GitHub.
Compilation of CUB from official CUDA release has conflicts with THRUST.
Thus, to compile CUB sources, option "-I" should be specified to the cloned CUB from NVLAB on GitHub.
2019-10-14 11:55:55 +03:00
foreman
7f090d69db
P4 to Git Change 2012424 by axie@axie_win_opencl_ssd on 2019/10/11 14:32:12
...
SWDEV-206239 - [hipclang-vdi-rocm][perf]RCCL: finegrain VRAM does not work
xGMI may not work. Otherwise, several GPUs and CPU can access the same host memory atomically by API hipExtMallocWithFlags
Tests:
http://ocltc:8111/viewModification.html?modId=127344&personal=true&init=1&tab=vcsModificationBuilds
ReviewBoard: http://ocltc.amd.com/reviews/r/18109/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#76 edit
2019-10-11 14:43:24 -04:00
Evgeny Mankov
7a1301eab9
[HIP] Fix typo in a comment
2019-10-11 15:20:58 +03:00
Evgeny Mankov
3a83b3a62c
[HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow
2019-10-11 15:18:08 +03:00
foreman
8ca652ba46
P4 to Git Change 2011990 by eshcherb@evgeny-hip on 2019/10/10 20:09:32
...
SWDEV-197287 - HIP tracing layer: any-api-id removing
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#3 edit
... //depot/stg/opencl/drivers/opencl/hip_prof_gen.py#3 edit
2019-10-10 20:23:33 -04:00
Evgeny Mankov
0ee069bad7
[HIPIFY][perl] Add "important" notice
...
# IMPORTANT: Do not change this file manually: it is generated by hipify-clang --perl
2019-10-10 18:25:26 +03:00
Jatin Chaudhary
444177ffac
Re enable test RTC ( #1516 )
...
Adding target resolution in hiprtc tests and reenable them.
2019-10-10 19:59:55 +05:30
Maneesh Gupta
3a5baaeeef
tracing layer unifying with hcc: removing API_ID_ANY ( #1514 )
2019-10-10 19:59:05 +05:30
ansurya
9bb22c4e0f
Fix for directed tests failure ( #1511 )
...
directed_tests/runtimeApi/module/hipLaunchCooperativeKernel.tst - Disabling test temporarily until driver support is available.
directed_tests/runtimeApi/memory/hipArray.tst - Disabling test temporarily to reimplement it correctly.
2019-10-10 19:58:41 +05:30
Evgeny Mankov
d8d9f16f17
[HIP] Introduce library_types.h as a common header for libs ( #1509 )
...
* [HIP] Introduce library_types.h as a common header for libs
[Reason]
Currently, hipFFT, hipBLAS and other HIP libs use their own data types, prefixed with HIPFFT or HIPBLAS, whereas in CUDA those types are common and declared in library_types.h
[TODO]
Switch hipFFT, hipBLAS and other HIP libs to use common library_types.h.
* [HIP] Move include for library_types.h to hip_runtime.h
[Reason]
Repeat CUDA's behaviour, where library_types.h is included in cuda_runtime.h
2019-10-10 19:57:28 +05:30
srinivamd
706e4498e3
remove dependencies on /opt/rocm path ( #1379 )
...
* remove hard coded dependencies on /opt/rocm path
2019-10-10 19:56:55 +05:30
Evgeny Mankov
e3319acbf8
[HIPIFY][test] Update allocators.cu test
2019-10-10 17:20:41 +03:00
Anusha Godavarthy Surya
a5d9f56bef
Fix undefine ref to hipUbindTexture for texture types
2019-10-09 16:26:06 +05:30
Evgeny
ed29c10394
tracing layer unifying with hcc: removing API_ID_ANY
2019-10-08 19:09:43 -05:00
Evgeny Mankov
7c3f5a387d
Merge pull request #1513 from emankov/hipify-clang
...
[HIPIFY][doc] Add a few words about hipify-perl
2019-10-08 22:30:25 +03:00
Evgeny Mankov
eaffbb10b8
[HIPIFY][doc] Add a few words about hipify-perl
...
+ Update testing and versions
2019-10-08 22:27:48 +03:00
foreman
250ecb0bdb
P4 to Git Change 2010058 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/10/08 14:44:53
...
SWDEV-144570 - Implementation of APIs hipMemsetD8Async, hipMemAllocPitch, hipMemAllocHost and template for hipMemsetD16, hipMemsetD16Async.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#30 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#29 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#75 edit
2019-10-08 14:55:27 -04:00
foreman
88f0064461
P4 to Git Change 2009953 by eshcherb@evgeny-hip on 2019/10/08 12:36:36
...
SWDEV-197287 - HIP tracing layer instrumentation - Windows link issues.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_intercept.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#2 edit
2019-10-08 12:46:05 -04:00
Evgeny Mankov
4a2d87b70c
[HIPIFY][ #1487 ][fix] Translate correctly kernel names prefixed with namespace
...
+ Modify CUDA2HIP_perl for the fix
+ Add ns_kernel_launch.cu test
+ Update hipify-perl by hipify-clang -perl
2019-10-08 15:58:48 +03:00
foreman
f8d01cc14e
P4 to Git Change 2009236 by eshcherb@evgeny-hip on 2019/10/07 11:49:55
...
SWDEV-197287 - HIP tracing layer instrumentation
hip_prof_str.h - generated header; as a next step a genrator will be integrated in HIP makefile (similar to HIP-HCC)
prof_protocol.h - temporarily included in HIP sources. Provided by roctracer-proto package. HIP-HCC CMake has parameter to set a path to the header.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_intercept.cpp#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#44 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#74 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#43 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/prof_protocol.h#1 add
... //depot/stg/opencl/drivers/opencl/hip_prof_gen.py#1 add
... //depot/stg/opencl/drivers/opencl/make/hip.git/include/hip/hcc_detail/hip_prof_str.h#2 delete
2019-10-07 11:55:30 -04:00
Evgeny Mankov
59c5220c2f
[HIPIFY] Sync with HIP
...
+ Update hipify-perl accordingly
2019-10-07 14:44:05 +03:00
Evgeny Mankov
b7c812160c
[HIPIFY] Remove duplicates
...
+ C++ maps and docs affected, hipify-perl left unchanged
2019-10-07 14:33:04 +03:00
Maneesh Gupta
cc4a9c72b7
[ci] Enable tests on ROCm 2.9 ( #1503 )
2019-10-07 14:12:08 +05:30
Rahul Garg
e2260d82a6
Fix PCI Domain ID query ( #1424 )
...
* Fix PCI Domain ID query
* Update BDF comment
2019-10-07 14:11:52 +05:30
Evgeny Mankov
201e6deaac
[HIPIFY][SPARSE] sync with hipSPARSE
...
+ Update doc and hipify-perl accordingly
2019-10-05 15:53:04 +03:00
foreman
dd3fbeba4d
P4 to Git Change 2008906 by axie@axie-hip-vdi-pal2 on 2019/10/04 18:55:34
...
SWDEV-189650 - [HIP-CLANG][HIP/VDI/PAL] Hangs on test hip_threadfence_system
1. In HIP + VDI + ROCm, allow SVM atomic in VEGA10 and later ASIC. GFX8 (Tonga) was enabled before.
2. In HIP + VDI + PAL Linux driver, allow SVM atomic in VEGA10 and later ASIC.
Tests:
1. In HIP + VDI + ROCm, hip_threadfence_system test passed.
2. In HIP + VDI + PAL + Linux , hip_threadfence_system test passed.
3. OpenCL + PAL, clinfo and ocltest runtime test pass.
4. OpenCL + ROCM, clinfo and ocltest runtime test pass.
5. Windows 10, VEGA 10, clinfo and and ocltest runtime test pass. hip_threadfence_system test passed by skipping the test.
Teamcity presubmission test:
http://ocltc.amd.com:8111/viewModification.html?modId=127083&personal=true&tab=vcsModificationBuilds
http://ocltc.amd.com:8111/viewModification.html?modId=127076&personal=true&tab=vcsModificationBuilds
ReviewBoard: http://ocltc.amd.com/reviews/r/18077/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#73 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#171 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#80 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.hpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#134 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#44 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#320 edit
2019-10-04 19:02:35 -04:00