Commit Graph

4345 Commits

Author SHA1 Message Date
foreman 599f0b1c93 P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.

	Tests:
	The sample code can be built without linkage error.
	http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17942/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit
2019-09-05 14:30:10 -04:00
foreman cd5c37bb4a P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit
2019-09-05 14:12:32 -04:00
Jeff Daily 3d7c146296 fix bug where HIP_DB=1 seg faults at startup (#1388) 2019-09-05 10:04:19 +00:00
mhbliao d511c3e363 [hip] Stop using noduplicate and replace it with convergent. (#1390) 2019-09-05 10:03:43 +00:00
Paul Fultz II d359cd4449 Use hcc when building with hcc compiler (#1225)
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME
2019-09-05 10:03:04 +00:00
Evgeny Mankov a847247d9a [HIPIFY][cmake][#1394] Fix
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7
2019-09-05 12:08:56 +03:00
Evgeny Mankov f114a79462 [HIPIFY][perl] Code cleanup (preparation for generating) 2019-09-05 11:52:59 +03:00
foreman 132d10a98a P4 to Git Change 1993529 by skudchad@skudchad_rocm on 2019/09/04 17:08:05
SWDEV-199293 - Initial API checkin and sym export defines

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#1 add
2019-09-04 17:16:03 -04:00
Evgeny Mankov 0ca6525d90 [HIPIFY][perl] Sync hipify-perl with hipify-clang
Sync by means of semi-automatic generation: hipify-clang -perl
2019-09-04 17:07:45 +03:00
Evgeny Mankov 7ab9afe513 [HIPIFY][perl] Code cleanup and formatting 2019-09-04 16:37:26 +03:00
Evgeny Mankov e26ec02a99 [HIPIFY][perl][#259] Fix
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );
2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu e72346dc24 Do not include cuda wappers for OMP for hip-clang (#1382) 2019-09-03 05:13:59 +00:00
Rahul Garg d433f6fb58 Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit 9bbd09b04f.
2019-09-03 05:13:46 +00:00
Nicholas Malaya 796b8aafd7 Fix Broken Link in hip_porting_guide (#1376)
The math library equivalents between CUDA-HIP are broken. This is a key feature for converting to AMD hardware. This fix corrects the broken link and moves the library equivalents to sit under the "Porting a New Cuda Project" header.
2019-09-03 05:13:35 +00:00
Sarbojit2019 4d270775c8 Removed hipLaunchKernel macro got missed in Merge (#1374) 2019-09-03 05:13:07 +00:00
Evgeny Mankov d9b5e2f74a [HIPIFY][doc] Update README.md (testing, versions) 2019-09-02 18:18:43 +03:00
Evgeny Mankov 608331250e [HIPIFY][tests] Add occupancy test 2019-09-02 17:54:06 +03:00
Evgeny Mankov 8eb7d53cec [HIPIFY][fix] Fix for upcoming LLVM 10.0 2019-09-01 18:15:03 +03:00
Sameer Sahasrabuddhe 68c133bd78 remove obsolete test for OCKL Asynchronous Streams
The implementation for OCKL AS was recently removed from the device
library since that feature is now superseded by hostcall.
2019-08-30 20:41:29 +05:30
foreman 8ea92c83f0 P4 to Git Change 1991227 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/29 17:26:37
SWDEV-193938 - [HIP] Use fine grained pool for hipHostRegister

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#43 edit
2019-08-29 17:35:38 -04:00
Evgeny Mankov a0a98790f0 [HIPIFY][DNN] cuDNN 7.6.3 support 2019-08-29 19:55:38 +03:00
Evgeny Mankov 451721a821 Merge pull request #1372 from emankov/master
[HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
2019-08-29 10:30:05 +03:00
Yaxun (Sam) Liu 793b18c0b1 Fix sample 11_texture_driver for hip-clang (#1370) 2019-08-29 01:03:20 +00:00
Yaxun (Sam) Liu 19a9b15306 Do not change opt level for -g for hip-clang (#1369)
Currently hipcc uses -O3 for hip-clang by default but uses -O0 if -g is used. This
causes surprise for users since -g should not affect default opt level.
2019-08-29 01:03:11 +00:00
Sarbojit2019 b5ff9e71ed Updated hipErrorString and CUDAErrorTohipError (#1365) 2019-08-29 01:02:59 +00:00
Sarbojit2019 1ae43cbeba [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path
2019-08-29 01:02:41 +00:00
satyanveshd d2df21e58c [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments
2019-08-29 01:01:49 +00:00
mshivama f74903851e Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support
2019-08-29 01:01:25 +00:00
Evgeny Mankov 32f22a0117 [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly
2019-08-28 21:17:35 +03:00
Evgeny Mankov e3eb62ac4b [HIPIFY][cmake] Minor refactoring
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions
2019-08-28 20:40:10 +03:00
foreman 534727cd01 P4 to Git Change 1990032 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/27 20:20:36
SWDEV-145570 - [HIP] Add missing HIP_INIT_API macros and more debug printf.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#23 edit
2019-08-27 20:26:25 -04:00
Maneesh Gupta b92c16f4d9 [packaging] update soft-links that already exist (#1364)
Change-Id: Ibe9840802b1765094ef998edf2210e95404cb989
2019-08-26 23:41:14 -04:00
foreman d0edeaf3cf P4 to Git Change 1989149 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 15:30:45
SWDEV-188177 - Adding ihipTexture APIs to hip_hcc.def.in

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#21 edit
2019-08-26 15:44:58 -04:00
foreman 441eefa78b P4 to Git Change 1989089 by kjayapra@0_HIPWS_P2P_ROCM on 2019/08/26 14:24:21
SWDEV-198194 - Delete vars at __hipUnregisterFatBinary.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#40 edit
2019-08-26 14:32:48 -04:00
Michael LIAO c84628f420 [hcc] Fix previous replacement of result_of_t.
- `result_of_t` is defined as the shortcut of
  ```
  template< class T >
  using result_of_t = typename result_of<T>::type;
  ```
2019-08-26 10:58:38 -04:00
ramcherukuri 6ea9e2b249 moving result_of_t to result_of 2019-08-24 08:59:58 -04:00
foreman 865a4f2c43 P4 to Git Change 1988496 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/23 19:43:16
SWDEV-199002 - [HIP] Add hipExtLaunchMultiKernelMultiDevice to in files.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#20 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#22 edit
2019-08-23 19:46:27 -04:00
Evgeny Mankov 7f5635d3ff [HIPIFY][cmake] Explicitly set c++14
[Reason] LLVM became c++14 last week due to the following change:

37508d3dd94b0154861a90b1909d17b01400df99
Replace llvm::integer_sequence and friends with the C++14 standard version
2019-08-23 19:32:24 +03:00
foreman d9777f8524 P4 to Git Change 1988234 by kjayapra@3_HIPWS_TXT_ROCM on 2019/08/23 12:12:45
SWDEV-201068 - Reverting back CL 1987582.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#84 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#27 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#98 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#96 edit
2019-08-23 12:15:29 -04:00
Sarbojit2019 919bb6c74d Added missing device prop fields into hipInfo sample (#1357)
* Added prop.integrated into hipInfo sample

* Added missing deviceProp fileds in hipInfo
2019-08-23 09:21:47 +00:00
Rahul Garg d367fdf28c Make Bundled_code_header visible for hipRTC usage (#1359) 2019-08-23 09:20:02 +00:00
chrispaquot d0b11deb7f Set device before processing each one (#1358) 2019-08-23 09:19:50 +00:00
Aryan Salmanpour 32ce882d6e [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339)
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties
2019-08-23 09:19:35 +00:00
Rahul Garg a786728939 Fix memcpy with IPC slowness (#1321)
* Fix memcpy with IPC slowness

* Make early erroneous returns

* Real Clean up

* Real Clean up++
2019-08-23 09:19:18 +00:00
foreman d83f474719 P4 to Git Change 1987598 by gandryey@gera-win10 on 2019/08/22 13:29:18
SWDEV-197289 - VDI tracing API integration in rocTracer
	- Add profiling activity callbacks for HIP API. The logic will utilize the  current profiling mechanism inside VDI

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_activity.cpp#1 add
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#21 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#246 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#341 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#426 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.hpp#145 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#148 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#64 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#83 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#26 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/activity.cpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/platform/activity.hpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#97 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#95 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/prof_protocol.h#1 add
2019-08-22 13:48:47 -04:00
foreman fb37058725 P4 to Git Change 1987582 by cpaquot@cpaquot-ocl-lc-lnx on 2019/08/22 13:20:28
SWDEV-185742 - [HIP] Add a svm path to avoid analyzing the mem objs
	and just memcpy the kernel args

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#82 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.hpp#25 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#96 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#94 edit
2019-08-22 13:26:57 -04:00
foreman 26a9ba7ba7 P4 to Git Change 1987529 by kjayapra@4_HIPWS_RCCM_ROCM on 2019/08/22 12:32:42
SWDEV-200625 - Reverting back CL#1986255.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#35 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#39 edit
2019-08-22 12:41:42 -04:00
Evgeny Mankov 3d07393003 [HIPIFY][fix] Set the correct exit value for hipify-clang if errors.
This fixes a hanging of unit tests.
2019-08-21 21:36:53 +03:00
Evgeny Mankov 8293f9a706 [HIPIFY] CUDA 10.1 Update 2 support 2019-08-21 21:06:20 +03:00
Rahul Garg 900590967d Remove -g from hipBusBandwidth makefile (#1351) 2019-08-21 10:01:31 +00:00