Commit Graph

12238 Commits

Author SHA1 Message Date
ansurya 688b6e6af0 Fix texture tests, always pass row pitch to HSA API for linear layout images (#1785)
=> New ROCr calculates pitch as per HSA specification and addrlib is used to check whether HW can support that configuration. Hence few texture tests are failing with HSA_EXT_STATUS_ERROR_IMAGE_PITCH_UNSUPPORTED.

=> Determine pitch for linear images and always pass rowpitch to HSA API's.
2020-01-16 08:54:30 +05:30
kpyzhov 1d6a2fb064 Don't use accelerated vector element access for hip-clang. (#1796) 2020-01-15 18:17:08 -08:00
foreman 65b47104c7 P4 to Git Change 2057426 by vsytchen@vsytchen-ocl-win10-2 on 2020/01/15 19:27:36
SWDEV-79445 - OCL generic changes and code clean-up

	Make the conversion from amd::Coord3D to size_t* be explicit.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/platform/object.hpp#21 edit
2020-01-15 19:38:07 -05:00
foreman 37c900f2a1 P4 to Git Change 2057410 by skudchad@skudchad_rocm on 2020/01/15 18:24:33
SWDEV-219341 - Free memory correctly. hiprtcProgram is a pointer by itself. So release *prog

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#10 edit
2020-01-15 18:32:44 -05:00
Aakanksha Patil 545ad0dad3 [HIPIFY][cmake] Packaging for hipify-clang 2020-01-15 11:39:02 -05:00
foreman 43ad5275cb P4 to Git Change 2056965 by chui@ocl-promo-incrementor on 2020/01/15 03:00:18
SWDEV-2 - Change OpenCL version number from 3079 to 3080.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2827 edit
2020-01-15 03:04:21 -05:00
foreman a9b467ba7b P4 to Git Change 2056728 by vsytchen@vsytchen-ocl-win10-2 on 2020/01/14 17:54:16
SWDEV-79445 - OCL generic changes and code clean-up

	Alllow amd::Coord3D to decay into size_t*. This allows creating an amd::BufferRect obect without the need of explicitly passing size_t[3] arguments.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18473/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/platform/object.hpp#20 edit
2020-01-14 17:56:39 -05:00
foreman ae5d557960 P4 to Git Change 2056720 by gandryey@gera-win10 on 2020/01/14 17:35:01
SWDEV-79445 - OCL generic changes and code clean-up
	- Use ClPrint to trace memory allocations

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.cpp#31 edit
2020-01-14 17:44:07 -05:00
kpyzhov 0918614615 Add missing constructors for Scalar_accessor class. (#1792) 2020-01-14 11:30:21 -08:00
foreman 7ceef75528 P4 to Git Change 2056207 by chui@ocl-promo-incrementor on 2020/01/14 03:00:17
SWDEV-2 - Change OpenCL version number from 3078 to 3079.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2826 edit
2020-01-14 03:07:09 -05:00
foreman 68107b160f P4 to Git Change 2055908 by axie@axie-opencl-rocm2 on 2020/01/13 16:27:17
SWDEV-219121 - [Navi][ROCm] Add performance counter support

	This is initial implementation for Navi 10 performance counter in OpenCL runtime.

	Tests:
	1. http://ocltc.amd.com:8111/viewModification.html?modId=130609&personal=true&tab=vcsModificationBuilds
	2. ./ocltst -m oclruntime.so -t OCLPerfCounters
	Before this code change, the segmenation fault happens inside OpenCL runtime. After this code change, the error happened inside HSA. Error message is generated in function hsa_ven_amd_aqlprofile_start. Inside this function, the C++ try block create exception. The exception error in HSA is "GFXIP is not supported(gfx1010)". We need HSA to add support for Navi.

	ReviewBoards: http://ocltc.amd.com/reviews/r/18463/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccounters.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/roccounters.hpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/runtime/OCLPerfCounters.cpp#50 edit
2020-01-13 16:35:17 -05:00
Evgeny Mankov 84ee66314e Merge pull request #1788 from emankov/HIP
[HIPIFY][fix] Add "--" separator in-place if needed
2020-01-13 18:53:02 +03:00
Evgeny Mankov df563c966c [HIPIFY][fix] Add "--" separator in-place if needed 2020-01-13 18:49:28 +03:00
Evgeny Mankov 083bfaeb6b Merge pull request #1787 from emankov/HIP
[HIPIFY] Sync with hipSPARSE
2020-01-13 18:40:10 +03:00
Evgeny Mankov 41beed4839 [HIPIFY] Sync with hipSPARSE
+ Update hipify-perl and doc accordingly
2020-01-13 18:34:10 +03:00
foreman e3e2727c47 P4 to Git Change 2055328 by chui@ocl-promo-incrementor on 2020/01/11 03:00:17
SWDEV-2 - Change OpenCL version number from 3077 to 3078.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2825 edit
2020-01-11 03:30:09 -05:00
foreman ec3fbfd60c P4 to Git Change 2055228 by jujiang@JJ-HIP on 2020/01/10 16:36:01
SWDEV-205925 - Update HIP texture APIs for issue in hipTexRefSetAddress in HIP/PAL on Windows
	-Update HIP texture function parameter to use hipChannelFormatDesc& desc

	http://ocltc.amd.com/reviews/r/18456/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#33 edit
2020-01-10 16:43:46 -05:00
Jenkins e7aaac2ccd Merge 'master' into 'amd-master'
Change-Id: I59a0793711937b997b97735d6ab10dee889cc1f9
2020-01-10 17:19:54 +00:00
Jatin Chaudhary 0b211478dd Remove filesystem dependency in hipRTC (#1749)
Removing dependency on filesystem, so libstdc++fs is no longer required to link
2020-01-10 13:47:54 +05:30
Evgeny Mankov 9c2fcff9ce [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path
2020-01-10 13:47:18 +05:30
Yaxun (Sam) Liu 55525fa466 Fix test hip_bitextract.cpp (#1784)
The randomly generated offset+width may exceeds 32, which causes
a left shift operation with 32-offset-width. As an unsigned number
that is greater than 32 and causes undefined behavior. When the
test is compiled without -mavx it is still OK. However when
the test is compiled with -mavx, the undefined behavior causes
wrong results and test failure.

This patch adjusts width so that offset+width<=32 always.
2020-01-10 13:46:57 +05:30
foreman c583dfddf8 P4 to Git Change 2054860 by chui@ocl-promo-incrementor on 2020/01/10 03:00:16
SWDEV-2 - Change OpenCL version number from 3076 to 3077.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2824 edit
2020-01-10 03:11:39 -05:00
Jenkins e27b0c8129 Merge 'master' into 'amd-master'
Change-Id: I09eb56a50f07d30b6bd0e03e5ee72e92d373c904
2020-01-09 06:06:58 -05:00
foreman b7dabf5c3b P4 to Git Change 2054168 by chui@ocl-promo-incrementor on 2020/01/09 03:00:16
SWDEV-2 - Change OpenCL version number from 3075 to 3076.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2823 edit
2020-01-09 03:06:46 -05:00
foreman 7bca33c5fb P4 to Git Change 2053967 by gandryey@gera-win10 on 2020/01/08 17:30:34
SWDEV-79445 - OCL generic changes and code clean-up
	- Propagate the error if flush() failed

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#159 edit
2020-01-08 17:36:14 -05:00
Maneesh Gupta c091635f5a Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit cf526f5484.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit cbd8f604ec.
2020-01-08 15:11:58 +05:30
foreman bc91a60139 P4 to Git Change 2053572 by chui@ocl-promo-incrementor on 2020/01/08 03:00:15
SWDEV-2 - Change OpenCL version number from 3074 to 3075.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2822 edit
2020-01-08 03:03:49 -05:00
foreman 0a27603178 P4 to Git Change 2053377 by gandryey@gera-win10 on 2020/01/07 17:55:38
SWDEV-218016 - There is a bug in the OCL/DX interop
	- Initialize event query value to FALSE and correct the loop condition to make sure query waits for the end.

	http://ocltc.amd.com/reviews/r/18447/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_d3d10.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_d3d11.cpp#28 edit
2020-01-07 17:59:52 -05:00
foreman e5c5338146 P4 to Git Change 2053320 by vsytchen@vsytchen-hip-win10 on 2020/01/07 15:54:34
SWDEV-215533 - [HIP][Windows]Output mismatch with tex3D()

	1. Implement hipMemcpy3DAsync().
	2. Add logic in hipMemcpy3D() to determine based on src/dst parameters if the user intended on calling cudaMemcpy3D() or cuMemcpy3D().

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18444/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#36 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#95 edit
2020-01-07 15:59:02 -05:00
Siu Chi Chan 26b50e1e1b Detect when an explicit printf buffer flush is required (#1766)
* Detect when an explicit printf buffer flush is required
in a device/stream synchronization function.

* hip_module.cpp: add missing hc_am.hpp header
2020-01-07 09:06:38 -08:00
Evgeny Mankov 76fb59122d Merge pull request #1779 from emankov/hipify-clang
[HIPIFY] main source file refactoring
2020-01-07 16:36:17 +03:00
Evgeny Mankov 8fbbaf3779 [HIPIFY] main source file refactoring 2020-01-07 16:25:18 +03:00
foreman 413eaa9dca P4 to Git Change 2052971 by chui@ocl-promo-incrementor on 2020/01/07 03:00:14
SWDEV-2 - Change OpenCL version number from 3073 to 3074.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2821 edit
2020-01-07 03:02:34 -05:00
ansurya cbd8f604ec Fix rocFFT build failure (#1777)
Fixes SWDEV-217761
2020-01-07 08:12:37 +05:30
satyanveshd 9b2f22f7aa hipMemcpy[To/From]Symbol(Async) fixes (#1774) 2020-01-07 08:11:53 +05:30
Rick Ho ade47bd848 Fix minor explainations in the kernel guide (#1775) 2020-01-06 12:34:21 +05:30
Rahul Garg 534376cb41 Add hipBindTexture2D on NVCC path (#1773) 2020-01-06 12:33:50 +05:30
Rahul Garg 178d432b90 Fix nested designator warnings (#1768) 2020-01-06 12:33:34 +05:30
Rahul Garg 3fe1695c3a Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.
2020-01-06 12:33:23 +05:30
Yaxun (Sam) Liu c80c2bf234 Update HIP-Clang build instruction (#1764) 2020-01-06 12:32:47 +05:30
Yaxun (Sam) Liu 7dcd5f6329 Document FMA settings (#1717) 2020-01-06 12:32:38 +05:30
foreman 93afda79fd P4 to Git Change 2052260 by chui@ocl-promo-incrementor on 2020/01/04 03:00:14
SWDEV-2 - Change OpenCL version number from 3072 to 3073.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2820 edit
2020-01-04 03:06:46 -05:00
foreman a941903848 P4 to Git Change 2052191 by skudchad@skudchad_test2_win_opencl on 2020/01/03 15:54:23
SWDEV-213000 - Backout change to notifyCmdQueue as the real issue has been identified

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#53 edit
2020-01-03 16:02:59 -05:00
foreman 375e16b00d P4 to Git Change 2051988 by chui@ocl-promo-incrementor on 2020/01/03 03:00:13
SWDEV-2 - Change OpenCL version number from 3071 to 3072.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2819 edit
2020-01-03 03:08:30 -05:00
foreman 0117e25aee P4 to Git Change 2051379 by chui@ocl-promo-incrementor on 2020/01/01 03:00:13
SWDEV-2 - Change OpenCL version number from 3070 to 3071.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2818 edit
2020-01-01 03:08:24 -05:00
foreman 4e2333f7d8 P4 to Git Change 2051215 by chui@ocl-promo-incrementor on 2019/12/31 03:00:12
SWDEV-2 - Change OpenCL version number from 3069 to 3070.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2817 edit
2019-12-31 03:05:52 -05:00
foreman 955b224ea0 P4 to Git Change 2051060 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/12/30 16:42:07
SWDEV-145570 - Clean up after `hipError_t` unification.

	- Replace deprecated `hipError_t` enums.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#5 edit
2019-12-30 16:46:39 -05:00
Evgeny Mankov ed43699a3a Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)
2019-12-30 19:21:09 +03:00
Sarbojit2019 4fd77f8336 Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.
2019-12-30 12:44:24 +05:30
Aryan Salmanpour 857052be1e [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.
2019-12-30 12:42:17 +05:30