Commit Graph

37731 Commits

Author SHA1 Message Date
Ben Richard 35493f440c Avoid crash when profiling data not generated (#694)
* Avoid crash when profiling data not generated

-Handle case where program has no kernel launches
-Improve error messages
-Avoid roofline when profiling data is missing

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Update other soc_gfx files to catch missing pmc_perf.csv

* Fix formatting

* Fix incorrectly ordered imports

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>
2025-05-05 16:09:48 -04:00
Guan, Zichuan 3775298655 Disable HIP_PLATFORM auto-detect if already defined (#254)
Co-authored-by: Stella Laurenzo <stellaraccident@gmail.com>
2025-05-05 15:37:53 -04:00
Pratik Basyal 369b755eb5 Changelog for ROCm Systems Profiler 1.0.1 added to develop (#199)
* Changelog for ROCm 6.4.1 added

* Reference docs added

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: f7c7cd297e]
2025-05-05 15:06:37 -04:00
Pratik Basyal f7c7cd297e Changelog for ROCm Systems Profiler 1.0.1 added to develop (#199)
* Changelog for ROCm 6.4.1 added

* Reference docs added

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-05-05 15:06:37 -04:00
Rawat, Swati 3e653b7ab3 RDC Doc formatting (#166)
* doc formatting

* Update job_stats_sample.rst

* Doc formatting

---------

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
2025-05-05 13:08:33 -05:00
Rawat, Swati 0519d1bee7 RDC Doc formatting (#166)
* doc formatting

* Update job_stats_sample.rst

* Doc formatting

---------

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>

[ROCm/rdc commit: 3e653b7ab3]
2025-05-05 13:08:33 -05:00
Arsenault, Matthew 1db9a7d48b SWDEV-1 - Stop using ocml rounding functions (#228)
Directly use the builtins. Use the elementwise versions since there's
no implied errno, regardless of -f[no]-math-errno.

I didn't change the cases unnecessarily casting. The bfloat and vector
cases should work directly.
2025-05-05 19:35:12 +02:00
dependabot[bot] 484d66f7eb Bump rocm-docs-core[api_reference] from 1.18.2 to 1.18.4 in /docs/sphinx (#196)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.18.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.2...v1.18.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.18.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-systems commit: a5c56a665d]
2025-05-05 13:10:38 -04:00
dependabot[bot] a5c56a665d Bump rocm-docs-core[api_reference] from 1.18.2 to 1.18.4 in /docs/sphinx (#196)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.18.2 to 1.18.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.18.2...v1.18.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.18.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-05 13:10:38 -04:00
Andryeyev, German 9b018165ce SWDEV-528808 - Disable dynamic queue by default (#256)
Dynamic queue management will be disabled by default and
the original sort logic is restored
2025-05-05 10:56:35 -04:00
Gollamandala, Srinivasarao e540c3b94a SWDEV-504658-[catch2][dtest]-Reduce the lock scope of the kernel object look-up (#73) 2025-05-05 14:24:11 +05:30
David Galiffi 80423ff010 Updating release build dockers (#195)
- Bringing in recent changes from rocm-6.4 branch (https://github.com/ROCm/rocprofiler-systems/pull/171)
- Add libdrm-devel to rhel and suse files
- Update ROCm installation method in Ubuntu file
- Add additional output to `test-release.sh` to catch failures due to a Python version not included
- Add Python 3.13 to Dockers

[ROCm/rocprofiler-systems commit: 83a9eb3d7c]
2025-05-02 19:29:15 -04:00
David Galiffi 83a9eb3d7c Updating release build dockers (#195)
- Bringing in recent changes from rocm-6.4 branch (https://github.com/ROCm/rocprofiler-systems/pull/171)
- Add libdrm-devel to rhel and suse files
- Update ROCm installation method in Ubuntu file
- Add additional output to `test-release.sh` to catch failures due to a Python version not included
- Add Python 3.13 to Dockers
2025-05-02 19:29:15 -04:00
Searles, Mark cd9bc61559 Fix typos in warning msgs (#231) 2025-05-02 14:31:42 -07:00
David Galiffi 6fe19b681a Fix path to post-processing merge script (#187)
- Path to merge script not found unless user explicitly sources "share/rocprofiler-systems/setup-env.sh" to setup PATHs.
- Instead, let's derive the path when the application loads and use it when executing the helper script
- Rename script to rocprof-sys-merge-output.sh.
- Change install folder to <prefix>/libexec/rocprofiler-systems based on dev-ops feedback.
- Updated PATH variable in the modulefile and source scrtipt.
- For SWDEV-528101

[ROCm/rocprofiler-systems commit: adc66956b0]
2025-05-02 16:52:54 -04:00
David Galiffi adc66956b0 Fix path to post-processing merge script (#187)
- Path to merge script not found unless user explicitly sources "share/rocprofiler-systems/setup-env.sh" to setup PATHs.
- Instead, let's derive the path when the application loads and use it when executing the helper script
- Rename script to rocprof-sys-merge-output.sh.
- Change install folder to <prefix>/libexec/rocprofiler-systems based on dev-ops feedback.
- Updated PATH variable in the modulefile and source scrtipt.
- For SWDEV-528101
2025-05-02 16:52:54 -04:00
anujshuk-amd 31dc2414e3 Reverting PR-154 Changes since VCN data not seen on Perfetto file (#191)
[ROCm/rocprofiler-systems commit: ff109912c2]
2025-05-02 16:19:43 -04:00
anujshuk-amd ff109912c2 Reverting PR-154 Changes since VCN data not seen on Perfetto file (#191) 2025-05-02 16:19:43 -04:00
Welton, Benjamin 4b414f1ee5 Remove unnecessary log line (#387)
Co-authored-by: Benjamin Welton <bewelton@amd.com>

[ROCm/rocprofiler-sdk commit: 65f60bbb96]
2025-05-02 12:25:32 -07:00
Welton, Benjamin 65f60bbb96 Remove unnecessary log line (#387)
Co-authored-by: Benjamin Welton <bewelton@amd.com>
2025-05-02 12:25:32 -07:00
David Galiffi 490ff33d25 Conditionally include ROCPROFILER_BUFFER_TRACING_PAGE_MIGRATION (#193)
- Include only if ROCPROFILER_SDK_VERSION < 1.0.0, as it is being removed
- For SWDEV-530639

[ROCm/rocprofiler-systems commit: 0f16d45445]
2025-05-02 15:05:27 -04:00
David Galiffi 0f16d45445 Conditionally include ROCPROFILER_BUFFER_TRACING_PAGE_MIGRATION (#193)
- Include only if ROCPROFILER_SDK_VERSION < 1.0.0, as it is being removed
- For SWDEV-530639
2025-05-02 15:05:27 -04:00
Roy, Rakesh 4794a250ba SWDEV-530762 - Disable failing test in Linux PSDB (#162)
Change-Id: If4ab846d74932384fd847c69f76d932f31d4523c
2025-05-02 18:31:24 +05:30
David Galiffi 091ae42b98 Install rocprof-sys-causal-print to /opt/rocm/libexec/rocprofiler-systems (#175)
For SWDEV-528225

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 7d74dc7d5d]
2025-05-01 19:49:11 -04:00
David Galiffi 7d74dc7d5d Install rocprof-sys-causal-print to /opt/rocm/libexec/rocprofiler-systems (#175)
For SWDEV-528225

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-05-01 19:49:11 -04:00
David Galiffi 2b61118a14 Re-enable RPM_PACKAGE_AUTOREQ (#174)
Removes workaround for SWDEV-525268

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: e9e194a3ca]
2025-05-01 19:46:24 -04:00
David Galiffi e9e194a3ca Re-enable RPM_PACKAGE_AUTOREQ (#174)
Removes workaround for SWDEV-525268

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-05-01 19:46:24 -04:00
Sajina PK 8c424f2074 Fix to overlapping VCN and JPEG tracks in perfetto (#192)
- Fix overlapping VCN and JPEG activity values in Perfetto output.
- Modify the storage of the activity values to be more efficient.

[ROCm/rocprofiler-systems commit: 99a411fe52]
2025-05-01 19:40:49 -04:00
Sajina PK 99a411fe52 Fix to overlapping VCN and JPEG tracks in perfetto (#192)
- Fix overlapping VCN and JPEG activity values in Perfetto output.
- Modify the storage of the activity values to be more efficient.
2025-05-01 19:40:49 -04:00
Rawat, Swati 4a230f0180 fix broken link (#169)
Update job_stats_sample.rst

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
2025-05-01 10:49:31 -05:00
Rawat, Swati f9ceb0e6b9 fix broken link (#169)
Update job_stats_sample.rst

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>

[ROCm/rdc commit: 4a230f0180]
2025-05-01 10:49:31 -05:00
Apurv Mishra aa0a32a166 kfdtest: Update ROCr homepage in CMakeLists.txt
Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>
2025-05-01 11:22:49 -04:00
Chaudhary, Jatin Jaikishan 12febe6782 SWDEV-514560 - add fp6 header implementation (#54)
Co-authored-by: rahul manocha <rmanocha_amdeng>
2025-05-01 15:17:38 +01:00
Kandula, Venkateshwar reddy d9bd0903f8 [PSDB] [CI] SWDEV-528922: Modify summary MEMORY_ALLOCATION for summary.txt (#375)
* Update validate.py

* increase memalloc to 4 to account new vmem.

* Format.

* modify test to work when vmem using and not to work.

* address comments.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>

[ROCm/rocprofiler-sdk commit: b69e12032e]
2025-05-01 00:58:00 -05:00
Kandula, Venkateshwar reddy b69e12032e [PSDB] [CI] SWDEV-528922: Modify summary MEMORY_ALLOCATION for summary.txt (#375)
* Update validate.py

* increase memalloc to 4 to account new vmem.

* Format.

* modify test to work when vmem using and not to work.

* address comments.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
2025-05-01 00:58:00 -05:00
Madsen, Jonathan 11fdedb874 [Build System] Install FindrocDecode.cmake and FindrocJPEG.cmake (#382)
Install FindrocDecode.cmake and FindrocJPEG.cmake

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: e9757e46ce]
2025-05-01 00:57:37 -05:00
Madsen, Jonathan e9757e46ce [Build System] Install FindrocDecode.cmake and FindrocJPEG.cmake (#382)
Install FindrocDecode.cmake and FindrocJPEG.cmake

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-05-01 00:57:37 -05:00
Trowbridge, Ian 24f054f509 Fix HIP Streams Duplication Error (#313)
* Fix stream duplication and fixed tests

* Added comments to explain stream.cpp code, change stream nullptr check to occur in update table to prevent readding null stream, simplified hip-streams bin file code, add destroyStreams to hip-streams bin file code

* Removed roctx from CMakeLists.txt

* Updated documentation

* Fix documentation

* Removed update_table for HIP compiler table and updated stream.cpp to remove support for HIP compiler table

* Added runtime initialization check for HIP

* Changed tool name, working on fixing memory management

* Added context for counter collection kernel rename combination

* Changed name from map to set and changed description

* Fix documentation description for group-by-queue

* Merged memory copy and kernel operations onto a single track when on the same stream

* Updated perfetto output to remove hardware information from track name to merge all memory copy and kernel operations on the same stream to the same track:

* Most pr comments addressed

* Added filter for counter collection and removed kernel buffer tracing hack

* Added PR comment fixes

---------

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

[ROCm/rocprofiler-sdk commit: e626df43eb]
2025-05-01 00:56:15 -05:00
Trowbridge, Ian e626df43eb Fix HIP Streams Duplication Error (#313)
* Fix stream duplication and fixed tests

* Added comments to explain stream.cpp code, change stream nullptr check to occur in update table to prevent readding null stream, simplified hip-streams bin file code, add destroyStreams to hip-streams bin file code

* Removed roctx from CMakeLists.txt

* Updated documentation

* Fix documentation

* Removed update_table for HIP compiler table and updated stream.cpp to remove support for HIP compiler table

* Added runtime initialization check for HIP

* Changed tool name, working on fixing memory management

* Added context for counter collection kernel rename combination

* Changed name from map to set and changed description

* Fix documentation description for group-by-queue

* Merged memory copy and kernel operations onto a single track when on the same stream

* Updated perfetto output to remove hardware information from track name to merge all memory copy and kernel operations on the same stream to the same track:

* Most pr comments addressed

* Added filter for counter collection and removed kernel buffer tracing hack

* Added PR comment fixes

---------

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
2025-05-01 00:56:15 -05:00
Assiouras, Ioannis 9d6a0d1a4d SWDEV-521011 - Fix alignment in PalResource::CreateSvm 2025-05-01 02:22:49 +01:00
Andryeyev, German 84a4f293f4 SWDEV-526836 - add PipelineStageBlt flag (#229)
CP sync requires PipelineStageBlt flag.
2025-04-30 14:27:41 -04:00
Brzak, Branislav 3f30d6d8ea SWDEV-515519 - Synchronize after mem pool trim (#89) 2025-04-30 16:09:15 +02:00
Luca Bruni 579596dbba Appropriately filter data based on -D and -H options (#163)
- Addresses concern that device metric tracks are still shown in Perfetto trace file even when only -H is specified to rocprof-sys-sample (and vice versa).
- Update sampling call-stack docs.

[ROCm/rocprofiler-systems commit: 8ae6651357]
2025-04-30 09:50:51 -04:00
Luca Bruni 8ae6651357 Appropriately filter data based on -D and -H options (#163)
- Addresses concern that device metric tracks are still shown in Perfetto trace file even when only -H is specified to rocprof-sys-sample (and vice versa).
- Update sampling call-stack docs.
2025-04-30 09:50:51 -04:00
Assiouras, Ioannis d3fb8eda8b SWDEV-525593, SWDEV-527293 - Acquire active queue after xferQueue is created (#165)
For xferQueue VirtualGPU::create is called after ProfilingBegin
so the active queue needs to be acquired.
2025-04-30 09:21:11 +01:00
Swargam, Rambabu 1b60d60f5a SWDEV-515926 - [catch2][dtest] Tests for Memory Manager for memory pool performance (#155) 2025-04-30 10:11:33 +05:30
Bhardwaj, Gopesh 5dcb2cbdd7 updating fmt submodule to latest release tag (#13)
* updating fmt submodule to latest release tag

* fix configuration error

[ROCm/rocprofiler-register commit: 4427f2bd6d]
2025-04-30 09:57:37 +05:30
Bhardwaj, Gopesh 4427f2bd6d updating fmt submodule to latest release tag (#13)
* updating fmt submodule to latest release tag

* fix configuration error
2025-04-30 09:57:37 +05:30
David Yat Sin 4ed5950beb rocr: Fix logic for scratch reclaim
Fix logic error that can cause scratch memory to be reclaimed while a
dispatch is still using it.
2025-04-29 17:23:45 -04:00
Godavarthy Surya, Anusha 2538d7f02b SWDEV-522841 - Graph nodes must be created/launched on device where they are captured/created (#108) 2025-04-29 22:20:39 +05:30