Commit Graph

36 Commits

Author SHA1 Message Date
Tao Sang 51b6c1856c Fix square build failure with static lib in Jenkin
When libamdhip64_static.a is built by Jenkin, sample square cannot been
built successfully because libamdhip64_static.a is archiveved in thin
mode. Thus in the patch it will be archiveved in full mode. Meanwhile
libamdhip64_static_temp.a will be useless and thus removed.

Change-Id: Ifd3882598ef0dc5e7af8db0e389e786025ceb455
2020-05-22 11:49:52 -04:00
Aryan Salmanpour 3a30b9eb8d Add support for hipExtStreamCreateWithCUMask API
Change-Id: I369d0eaca493821c4badc6b18ac02daa2fddc95f
2020-05-22 11:34:06 -04:00
Matt Arsenault 1003128925 Don't search ROCclr_DIR for prof_protocol.h
This points to the cmake directory where the find module was found,
not a prefix for where it was found.

Based on the search below looking in roctracer, searching in ROCclr
for the header doesn't make much sense. The header should be either
provided by ROCclr xor roctracer. Having it possibly be provided by
two different dependencies is confusing, and a potential source of
version mismatch problems.

Change-Id: Ic2f6ec03f9a7b86225cf7e5c43f39a1360318a34
2020-05-22 09:59:09 -04:00
Laurent Morichetti 161c14c1de load functions when registered if lazy load is disabled
Change-Id: I08c9684ca4ab86a6294ed9e670f3125c1a0cc6c4
2020-05-21 09:19:20 -04:00
Sarbojit Sarkar 06a0de3567 added null check
Change-Id: I7631965286bad5684bacb7e38c63031b5c691dc0
2020-05-20 23:08:55 -04:00
Saleel Kudchadker fe9aa9356b Fix elapsed time calc for hipEventElapsedTime
If the start and stop events have same command internally
then measure command end to command start
Change-Id: Ie70cfa37c06c06573f0ed58dab2bbe4434c1724b
2020-05-20 16:02:48 -04:00
agodavar e1961c838f Fix hipMemset for unaligned ptr, correct offset required by ROCclr per aligment and testcase to validate unaligned ptr
Change-Id: Ib1a0f9d1556d09cf72a12a90cad2e27c6d9c6a1c
2020-05-16 02:38:14 -04:00
Matt Arsenault 206810e014 Include interface directories from rocclr target
This is overly painful because this is an object library.

Change-Id: I618843b810549876053212bf24efff18aece9470
2020-05-15 13:17:13 -04:00
Payam 0a9d550d9b load functions when registered if lazy load is disabled
Change-Id: I6f10a72f7643e476407af03b04ef52e59741be45
2020-05-15 12:15:32 -04:00
Evgeny 10cb7645dc API tracing instrumentation
Change-Id: I257409b9fe299b009ded3e3a43287322d5f93a70
2020-05-14 11:03:09 -05:00
Payam 6152b200cb adding support to disable lazy loading, HIP_ENABLE_LAZY_KERNEL_LOADING
Change-Id: Iafe0f396570ee2bccf642b537cbf9aad967e1370
2020-05-13 17:18:48 -04:00
Christophe Paquot 2cc0fb9381 Make sure to remove the global var from amd::MemObjMap
We need this otherwise ROCr can give us a matching address
for another allocation and doing "insert" in ROCclr will not
update the map with the newest object. We would then end up
using stale objects (yikes)
SWDEV-234992

Change-Id: I3475adf9781a9309d64a024fae45181d7e5afb04
2020-05-13 00:26:19 -07:00
Christophe Paquot 374fd36f31 Add lock to addFatBinary and removeFatBinary
In case hipModule(Un)Load is called from different thread as hipInit we need to grab the lock
as both are going to modify modules_
Also add some logging for __hipExtractCodeObjectFromFatBinary in case binary isn't found for GPU
SWDEV-236032

Change-Id: Icbd72b412502df80d5066cea42a4fbcd5b0b8a98
2020-05-12 16:04:08 -07:00
Saleel Kudchadker 93dcace83c Merge "SWDEV-235495 Fix elapsed time calculation" into amd-master-next 2020-05-12 15:23:23 -04:00
Saleel Kudchadker 5b60eee02e SWDEV-235495 Fix elapsed time calculation
This issue happens because we getLastQueuedCommand when recording
the event and do end_ - start_ so it takes the ticks for the
completion of the last command before event record. This may not
happen if one records a marker command for hipEventRecord

Change-Id: I1d6b06a5befb3b93f16b67692c59dca25c982e0f
2020-05-12 09:38:01 -07:00
Christophe Paquot a5f15bd7bc Merge "HPC : Intermittent hangs are observed while running Gromacs benchmarks" into amd-master-next 2020-05-12 11:21:47 -04:00
Karthik Jayaprakash eddf19fa4e Merge "SWDEV-227602 - Fixing hipFuncGetAttribute parameters" into amd-master-next 2020-05-12 10:52:25 -04:00
Matt Arsenault 1f0c398a6f Use find_package to find ROCclr
Maintain compatability with the old finding for now for the
convenience of commit order.

Change-Id: I99b236cbb3d61b00650e3da7fe5931d4c4b3fec6
2020-05-12 09:28:19 -04:00
kjayapra-amd aaf3002567 SWDEV-227602 - Fixing hipFuncGetAttribute parameters
Change-Id: I46bd079372f453cabfaa2c709e2b30c69400dd33
2020-05-12 09:15:43 -04:00
Matt Arsenault a92dc8c25c Use project relative include dir for generated header paths
Change-Id: I8c0834d68e6dac00b41a7059a978cbd2ebb933f9
2020-05-11 21:57:25 -04:00
Christophe Paquot 163fdd6b74 HPC : Intermittent hangs are observed while running Gromacs benchmarks
SWDEV-235579
Move the lock before destroying the queue as there's a multithreaded race condition if the queue
is being destroy and right after we set queue_ to nullptr, another thread can call ihipWaitStreams
which will then call create on that same stream because queue is now nullptr.
Moving the lock on streamSet prevents this from happening because we would remove the stream from that
list and therefore ihipWait will not try to call asHostQueue which tries to create the queue if not created yet
since the stream won't be in the list anymore

Change-Id: I3108657ab403d39d4123e83294fcf1f0880e5563
2020-05-11 16:35:13 -07:00
Payam 005a033c53 updating hipDeviceProps_t-< arch flags according to SWDEV-234277
Change-Id: I6238edf9a2df15a5dfe420dbb8723e10a0725f98
2020-05-11 16:43:13 -04:00
Matt Arsenault 28cb3e5496 Start cleaning up rocclr include paths
Use target_include_directories instead of global includes.

Change-Id: I3adadc905843f152a548c71b2f12701476065207
2020-05-11 15:24:19 -04:00
Vlad Sytchenko a88e52ba80 Correct HIP_FUNC_ATTRIBUTE_NUM_REGS query
Change-Id: I526cc7871c690260df0fa8c1b3b4b15fbc5af219
2020-05-09 12:42:30 -04:00
Christophe Paquot 6c05f34e6d Merge "Don't add a null command to waitList in hipMemcpy" into amd-master-next 2020-05-08 17:01:38 -04:00
Christophe Paquot 8c2c4c3b27 Don't add a null command to waitList in hipMemcpy
SWDEV-235345

Change-Id: Ib1abd0ba6414d081891a9f5209df083c45734aee
2020-05-08 12:43:41 -07:00
Vlad Sytchenko b5f9d2f818 Correct HIP_FUNC_ATTRIBUTE_MAX_THREADS_PER_BLOCK query
We should be returning the max workgroup size calculated by the compiler.

Change-Id: If86590efbb9b291f470bdbe87e5df992e661c539
2020-05-08 14:36:47 -04:00
Vlad Sytchenko 276bfc9667 Fix confusion in hipFuncGetAttribute()
Cuda shared == OpenCL local

Cuda local == OpenCL private

Change-Id: I5a204945ecde35919b9e9def20bbb2662fffea2b
2020-05-08 14:36:36 -04:00
Matt Arsenault 1ff46e24c5 Don't add llvm includes to rocclr build
There are no llvm includes here.

Change-Id: I0567c6e47e717580819f3854782ba08501bd069d
2020-05-08 12:24:49 -04:00
Sarbojit Sarkar 94699a7a6f Enabling hipGetDeviceFlags required in [SWDEV-229170]
Change-Id: I998d37e5847f9651345554bada86df6fce86d1eb
2020-05-08 01:37:23 -04:00
Aaron Enye Shi 88ce9d5a10 Fix missed VDI names in hip-on-rocclr
Change-Id: I830feb37a043656136648e92a0c6f1eaae8402d7
2020-05-07 08:37:28 -04:00
Christophe Paquot e1cfe54975 Merge "SWDEV-232464 - Need to initialize image with ptr passed since they can pass image not of type __ClangOffloadBundler." into amd-master-next 2020-05-06 16:42:50 -04:00
kjayapra-amd 8f38c3260e SWDEV-232464 - Need to initialize image with ptr passed since they can pass image not of type __ClangOffloadBundler.
Change-Id: I2c50042220a0230bc445ed21728f114a229c53e1
2020-05-06 14:25:43 -04:00
Christophe Paquot 0a103a5c49 Skip iHipWaitActiveStreams if stream is NonBlocking
SWDEV-234484

Change-Id: I279bdc8485d8218e0aaa89d094c08a84f002a608
2020-05-06 10:36:53 -07:00
Aakash Sudhanwa 8e6d7dffe3 rocclr/CMakeLists.txt: Fixing unresolved merge conflict
Change-Id: I09b9a955b0f1ece8d278112a22bc8aef31b57258
Signed-off-by: Aakash Sudhanwa <Aakash.Sudhanwa@amd.com>
2020-05-06 07:24:25 -07:00
Payam dba0e72de2 name change vdi to rocclr
Change-Id: I06d198bbb4a499e153b290b73a92afed3553b252
2020-05-06 09:14:30 -04:00