Commit graph

6604 Commits

Autor SHA1 Nachricht Datum
Evgeny Mankov 9c4ec3eca2 [HIPIFY] Scripting related refactoring
+ Move generating hipify-perl and hipify-python into separate namespaces and files
+ Move getAbsoluteFilePath and getAbsoluteDirectoryPath to StringUtils


[ROCm/clr commit: db2fee682b]
2019-09-15 21:13:56 +03:00
Evgeny Mankov f5417d5f6d Merge pull request #1420 from emankov/hipify-clang
[HIPIFY][perl] Syn with hipify-clang

[ROCm/clr commit: 32c6bae2f4]
2019-09-15 15:26:54 +03:00
Evgeny Mankov 7e629aa218 [HIPIFY][perl] Syn with hipify-clang
[ROCm/clr commit: 422403a3ff]
2019-09-15 15:25:40 +03:00
Evgeny Mankov 96c7aef471 Merge pull request #1419 from emankov/hipify-clang
[HIPIFY][perl] Generate sub warnUnsupportedDeviceFunctions

[ROCm/clr commit: a5309b7bc0]
2019-09-15 15:20:13 +03:00
Evgeny Mankov a58504a20f [HIPIFY][perl] Generate sub warnUnsupportedDeviceFunctions
[ROCm/clr commit: b69f7afa67]
2019-09-15 15:18:58 +03:00
Evgeny Mankov c395967d40 Merge pull request #1417 from emankov/master
[HIPIFY][doc] Update README.md

[ROCm/clr commit: d05caef113]
2019-09-13 18:58:22 +03:00
Evgeny Mankov 4ba645fc09 Merge pull request #1416 from gargrahul/HACK_hipFreeForManangedMalloc
[HACK] Temporary fix in hipFree for hipManagedMalloc use

[ROCm/clr commit: 8e2f68c2a0]
2019-09-13 18:57:21 +03:00
Evgeny Mankov 267555caff [HIPIFY][doc] Update README.md
+ Adding -DLLVM_TARGETS_TO_BUILD="NVPTX" to LLVM's cmake command line for minimizing LLVM's build (tested)
+ Test logs update
+ Versions update


[ROCm/clr commit: 0416eaf12e]
2019-09-13 18:56:48 +03:00
foreman e4eb8e6a1b P4 to Git Change 1997981 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/13 11:17:32
SWDEV-203438 - [HIP] AllGather RCCL test issue
	The test tries to launch a kernel on two devices at once and they need to communicate with each other.
	For that, it uses a custom stream for each devices.
	Problem is in getNullStream we used to call syncStreams all the time
	and it was syncing all the streams even the ones on different devices.
	So that made the second kernel launch (on 2n dev) to wait for the first kernel to finish which
	would never occur since the first one was waiting for the second one.
	The fix is to not call syncStreams from getNullStream because we sync already anyway prior in general.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#21 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#24 edit


[ROCm/clr commit: 0aa24f6d4d]
2019-09-13 11:28:33 -04:00
Jenkins c7894e21c1 Merge 'master' into 'amd-master'
Change-Id: I449c7c1d18e70c4f7f25b264d7871a49b75fc77c


[ROCm/clr commit: 340ae81eb1]
2019-09-13 05:10:52 -04:00
Rahul Garg f79ffd587e Fix typo and colon in comment
[ROCm/clr commit: d9179cbe70]
2019-09-13 03:09:01 +05:30
Rahul Garg b7a06efb6c [HACK] Temporary fix for hipFree for hipManagedMalloc
[ROCm/clr commit: 2e9b8e9d0d]
2019-09-13 02:10:21 +05:30
foreman ebbf31efc0 P4 to Git Change 1997621 by cpaquot@cpaquot-ocl-lc-lnx on 2019/09/12 14:16:09
SWDEV-145570 - Fixed some logging issues regarding hip(Ext)ModuleLaunchXXX.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#40 edit


[ROCm/clr commit: b0b5c92469]
2019-09-12 14:35:36 -04:00
Evgeny Mankov 6238b80b9d Merge pull request #1414 from emankov/master
[HIPIFY] Add unsupported fp16 functions

[ROCm/clr commit: b0156df459]
2019-09-12 18:53:08 +03:00
Evgeny Mankov ab1bbd7eca [HIPIFY] Add unsupported fp16 functions
[ROCm/clr commit: 4b3889b47e]
2019-09-12 18:51:25 +03:00
Evgeny Mankov 3cb5065590 Merge pull request #1413 from emankov/master
[HIPIFY] Add more unsupported device functions

[ROCm/clr commit: d8fe39ffd2]
2019-09-12 17:55:43 +03:00
Evgeny Mankov 76cdd624ef [HIPIFY] Add more unsupported device functions
[ROCm/clr commit: ece8a71bad]
2019-09-12 17:53:25 +03:00
Jenkins b834dd2c35 Merge 'master' into 'amd-master'
Change-Id: I99fcb0d69a58ce09065991a580662660d2941f9f


[ROCm/clr commit: 0e1ef39580]
2019-09-12 06:06:14 -04:00
Evgeny Mankov ae66e0b3a1 Merge pull request #1410 from emankov/master
[HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h

[ROCm/clr commit: 6a75382e86]
2019-09-11 18:13:05 +03:00
Evgeny Mankov 54ba179911 [HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h
[ROCm/clr commit: 905c6383db]
2019-09-11 18:07:09 +03:00
Evgeny Mankov 38c128b941 Merge pull request #1406 from emankov/master
[HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)

[ROCm/clr commit: ede7e2a094]
2019-09-11 15:49:46 +03:00
Jenkins 16adcbf9bf Merge 'master' into 'amd-master'
Change-Id: I836a4d36b2f43db1e1850c55e8b174755abd414f


[ROCm/clr commit: b6163e45c5]
2019-09-10 10:07:07 -04:00
Evgeny Mankov 4cfb3aa7b7 [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);


[ROCm/clr commit: 4e3845be83]
2019-09-10 15:59:06 +03:00
Aditya Lad 4225ba4c8a Replacment of RENAME command in CMakeLists.txt (#1402)
[ROCm/clr commit: 4a53718e10]
2019-09-10 08:35:16 +00:00
foreman dd954b519f P4 to Git Change 1995672 by skudchad@skudchad_rocm on 2019/09/09 14:45:42
SWDEV-199293 - Fix build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#4 edit


[ROCm/clr commit: 15d819d61f]
2019-09-09 14:50:37 -04:00
foreman 427ec323d2 P4 to Git Change 1995665 by skudchad@skudchad_test2_win_opencl on 2019/09/09 14:36:57
SWDEV-199293 - Implement hiprtcGetLoweredName

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17960/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#3 edit


[ROCm/clr commit: f0f4755aae]
2019-09-09 14:42:47 -04:00
Jenkins 2dcff60dbb Merge 'master' into 'amd-master'
Change-Id: Ibb1dbe78aa52c8aeb77851ee1471e1edaec4c654


[ROCm/clr commit: 4b88d83acc]
2019-09-09 05:10:28 -04:00
Evgeny Mankov 452b53fa21 Merge pull request #1398 from emankov/master
[HIPIFY] Add device functions support

[ROCm/clr commit: 861dada8ea]
2019-09-07 19:00:00 +03:00
foreman fb96543a7d P4 to Git Change 1994974 by skudchad@skudchad_test2_win_opencl on 2019/09/06 19:09:36
SWDEV-199293 - Implement some hipRTC apis.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/17953/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/build/Makefile.hip#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#2 edit


[ROCm/clr commit: 9a839c46dc]
2019-09-06 19:11:43 -04:00
Evgeny Mankov 755d1a9ea6 [HIPIFY] Add device functions support
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.


[ROCm/clr commit: aec10d6ee1]
2019-09-06 18:34:12 +03:00
foreman 95c0f07e54 P4 to Git Change 1994498 by skudchad@skudchad_test2_win_opencl on 2019/09/06 04:25:22
SWDEV-202136 - Fix windows build

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#26 edit


[ROCm/clr commit: 860615b64d]
2019-09-06 04:33:24 -04:00
foreman 8eafceb663 P4 to Git Change 1994199 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/09/05 16:35:36
SWDEV-202136 - Fix typos in `hip_hcc.def.in`.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#25 edit


[ROCm/clr commit: 0322bfd64f]
2019-09-05 16:45:19 -04:00
foreman e5570ea1ca P4 to Git Change 1994120 by axie@axie-hip-pal on 2019/09/05 14:22:40
SWDEV-201667 - Linker errors when using hipArrayCreate and hipMemcpyParam2D

	Tests:
	In Windows 10, the linker errors has been fixed with this code change.
	http://ocltc.amd.com:8111/viewModification.html?modId=125600&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17943/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#24 edit


[ROCm/clr commit: 53d56a3843]
2019-09-05 14:34:47 -04:00
foreman 46e691878d P4 to Git Change 1994119 by axie@axie-hip-pal on 2019/09/05 14:20:44
SWDEV-197057 - [hipclang-vdi-rocm][func] 11_texture_driver test in hip samples fails.

	Tests:
	The sample code can be built without linkage error.
	http://ocltc.amd.com:8111/viewModification.html?modId=125598&personal=true&tab=vcsModificationBuilds

	Review:
	http://ocltc.amd.com/reviews/r/17942/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#25 edit


[ROCm/clr commit: 599f0b1c93]
2019-09-05 14:30:10 -04:00
foreman bcde771762 P4 to Git Change 1994105 by skudchad@skudchad_rocm on 2019/09/05 13:59:26
SWDEV-202136 - Export symbols for hiprtcVersion and hiprtcGetTypeName

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#24 edit


[ROCm/clr commit: cd5c37bb4a]
2019-09-05 14:12:32 -04:00
Jeff Daily 42c49b6ba9 fix bug where HIP_DB=1 seg faults at startup (#1388)
[ROCm/clr commit: 3d7c146296]
2019-09-05 10:04:19 +00:00
mhbliao b55c3dba08 [hip] Stop using noduplicate and replace it with convergent. (#1390)
[ROCm/clr commit: d511c3e363]
2019-09-05 10:03:43 +00:00
Paul Fultz II a61aaacbca Use hcc when building with hcc compiler (#1225)
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME


[ROCm/clr commit: d359cd4449]
2019-09-05 10:03:04 +00:00
Evgeny Mankov d99539e82d Merge pull request #1395 from emankov/master
[HIPIFY][cmake][#1394] Fix

[ROCm/clr commit: 93bf378a56]
2019-09-05 12:12:08 +03:00
Evgeny Mankov b6c6ecab67 [HIPIFY][cmake][#1394] Fix
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7


[ROCm/clr commit: a847247d9a]
2019-09-05 12:08:56 +03:00
Evgeny Mankov 17b2943d8a Merge pull request #1393 from emankov/master
[HIPIFY][perl] Code cleanup (preparation for generating)

[ROCm/clr commit: 4dc98fb754]
2019-09-05 11:54:10 +03:00
Evgeny Mankov 8dfefa1f9a [HIPIFY][perl] Code cleanup (preparation for generating)
[ROCm/clr commit: f114a79462]
2019-09-05 11:52:59 +03:00
Evgeny Mankov af968ced14 Merge pull request #1391 from emankov/master
[HIPIFY][perl] Sync hipify-perl with hipify-clang

[ROCm/clr commit: 2563e782c5]
2019-09-05 09:07:32 +03:00
foreman e3a5206b3e P4 to Git Change 1993529 by skudchad@skudchad_rocm on 2019/09/04 17:08:05
SWDEV-199293 - Initial API checkin and sym export defines

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#22 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#1 add


[ROCm/clr commit: 132d10a98a]
2019-09-04 17:16:03 -04:00
Evgeny Mankov a9d5b1e29e [HIPIFY][perl] Sync hipify-perl with hipify-clang
Sync by means of semi-automatic generation: hipify-clang -perl


[ROCm/clr commit: 0ca6525d90]
2019-09-04 17:07:45 +03:00
Evgeny Mankov 076988c31b Merge pull request #1389 from emankov/master
[HIPIFY][perl] Code cleanup and formatting

[ROCm/clr commit: 9df5971e0d]
2019-09-04 16:39:12 +03:00
Evgeny Mankov 73e71db792 [HIPIFY][perl] Code cleanup and formatting
[ROCm/clr commit: 7ab9afe513]
2019-09-04 16:37:26 +03:00
Evgeny Mankov 4da6af254e Merge pull request #1387 from emankov/master
[HIPIFY][perl][#259] Fix

[ROCm/clr commit: 9af6190ec9]
2019-09-04 16:11:16 +03:00
Evgeny Mankov 790ab87461 [HIPIFY][perl][#259] Fix
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );


[ROCm/clr commit: e26ec02a99]
2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu 732c9829c1 Do not include cuda wappers for OMP for hip-clang (#1382)
[ROCm/clr commit: e72346dc24]
2019-09-03 05:13:59 +00:00