Commit Graph

169 Commits

Author SHA1 Message Date
Rahul Garg dd95d3d23c ROCMOPS-1956 - Push restructured code to hipamd
hipamd will have AMD's ROCCLR based HIP backend implementation

Change-Id: Id7de9634519b4ce46fca71a1b61f3d5b1e3fc459


[ROCm/clr commit: 19c84bc604]
2021-06-07 21:42:44 +00:00
Tao Sang 2c1c9f78d6 Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce


[ROCm/clr commit: 8a2b0b7424]
2021-01-05 10:39:31 -05:00
Tao Sang 6227f3fae2 Remove hip-hcc codes: Part one
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd


[ROCm/clr commit: 1cba7ec965]
2020-12-09 15:49:47 -05:00
Satyanvesh Dittakavi 37f121bda2 Fix hipLaunchCooperativeKernel failure on nvidia platform
SWDEV-262064 - compilation fails when hipLaunchCooperativeKernel C++ routine is invoked 
on nvcc path.
Change-Id: Icde35dd1a7008b406401bb3996c06d7acfb27d8d


[ROCm/clr commit: 80cb172fef]
2020-11-25 01:15:55 -05:00
Sourabh Betigeri 69b62789fb SWDEV-255694: Include attributes - hipFuncAttributePreferredSharedMemoryCarveout and hipFuncAttributeMaxDynamicSharedMemorySize
Change-Id: I3569859e6db0c59a10a76c8ea356d4bc0a0bb906


[ROCm/clr commit: b0664a0087]
2020-11-02 19:39:39 -05:00
agodavar 52c79e6b63 SWDEV-255853: CUDA device P2P attributes
Change-Id: I7deffd04101b565f68a72a179f9faeaa22cab97d


[ROCm/clr commit: e65bbb0329]
2020-10-13 05:32:29 -04:00
agodavar 815e10863c SWDEV-254909:Support for missing texture/array cuda driver types
Change-Id: I9c769f6335ec3e7feacaa8929719c666bff91934


[ROCm/clr commit: fae443cb36]
2020-10-13 05:30:31 -04:00
Vladislav Sytchenko 7b635ae18c Revert "Revert "Merge branch 'amd-master-next' into amd-npi-next""
This reverts commit 0627e8783b.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I92ceb171e31026ed1864704cef2fc1497b883ef9


[ROCm/clr commit: d5aa0f607d]
2020-10-05 13:20:58 -04:00
Vladislav Sytchenko 0627e8783b Revert "Merge branch 'amd-master-next' into amd-npi-next"
This reverts commit 6c6299acb2.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I53322718dadde2c98f96140b8e260ec7ee9ef721


[ROCm/clr commit: 9142674ef0]
2020-10-05 13:02:39 -04:00
Aryan Salmanpour 0bc09def97 rename abort in nvcc path
[background] There is currently a compilation issue when both hip/hip_runtime.h and hip/hip_cooperative_groups.h included
in a file and hipcc used to compile it on NV platform. The issue is that an abort is defined in hip/nvcc_detail/hip_runtime.h
and it is also defined in the CUDA cooperative groups header (/cuda/include/cooperative_groups/details/helpers.h).
this is problematic and leads to a compilation issue in hipcc on NV platform.

Change-Id: I2ab6982ac4103822a1a4a0ced942cd604d6c19c1


[ROCm/clr commit: 35a3304acc]
2020-10-01 14:28:51 -04:00
mshivama 4bd3a9fb18 Layout the cooperative group related headers to target Nvidia
Change-Id: I530ffc72d6fae1e273b5322d508629221e11ea6f


[ROCm/clr commit: b35f5215b2]
2020-09-29 21:32:24 -04:00
Sarbojit Sarkar 596fa95c9b SWDEV-252337: Fix for V100 compilation issue
Change-Id: Ib57ff3ac28f0a581f395f32181974e64eca6d858


[ROCm/clr commit: 7da8264b7c]
2020-09-25 21:55:22 -04:00
Todd tiantuo Li 49910cc949 SWDEV-240803 - add hipFuncSetSharedMemConfig
Change-Id: I160b04677b3e7b99b3981ae7ecc84a0e3811d5e8


[ROCm/clr commit: a243a69e98]
2020-08-20 18:18:24 -04:00
Todd tiantuo Li 4885fa0e48 SWDEV-240803 - add hipFuncSetAttribute and hipFuncAttribute
Change-Id: I3f4d67b19d89fd348fa5b884af4a2542ee4aba60


[ROCm/clr commit: fb43f21044]
2020-08-14 17:39:29 -04:00
Jatin Chaudhary bee94be69d Cuda 11 changes: https://docs.nvidia.com/cuda/cuda-runtime-api/structcudaPointerAttributes.html\#structcudaPointerAttributes
Change-Id: I8a5389b88df286043c365a734983a4c5de352102


[ROCm/clr commit: 94bfd485ef]
2020-08-07 05:33:33 -04:00
kjayapra-amd 7aa68bc3cb SWDEV-240800 - Adding initial support for hipDeviceGetP2PAttribute. Some attr support still pending.
Change-Id: I0611aed136270db497dfa374144f6f5e35352a8f


[ROCm/clr commit: 311fc8c513]
2020-07-22 14:54:34 -04:00
Ronak Chauhan 845c0a5b8a Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

This is different from 4dfef9a25b.

We try to accomodate the case when a kernel template has multiple
type parameters.

Change-Id: I87577d402c92b0f3b51e298f8293f4065e1f6de8


[ROCm/clr commit: 133251a6e1]
2020-06-30 10:44:55 -04:00
Ronak Nilesh Chauhan 179a9974f4 Revert "Support passing macros to hipLaunchKernelGGL"
This reverts commit 4dfef9a25b.

Reason for revert: This patch breaks ROCPrim tests

Change-Id: Ib2235f719861c9f4317c33e86b6c1f8bc669cfd4


[ROCm/clr commit: b15e835d9e]
2020-06-24 04:28:46 -04:00
Ronak Chauhan 4dfef9a25b Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

Change-Id: Id76e2bf91acd5d68f56a24fc39f219f2eeb06d33


[ROCm/clr commit: fb6bb04f03]
2020-06-22 04:35:29 -04:00
Sarbojit Sarkar 38f3c57f58 [doc]shfl*sync update
1. Updated FAQ with shft*sync not supported hip_faq.md
2. Corrected some of input parameter description in hcc_details/hip_runtime_api.h
3. Redirect shfl*() to shfl_*_sync() for nvcc path where CUDA > 9.0

Change-Id: I3d8184db5fcc622852c9bad96b706348e8dfc16c


[ROCm/clr commit: e288338e4a]
2020-05-27 02:17:40 -04:00
Sarbojit Sarkar 8ea2da75d2 Enabling hipGetDeviceFlags required in [SWDEV-229170]
Change-Id: I998d37e5847f9651345554bada86df6fce86d1eb


[ROCm/clr commit: 94699a7a6f]
2020-05-08 01:37:23 -04:00
Rahul Garg 63332172d6 Rename hipDrvOccupancy to hipModuleOccupancy and match CUDA syntax (#1943)
[ROCm/clr commit: 69e09a0b1b]
2020-04-07 14:02:52 +05:30
Joseph Greathouse 7adeaffd61 Fix compiler warning on NVCC path (#1942)
GCC emits a warning about using static functions like
hipCUDAErrorTohipError inside this function, because it has an
inline directive, but it's not static. Adding static to this function
to silence warnings (and prevent potential problems in the future).

[ROCm/clr commit: dc9ecf03f8]
2020-03-17 14:02:59 +05:30
Joseph Greathouse 43c687a5e8 Fix occupancy calculations API on NVCC (#1941)
NVCC warned if you tried to use hipOccupancyMaxActiveBlocksPerMultiprocessor
because when passing in a device function pointer, "const void* func" was
insufficient to describe it accurately. Adding a C++ templated class type
definition for this function.

[ROCm/clr commit: 7f49e47217]
2020-03-17 14:02:48 +05:30
Aryan Salmanpour 518130a0b7 [HIP] add cooperative kernel launch APIs on NVCC (#1929)
[ROCm/clr commit: e509a6d0b4]
2020-03-17 14:01:11 +05:30
Aryan Salmanpour a582f9797e [HIP] add hip specific properties for cooperative kernel multi device
[ROCm/clr commit: 7bfb990ef7]
2020-03-03 13:25:36 -05:00
Aryan Salmanpour 89cb17284b fix build error in nvcc path
[ROCm/clr commit: 1c013bab3e]
2020-02-11 12:16:51 -05:00
Aryan Salmanpour cbefd62db9 code clean up
[ROCm/clr commit: 75572a4175]
2020-01-31 13:08:25 -05:00
Aryan Salmanpour 2733df36b5 [HIP][HIPIFY] Add some missing flags for cooperative launch and occupancy APIs
[ROCm/clr commit: 6db9b782be]
2020-01-30 15:05:53 -05:00
vsytch 4162b55dbe Add missing texturePitchAlignment member to the hipDeviceProp_t struct. (#1802)
* Add missing texturePitchAlignment member to the hipDeviceProp_t struct.

* Add missing hipDeviceAttributeTexturePitchAlignment enumerator to the hipDeviceAttribute_t enum.

* Initialize texturePitchAlignment to 256. This works for gfx9+, but is technically overaligned in most cases for pre-gfx9.

* Add the texturePitchAlignment property to the NVCC path.


[ROCm/clr commit: 6da0c82b78]
2020-01-27 16:37:00 -08:00
Evgeny Mankov d1d680a1d6 [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path


[ROCm/clr commit: 9c2fcff9ce]
2020-01-10 13:47:18 +05:30
Rahul Garg 1e78733f53 Add hipBindTexture2D on NVCC path (#1773)
[ROCm/clr commit: 534376cb41]
2020-01-06 12:33:50 +05:30
Evgeny Mankov 8c58286a9b Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/clr commit: ed43699a3a]
2019-12-30 19:21:09 +03:00
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
2019-12-23 17:01:35 +03:00
Alex Voicu 1f762e3970 Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/clr commit: 150e690a3a]
2019-12-23 19:11:24 +05:30
Rahul Garg 48faf7423a Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/clr commit: a369bd4418]
2019-12-06 09:51:53 +05:30
Alex Voicu 553a7c2ce3 General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp


[ROCm/clr commit: 022ac3cb0a]
2019-11-20 21:36:37 +05:30
Rahul Garg f524f75b69 Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests


[ROCm/clr commit: ff31f734fe]
2019-11-18 12:19:22 +05:30
Anusha Godavarthy Surya 2d538b702d Merge branch 'master' into tex_unbind_issue_fix
[ROCm/clr commit: c0fc5e718c]
2019-10-25 15:36:55 +05:30
Anusha Godavarthy Surya 1dd70e007b Fixed CI build failure
[ROCm/clr commit: b9c8dd8ac6]
2019-10-25 12:21:41 +05:30
Evgeny Mankov caba615304 [HIP] Fix typo in a comment
[ROCm/clr commit: 7a1301eab9]
2019-10-11 15:20:58 +03:00
Evgeny Mankov 1881f7fe8a [HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow
[ROCm/clr commit: 3a83b3a62c]
2019-10-11 15:18:08 +03:00
Evgeny Mankov 949e778f66 [HIP] Introduce library_types.h as a common header for libs (#1509)
* [HIP] Introduce library_types.h as a common header for libs

[Reason]
Currently, hipFFT, hipBLAS and other HIP libs use their own data types, prefixed with HIPFFT or HIPBLAS, whereas in CUDA those types are common and declared in library_types.h

[TODO]
Switch hipFFT, hipBLAS and other HIP libs to use common library_types.h.

* [HIP] Move include for library_types.h to hip_runtime.h

[Reason]
Repeat CUDA's behaviour, where library_types.h is included in cuda_runtime.h


[ROCm/clr commit: d8d9f16f17]
2019-10-10 19:57:28 +05:30
Philip Salzmann 2dee09bd5b Fix uninitialized var in hipDeviceGetAttribute (#1497)
This fixes the usage of an uninitialized cdattr variable in hipDeviceGetAttribute for the CUDA backend when taking the switch default, as detailed in #1317.

Note that the directed_tests/runtimeApi/device/hipGetDeviceAttribute.tst test fails for me, but it already did before applying this patch. Let's see what CI says!

[ROCm/clr commit: 11f23bba39]
2019-10-04 13:39:19 +05:30
ansurya efc64a4f8a Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.


[ROCm/clr commit: 96890792b0]
2019-10-04 13:36:31 +05:30
Sarbojit2019 3ef2e123bb [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.

[ROCm/clr commit: db4c0c0811]
2019-09-26 13:53:33 +05:30
ansurya 4436a38e65 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/clr commit: e2a934f377]
2019-09-16 08:31:30 +00:00
Sarbojit2019 15b80a759d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/clr commit: b5ff9e71ed]
2019-08-29 01:02:59 +00:00
Sarbojit2019 4d23e35532 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/clr commit: 1ae43cbeba]
2019-08-29 01:02:41 +00:00
Sarbojit2019 40c0bc5588 Compilation failure on nvcc path when using hipChannelFormatKind (#1345)
Fix for github #1183 issue reported

[ROCm/clr commit: 684801fc1d]
2019-08-21 10:01:03 +00:00