Commit Graph

11517 Commits

Author SHA1 Message Date
German bc14b745e8 SWDEV-365121 - Use CP DMA for tiny transfers
Sync between compute and SDMA engines can be very expensive under Windows.
Use CP DMA for tiny transfers (< 1KiB) to avoid syncs and improve performance.

Change-Id: I9db39a2199f7b9e337ed08fd36d9cbc150502f1f


[ROCm/clr commit: 473621c008]
2022-11-03 10:04:53 -04:00
German Andryeyev 670266f94f SWDEV-364457 - Don't attempt adding duplicates into the memory map
KMD can enable hipHostRegister optimization  with HMM path.
That will make CPU and GPU pointers matching.

Change-Id: Iad96ceada5cfa3bada20452b906f744f9dbaebbe


[ROCm/clr commit: 55d085ca8c]
2022-11-03 10:04:12 -04:00
Tao Sang 441effd3d7 SWDEV-363140 - Support performance counter on gfx11
Change-Id: I2216f71f4d4db6dd3766333b0c821cb3d35d7851


[ROCm/clr commit: 06573ac92f]
2022-11-03 07:59:24 -04:00
Chauncey Hui fb16e20571 SWDEV-2 - Change OpenCL version number from 3521 to 3522
[ROCm/clr commit: 4b3ff92abd]
2022-11-03 03:00:09 -04:00
Jaydeep Patel 420ab29155 SWDEV-362367 - pciBusId should be large enough to store 13 characters including the NULL-terminator.
Change-Id: Ie58be0495065713bae7e13923ac04a4643e246be


[ROCm/clr commit: 4e2f7192e3]
2022-11-03 00:04:27 -04:00
Laurent Morichetti 6d3939cd49 SWDEV-351980 - Store the correlation ID in the dispatch packet
The profiler can retrieve this correlation ID to attribute waves to
specific dispatch locations.

Change-Id: I700e8a91219d612f6a2028c0dda0c92753f3526a


[ROCm/clr commit: b043b4f5a2]
2022-11-02 23:40:10 -04:00
Tao Sang 94946f5616 SWDEV-363140 - Support performance counter on gfx11
Support performance counter on gfx11 in Windows only
as Rocm doesn't support performance counter on gfx11 in Linux.

Change-Id: I2216f72f4d4db6dd3766343b0c821cb3d35d7852


[ROCm/clr commit: 6f43b210d7]
2022-11-01 18:12:02 -04:00
Tao Sang 9091d2751f SWDEV-363038 - Fix hipGraphKernelNodeSetParams
Fix crash in hipGraphKernelNodeSetParams where paremeters
are taken from hipGraphKernelNodeGetParams.

Change-Id: I2216f72f4d4de6dd3766343b0d821cb3d35d7853


[ROCm/clr commit: 0c4307f86e]
2022-11-01 15:02:39 -04:00
Chauncey Hui a2df4f8400 SWDEV-2 - Change OpenCL version number from 3520 to 3521
[ROCm/clr commit: b070ba9cc3]
2022-11-01 03:00:05 -04:00
jatang 53f289e0ac SWDEV-293816 - Only dispatch Counter Aql packet when it is created successfully.
Change-Id: Ic8a7374d19012754c6de5d483ec5d07a56661d1b


[ROCm/clr commit: 166ef6b622]
2022-10-31 15:11:41 -04:00
Saleel Kudchadker 0d1d52d249 SWDEV-301667 - Use queue base address for AQL log
Change-Id: Ie525991b341deeb93ab3cb2d77550e8e1d87ee20


[ROCm/clr commit: cf1fd98074]
2022-10-31 13:54:49 -04:00
AravindanC 7219645700 SWDEV-352878 - LLVM pkg search directly using find_dep() for CLANG Include path
Change-Id: I355e39890757be07de8b9332deca159f35039dfd


[ROCm/clr commit: c8500cd72d]
2022-10-31 09:42:47 -07:00
Julia Jiang 1d74b9271a SWDEV-342013,SWDEV-342014 - Update validation on hipDeviceGet and hipDeviceGetName
Change-Id: I719da6169ce9f505449e07775cb94a5718f79ca3


[ROCm/clr commit: 3415f0a56e]
2022-10-31 11:44:40 -04:00
German c04e2300c8 SWDEV-363074 - Clean-up sync between SDMA and compute
HIP can't rely on the resource tracking, used in OCL and requires different explicit sync.
Make sure ROCCLR syncs compute only when SDMA is used and vise versa.
The new logic will allow to enable CPDMA without unnecessary waits.

Change-Id: Ib9d1788cfd5afa5ea2fec4c96a37d8b9c4d0059d


[ROCm/clr commit: ff6b4db70b]
2022-10-31 10:02:01 -04:00
Anusha GodavarthySurya c9f30dcdd6 SWDEV-362611 - Added hmax and hmin
Change-Id: I133a80e997e39357693df7ab969425c0d5585607


[ROCm/clr commit: 07b3070e25]
2022-10-31 00:23:57 -04:00
Chauncey Hui 30ec1ca8df SWDEV-2 - Change OpenCL version number from 3519 to 3520
[ROCm/clr commit: 3bce4df27d]
2022-10-29 03:00:09 -04:00
agunashe 8b2c273837 SWDEV-337331 - Windows graph fix
Unit_hipGraphNodeGetDependentNodes_Functional
Unit_hipGraphNodeGetDependencies_Functional
Unit_hipGraphAddEventRecordNode_Functional_WithoutFlags
Unit_hipGraphMemcpyNodeSetParams_Functional
Unit_hipGraphExecChildGraphNodeSetParams_ChildTopology

Change-Id: I762776d33f27197bcc012951a1828d3d1d2b3e2e


[ROCm/clr commit: 47ae1f1fff]
2022-10-28 14:46:04 -04:00
German c15bee3157 SWDEV-363074 - Enable resource cache for SVM
Blender creates and destroys big allocations during the benchmark.
That causes big delays, because vidmm has to page-in/page-out memory.

Change-Id: I2baf4545807127406e3d2870a7581ff9ae7bcdb5


[ROCm/clr commit: dc4ad8c99c]
2022-10-27 16:39:29 -04:00
sdashmiz c46a687045 SWDEV-363850 - fix a bug in mutual exclusive flags
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If7687b5bf7ec7ff1978991cbf7dafa0612912274


[ROCm/clr commit: 84fa61a39b]
2022-10-27 11:23:35 -04:00
Pierre van Houtryve 6d160e5a69 Replace LLVM atomic.inc intrinsics with Clang builtins
With opaque pointers, the suffix of those intrinsics changed. This caused
build failures that should be solved by just using the corresponding
Clang builtins instead of using intrinsics directly

See SWDEV-356581

Change-Id: Icd1d9b9438cac4bef0f7c52d4cd341ac76500890


[ROCm/clr commit: dcb5d29f1e]
2022-10-27 10:17:21 -04:00
jatang dec87c74f0 SWDEV-293816 - Test a CPC counter that's supported by both gfx10 ROCr and PAL backend.
Change-Id: I5d20d07b999c26707611dba5b2c7da9782ad08f3


[ROCm/clr commit: 7cb2b815b3]
2022-10-25 18:14:07 -04:00
jatang fe5311622d SWDEV-362451 - Reenable OCLPinnedMemory
Change-Id: I75897846913190422bb8c95d1dce83077d5c77d6


[ROCm/clr commit: b7b458730a]
2022-10-25 12:32:13 -04:00
Chauncey Hui b0af040a7d SWDEV-2 - Change OpenCL version number from 3518 to 3519
[ROCm/clr commit: cff74ae551]
2022-10-25 03:00:08 -04:00
pghafari e67454dc70 SWDEV-362280 - retur NotSupoorted for hip-vulkan
hip-vulkan semaphore on rocm is not supported

Change-Id: I6e01c4f5b192cfb17546a29a1cb17f320c4b1adc


[ROCm/clr commit: 895473e8d8]
2022-10-24 13:36:18 -04:00
German e3f6a5fa0d SWDEV-363069 - Disable sync force for MT
hipMemcpyAsync doesn't require any forced sync even for sysmem

Change-Id: I83951f6118e84d79c74d5671df62678c5db085a8


[ROCm/clr commit: 52ff4368e5]
2022-10-24 10:59:07 -04:00
German 23fc103652 SWDEV-363602 - Notify cmd queue about callback wait
Remove extra barrier, since ROCR backend in DD mode blocks HW queue now when a callback is injected
Add a notificaiton for MT mode about possible waiter for a callback

Change-Id: Ifd70ce5597e1ba868e4197ad1850ace11a4f90ae


[ROCm/clr commit: 413cc757af]
2022-10-24 10:56:20 -04:00
sdashmiz a75852fb97 SWDEV-357917 - correct userobj for negative test cases
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6a2a74c763d2b938430ca53a14360f459af04665


[ROCm/clr commit: 4fc9df2a1a]
2022-10-24 10:27:02 -04:00
German f5f0a6c618 SWDEV-352487 - Don't add notifications as the last command
Change-Id: Ifed34485839ef2c9491e8e8f6bb3569932160b1c


[ROCm/clr commit: e223b0f678]
2022-10-24 09:39:03 -04:00
Chauncey Hui 4c1741acfd SWDEV-2 - Change OpenCL version number from 3517 to 3518
[ROCm/clr commit: a65ed69c1b]
2022-10-22 03:00:06 -04:00
Jason Tang e07fd20922 Merge "SWDEV-362891 - Add the ocltst install path to RUNPATH." into amd-staging
[ROCm/clr commit: a19e8ab0bb]
2022-10-21 18:22:20 -04:00
German 1bcd517a43 SWDEV-345024 - Restore break
Commit a3c9b7dde6 accidently removed break for mempool property

Change-Id: Ica3cbec796ca6b2366583d3302d3226c73224177


[ROCm/clr commit: 8d2885f331]
2022-10-21 18:04:20 -04:00
Laurent Morichetti bec405981e SWDEV-361847 - Print 'char' parameters as 'integer'
When printing HIP API function parameters, use the integer format to
print 'char' arguments to avoid printing invalid ASCII characters
(value > 127).

Make sure the roctracer::hip_support::detail operator<< overloads are
used when printing arguments.

Change-Id: Id072c2ed19b1b4166108599e393d1cae6c54b6b0


[ROCm/clr commit: 19107858d6]
2022-10-21 14:55:33 -04:00
Ajay 09e359f925 SWDEV-357207 - Linux: enable StreamWrite/Wait APIs in deviceAttribute
Change-Id: I593df2dbb7a0233dd42f8d873510d85bbb27feff


[ROCm/clr commit: 261620a2ef]
2022-10-21 12:44:35 -04:00
Ajay 548b3e0dab SWDEV-332251 - Remove tests packaging from hipamd
Change-Id: I98c0d19ce2eea921d214661b8a1588cb5dbf4268


[ROCm/clr commit: f2fbe4938e]
2022-10-21 11:48:30 -04:00
German 6ab9293146 SWDEV-360183 - Finish the trace if queue was destroyed
- Make sure SQQT trace is captured for RGP server if the queue is destroyed before normal capture is done.
- Remove prepare queue from the logic. It's not really used for any HW capture and can cause RGP server abort if destroyed before capture is even started(delayed capture)

Change-Id: I6eb19963190a5769c6477a5496c1b831a6d59b89


[ROCm/clr commit: c1c5127875]
2022-10-21 10:44:10 -04:00
Alex (Bin) Xie d77a150bf9 SWDEV-361591 - clean up header files
Change-Id: I25ca37a94524da0521f5b856a9fa9bab73f103c1


[ROCm/clr commit: 06867f0c04]
2022-10-21 10:23:55 -04:00
Chauncey Hui 7347172bc3 SWDEV-2 - Change OpenCL version number from 3516 to 3517
[ROCm/clr commit: 904f3e3d75]
2022-10-21 03:00:52 -04:00
Satyanvesh Dittakavi 25ff252d73 SWDEV-362371 - Uninitialized stream error checks
Change-Id: I7e04ef46f0cf2b0c45caf42d5b2ee31cb68e93eb


[ROCm/clr commit: bded3d8d1f]
2022-10-20 21:57:11 -04:00
Tao Sang 326049efb8 SWDEV-360706 - Fix WriteAqlArgAt() crash in X86
In X86 on Windows, sizeof(size_t)=4, but size=8, for
amd::KernelParameterDescriptor::HiddenGlobalOffsetX/Y/Z items.
Loose the condition to prevent crash.

Change-Id: I2216f71f4d4fd6dd3766023b1c821cb3d35d7848


[ROCm/clr commit: 3d281114fb]
2022-10-20 18:04:49 -04:00
jatang 17948751c9 SWDEV-362451 - Disable OCLPinnedMemory for now.
Change-Id: I9a771cfc5751e06c5a494ad2e4036f9aa3efbe9a


[ROCm/clr commit: b7d64f9f5f]
2022-10-20 16:03:36 -04:00
Sourabh Betigeri 644fc9421c SWDEV-361730 - Fix to match the kernel arg allocation sizes between gpu visible mem and host/runtime mem
Change-Id: I6495aa57e97b46373c1d90cc230435780fdcf3ef


[ROCm/clr commit: b2665ccc4b]
2022-10-20 14:20:37 -04:00
Ajay e81e8965c9 SWDEV-360944 - palBlit setArgument desc.size_ --> argSize
Fixes AMF tests that were impacted on Windows

Change-Id: I0326e794ec5a34fdec7a5ff4ed79d5bd055997d2


[ROCm/clr commit: a5b550e828]
2022-10-20 12:44:15 -04:00
Laurent Morichetti 860e33dbed SWDEV-362046 - Report HIP_OPS activities using the ROCr driver_node_id instead of the device's index
The ROCclr assigns zero-based IDs to GPUs in the order they are
discovered. That zero-based ID is what is used to identify the GPU
on which the HIP_OPS activity took place.

When multiple ranks are used, each rank's first logical device always
has GPU ID 0, regardless of which physical device is selected with
CUDA_VISIBLE_DEVICES. Because of this, when merging trace files from
multiple ranks, GPU IDs from different processes may overlap.

The long term solution is to use the KFD's gpu_id which is stable
across APIs and processes. Unfortunately the gpu_id is not yet exposed
by the ROCr, so for now use the driver's node id.

Change-Id: Ib78854527d600d175bb76e2df0747c33f898c615


[ROCm/clr commit: 9a82118c85]
2022-10-20 12:31:30 -04:00
Julia Jiang a8c33d177a SWDEV-357122 - fix failure in vdi so as to handle unreasonable input size in MallocManagedNegativeTest
Change-Id: I1ed1916b652afc67327b0935c3c60fc2a404df30


[ROCm/clr commit: dacd55f3d7]
2022-10-20 12:19:22 -04:00
Chauncey Hui cc132b1aec SWDEV-2 - Change OpenCL version number from 3515 to 3516
[ROCm/clr commit: 05b2bd7995]
2022-10-20 03:00:06 -04:00
jatang cecfda83f5 SWDEV-362891 - Add the ocltst install path to RUNPATH.
So ocltst can automatically find liboclruntime.so from the same directory as ocltst.

Change-Id: Id2f4f58b1c7f0304be76a3aeecd5eea2eec328de


[ROCm/clr commit: cbbf0d1edd]
2022-10-19 18:17:17 -04:00
Ashutosh Mishra c8eadd18af SWDEV-362882 - Unable to run clinfo/opencl tests
The explicit RUNPATH addtion has been
revoked after the file reorg. Hence
the rpath for discovery of the libs
has to be taken care by individual binaries
Current patch adds the run path for
descovery of the libOpenCL.so

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: Ia3bf9202bea78ecfdb881e40b0eb7a0d4a303ed3


[ROCm/clr commit: 1754b043a3]
2022-10-19 15:03:07 -04:00
Ranjith Ramakrishnan 89321974f3 SWDEV-345870 - Correct HIP path for new directory layout
With file reorganization changes HIP is installed in /opt/rocm-ver
Using HIP path as /opt/rocm-ver/hip will generate warnings
Use real path with symlinks resolved, so that HIP path always points to the installed path
Removed redundant code for finding hsa header files. find_dependency to hsa-runtime should handle hsa dependency

Change-Id: Iccea3c1c7297c705244bf752f38fbff71929d64c


[ROCm/clr commit: f3394cf7a5]
2022-10-19 12:58:02 -04:00
Christophe Paquot b2d02fe704 SWDEV-322620 - Virtual Memory Management
Hooked up the start VA hint address to PAL.

Change-Id: I4301d3eaaabcc85faf63fb25291291dcc3e8ebd1


[ROCm/clr commit: 470c4d7335]
2022-10-19 10:50:07 -04:00
pghafari 18808d87a4 SWDEV-356557, SWDEV-356558 - matching cuda return
Change-Id: I3b7d50e07bd437bd23a495439d66940ff30f7f07


[ROCm/clr commit: d7b27989b4]
2022-10-19 09:17:28 -04:00